Skip to content

DRAFT: Update details box. #1636

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bgravenorst wants to merge 3 commits into
base: main
Choose a base branch
from
+48 −16
Open

DRAFT: Update details box. #1636

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0250936
Update details box.
bgravenorst Oct 16, 2024
5fd7e43
Remove line.
bgravenorst Oct 16, 2024
fb4de64
Merge branch 'main' into updateDetailsBox
joaniekube Oct 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove line. 
Signed-off-by: bgravenorst <[email protected]>
  • Loading branch information
@bgravenorst
bgravenorst committed Oct 16, 2024
commit 5fd7e433840a674c0557a953274da143648ce31c
2 changes: 1 addition & 1 deletion src/components/ParserOpenRPC/DetailsBox/RenderParams.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,7 +150,7 @@ export const renderParamSchemas = (inputSchema, schemas) => {
<>
{inputSchema.map((item, i) => {
return (
<div key={`${i}`} className={styles.borderTopLine}>
<div key={`${i}`}>
{renderSchema(item, schemas, item.name)}
{i < inputSchema.length - 1 && <hr className={styles.paramSeparator} />}
</div>
Expand Down
13 changes: 9 additions & 4 deletions src/components/ParserOpenRPC/DetailsBox/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,13 +49,19 @@ export default function DetailsBox({
)}
<Heading as="h1">{method}</Heading>
{summary !== null && (
<p style={{ marginBottom: "0.5rem" }}>
<p style={{ marginBottom: "0.5rem" }}
className={clsx("padding-bottom--md", styles.borderBottomLine)}
>
<strong>Summary: </strong>
<MDContent content={summary} />
<span className={styles.summaryText}>
<MDContent content={summary} />
</span>
</p>
)}
{description !== null && (
<MDContent content={description} />
<div className="padding-top--lg">
<MDContent content={description} />
</div>
)}
{extraContent && <div className="padding-top--lg">{extraContent}</div>}
<Heading
Expand All @@ -80,7 +86,6 @@ export default function DetailsBox({
as="h2"
className={clsx(
styles.secondaryHeading,
styles.borderBottomLine,
"padding-top--lg padding-vert--md",
)}
>
Expand Down