Skip to content

[DO NOT MERGE] - Snap debugging branch #1799

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Prithpal-Sooriya wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

[DO NOT MERGE] - Snap debugging branch #1799

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
af08274
chore: use new version of profile sync controller
Jwhiles Jan 7, 2025
1819f9c
fix: don't always show install button on mobile
Jwhiles Jan 7, 2025
7989bb3
chore: add a bunch of logging etc
Jwhiles Jan 7, 2025
46ba2e6
chore: add SDK logs
Jwhiles Jan 7, 2025
4ed5118
chore: use window.ethereum
Jwhiles Jan 8, 2025
fa23db1
temp: adding debug snap test button for testing
Prithpal-Sooriya Jan 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: don't always show install button on mobile
  • Loading branch information
@Jwhiles
Jwhiles committed Jan 7, 2025
commit 1819f9c1addc39559a6f43bb471d6eef5c230be1
13 changes: 9 additions & 4 deletions src/components/Faucet/Hero.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,13 +36,18 @@ export default function Hero({
projects,
walletAuthUrl,
} = useContext(MetamaskProviderContext);

const isMobile = sdk.platformManager.isMobile()
const isExtensionActive = sdk.isExtensionActive();

const showInstallButton = !isExtensionActive && !isMobile;

const [isWalletLinking, setIsWalletLinking] = useState(false);

const handleConnectWallet = () => {
setIsWalletLinking(true);
trackClickForSegment({
eventName: !isExtensionActive ? "Install MetaMask" : "Connect MetaMask",
eventName: showInstallButton ? "Install MetaMask" : "Connect MetaMask",
clickType: "Hero",
userExperience: "B",
responseStatus: null,
Expand Down Expand Up @@ -95,7 +100,7 @@ export default function Hero({
className,
)}
>
{!(isExtensionActive && metaMaskAccount) && <EthIcon />}
{!(!showInstallButton && metaMaskAccount) && <EthIcon />}
<Text as="h1">
<span>
{network === "linea" && "Linea Sepolia"}
Expand All @@ -104,7 +109,7 @@ export default function Hero({
</span>
</Text>
<Text as="p">
{!isExtensionActive
{showInstallButton
? "Install MetaMask for your browser to get started and request ETH."
: !Object.keys(projects).length
? walletLinked === undefined
Expand Down Expand Up @@ -139,7 +144,7 @@ export default function Hero({
!!Object.keys(projects).length && styles.alignedButtons,
)}
>
{!isExtensionActive ? (
{showInstallButton ? (
<Button
testId="hero-cta-install-metamask"
className={styles.button}
Expand Down
Loading