Skip to content

Add multichain error codes #2063

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
alexandratran wants to merge 3 commits into
base: main
Choose a base branch
from
+16 −1
Open

Add multichain error codes #2063

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
73985ad
Add multichain error codes
alexandratran May 29, 2025
1904042
Merge branch 'main' into multichain-error-codes
alexandratran Jun 26, 2025
39d808e
Remove 5101, 5102, 5300, 5301
alexandratran Jun 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Remove 5101, 5102, 5300, 5301
  • Loading branch information
@alexandratran
alexandratran committed Jun 26, 2025
commit 39d808eea3fa8e4a19170a09c702ed79697cb383
4 changes: 0 additions & 4 deletions wallet/reference/multichain-api.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -393,8 +393,4 @@ The Multichain API can return the following JSON-RPC error codes:
| ---- | ----------- | --------------- |
| 5000 | Unknown error with request | `wallet_revokeSession`, `wallet_createSession` |
Copy link
Contributor

@jiexi jiexi May 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vandan @adonesky1 we're firing -32603 on wallet_revokeSession, same for wallet_createSession

Copy link
Contributor

@vandan vandan May 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm. I don't see error codes in that range anywhere in the CAIP standards for this so it seems like we should instead map any errors fired to codes in the 5000 range (ex. 5500, 5501, or 5502 for wallet_revokeSession).

Copy link
Contributor

@adonesky1 adonesky1 Jun 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We probably should throw CAIP-25's unknown error code (5000) instead of -32602 here

| 5100 | Requested networks are not supported | `wallet_createSession` |
| 5101 | Requested methods are not supported | `wallet_createSession` |
| 5102 | Requested notifications are not supported | `wallet_createSession` |
| 5300 | Invalid `scopedProperties` requested | `wallet_createSession`|
| 5301 | `scopedProperties` can only be outside of `sessionScopes` | `wallet_createSession`|
| 5302 | Invalid `sessionProperties` requested | `wallet_createSession` |
Loading