Skip to content

fix: make focus visible to improve clarity for keyboard users #2222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
michalconsensys wants to merge 13 commits into
base: main
Choose a base branch
from
Open

fix: make focus visible to improve clarity for keyboard users #2222

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
c08dcc1
fix: fix focus
michalconsensys Aug 11, 2025
d3bf734
chore: revert old files
michalconsensys Aug 11, 2025
14d9869
chore: remove unused code
michalconsensys Aug 11, 2025
6568fa9
chore: remove unused code
michalconsensys Aug 11, 2025
611f9f4
chore: remove unused code
michalconsensys Aug 11, 2025
f467892
Merge branch 'main' into fix-focus
michalconsensys Aug 11, 2025
461256b
Merge branch 'main' into fix-focus
michalconsensys Aug 12, 2025
99eba62
Merge branch 'main' into fix-focus
michalconsensys Aug 13, 2025
b3b2bbc
Merge branch 'main' into fix-focus
michalconsensys Aug 20, 2025
a41e53f
Merge branch 'main' into fix-focus
michalconsensys Sep 1, 2025
aec66d2
chore: fix props
michalconsensys Sep 1, 2025
308bf54
chore: remove comments
michalconsensys Sep 1, 2025
d2530fe
chore: dont use any
michalconsensys Sep 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
chore: revert old files
  • Loading branch information
@michalconsensys
michalconsensys committed Aug 11, 2025
commit d3bf73467aebd6b973346b54eea9148ebcef04ea
14 changes: 3 additions & 11 deletions src/components/ParserOpenRPC/InteractiveBox/styles.module.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -285,11 +285,8 @@
background-color: var(--general-gray-dark);
}
}
/* Enhanced focus styles for better accessibility */
.formControl:focus-visible {
outline: 2px solid var(--focus-outline-color-light);
outline-offset: 1px;
border-color: var(--focus-outline-color-light);
.formControl:focus {
outline: none;
}
.formControl[type='number'] {
border-color: transparent;
Expand Down Expand Up @@ -385,16 +382,11 @@
background: none;
padding: 0;
border: 0;
outline: none;
color: var(--general-gray-mid);
font-size: inherit;
line-height: 1;
cursor: pointer;

/* Enhanced focus styles for interactive buttons */
&:focus-visible {
outline: 2px solid var(--focus-outline-color-light);
outline-offset: 2px;
}
}
.addItemIcon {
display: inline-flex;
Expand Down
9 changes: 1 addition & 8 deletions src/scss/elements/_form.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,14 +25,7 @@ select {
border-color calc(var(--motion) * var(--motion-speed) * 0.5) $gentle-ease;

&:focus {
border-color: var(--focus-outline-color-light);
}

/* Enhanced focus visibility for form controls */
&:focus-visible {
border-color: var(--focus-outline-color-light);
outline: 2px solid var(--focus-outline-color-light);
outline-offset: 1px;
border-color: var(--general-dark);
}
}

Expand Down
13 changes: 0 additions & 13 deletions src/scss/theme/_interactive-box.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,13 +69,6 @@
transition: border var(--ifm-transition-fast) ease;

background-color: transparent;

/* Enhanced focus styles for interactive box inputs */
&:focus-visible {
outline: 2px solid var(--focus-outline-color-light);
outline-offset: 1px;
border-color: var(--focus-outline-color-light);
}
}

&#method select,
Expand All @@ -94,12 +87,6 @@
appearance: auto;
width: 1.6rem;
height: 1.6rem;

/* Enhanced focus styles for checkboxes */
&:focus-visible {
outline: 2px solid var(--focus-outline-color-light);
outline-offset: 2px;
}
}

&#interactive-box .form-group {
Expand Down