temp+fix: cp-13.1.0 bump solana snap (#34887)

## **Description**

Bumps the Solana Snap to
[v2.1.4](https://github.com/MetaMask/snap-solana-wallet/releases/tag/v2.1.4),
bringing in the following:
- Changed
- Enhance performance by triggering UI refresh jobs only when the UI is
open (MetaMask/snap-solana-wallet#490)
- Fixed
- Increase the compute unit limit used for sending SPL tokens
(MetaMask/snap-solana-wallet#492)
- Ensure WebSocket connections are open whenever the client becomes
active (MetaMask/snap-solana-wallet#489)

## **Changelog**

<!--
If this PR is not End-User-Facing and should not show up in the
CHANGELOG, you can choose to either:
1. Write `CHANGELOG entry: null`
2. Label with `no-changelog`

If this PR is End-User-Facing, please write a short User-Facing
description in the past tense like:
`CHANGELOG entry: Added a new tab for users to see their NFTs`
`CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker`

(This helps the Release Engineer do their job more quickly and
accurately)
-->

CHANGELOG entry:

## **Related issues**

Fixes:

## **Manual testing steps**

1. Go to this page...
2.
3.

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [x] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I’ve included tests if applicable
- [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

---------

Co-authored-by: Alejandro Garcia Anglada <aganglada@gmail.com>
Co-authored-by: MetaMask Bot <metamaskbot@users.noreply.github.com>

Author: 3 people

.eslintrc.base.js

@@ -9,10 +9,6 @@ module.exports = {
   globals: {
     document: 'readonly',
     window: 'readonly',
-    // Our ESLint config is stuck at ES2017 because Browserify doesn't support the spread operator.
-    // We can remove this global after we've migrated away from Browserify and updated our ESLint
-    // config to at least ES2021.
-    AggregateError: 'readonly',
   },
 
   rules: {

.github/scripts/check-template-and-add-labels.ts

@@ -17,7 +17,6 @@ import {
   craftRegressionLabel,
   externalContributorLabel,
   needsTriageLabel,
-  areaSentryLabel,
   flakyTestsLabel,
   invalidIssueTemplateLabel,
   invalidPullRequestTemplateLabel,
@@ -99,9 +98,8 @@ async function main(): Promise<void> {
     labelable.body,
   );
 
-  // If labelable's author is a bot we skip the rest of the script, including the template checks as bots don't use templates.
-  // Exception: For issues created the 'sentry-io' bot, we don't skip the rest of the script because there's a specific handling for those issues.
-  if (knownBots.includes(labelable.author) && labelable.author !== 'sentry-io') {
+  // If labelable's author is a bot we skip the template checks as bots don't use templates
+  if (knownBots.includes(labelable.author)) {
     console.log(
       `${
         labelable.type === LabelableType.PullRequest ? 'PR' : 'Issue'
@@ -125,24 +123,6 @@ async function main(): Promise<void> {
       process.exit(0); // Stop the process and exit with a success status code
     }
 
-    if (labelable.author === 'sentry-io') {
-      console.log(
-        `Issue ${labelable?.number} was created through Sentry. Issue's description doesn't need to match issue template in that case. Skip template checks.`,
-      );
-      await removeLabelFromLabelableIfPresent(
-        octokit,
-        labelable,
-        invalidIssueTemplateLabel,
-      );
-      // Add needs triage label ONLY if issue is created (not updated)
-      if (context.payload.action === 'opened') {
-        await addNeedsTriageLabelToIssue(octokit, labelable);
-      }
-      // Add area-Sentry label to the bug report issue
-      await addAreaSentryLabelToIssue(octokit, labelable);
-      process.exit(0); // Stop the process and exit with a success status code
-    }
-
     if (templateType === TemplateType.GeneralIssue) {
       console.log("Issue matches 'general-issue.yml' template.");
       await removeLabelFromLabelableIfPresent(
@@ -159,12 +139,10 @@ async function main(): Promise<void> {
       );
 
       // Add regression label to the bug report issue
-      await addRegressionLabelToIssue(octokit, labelable);
+      addRegressionLabelToIssue(octokit, labelable);
 
-      // Add needs triage label ONLY if issue is created (not updated)
-      if (context.payload.action === 'opened') {
-        await addNeedsTriageLabelToIssue(octokit, labelable);
-      }
+      // Add needs triage label to the bug report issue
+      addNeedsTriageLabelToIssue(octokit, labelable);
     } else {
       const errorMessage =
         "Issue body does not match any of expected templates ('general-issue.yml' or 'bug-report.yml').\n\nMake sure issue's body includes all section titles.\n\nSections titles are listed here: https://github.com/MetaMask/metamask-extension/blob/main/.github/scripts/shared/template.ts#L14-L37";
@@ -293,13 +271,6 @@ async function addNeedsTriageLabelToIssue(
 ): Promise<void> {
   await addLabelToLabelable(octokit, issue, needsTriageLabel);
 }
-// This function adds the "area-Sentry" label to the issue if it doesn't have it
-async function addAreaSentryLabelToIssue(
-  octokit: InstanceType<typeof GitHub>,
-  issue: Labelable,
-): Promise<void> {
-  await addLabelToLabelable(octokit, issue, areaSentryLabel);
-}
 // This function adds the correct regression label to the issue, and removes other ones
 async function addRegressionLabelToIssue(
   octokit: InstanceType<typeof GitHub>,

.github/scripts/shared/label.ts

@@ -29,16 +29,10 @@ export const externalContributorLabel: Label = {
 
 export const needsTriageLabel: Label = {
   name: 'needs-triage',
-  color: '68AEE6',
+  color: '#68AEE6',
   description: 'Issue needs to be triaged',
 };
 
-export const areaSentryLabel: Label = {
-  name: 'area-sentry',
-  color: '5319E7',
-  description: 'Issue from Sentry',
-};
-
 export const flakyTestsLabel: Label = {
   name: 'flaky tests',
   color: 'BE564E',
@@ -119,14 +113,14 @@ export function craftTeamLabel(teamName: string): Label {
     case 'extension-platform':
       return {
         name: `team-${teamName}`,
-        color: 'BFD4F2', // light blue
+        color: '#BFD4F2', // light blue
         description: `Extension Platform team`,
       };
 
     case 'mobile-platform':
       return {
         name: `team-${teamName}`,
-        color: '76E9D0', // light green
+        color: '#76E9D0', // light green
         description: `Mobile Platform team`,
       };
 

.github/workflows/add-team-label.yml

@@ -4,6 +4,8 @@ on:
   pull_request:
     types:
       - opened
+      - reopened
+      - synchronize
 
 jobs:
   add-team-label:

.github/workflows/automated-rca.yml

@@ -10,7 +10,7 @@ permissions:
 
 jobs:
   automated-rca:
-    uses: MetaMask/github-tools/.github/workflows/post-gh-rca.yml@727c028d5fdb2b86f6b1cf205b97fa8e79f7de61
+    uses: MetaMask/github-tools/.github/workflows/post-gh-rca.yml@af33de88e00adce0e41583beb7954d691ad3e304
     with:
       google-form-base-url: 'https://docs.google.com/forms/d/e/1FAIpQLSfnfEWH7JCFFtvjCHixgyqJdTU3LW3BmTwdF1dDezTNf7m4ig/viewform'
       repo-owner: ${{ github.repository_owner }}

…b/workflows/create-release-pr-legacy.yml …ithub/workflows/create-release-pr-v2.yml.github/workflows/create-release-pr-legacy.yml renamed to .github/workflows/create-release-pr-v2.yml .github/workflows/create-release-pr-legacy.yml renamed to .github/workflows/create-release-pr-v2.yml

@@ -1,10 +1,10 @@
-name: Create Release Pull Request (Legacy)
+name: Create Release Pull Request V2
 
 on:
   workflow_dispatch:
     inputs:
       base-branch:
-        description: 'The base branch, tag, or SHA for git operations and the pull request. Usually `main`'
+        description: 'The base branch, tag, or SHA for git operations and the pull request (usually `main`)'
         required: true
       semver-version:
         description: 'A semantic version, eg: x.x.x'
@@ -14,14 +14,13 @@ on:
         required: true
 jobs:
   create-release-pr:
-    name: Create Release Pull Request using Github Tools
-    uses: MetaMask/github-tools/.github/workflows/create-release-pr.yml@fc6fe1a3fb591f6afa61f0dbbe7698bd50fab9c7
+    uses: MetaMask/github-tools/.github/workflows/create-release-pr.yml@dde6d530bebae07d1e50180894ab2cac64170a2c
     with:
       platform: extension
       base-branch: ${{ inputs.base-branch }}
       semver-version: ${{ inputs.semver-version }}
       previous-version-tag: Version-v${{ inputs.previous-semver-version }}
-      github-tools-version: fc6fe1a3fb591f6afa61f0dbbe7698bd50fab9c7
+      github-tools-version: dde6d530bebae07d1e50180894ab2cac64170a2c
     secrets:
       # This token needs write permissions to metamask-extension & read permissions to metamask-planning
       github-token: ${{ secrets.PR_TOKEN }}

.github/workflows/create-release-pr.yml

@@ -9,20 +9,20 @@ on:
       semver-version:
         description: 'A semantic version, eg: x.x.x'
         required: true
-      previous-version-ref:
-        description: 'Previous release version reference (tag or commit hash). eg: v7.7.0'
+      previous-semver-version:
+        description: 'Previous semantic version, eg: x.x.x'
         required: true
 
 jobs:
   create-release-pr:
     name: Create Release Pull Request using Github Tools
-    uses: MetaMask/github-tools/.github/workflows/create-release-pr.yml@dde6d530bebae07d1e50180894ab2cac64170a2c
+    uses: MetaMask/github-tools/.github/workflows/create-release-pr.yml@fc6fe1a3fb591f6afa61f0dbbe7698bd50fab9c7
     with:
       platform: extension
       base-branch: ${{ inputs.base-branch }}
       semver-version: ${{ inputs.semver-version }}
-      previous-version-tag: ${{ inputs.previous-version-ref }}
-      github-tools-version: dde6d530bebae07d1e50180894ab2cac64170a2c
+      previous-version-tag: Version-v${{ inputs.previous-semver-version }}
+      github-tools-version: fc6fe1a3fb591f6afa61f0dbbe7698bd50fab9c7
     secrets:
       # This token needs write permissions to metamask-extension & read permissions to metamask-planning
       github-token: ${{ secrets.PR_TOKEN }}