Skip to content

Conversation

@xavier-brochard
Copy link
Contributor

@xavier-brochard xavier-brochard commented Aug 6, 2025

Description

Bumps the Solana Snap to v2.1.4, bringing in the following:

Changelog

CHANGELOG entry:

Related issues

Fixes: #34967

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 6, 2025

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-new-networks PRs from the New Networks team label Aug 6, 2025
@xavier-brochard xavier-brochard marked this pull request as ready for review August 6, 2025 08:13
@socket-security
Copy link

socket-security bot commented Aug 6, 2025

All alerts resolved. Learn more about Socket for GitHub.

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Ignoring alerts on:

View full report

@xavier-brochard xavier-brochard changed the title feat: bump solana snap feat: cp-13.1.0 bump solana snap Aug 6, 2025
@metamaskbot
Copy link
Collaborator

Builds ready [515eb63]
UI Startup Metrics (1151 ± 62 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1151103114056211821271
load97287711195410071064
domContentLoaded9648691114539991056
domInteractive1814106101731
firstPaint63010310913939861061
backgroundConnect2142032608217227
firstReactRender20145662135
getState1256281326
initialActions2015329
loadScripts75866890453791851
setupStore84293812
WebpackHomeuiStartup22031621264821623162579
load16521185202617917441937
domContentLoaded16451181202217717381923
domInteractive171196141452
firstPaint1755862487201306
backgroundConnect3011370363250
firstReactRender20790415109346390
getState214292521255
initialActions52354612
loadScripts16381179201918117321911
setupStore3163337114273
FirefoxBrowserifyHomeuiStartup13191110191112113801527
load112396712867011781242
domContentLoaded112396712867011781242
domInteractive1003330852104224
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect3116126183374
firstReactRender24195572350
getState9214218729
initialActions30295214
loadScripts110095312487111581221
setupStore1037914747
WebpackHomeuiStartup15981395196713016701874
load1336116716469913921509
domContentLoaded1336116616469913921509
domInteractive98352815295249
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect3320120173570
firstReactRender52428275765
getState104579837
initialActions409610313
loadScripts1311114716249813731483
setupStore1048311734
Benchmark value 215 exceeds gate value 10 for chrome browserify home mean backgroundConnect
Benchmark value 3 exceeds gate value 1 for chrome browserify home mean initialActions
Benchmark value 227 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 9 exceeds gate value 1.2 for chrome browserify home p95 initialActions
Benchmark value 2203 exceeds gate value 2192 for chrome webpack home mean uiStartup
Benchmark value 2580 exceeds gate value 2454 for chrome webpack home p95 uiStartup
Benchmark value 390 exceeds gate value 370 for chrome webpack home p95 firstReactRender
Benchmark value 12 exceeds gate value 7 for chrome webpack home p95 initialActions
Benchmark value 273 exceeds gate value 65 for chrome webpack home p95 setupStore
Benchmark value 32 exceeds gate value 25 for firefox browserify home mean backgroundConnect
Benchmark value 4 exceeds gate value 1 for firefox browserify home mean initialActions
Benchmark value 10 exceeds gate value 9 for firefox browserify home mean setupStore
Benchmark value 224 exceeds gate value 195 for firefox browserify home p95 domInteractive
Benchmark value 74 exceeds gate value 70 for firefox browserify home p95 backgroundConnect
Benchmark value 29 exceeds gate value 24 for firefox browserify home p95 getState
Benchmark value 14 exceeds gate value 2 for firefox browserify home p95 initialActions
Benchmark value 47 exceeds gate value 27 for firefox browserify home p95 setupStore
Benchmark value 34 exceeds gate value 26 for firefox webpack home mean backgroundConnect
Benchmark value 53 exceeds gate value 38 for firefox webpack home mean firstReactRender
Benchmark value 4 exceeds gate value 1 for firefox webpack home mean initialActions
Benchmark value 249 exceeds gate value 156 for firefox webpack home p95 domInteractive
Benchmark value 70 exceeds gate value 49 for firefox webpack home p95 backgroundConnect
Benchmark value 65 exceeds gate value 50 for firefox webpack home p95 firstReactRender
Benchmark value 37 exceeds gate value 32 for firefox webpack home p95 getState
Benchmark value 13 exceeds gate value 2 for firefox webpack home p95 initialActions
Benchmark value 34 exceeds gate value 28 for firefox webpack home p95 setupStore
Sum of mean exceeds: 255ms | Sum of p95 exceeds: 796.8ms
Sum of all benchmark exceeds: 1051.8ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 43 Bytes (0%)
  • ui: 0 Bytes (0%)
  • common: 10 Bytes (0%)

@xavier-brochard
Copy link
Contributor Author

@SocketSecurity ignore npm/@metamask/[email protected]

salimtb
salimtb previously approved these changes Aug 6, 2025
@metamaskbot
Copy link
Collaborator

Builds ready [9d0dc43]
UI Startup Metrics (1141 ± 54 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1141104213965411701245
load9648651153539971062
domContentLoaded9558611144549871053
domInteractive17135061734
firstPaint6328311673809761041
backgroundConnect2152022499217239
firstReactRender20143952130
getState1043151022
initialActions2011225
loadScripts74866192554780855
setupStore74152811
WebpackHomeuiStartup22091789254720023452534
load16531232195617517521882
domContentLoaded16471224194417417441861
domInteractive171191141457
firstPaint1696437361204291
backgroundConnect3012430413147
firstReactRender20591451103320391
getState2543186112269
initialActions52273611
loadScripts16431219193417317421849
setupStore2462865315158
FirefoxBrowserifyHomeuiStartup13921138184411114541555
load119799015898812531362
domContentLoaded119698915898812521362
domInteractive1083545159115235
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect301784123350
firstReactRender25216072546
getState728610624
initialActions30345212
loadScripts117497515678812251316
setupStore1037713637
WebpackHomeuiStartup15451356196112816191790
load13011138160911013851485
domContentLoaded13001138160911013851485
domInteractive95332464096222
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect301992143265
firstReactRender504210785362
getState1149513841
initialActions40739217
loadScripts12771119153410613651466
setupStore84628724
Benchmark value 216 exceeds gate value 10 for chrome browserify home mean backgroundConnect
Benchmark value 2 exceeds gate value 1 for chrome browserify home mean initialActions
Benchmark value 240 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 5 exceeds gate value 1.2 for chrome browserify home p95 initialActions
Benchmark value 2209 exceeds gate value 2192 for chrome webpack home mean uiStartup
Benchmark value 2534 exceeds gate value 2454 for chrome webpack home p95 uiStartup
Benchmark value 58 exceeds gate value 57 for chrome webpack home p95 domInteractive
Benchmark value 391 exceeds gate value 370 for chrome webpack home p95 firstReactRender
Benchmark value 269 exceeds gate value 195 for chrome webpack home p95 getState
Benchmark value 11 exceeds gate value 7 for chrome webpack home p95 initialActions
Benchmark value 158 exceeds gate value 65 for chrome webpack home p95 setupStore
Benchmark value 31 exceeds gate value 25 for firefox browserify home mean backgroundConnect
Benchmark value 26 exceeds gate value 25 for firefox browserify home mean firstReactRender
Benchmark value 4 exceeds gate value 1 for firefox browserify home mean initialActions
Benchmark value 10 exceeds gate value 9 for firefox browserify home mean setupStore
Benchmark value 235 exceeds gate value 195 for firefox browserify home p95 domInteractive
Benchmark value 12 exceeds gate value 2 for firefox browserify home p95 initialActions
Benchmark value 37 exceeds gate value 27 for firefox browserify home p95 setupStore
Benchmark value 30 exceeds gate value 26 for firefox webpack home mean backgroundConnect
Benchmark value 51 exceeds gate value 38 for firefox webpack home mean firstReactRender
Benchmark value 4 exceeds gate value 1 for firefox webpack home mean initialActions
Benchmark value 222 exceeds gate value 156 for firefox webpack home p95 domInteractive
Benchmark value 65 exceeds gate value 49 for firefox webpack home p95 backgroundConnect
Benchmark value 62 exceeds gate value 50 for firefox webpack home p95 firstReactRender
Benchmark value 41 exceeds gate value 32 for firefox webpack home p95 getState
Benchmark value 17 exceeds gate value 2 for firefox webpack home p95 initialActions
Sum of mean exceeds: 255ms | Sum of p95 exceeds: 676.8ms
Sum of all benchmark exceeds: 931.8ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 656 Bytes (0.01%)
  • ui: 0 Bytes (0%)
  • common: 492 Bytes (0.01%)

@metamaskbot
Copy link
Collaborator

Builds ready [76644c5]
UI Startup Metrics (1175 ± 64 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1175105413176412221290
load99588111346210441104
domContentLoaded98787411266310351096
domInteractive17133231724
firstPaint61513311363949981096
backgroundConnect2182032508220237
firstReactRender19143742130
getState1152961425
initialActions406110216
loadScripts77664290164819891
setupStore84294812
WebpackHomeuiStartup22521613279421223682561
load16981183227017417801964
domContentLoaded16901177226317117711943
domInteractive1812130161452
firstPaint1716938969204318
backgroundConnect2812286282853
firstReactRender22190402115366394
getState3242877213278
initialActions822822869
loadScripts16861174226117017691931
setupStore176317351424
FirefoxBrowserifyHomeuiStartup13121136179611213611552
load113097515579311751270
domContentLoaded113097515579311751270
domInteractive993140555100226
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect271688123055
firstReactRender24205272443
getState926412637
initialActions20314211
loadScripts111096015369211571238
setupStore837010733
WebpackHomeuiStartup15761384211912716271847
load1321114815858913601506
domContentLoaded1321114715848913601506
domInteractive91302814392232
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect3320199223481
firstReactRender50416465361
getState94479830
initialActions6019722225
loadScripts1297112915639013341480
setupStore1045810833
Benchmark value 218 exceeds gate value 10 for chrome browserify home mean backgroundConnect
Benchmark value 4 exceeds gate value 1 for chrome browserify home mean initialActions
Benchmark value 238 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 16 exceeds gate value 1.2 for chrome browserify home p95 initialActions
Benchmark value 2253 exceeds gate value 2192 for chrome webpack home mean uiStartup
Benchmark value 32 exceeds gate value 29 for chrome webpack home mean getState
Benchmark value 8 exceeds gate value 7 for chrome webpack home mean initialActions
Benchmark value 2562 exceeds gate value 2454 for chrome webpack home p95 uiStartup
Benchmark value 394 exceeds gate value 370 for chrome webpack home p95 firstReactRender
Benchmark value 278 exceeds gate value 195 for chrome webpack home p95 getState
Benchmark value 9 exceeds gate value 7 for chrome webpack home p95 initialActions
Benchmark value 28 exceeds gate value 25 for firefox browserify home mean backgroundConnect
Benchmark value 3 exceeds gate value 1 for firefox browserify home mean initialActions
Benchmark value 226 exceeds gate value 195 for firefox browserify home p95 domInteractive
Benchmark value 37 exceeds gate value 24 for firefox browserify home p95 getState
Benchmark value 11 exceeds gate value 2 for firefox browserify home p95 initialActions
Benchmark value 33 exceeds gate value 27 for firefox browserify home p95 setupStore
Benchmark value 33 exceeds gate value 26 for firefox webpack home mean backgroundConnect
Benchmark value 50 exceeds gate value 38 for firefox webpack home mean firstReactRender
Benchmark value 7 exceeds gate value 1 for firefox webpack home mean initialActions
Benchmark value 232 exceeds gate value 156 for firefox webpack home p95 domInteractive
Benchmark value 81 exceeds gate value 49 for firefox webpack home p95 backgroundConnect
Benchmark value 61 exceeds gate value 50 for firefox webpack home p95 firstReactRender
Benchmark value 25 exceeds gate value 2 for firefox webpack home p95 initialActions
Benchmark value 33 exceeds gate value 28 for firefox webpack home p95 setupStore
Sum of mean exceeds: 306ms | Sum of p95 exceeds: 657.8ms
Sum of all benchmark exceeds: 963.8ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 655 Bytes (0.01%)
  • ui: 6.54 KiB (0.09%)
  • common: 852 Bytes (0.01%)

aganglada
aganglada previously approved these changes Aug 7, 2025
@GuillaumeRx
Copy link
Contributor

@metamaskbot update-policies

@metamaskbot
Copy link
Collaborator

Policies updated.
👀 Please review the diff for suspicious new powers.

🧠 Learn how: https://lavamoat.github.io/guides/policy-diff/#what-to-look-for-when-reviewing-a-policy-diff

@metamaskbot
Copy link
Collaborator

Builds ready [1028513]
UI Startup Metrics (1187 ± 68 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1187107313846812401300
load99585411427010631107
domContentLoaded98784611357110551100
domInteractive18144351827
firstPaint68274111939310211094
backgroundConnect2232092478227241
firstReactRender2616134182745
getState13481101826
initialActions30586311
loadScripts77264192170835884
setupStore95274920
WebpackHomeuiStartup21651602251818222762472
load16151176188915216891822
domContentLoaded16091171187615116811805
domInteractive171180131454
firstPaint1656066678189297
backgroundConnect2912399392955
firstReactRender20190417107324385
getState3543047913276
initialActions7215916613
loadScripts16051165186514916781794
setupStore2562995815242
FirefoxBrowserifyHomeuiStartup12881093167011013641467
load111195514438811711275
domContentLoaded111195514428811711275
domInteractive1013340859104243
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect26167592943
firstReactRender23195662228
getState62669623
initialActions30577212
loadScripts109294014288611511248
setupStore834510635
WebpackHomeuiStartup15691354217915316351889
load13031145161110713951497
domContentLoaded13031145161110713941497
domInteractive97322735592249
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect3019103133362
firstReactRender51419575462
getState11469121130
initialActions5012012313
loadScripts12801126159110713711479
setupStore12514418847
Benchmark value 223 exceeds gate value 10 for chrome browserify home mean backgroundConnect
Benchmark value 26 exceeds gate value 23 for chrome browserify home mean firstReactRender
Benchmark value 4 exceeds gate value 1 for chrome browserify home mean initialActions
Benchmark value 241 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 11 exceeds gate value 1.2 for chrome browserify home p95 initialActions
Benchmark value 20 exceeds gate value 17 for chrome browserify home p95 setupStore
Benchmark value 35 exceeds gate value 29 for chrome webpack home mean getState
Benchmark value 2473 exceeds gate value 2454 for chrome webpack home p95 uiStartup
Benchmark value 385 exceeds gate value 370 for chrome webpack home p95 firstReactRender
Benchmark value 276 exceeds gate value 195 for chrome webpack home p95 getState
Benchmark value 13 exceeds gate value 7 for chrome webpack home p95 initialActions
Benchmark value 242 exceeds gate value 65 for chrome webpack home p95 setupStore
Benchmark value 26 exceeds gate value 25 for firefox browserify home mean backgroundConnect
Benchmark value 4 exceeds gate value 1 for firefox browserify home mean initialActions
Benchmark value 243 exceeds gate value 195 for firefox browserify home p95 domInteractive
Benchmark value 12 exceeds gate value 2 for firefox browserify home p95 initialActions
Benchmark value 35 exceeds gate value 27 for firefox browserify home p95 setupStore
Benchmark value 31 exceeds gate value 26 for firefox webpack home mean backgroundConnect
Benchmark value 51 exceeds gate value 38 for firefox webpack home mean firstReactRender
Benchmark value 5 exceeds gate value 1 for firefox webpack home mean initialActions
Benchmark value 249 exceeds gate value 156 for firefox webpack home p95 domInteractive
Benchmark value 62 exceeds gate value 49 for firefox webpack home p95 backgroundConnect
Benchmark value 62 exceeds gate value 50 for firefox webpack home p95 firstReactRender
Benchmark value 13 exceeds gate value 2 for firefox webpack home p95 initialActions
Benchmark value 47 exceeds gate value 28 for firefox webpack home p95 setupStore
Sum of mean exceeds: 251ms | Sum of p95 exceeds: 747.8ms
Sum of all benchmark exceeds: 998.8ms

Bundle size diffs [🚀 Bundle size reduced!]
  • background: -491.09 KiB (-9.5%)
  • ui: 6.56 KiB (0.09%)
  • common: 855 Bytes (0.01%)

aganglada
aganglada previously approved these changes Aug 7, 2025
FrederikBolding
FrederikBolding previously approved these changes Aug 7, 2025
@xavier-brochard xavier-brochard added this pull request to the merge queue Aug 7, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 7, 2025
@aganglada aganglada added this pull request to the merge queue Aug 7, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Aug 7, 2025
@aganglada aganglada added this pull request to the merge queue Aug 7, 2025
@aganglada aganglada removed this pull request from the merge queue due to a manual request Aug 7, 2025
@metamaskbot
Copy link
Collaborator

Builds ready [63f347f]
UI Startup Metrics (1175 ± 58 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1175106313735812121272
load99387511635910321095
domContentLoaded98486511565810201084
domInteractive17133951829
firstPaint639137116539610051092
backgroundConnect21920526310223241
firstReactRender20153642132
getState1153061323
initialActions30781028
loadScripts77366693658810870
setupStore84385818
WebpackHomeuiStartup22381764257217223312497
load16631282195014917351860
domContentLoaded16561279194214817311854
domInteractive171198141452
firstPaint1666060378193271
backgroundConnect291484113650
firstReactRender21290403114362397
getState4143078613285
initialActions1022803969
loadScripts16521277193114617281842
setupStore3162957113288
FirefoxBrowserifyHomeuiStartup1300111915799513561475
load111897513657411641233
domContentLoaded111897513657411641233
domInteractive953427845103222
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect281574123165
firstReactRender23195352328
getState729711524
initialActions30577212
loadScripts109796213497311441211
setupStore9310416652
WebpackHomeuiStartup15661329197814516481896
load13131110169511613731531
domContentLoaded13131109169411613731531
domInteractive93302664893242
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect3219118173356
firstReactRender51429695566
getState92589827
initialActions30265314
loadScripts12881090166411413471502
setupStore949512725
Benchmark value 220 exceeds gate value 10 for chrome browserify home mean backgroundConnect
Benchmark value 4 exceeds gate value 1 for chrome browserify home mean initialActions
Benchmark value 241 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 8 exceeds gate value 1.2 for chrome browserify home p95 initialActions
Benchmark value 18 exceeds gate value 17 for chrome browserify home p95 setupStore
Benchmark value 2238 exceeds gate value 2192 for chrome webpack home mean uiStartup
Benchmark value 42 exceeds gate value 29 for chrome webpack home mean getState
Benchmark value 11 exceeds gate value 7 for chrome webpack home mean initialActions
Benchmark value 2498 exceeds gate value 2454 for chrome webpack home p95 uiStartup
Benchmark value 397 exceeds gate value 370 for chrome webpack home p95 firstReactRender
Benchmark value 285 exceeds gate value 195 for chrome webpack home p95 getState
Benchmark value 9 exceeds gate value 7 for chrome webpack home p95 initialActions
Benchmark value 288 exceeds gate value 65 for chrome webpack home p95 setupStore
Benchmark value 28 exceeds gate value 25 for firefox browserify home mean backgroundConnect
Benchmark value 4 exceeds gate value 1 for firefox browserify home mean initialActions
Benchmark value 10 exceeds gate value 9 for firefox browserify home mean setupStore
Benchmark value 222 exceeds gate value 195 for firefox browserify home p95 domInteractive
Benchmark value 12 exceeds gate value 2 for firefox browserify home p95 initialActions
Benchmark value 52 exceeds gate value 27 for firefox browserify home p95 setupStore
Benchmark value 32 exceeds gate value 26 for firefox webpack home mean backgroundConnect
Benchmark value 52 exceeds gate value 38 for firefox webpack home mean firstReactRender
Benchmark value 4 exceeds gate value 1 for firefox webpack home mean initialActions
Benchmark value 242 exceeds gate value 156 for firefox webpack home p95 domInteractive
Benchmark value 56 exceeds gate value 49 for firefox webpack home p95 backgroundConnect
Benchmark value 66 exceeds gate value 50 for firefox webpack home p95 firstReactRender
Benchmark value 14 exceeds gate value 2 for firefox webpack home p95 initialActions
Sum of mean exceeds: 306ms | Sum of p95 exceeds: 799.8ms
Sum of all benchmark exceeds: 1105.8ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 43 Bytes (0%)
  • ui: 0 Bytes (0%)
  • common: 1.07 KiB (0.01%)

@davidmurdoch
Copy link
Contributor

Does this bring new user-facing features? If not, I think the PR title should start with feat:

@aganglada aganglada changed the title feat: cp-13.1.0 bump solana snap fix: cp-13.1.0 bump solana snap Aug 7, 2025
@aganglada aganglada dismissed stale reviews from FrederikBolding and themself via 7a992b0 August 7, 2025 15:56
@aganglada aganglada force-pushed the feat/bump-solana-snap branch from 63f347f to 7a992b0 Compare August 7, 2025 15:56
@metamaskbot
Copy link
Collaborator

Builds ready [7a992b0]
UI Startup Metrics (1174 ± 69 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1174106813586912181308
load99687311666810461101
domContentLoaded98886811566810371094
domInteractive17135161734
firstPaint5827811623959841068
backgroundConnect2162052467219230
firstReactRender20154852128
getState125100121325
initialActions2030428
loadScripts77966094768830886
setupStore84223816
WebpackHomeuiStartup23271681270719524392666
load17301220216016818131966
domContentLoaded17221214215416618051950
domInteractive171281121445
firstPaint1626341358186264
backgroundConnect4013351533383
firstReactRender22194395111366389
getState2843176513252
initialActions72316722
loadScripts17151212196916018031932
setupStore2973156318260
FirefoxBrowserifyHomeuiStartup13051115170611813531584
load112497413598311851290
domContentLoaded112497413598311841289
domInteractive953324140107202
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect26177293040
firstReactRender24205762332
getState62598516
initialActions4016317214
loadScripts110495413158111641266
setupStore9312717634
WebpackHomeuiStartup15721386209313616381872
load13121156161610613841518
domContentLoaded13121156161510613841518
domInteractive95352654692210
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect3219138173453
firstReactRender534211995766
getState94508828
initialActions7017219433
loadScripts12881132155110513641496
setupStore10419419724
Benchmark value 216 exceeds gate value 10 for chrome browserify home mean backgroundConnect
Benchmark value 3 exceeds gate value 1 for chrome browserify home mean initialActions
Benchmark value 231 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 8 exceeds gate value 1.2 for chrome browserify home p95 initialActions
Benchmark value 2328 exceeds gate value 2192 for chrome webpack home mean uiStartup
Benchmark value 1730 exceeds gate value 1711 for chrome webpack home mean load
Benchmark value 1723 exceeds gate value 1704 for chrome webpack home mean domContentLoaded
Benchmark value 1716 exceeds gate value 1699 for chrome webpack home mean loadScripts
Benchmark value 2666 exceeds gate value 2454 for chrome webpack home p95 uiStartup
Benchmark value 389 exceeds gate value 370 for chrome webpack home p95 firstReactRender
Benchmark value 252 exceeds gate value 195 for chrome webpack home p95 getState
Benchmark value 22 exceeds gate value 7 for chrome webpack home p95 initialActions
Benchmark value 260 exceeds gate value 65 for chrome webpack home p95 setupStore
Benchmark value 27 exceeds gate value 25 for firefox browserify home mean backgroundConnect
Benchmark value 5 exceeds gate value 1 for firefox browserify home mean initialActions
Benchmark value 10 exceeds gate value 9 for firefox browserify home mean setupStore
Benchmark value 202 exceeds gate value 195 for firefox browserify home p95 domInteractive
Benchmark value 14 exceeds gate value 2 for firefox browserify home p95 initialActions
Benchmark value 34 exceeds gate value 27 for firefox browserify home p95 setupStore
Benchmark value 32 exceeds gate value 26 for firefox webpack home mean backgroundConnect
Benchmark value 53 exceeds gate value 38 for firefox webpack home mean firstReactRender
Benchmark value 8 exceeds gate value 1 for firefox webpack home mean initialActions
Benchmark value 210 exceeds gate value 156 for firefox webpack home p95 domInteractive
Benchmark value 53 exceeds gate value 49 for firefox webpack home p95 backgroundConnect
Benchmark value 66 exceeds gate value 50 for firefox webpack home p95 firstReactRender
Benchmark value 33 exceeds gate value 2 for firefox webpack home p95 initialActions
Sum of mean exceeds: 434ms | Sum of p95 exceeds: 848.8ms
Sum of all benchmark exceeds: 1282.8ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 43 Bytes (0%)
  • ui: 0 Bytes (0%)
  • common: 1.07 KiB (0.01%)

@aganglada
Copy link
Contributor

@metamaskbot update-policies

@metamaskbot
Copy link
Collaborator

Policies updated.
👀 Please review the diff for suspicious new powers.

🧠 Learn how: https://lavamoat.github.io/guides/policy-diff/#what-to-look-for-when-reviewing-a-policy-diff

@socket-security
Copy link

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Updated@​metamask/​solana-wallet-snap@​2.1.3 ⏵ 2.1.498 -210088 -12100100
Updated@​metamask/​assets-controllers@​73.0.0 ⏵ 73.0.29610090 +1100100

View full report

@metamaskbot
Copy link
Collaborator

✨ Files requiring CODEOWNER review ✨

🧩 @MetaMask/extension-devs (4 files, +0 -4)
  • 📁 lavamoat/
    • 📁 browserify/
      • 📁 beta/
        • 📄 policy.json +0 -1
      • 📁 experimental/
        • 📄 policy.json +0 -1
      • 📁 flask/
        • 📄 policy.json +0 -1
      • 📁 main/
        • 📄 policy.json +0 -1

📜 @MetaMask/policy-reviewers (4 files, +0 -4)
  • 📁 lavamoat/
    • 📁 browserify/
      • 📁 beta/
        • 📄 policy.json +0 -1
      • 📁 experimental/
        • 📄 policy.json +0 -1
      • 📁 flask/
        • 📄 policy.json +0 -1
      • 📁 main/
        • 📄 policy.json +0 -1

Tip

Follow the policy review process outlined in the LavaMoat Policy Review Process doc before expecting an approval from Policy Reviewers.


🔗 @MetaMask/supply-chain (4 files, +0 -4)
  • 📁 lavamoat/
    • 📁 browserify/
      • 📁 beta/
        • 📄 policy.json +0 -1
      • 📁 experimental/
        • 📄 policy.json +0 -1
      • 📁 flask/
        • 📄 policy.json +0 -1
      • 📁 main/
        • 📄 policy.json +0 -1

@metamaskbot
Copy link
Collaborator

Builds ready [73b31d0]
UI Startup Metrics (1171 ± 72 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1171104614337212221294
load99087212186910401103
domContentLoaded98286612106910341093
domInteractive16132831625
firstPaint5498411433999781072
backgroundConnect2162032649220233
firstReactRender20143852232
getState12484101527
initialActions2015338
loadScripts77466098468828880
setupStore74182811
WebpackHomeuiStartup21561574255319522602473
load16151150189315516991855
domContentLoaded16091147188515416931840
domInteractive1811100161461
firstPaint1736335960215264
backgroundConnect2913323313046
firstReactRender20087419114346393
getState3933108512286
initialActions8227027618
loadScripts16051145187315316891828
setupStore2463055514156
FirefoxBrowserifyHomeuiStartup13301118180811813911527
load114397314178712001297
domContentLoaded114397214168712001296
domInteractive983335552106223
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect3216162213282
firstReactRender25205582551
getState7217117523
initialActions30295212
loadScripts111996013138111741271
setupStore10320222646
WebpackHomeuiStartup15321354197613416021843
load12841116169411613351530
domContentLoaded12831116169411613351530
domInteractive88302654290182
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect3320145163655
firstReactRender51416865562
getState1047612843
initialActions31526311
loadScripts12601094166511413171510
setupStore84466722
Benchmark value 216 exceeds gate value 10 for chrome browserify home mean backgroundConnect
Benchmark value 3 exceeds gate value 1 for chrome browserify home mean initialActions
Benchmark value 233 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 8 exceeds gate value 1.2 for chrome browserify home p95 initialActions
Benchmark value 40 exceeds gate value 29 for chrome webpack home mean getState
Benchmark value 9 exceeds gate value 7 for chrome webpack home mean initialActions
Benchmark value 2473 exceeds gate value 2454 for chrome webpack home p95 uiStartup
Benchmark value 62 exceeds gate value 57 for chrome webpack home p95 domInteractive
Benchmark value 393 exceeds gate value 370 for chrome webpack home p95 firstReactRender
Benchmark value 286 exceeds gate value 195 for chrome webpack home p95 getState
Benchmark value 18 exceeds gate value 7 for chrome webpack home p95 initialActions
Benchmark value 156 exceeds gate value 65 for chrome webpack home p95 setupStore
Benchmark value 32 exceeds gate value 25 for firefox browserify home mean backgroundConnect
Benchmark value 26 exceeds gate value 25 for firefox browserify home mean firstReactRender
Benchmark value 3 exceeds gate value 1 for firefox browserify home mean initialActions
Benchmark value 11 exceeds gate value 9 for firefox browserify home mean setupStore
Benchmark value 223 exceeds gate value 195 for firefox browserify home p95 domInteractive
Benchmark value 82 exceeds gate value 70 for firefox browserify home p95 backgroundConnect
Benchmark value 12 exceeds gate value 2 for firefox browserify home p95 initialActions
Benchmark value 46 exceeds gate value 27 for firefox browserify home p95 setupStore
Benchmark value 34 exceeds gate value 26 for firefox webpack home mean backgroundConnect
Benchmark value 51 exceeds gate value 38 for firefox webpack home mean firstReactRender
Benchmark value 4 exceeds gate value 1 for firefox webpack home mean initialActions
Benchmark value 182 exceeds gate value 156 for firefox webpack home p95 domInteractive
Benchmark value 55 exceeds gate value 49 for firefox webpack home p95 backgroundConnect
Benchmark value 62 exceeds gate value 50 for firefox webpack home p95 firstReactRender
Benchmark value 43 exceeds gate value 32 for firefox webpack home p95 getState
Benchmark value 11 exceeds gate value 2 for firefox webpack home p95 initialActions
Sum of mean exceeds: 257ms | Sum of p95 exceeds: 594.8ms
Sum of all benchmark exceeds: 851.8ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 43 Bytes (0%)
  • ui: 1.69 KiB (0.02%)
  • common: 4.89 KiB (0.07%)

@aganglada aganglada enabled auto-merge August 8, 2025 08:54
@aganglada aganglada added this pull request to the merge queue Aug 8, 2025
Merged via the queue into main with commit ad08b4e Aug 8, 2025
271 of 274 checks passed
@aganglada aganglada deleted the feat/bump-solana-snap branch August 8, 2025 09:39
@github-actions github-actions bot locked and limited conversation to collaborators Aug 8, 2025
@gauthierpetetin gauthierpetetin added release-13.1.0 Issue or pull request that will be included in release 13.1.0 and removed release-13.3.0 labels Aug 12, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-13.1.0 Issue or pull request that will be included in release 13.1.0 team-new-networks PRs from the New Networks team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Solana WSS connections aren't maintained over time

9 participants