-
Notifications
You must be signed in to change notification settings - Fork 5.5k
fix: cp-13.1.0 bump solana snap #34887
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
|
All alerts resolved. Learn more about Socket for GitHub. This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. Ignoring alerts on:
|
Builds ready [515eb63]
UI Startup Metrics (1151 ± 62 ms)
Benchmark value 3 exceeds gate value 1 for chrome browserify home mean initialActions Benchmark value 227 exceeds gate value 18 for chrome browserify home p95 backgroundConnect Benchmark value 9 exceeds gate value 1.2 for chrome browserify home p95 initialActions Benchmark value 2203 exceeds gate value 2192 for chrome webpack home mean uiStartup Benchmark value 2580 exceeds gate value 2454 for chrome webpack home p95 uiStartup Benchmark value 390 exceeds gate value 370 for chrome webpack home p95 firstReactRender Benchmark value 12 exceeds gate value 7 for chrome webpack home p95 initialActions Benchmark value 273 exceeds gate value 65 for chrome webpack home p95 setupStore Benchmark value 32 exceeds gate value 25 for firefox browserify home mean backgroundConnect Benchmark value 4 exceeds gate value 1 for firefox browserify home mean initialActions Benchmark value 10 exceeds gate value 9 for firefox browserify home mean setupStore Benchmark value 224 exceeds gate value 195 for firefox browserify home p95 domInteractive Benchmark value 74 exceeds gate value 70 for firefox browserify home p95 backgroundConnect Benchmark value 29 exceeds gate value 24 for firefox browserify home p95 getState Benchmark value 14 exceeds gate value 2 for firefox browserify home p95 initialActions Benchmark value 47 exceeds gate value 27 for firefox browserify home p95 setupStore Benchmark value 34 exceeds gate value 26 for firefox webpack home mean backgroundConnect Benchmark value 53 exceeds gate value 38 for firefox webpack home mean firstReactRender Benchmark value 4 exceeds gate value 1 for firefox webpack home mean initialActions Benchmark value 249 exceeds gate value 156 for firefox webpack home p95 domInteractive Benchmark value 70 exceeds gate value 49 for firefox webpack home p95 backgroundConnect Benchmark value 65 exceeds gate value 50 for firefox webpack home p95 firstReactRender Benchmark value 37 exceeds gate value 32 for firefox webpack home p95 getState Benchmark value 13 exceeds gate value 2 for firefox webpack home p95 initialActions Benchmark value 34 exceeds gate value 28 for firefox webpack home p95 setupStore Sum of mean exceeds: 255ms | Sum of p95 exceeds: 796.8ms Sum of all benchmark exceeds: 1051.8ms Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
|
@SocketSecurity ignore npm/@metamask/[email protected] |
Builds ready [9d0dc43]
UI Startup Metrics (1141 ± 54 ms)
Benchmark value 2 exceeds gate value 1 for chrome browserify home mean initialActions Benchmark value 240 exceeds gate value 18 for chrome browserify home p95 backgroundConnect Benchmark value 5 exceeds gate value 1.2 for chrome browserify home p95 initialActions Benchmark value 2209 exceeds gate value 2192 for chrome webpack home mean uiStartup Benchmark value 2534 exceeds gate value 2454 for chrome webpack home p95 uiStartup Benchmark value 58 exceeds gate value 57 for chrome webpack home p95 domInteractive Benchmark value 391 exceeds gate value 370 for chrome webpack home p95 firstReactRender Benchmark value 269 exceeds gate value 195 for chrome webpack home p95 getState Benchmark value 11 exceeds gate value 7 for chrome webpack home p95 initialActions Benchmark value 158 exceeds gate value 65 for chrome webpack home p95 setupStore Benchmark value 31 exceeds gate value 25 for firefox browserify home mean backgroundConnect Benchmark value 26 exceeds gate value 25 for firefox browserify home mean firstReactRender Benchmark value 4 exceeds gate value 1 for firefox browserify home mean initialActions Benchmark value 10 exceeds gate value 9 for firefox browserify home mean setupStore Benchmark value 235 exceeds gate value 195 for firefox browserify home p95 domInteractive Benchmark value 12 exceeds gate value 2 for firefox browserify home p95 initialActions Benchmark value 37 exceeds gate value 27 for firefox browserify home p95 setupStore Benchmark value 30 exceeds gate value 26 for firefox webpack home mean backgroundConnect Benchmark value 51 exceeds gate value 38 for firefox webpack home mean firstReactRender Benchmark value 4 exceeds gate value 1 for firefox webpack home mean initialActions Benchmark value 222 exceeds gate value 156 for firefox webpack home p95 domInteractive Benchmark value 65 exceeds gate value 49 for firefox webpack home p95 backgroundConnect Benchmark value 62 exceeds gate value 50 for firefox webpack home p95 firstReactRender Benchmark value 41 exceeds gate value 32 for firefox webpack home p95 getState Benchmark value 17 exceeds gate value 2 for firefox webpack home p95 initialActions Sum of mean exceeds: 255ms | Sum of p95 exceeds: 676.8ms Sum of all benchmark exceeds: 931.8ms Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Builds ready [76644c5]
UI Startup Metrics (1175 ± 64 ms)
Benchmark value 4 exceeds gate value 1 for chrome browserify home mean initialActions Benchmark value 238 exceeds gate value 18 for chrome browserify home p95 backgroundConnect Benchmark value 16 exceeds gate value 1.2 for chrome browserify home p95 initialActions Benchmark value 2253 exceeds gate value 2192 for chrome webpack home mean uiStartup Benchmark value 32 exceeds gate value 29 for chrome webpack home mean getState Benchmark value 8 exceeds gate value 7 for chrome webpack home mean initialActions Benchmark value 2562 exceeds gate value 2454 for chrome webpack home p95 uiStartup Benchmark value 394 exceeds gate value 370 for chrome webpack home p95 firstReactRender Benchmark value 278 exceeds gate value 195 for chrome webpack home p95 getState Benchmark value 9 exceeds gate value 7 for chrome webpack home p95 initialActions Benchmark value 28 exceeds gate value 25 for firefox browserify home mean backgroundConnect Benchmark value 3 exceeds gate value 1 for firefox browserify home mean initialActions Benchmark value 226 exceeds gate value 195 for firefox browserify home p95 domInteractive Benchmark value 37 exceeds gate value 24 for firefox browserify home p95 getState Benchmark value 11 exceeds gate value 2 for firefox browserify home p95 initialActions Benchmark value 33 exceeds gate value 27 for firefox browserify home p95 setupStore Benchmark value 33 exceeds gate value 26 for firefox webpack home mean backgroundConnect Benchmark value 50 exceeds gate value 38 for firefox webpack home mean firstReactRender Benchmark value 7 exceeds gate value 1 for firefox webpack home mean initialActions Benchmark value 232 exceeds gate value 156 for firefox webpack home p95 domInteractive Benchmark value 81 exceeds gate value 49 for firefox webpack home p95 backgroundConnect Benchmark value 61 exceeds gate value 50 for firefox webpack home p95 firstReactRender Benchmark value 25 exceeds gate value 2 for firefox webpack home p95 initialActions Benchmark value 33 exceeds gate value 28 for firefox webpack home p95 setupStore Sum of mean exceeds: 306ms | Sum of p95 exceeds: 657.8ms Sum of all benchmark exceeds: 963.8ms Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
|
@metamaskbot update-policies |
|
Policies updated. 🧠 Learn how: https://lavamoat.github.io/guides/policy-diff/#what-to-look-for-when-reviewing-a-policy-diff |
Builds ready [1028513]
UI Startup Metrics (1187 ± 68 ms)
Benchmark value 26 exceeds gate value 23 for chrome browserify home mean firstReactRender Benchmark value 4 exceeds gate value 1 for chrome browserify home mean initialActions Benchmark value 241 exceeds gate value 18 for chrome browserify home p95 backgroundConnect Benchmark value 11 exceeds gate value 1.2 for chrome browserify home p95 initialActions Benchmark value 20 exceeds gate value 17 for chrome browserify home p95 setupStore Benchmark value 35 exceeds gate value 29 for chrome webpack home mean getState Benchmark value 2473 exceeds gate value 2454 for chrome webpack home p95 uiStartup Benchmark value 385 exceeds gate value 370 for chrome webpack home p95 firstReactRender Benchmark value 276 exceeds gate value 195 for chrome webpack home p95 getState Benchmark value 13 exceeds gate value 7 for chrome webpack home p95 initialActions Benchmark value 242 exceeds gate value 65 for chrome webpack home p95 setupStore Benchmark value 26 exceeds gate value 25 for firefox browserify home mean backgroundConnect Benchmark value 4 exceeds gate value 1 for firefox browserify home mean initialActions Benchmark value 243 exceeds gate value 195 for firefox browserify home p95 domInteractive Benchmark value 12 exceeds gate value 2 for firefox browserify home p95 initialActions Benchmark value 35 exceeds gate value 27 for firefox browserify home p95 setupStore Benchmark value 31 exceeds gate value 26 for firefox webpack home mean backgroundConnect Benchmark value 51 exceeds gate value 38 for firefox webpack home mean firstReactRender Benchmark value 5 exceeds gate value 1 for firefox webpack home mean initialActions Benchmark value 249 exceeds gate value 156 for firefox webpack home p95 domInteractive Benchmark value 62 exceeds gate value 49 for firefox webpack home p95 backgroundConnect Benchmark value 62 exceeds gate value 50 for firefox webpack home p95 firstReactRender Benchmark value 13 exceeds gate value 2 for firefox webpack home p95 initialActions Benchmark value 47 exceeds gate value 28 for firefox webpack home p95 setupStore Sum of mean exceeds: 251ms | Sum of p95 exceeds: 747.8ms Sum of all benchmark exceeds: 998.8ms Bundle size diffs [🚀 Bundle size reduced!]
|
Builds ready [63f347f]
UI Startup Metrics (1175 ± 58 ms)
Benchmark value 4 exceeds gate value 1 for chrome browserify home mean initialActions Benchmark value 241 exceeds gate value 18 for chrome browserify home p95 backgroundConnect Benchmark value 8 exceeds gate value 1.2 for chrome browserify home p95 initialActions Benchmark value 18 exceeds gate value 17 for chrome browserify home p95 setupStore Benchmark value 2238 exceeds gate value 2192 for chrome webpack home mean uiStartup Benchmark value 42 exceeds gate value 29 for chrome webpack home mean getState Benchmark value 11 exceeds gate value 7 for chrome webpack home mean initialActions Benchmark value 2498 exceeds gate value 2454 for chrome webpack home p95 uiStartup Benchmark value 397 exceeds gate value 370 for chrome webpack home p95 firstReactRender Benchmark value 285 exceeds gate value 195 for chrome webpack home p95 getState Benchmark value 9 exceeds gate value 7 for chrome webpack home p95 initialActions Benchmark value 288 exceeds gate value 65 for chrome webpack home p95 setupStore Benchmark value 28 exceeds gate value 25 for firefox browserify home mean backgroundConnect Benchmark value 4 exceeds gate value 1 for firefox browserify home mean initialActions Benchmark value 10 exceeds gate value 9 for firefox browserify home mean setupStore Benchmark value 222 exceeds gate value 195 for firefox browserify home p95 domInteractive Benchmark value 12 exceeds gate value 2 for firefox browserify home p95 initialActions Benchmark value 52 exceeds gate value 27 for firefox browserify home p95 setupStore Benchmark value 32 exceeds gate value 26 for firefox webpack home mean backgroundConnect Benchmark value 52 exceeds gate value 38 for firefox webpack home mean firstReactRender Benchmark value 4 exceeds gate value 1 for firefox webpack home mean initialActions Benchmark value 242 exceeds gate value 156 for firefox webpack home p95 domInteractive Benchmark value 56 exceeds gate value 49 for firefox webpack home p95 backgroundConnect Benchmark value 66 exceeds gate value 50 for firefox webpack home p95 firstReactRender Benchmark value 14 exceeds gate value 2 for firefox webpack home p95 initialActions Sum of mean exceeds: 306ms | Sum of p95 exceeds: 799.8ms Sum of all benchmark exceeds: 1105.8ms Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
|
Does this bring new user-facing features? If not, I think the PR title should start with |
7a992b0
63f347f to
7a992b0
Compare
Builds ready [7a992b0]
UI Startup Metrics (1174 ± 69 ms)
Benchmark value 3 exceeds gate value 1 for chrome browserify home mean initialActions Benchmark value 231 exceeds gate value 18 for chrome browserify home p95 backgroundConnect Benchmark value 8 exceeds gate value 1.2 for chrome browserify home p95 initialActions Benchmark value 2328 exceeds gate value 2192 for chrome webpack home mean uiStartup Benchmark value 1730 exceeds gate value 1711 for chrome webpack home mean load Benchmark value 1723 exceeds gate value 1704 for chrome webpack home mean domContentLoaded Benchmark value 1716 exceeds gate value 1699 for chrome webpack home mean loadScripts Benchmark value 2666 exceeds gate value 2454 for chrome webpack home p95 uiStartup Benchmark value 389 exceeds gate value 370 for chrome webpack home p95 firstReactRender Benchmark value 252 exceeds gate value 195 for chrome webpack home p95 getState Benchmark value 22 exceeds gate value 7 for chrome webpack home p95 initialActions Benchmark value 260 exceeds gate value 65 for chrome webpack home p95 setupStore Benchmark value 27 exceeds gate value 25 for firefox browserify home mean backgroundConnect Benchmark value 5 exceeds gate value 1 for firefox browserify home mean initialActions Benchmark value 10 exceeds gate value 9 for firefox browserify home mean setupStore Benchmark value 202 exceeds gate value 195 for firefox browserify home p95 domInteractive Benchmark value 14 exceeds gate value 2 for firefox browserify home p95 initialActions Benchmark value 34 exceeds gate value 27 for firefox browserify home p95 setupStore Benchmark value 32 exceeds gate value 26 for firefox webpack home mean backgroundConnect Benchmark value 53 exceeds gate value 38 for firefox webpack home mean firstReactRender Benchmark value 8 exceeds gate value 1 for firefox webpack home mean initialActions Benchmark value 210 exceeds gate value 156 for firefox webpack home p95 domInteractive Benchmark value 53 exceeds gate value 49 for firefox webpack home p95 backgroundConnect Benchmark value 66 exceeds gate value 50 for firefox webpack home p95 firstReactRender Benchmark value 33 exceeds gate value 2 for firefox webpack home p95 initialActions Sum of mean exceeds: 434ms | Sum of p95 exceeds: 848.8ms Sum of all benchmark exceeds: 1282.8ms Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
|
@metamaskbot update-policies |
|
Policies updated. 🧠 Learn how: https://lavamoat.github.io/guides/policy-diff/#what-to-look-for-when-reviewing-a-policy-diff |
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
✨ Files requiring CODEOWNER review ✨🧩 @MetaMask/extension-devs (4 files, +0 -4)
📜 @MetaMask/policy-reviewers (4 files, +0 -4)
Tip Follow the policy review process outlined in the LavaMoat Policy Review Process doc before expecting an approval from Policy Reviewers. 🔗 @MetaMask/supply-chain (4 files, +0 -4)
|
Builds ready [73b31d0]
UI Startup Metrics (1171 ± 72 ms)
Benchmark value 3 exceeds gate value 1 for chrome browserify home mean initialActions Benchmark value 233 exceeds gate value 18 for chrome browserify home p95 backgroundConnect Benchmark value 8 exceeds gate value 1.2 for chrome browserify home p95 initialActions Benchmark value 40 exceeds gate value 29 for chrome webpack home mean getState Benchmark value 9 exceeds gate value 7 for chrome webpack home mean initialActions Benchmark value 2473 exceeds gate value 2454 for chrome webpack home p95 uiStartup Benchmark value 62 exceeds gate value 57 for chrome webpack home p95 domInteractive Benchmark value 393 exceeds gate value 370 for chrome webpack home p95 firstReactRender Benchmark value 286 exceeds gate value 195 for chrome webpack home p95 getState Benchmark value 18 exceeds gate value 7 for chrome webpack home p95 initialActions Benchmark value 156 exceeds gate value 65 for chrome webpack home p95 setupStore Benchmark value 32 exceeds gate value 25 for firefox browserify home mean backgroundConnect Benchmark value 26 exceeds gate value 25 for firefox browserify home mean firstReactRender Benchmark value 3 exceeds gate value 1 for firefox browserify home mean initialActions Benchmark value 11 exceeds gate value 9 for firefox browserify home mean setupStore Benchmark value 223 exceeds gate value 195 for firefox browserify home p95 domInteractive Benchmark value 82 exceeds gate value 70 for firefox browserify home p95 backgroundConnect Benchmark value 12 exceeds gate value 2 for firefox browserify home p95 initialActions Benchmark value 46 exceeds gate value 27 for firefox browserify home p95 setupStore Benchmark value 34 exceeds gate value 26 for firefox webpack home mean backgroundConnect Benchmark value 51 exceeds gate value 38 for firefox webpack home mean firstReactRender Benchmark value 4 exceeds gate value 1 for firefox webpack home mean initialActions Benchmark value 182 exceeds gate value 156 for firefox webpack home p95 domInteractive Benchmark value 55 exceeds gate value 49 for firefox webpack home p95 backgroundConnect Benchmark value 62 exceeds gate value 50 for firefox webpack home p95 firstReactRender Benchmark value 43 exceeds gate value 32 for firefox webpack home p95 getState Benchmark value 11 exceeds gate value 2 for firefox webpack home p95 initialActions Sum of mean exceeds: 257ms | Sum of p95 exceeds: 594.8ms Sum of all benchmark exceeds: 851.8ms Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Description
Bumps the Solana Snap to v2.1.4, bringing in the following:
Changelog
CHANGELOG entry:
Related issues
Fixes: #34967
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist