-
Notifications
You must be signed in to change notification settings - Fork 5.5k
Description
Describe the bug
We received this report from an external party:
0xNAME Resolver Snap, listed on the Snap Directory, is simply resolving 0xNAMEs to addresses and was working perfectly since it was published until recently. We noticed that with the most recent MetaMask browser extension update (13.11.2) 0xNAMEs are not being resolved in the "send flow" anymore, although the Resolver Snap is installed and nothing changed on the Snap side. I attached a screenshot from my MetaMask Firefox browser extension, and here is the brief description of the issue: now when I write a name (for ex. yulia@beast) while sending anything, instead of resolving the name to the address as usually, I see the error message "invalid address".
We tested and confirmed the issue. The Snap supports names like alice@ethereum. The send flow attempts a validation check before calling any resolver Snaps here. Due to this, any name that does not look like a domain name will never work. This breaks multiple resolver Snaps, including 0xName and Clusters.
Expected behavior
When the 0xNAME Resolver Snap is installed and entering yulia@beast in the send flow on Ethereum, it resolves to an address.
Screenshots/Recordings
No response
Steps to reproduce
- Install 0xNAME Resolver Snap https://snaps.metamask.io/snap/npm/0xname-resolver-snap/
- Open send flow
- Enter
yulia@beast - Observe the error
Error messages or log output
Where was this bug found?
Live version (from official store)
Version
13.11.2, 13.13.2
Build type
None
Browser
Firefox
Operating system
MacOS
Hardware wallet
No response
Additional context
No response
Severity
No response
Metadata
Metadata
Assignees
Labels
Type
Projects
Status