chore: revert recent gas api endpoint changes by dbrans · Pull Request #25230 · MetaMask/metamask-extension

dbrans · 2024-06-11T20:07:03Z

Note

Once this PR is merged into develop, it will be cherry-picked into the next 11.16 hotfix as well as v12.0.0.

Description

We need to move quickly on a hotfix for the Extension due to a caching issue with the infura.io endpoint. The API team has asked us to revert a recent gas API endpoint change until the issue is resolved, which could take months.

Here is what is in this PR:

apply patch using core patch branch patch(gas-fee-controller@15.1.2): revert "use hardcoded Infura gas API urls" (#4068) core#4403
revert feat: use Infura gas API #23717

Re: Large gas-fee-controller patch file

The renaming of chunk files in the dist folder of the gas-fee-controller are the cause of the large .patch file. For more context, see this slack thread.

Re: Transitive dependencies on `gas-fee-controller@17.0.0`

Although transaction-controller and user-operation-controller depend on v17, they can be safely ignored. The only runtime dependency those packages have is on the enum-like GAS_ESTIMATE_TYPES, (example1, example2) which hasn't be touched in 3 years.

After the hotfix we need to:

Revert MetaMask/core/pulls/4068 in core on top of the latest gas-fee-controller (v17)
Upgrade gas-fee-controller in Extension and Mobile

Related issues

Related: Update Gas API to use MetaMask Gas API #25194

Manual testing steps

Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

github-actions · 2024-06-11T20:07:15Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

dbrans · 2024-06-11T20:07:36Z

@metamaskbot update-policies

metamaskbot · 2024-06-11T20:16:29Z

Policy update failed. You can review the logs or retry the policy update here

This reverts commit 3ed1ee1.

dbrans · 2024-06-12T01:58:04Z

@metamaskbot update-policies

metamaskbot · 2024-06-12T02:07:59Z

Policy update failed. You can review the logs or retry the policy update here

metamaskbot · 2024-06-12T12:46:43Z

Policy update failed. You can review the logs or retry the policy update here

metamaskbot · 2024-06-12T12:59:11Z

Policies updated

metamaskbot · 2024-06-12T13:55:01Z

No policy changes

metamaskbot · 2024-06-12T20:51:47Z

Builds ready [418ecfc]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (133 ± 162 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	71	109	86	9	4
		domContentLoaded	9	24	13	4	2
		load	42	1606	133	338	162
		domInteractive	9	24	13	4	2

Bundle size diffs [🚀 Bundle size reduced!]

background: 111 Bytes (0.00%)
ui: 0 Bytes (0.00%)
common: -703 Bytes (-0.01%)

codecov · 2024-06-12T20:52:37Z

Codecov Report

Attention: Patch coverage is 66.66667% with 3 lines in your changes missing coverage. Please review.

Project coverage is 65.65%. Comparing base (d8e0cd1) to head (f011d0a).
Report is 12 commits behind head on develop.

Files	Patch %	Lines
app/scripts/metamask-controller.js	50.00%	3 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           develop   #25230      +/-   ##
===========================================
+ Coverage    65.61%   65.65%   +0.04%     
===========================================
  Files         1372     1375       +3     
  Lines        54519    54530      +11     
  Branches     14282    14299      +17     
===========================================
+ Hits         35770    35800      +30     
+ Misses       18749    18730      -19

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

metamaskbot · 2024-06-13T02:06:05Z

Builds ready [63bf6c1]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (45 ± 4 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	64	96	77	8	4
		domContentLoaded	9	20	10	2	1
		load	39	68	45	7	4
		domInteractive	9	20	10	2	1

Bundle size diffs [🚀 Bundle size reduced!]

background: 111 Bytes (0.00%)
ui: 0 Bytes (0.00%)
common: -703 Bytes (-0.01%)

…api-endpoint

metamaskbot · 2024-06-13T16:24:48Z

Builds ready [f011d0a]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (265 ± 284 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	76	146	105	15	7
		domContentLoaded	11	38	14	6	3
		load	45	2052	265	592	284
		domInteractive	11	38	14	6	3

mcmire

Had one question, but otherwise LGTM.

package.json

patch gas-fee-controller@15.1.2 using MetaMask/core#4403

843950c

dbrans added the team-transactions Transactions team label Jun 11, 2024

dbrans requested a review from OGPoyraz June 11, 2024 20:08

dbrans marked this pull request as ready for review June 11, 2024 20:08

dbrans requested review from a team as code owners June 11, 2024 20:08

dbrans requested a review from blurpesec June 11, 2024 20:09

blurpesec previously approved these changes Jun 11, 2024

View reviewed changes

Revert "feat: use Infura gas API (#23717)"

b81bb5d

This reverts commit 3ed1ee1.

dbrans dismissed blurpesec’s stale review via b81bb5d June 12, 2024 01:57

dbrans force-pushed the dbrans/revert-gas-api-endpoint branch from 9e44361 to b81bb5d Compare June 12, 2024 01:57

Update LavaMoat policies

4a1b4e8

metamaskbot requested review from a team as code owners June 12, 2024 12:59

micaelae force-pushed the dbrans/revert-gas-api-endpoint branch 2 times, most recently from 4a72af4 to 418ecfc Compare June 12, 2024 19:42

dbrans force-pushed the dbrans/revert-gas-api-endpoint branch from 0b6ff56 to 4a1b4e8 Compare June 12, 2024 21:26

dbrans mentioned this pull request Jun 12, 2024

fix: swap+send e2e tests #25275

Merged

7 tasks

micaelae previously approved these changes Jun 12, 2024

View reviewed changes

Merge branch 'develop' into dbrans/revert-gas-api-endpoint

63bf6c1

dbrans dismissed micaelae’s stale review via 63bf6c1 June 12, 2024 22:47

dbrans added the DO-NOT-MERGE Pull requests that should not be merged label Jun 13, 2024

Merge remote-tracking branch 'origin/develop' into dbrans/revert-gas-…

f011d0a

…api-endpoint

dbrans removed the DO-NOT-MERGE Pull requests that should not be merged label Jun 13, 2024

blurpesec self-requested a review June 13, 2024 16:34

blurpesec approved these changes Jun 13, 2024

View reviewed changes

dbrans requested a review from a team June 13, 2024 17:15

mcmire reviewed Jun 13, 2024

View reviewed changes

package.json Show resolved Hide resolved

mcmire approved these changes Jun 13, 2024

View reviewed changes

dbrans merged commit 04642d2 into develop Jun 13, 2024

dbrans deleted the dbrans/revert-gas-api-endpoint branch June 13, 2024 17:48

github-actions bot locked and limited conversation to collaborators Jun 13, 2024

metamaskbot added the release-12.1.0 Issue or pull request that will be included in release 12.1.0 label Jun 13, 2024

Conversation

dbrans commented Jun 11, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Re: Large gas-fee-controller patch file

Re: Transitive dependencies on gas-fee-controller@17.0.0

After the hotfix we need to:

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

Uh oh!

github-actions bot commented Jun 11, 2024

Uh oh!

dbrans commented Jun 11, 2024

Uh oh!

metamaskbot commented Jun 11, 2024

Uh oh!

dbrans commented Jun 12, 2024

Uh oh!

metamaskbot commented Jun 12, 2024

Uh oh!

metamaskbot commented Jun 12, 2024

Uh oh!

metamaskbot commented Jun 12, 2024

Uh oh!

metamaskbot commented Jun 12, 2024

Uh oh!

metamaskbot commented Jun 12, 2024

Uh oh!

codecov bot commented Jun 12, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

metamaskbot commented Jun 13, 2024

Uh oh!

metamaskbot commented Jun 13, 2024

Uh oh!

mcmire left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

dbrans commented Jun 11, 2024 •

edited

Loading

Re: Transitive dependencies on `gas-fee-controller@17.0.0`

codecov bot commented Jun 12, 2024 •

edited

Loading