feat(deeplinks): add preference flag to skip the (up and coming) "Deep Link Interstitial" #33634

davidmurdoch · 2025-06-12T20:40:15Z

Adds a new preference, that isn't used anywhere yet, but will be soon: skipDeepLinkInterstitial

This is part of the work to introduce Deep Linking into the extension.

To test it go to the Security tab in Settings and check and uncheck the new Deep Link Interstitial checkbox. It should stay set on reload. It doesn't do anything in the app yet.

MetaMask.Mozilla.Firefox.2025-06-12.17-22-07.mp4

…ial"

github-actions · 2025-06-12T20:40:25Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

metamaskbot · 2025-06-12T21:05:19Z

Builds ready [c01fd0a]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- content-script: 0
- offscreen: 0

UI Startup Metrics (1210 ± 59 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1210	1102	1381	59	1243	1326
			load	1050	951	1175	53	1076	1154
			domContentLoaded	1044	945	1166	53	1072	1148
			domInteractive	16	13	32	3	16	23
			firstPaint	795	132	1174	394	1070	1155
			backgroundConnect	7	4	23	4	7	20
			firstReactRender	20	16	37	3	20	23
			getState	13	6	31	7	18	27
			initialActions	0	0	1	0	0	1
			loadScripts	796	699	924	52	824	900
			setupStore	8	5	31	4	8	15
	Webpack	Home	uiStartup	2047	1563	2462	219	2199	2402
			load	1580	1236	1860	165	1693	1837
			domContentLoaded	1575	1232	1851	164	1686	1829
			domInteractive	15	11	47	8	13	42
			firstPaint	150	59	338	54	187	257
			backgroundConnect	20	10	43	7	22	35
			firstReactRender	147	45	360	111	281	354
			getState	14	5	308	30	12	25
			initialActions	3	1	6	1	3	4
			loadScripts	1571	1231	1840	162	1685	1818
			setupStore	34	7	312	74	17	303
Firefox	Browserify	Home	uiStartup	1313	1153	1643	73	1354	1445
			load	1171	1027	1492	79	1221	1318
			domContentLoaded	1171	1026	1492	79	1221	1318
			domInteractive	97	35	182	27	107	146
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	19	13	57	6	20	26
			firstReactRender	22	20	27	1	23	26
			getState	8	4	38	6	8	11
			initialActions	0	0	1	0	0	1
			loadScripts	1154	1012	1477	79	1194	1301
			setupStore	6	4	22	3	6	11
	Webpack	Home	uiStartup	1508	1360	1819	94	1554	1718
			load	1303	1173	1620	90	1340	1490
			domContentLoaded	1302	1172	1619	90	1340	1490
			domInteractive	80	34	143	14	85	112
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	22	16	76	8	23	41
			firstReactRender	41	30	51	4	44	47
			getState	10	4	32	7	10	31
			initialActions	0	0	1	0	1	1
			loadScripts	1283	1158	1602	91	1320	1469
			setupStore	9	5	43	6	9	22

Benchmark value 21 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 35 exceeds gate value 32 for chrome webpack home mean setupStore
Benchmark value 303 exceeds gate value 65 for chrome webpack home p95 setupStore
Benchmark value 42 exceeds gate value 38 for firefox webpack home mean firstReactRender
Sum of mean exceeds: 7ms | Sum of p95 exceeds: 241ms
Sum of all benchmark exceeds: 248ms

metamaskbot · 2025-06-12T21:50:19Z

Builds ready [6b755ad]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- content-script: 0
- offscreen: 0

UI Startup Metrics (1240 ± 60 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1240	1133	1405	60	1282	1347
			load	1071	973	1218	57	1108	1163
			domContentLoaded	1064	966	1214	57	1104	1157
			domInteractive	18	14	53	6	17	33
			firstPaint	690	77	1170	428	1087	1150
			backgroundConnect	8	4	56	6	8	22
			firstReactRender	21	17	57	5	21	32
			getState	14	5	49	9	19	33
			initialActions	0	0	1	0	0	1
			loadScripts	815	718	961	56	853	906
			setupStore	8	6	25	3	9	13
	Webpack	Home	uiStartup	2083	1619	2563	221	2236	2500
			load	1613	1269	1955	169	1729	1909
			domContentLoaded	1607	1265	1946	169	1725	1899
			domInteractive	15	11	50	10	13	46
			firstPaint	158	59	333	56	197	279
			backgroundConnect	20	10	43	6	23	35
			firstReactRender	137	46	375	109	175	349
			getState	14	4	317	31	11	26
			initialActions	3	1	7	1	3	4
			loadScripts	1603	1264	1935	167	1723	1889
			setupStore	61	7	321	108	20	312
Firefox	Browserify	Home	uiStartup	1317	1171	1499	80	1370	1471
			load	1176	1016	1343	82	1238	1328
			domContentLoaded	1176	1015	1343	82	1238	1328
			domInteractive	101	36	190	29	116	151
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	20	13	115	10	20	29
			firstReactRender	22	20	28	1	23	26
			getState	7	5	36	3	8	9
			initialActions	0	0	1	0	0	1
			loadScripts	1157	1002	1328	79	1220	1314
			setupStore	6	4	33	3	6	11
	Webpack	Home	uiStartup	1464	1324	1713	91	1505	1657
			load	1274	1157	1542	91	1308	1462
			domContentLoaded	1274	1157	1542	91	1308	1462
			domInteractive	75	30	151	16	81	103
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	20	15	40	4	21	25
			firstReactRender	39	28	46	4	42	45
			getState	9	4	30	6	9	29
			initialActions	0	0	1	0	1	1
			loadScripts	1256	1142	1525	91	1292	1443
			setupStore	8	5	29	4	7	20

Benchmark value 1241 exceeds gate value 1234 for chrome browserify home mean uiStartup
Benchmark value 1071 exceeds gate value 1070 for chrome browserify home mean load
Benchmark value 1064 exceeds gate value 1061 for chrome browserify home mean domContentLoaded
Benchmark value 22 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 62 exceeds gate value 32 for chrome webpack home mean setupStore
Benchmark value 2501 exceeds gate value 2454 for chrome webpack home p95 uiStartup
Benchmark value 312 exceeds gate value 65 for chrome webpack home p95 setupStore
Benchmark value 39 exceeds gate value 38 for firefox webpack home mean firstReactRender
Sum of mean exceeds: 42ms | Sum of p95 exceeds: 298ms
Sum of all benchmark exceeds: 340ms

metamaskbot · 2025-06-12T23:07:16Z

Builds ready [f839f9d]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- content-script: 0
- offscreen: 0

UI Startup Metrics (1186 ± 60 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1186	1104	1350	60	1223	1301
			load	1028	933	1178	54	1055	1129
			domContentLoaded	1022	927	1173	54	1050	1122
			domInteractive	16	14	32	4	16	29
			firstPaint	679	72	1180	417	1043	1129
			backgroundConnect	7	4	37	5	7	23
			firstReactRender	21	16	52	6	21	32
			getState	13	6	32	7	17	27
			initialActions	0	0	1	0	0	1
			loadScripts	779	694	927	53	805	884
			setupStore	8	5	26	4	8	20
	Webpack	Home	uiStartup	2054	1533	2534	215	2189	2442
			load	1591	1195	1957	173	1703	1877
			domContentLoaded	1585	1191	1948	172	1696	1868
			domInteractive	17	11	79	14	13	52
			firstPaint	155	67	339	50	187	254
			backgroundConnect	24	11	345	33	24	33
			firstReactRender	133	46	368	104	145	346
			getState	20	4	318	52	14	23
			initialActions	5	1	289	29	3	4
			loadScripts	1582	1189	1937	171	1694	1858
			setupStore	45	7	313	89	19	308
Firefox	Browserify	Home	uiStartup	1342	1179	1777	88	1384	1510
			load	1191	1055	1415	75	1239	1352
			domContentLoaded	1190	1055	1414	75	1238	1352
			domInteractive	103	35	248	31	118	151
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	20	13	107	10	21	28
			firstReactRender	24	22	54	3	24	26
			getState	8	4	44	5	8	10
			initialActions	0	0	2	0	0	1
			loadScripts	1172	1042	1399	72	1222	1318
			setupStore	6	4	37	3	6	11
	Webpack	Home	uiStartup	1523	1355	1799	117	1621	1731
			load	1331	1165	1608	120	1428	1550
			domContentLoaded	1330	1165	1608	120	1427	1549
			domInteractive	81	32	150	16	88	108
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	19	16	42	4	20	24
			firstReactRender	40	27	50	4	43	46
			getState	8	5	29	4	8	10
			initialActions	0	0	1	0	1	1
			loadScripts	1313	1149	1591	120	1410	1532
			setupStore	7	5	22	2	8	9

Benchmark value 24 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 20 exceeds gate value 17 for chrome browserify home p95 setupStore
Benchmark value 45 exceeds gate value 32 for chrome webpack home mean setupStore
Benchmark value 308 exceeds gate value 65 for chrome webpack home p95 setupStore
Benchmark value 41 exceeds gate value 38 for firefox webpack home mean firstReactRender
Sum of mean exceeds: 16ms | Sum of p95 exceeds: 252ms
Sum of all benchmark exceeds: 268ms

metamaskbot · 2025-06-12T23:55:42Z

Builds ready [bac4e32]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- content-script: 0
- offscreen: 0

UI Startup Metrics (1226 ± 59 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1226	1118	1385	59	1269	1332
			load	1062	958	1207	56	1103	1152
			domContentLoaded	1057	954	1203	55	1096	1146
			domInteractive	17	14	38	5	17	30
			firstPaint	774	86	1173	411	1079	1144
			backgroundConnect	7	4	26	3	7	11
			firstReactRender	20	16	39	3	20	27
			getState	13	6	30	7	19	27
			initialActions	0	0	1	0	0	1
			loadScripts	806	705	947	54	844	897
			setupStore	8	5	14	2	8	13
	Webpack	Home	uiStartup	2069	1600	2547	213	2184	2468
			load	1605	1255	1958	169	1719	1897
			domContentLoaded	1599	1251	1949	168	1715	1886
			domInteractive	15	11	49	9	13	44
			firstPaint	157	60	380	55	189	262
			backgroundConnect	23	13	267	25	23	33
			firstReactRender	125	45	361	99	124	350
			getState	13	4	313	30	13	21
			initialActions	3	1	4	1	3	4
			loadScripts	1596	1249	1938	167	1713	1875
			setupStore	58	6	330	105	18	310
Firefox	Browserify	Home	uiStartup	1356	1187	1542	73	1396	1519
			load	1205	1052	1409	75	1248	1360
			domContentLoaded	1204	1051	1409	75	1247	1359
			domInteractive	102	35	207	28	118	150
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	21	15	52	6	22	30
			firstReactRender	24	21	56	4	24	27
			getState	8	4	34	4	8	10
			initialActions	0	0	1	0	0	1
			loadScripts	1186	1036	1386	73	1225	1334
			setupStore	7	4	35	4	7	12
	Webpack	Home	uiStartup	1506	1347	1788	109	1600	1724
			load	1319	1161	1605	112	1424	1543
			domContentLoaded	1319	1161	1605	112	1424	1542
			domInteractive	79	60	125	12	86	99
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	19	14	26	2	20	25
			firstReactRender	39	28	47	3	41	44
			getState	8	5	41	6	8	27
			initialActions	0	0	2	1	1	1
			loadScripts	1302	1142	1588	113	1409	1526
			setupStore	7	5	22	2	7	9

Benchmark value 58 exceeds gate value 32 for chrome webpack home mean setupStore
Benchmark value 2468 exceeds gate value 2454 for chrome webpack home p95 uiStartup
Benchmark value 310 exceeds gate value 65 for chrome webpack home p95 setupStore
Benchmark value 40 exceeds gate value 38 for firefox webpack home mean firstReactRender
Sum of mean exceeds: 28ms | Sum of p95 exceeds: 259ms
Sum of all benchmark exceeds: 287ms

metamaskbot · 2025-06-14T00:10:57Z

Builds ready [8378437]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- content-script: 0
- offscreen: 0

UI Startup Metrics (1178 ± 68 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1178	1050	1575	68	1223	1264
			load	1025	911	1421	67	1068	1105
			domContentLoaded	1019	902	1414	67	1062	1100
			domInteractive	16	12	35	4	16	28
			firstPaint	721	83	1419	401	1036	1102
			backgroundConnect	7	4	27	4	7	22
			firstReactRender	19	16	33	3	19	23
			getState	13	6	31	6	18	23
			initialActions	0	0	1	0	0	1
			loadScripts	778	670	919	55	826	859
			setupStore	7	5	13	2	8	12
	Webpack	Home	uiStartup	2026	1649	2575	224	2177	2392
			load	1588	1277	2014	182	1713	1873
			domContentLoaded	1583	1273	2005	182	1708	1864
			domInteractive	18	11	190	26	13	48
			firstPaint	158	81	380	55	186	255
			backgroundConnect	19	10	39	5	21	33
			firstReactRender	118	45	363	93	109	339
			getState	10	4	31	4	11	23
			initialActions	2	1	8	1	3	4
			loadScripts	1580	1271	1994	180	1706	1853
			setupStore	48	7	314	93	18	307
Firefox	Browserify	Home	uiStartup	1315	1182	1603	76	1361	1469
			load	1168	1044	1445	73	1203	1320
			domContentLoaded	1168	1044	1445	73	1203	1320
			domInteractive	100	35	203	28	112	145
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	21	12	116	15	20	32
			firstReactRender	23	20	30	2	23	26
			getState	8	4	39	5	8	12
			initialActions	0	0	1	0	0	1
			loadScripts	1148	1028	1332	70	1184	1296
			setupStore	7	4	79	8	6	11
	Webpack	Home	uiStartup	1499	1336	1803	106	1574	1687
			load	1308	1162	1606	108	1401	1507
			domContentLoaded	1308	1161	1606	108	1401	1506
			domInteractive	77	63	124	11	82	97
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	20	16	43	4	21	25
			firstReactRender	40	27	50	4	42	45
			getState	8	5	30	5	8	27
			initialActions	0	0	2	1	1	1
			loadScripts	1290	1146	1588	109	1385	1490
			setupStore	7	5	38	3	8	9

Benchmark value 22 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 48 exceeds gate value 32 for chrome webpack home mean setupStore
Benchmark value 307 exceeds gate value 65 for chrome webpack home p95 setupStore
Benchmark value 40 exceeds gate value 38 for firefox webpack home mean firstReactRender
Sum of mean exceeds: 18ms | Sum of p95 exceeds: 246ms
Sum of all benchmark exceeds: 264ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 56 Bytes (0%)
ui: 1.64 KiB (0.02%)
common: 735 Bytes (0.01%)

metamaskbot · 2025-06-17T21:58:07Z

Builds ready [3706d82]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- content-script: 0
- offscreen: 0

UI Startup Metrics (1231 ± 57 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1231	1124	1410	57	1265	1322
			load	1064	956	1196	51	1097	1142
			domContentLoaded	1058	951	1190	51	1093	1137
			domInteractive	19	14	151	15	17	43
			firstPaint	647	138	1203	434	1083	1154
			backgroundConnect	7	4	33	4	7	17
			firstReactRender	21	16	44	5	22	37
			getState	14	6	64	9	18	28
			initialActions	0	0	1	0	0	1
			loadScripts	810	712	939	49	839	885
			setupStore	8	5	22	3	8	16
	Webpack	Home	uiStartup	2090	1641	2624	230	2244	2517
			load	1620	1290	2145	192	1735	1975
			domContentLoaded	1612	1286	2139	190	1729	1970
			domInteractive	16	11	70	12	13	49
			firstPaint	158	62	637	70	168	260
			backgroundConnect	21	13	124	12	23	35
			firstReactRender	155	46	359	113	301	355
			getState	17	5	322	43	12	22
			initialActions	3	1	5	1	3	4
			loadScripts	1609	1284	2129	189	1726	1960
			setupStore	14	7	33	5	16	22
Firefox	Browserify	Home	uiStartup	1342	1218	1721	91	1379	1527
			load	1184	1060	1477	74	1220	1333
			domContentLoaded	1184	1060	1476	75	1220	1333
			domInteractive	108	35	344	50	114	193
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	22	13	113	14	22	48
			firstReactRender	23	20	36	2	24	26
			getState	10	5	95	10	8	27
			initialActions	0	0	1	0	0	1
			loadScripts	1165	1043	1458	72	1202	1304
			setupStore	8	4	66	7	8	22
	Webpack	Home	uiStartup	1531	1320	3411	241	1598	1837
			load	1320	1148	1803	131	1426	1552
			domContentLoaded	1320	1147	1803	131	1426	1552
			domInteractive	91	30	449	62	88	259
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	20	14	44	5	21	29
			firstReactRender	39	32	47	3	42	45
			getState	25	4	1612	160	9	29
			initialActions	0	0	2	1	1	1
			loadScripts	1302	1128	1786	132	1406	1533
			setupStore	8	5	45	5	8	20

Benchmark value 43 exceeds gate value 41 for chrome browserify home p95 domInteractive
Benchmark value 2517 exceeds gate value 2454 for chrome webpack home p95 uiStartup
Benchmark value 27 exceeds gate value 24 for firefox browserify home p95 getState
Benchmark value 40 exceeds gate value 38 for firefox webpack home mean firstReactRender
Benchmark value 26 exceeds gate value 15 for firefox webpack home mean getState
Benchmark value 259 exceeds gate value 156 for firefox webpack home p95 domInteractive
Sum of mean exceeds: 13ms | Sum of p95 exceeds: 171ms
Sum of all benchmark exceeds: 184ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 56 Bytes (0%)
ui: 1.64 KiB (0.02%)
common: 735 Bytes (0.01%)

metamaskbot · 2025-06-18T01:36:42Z

Builds ready [3706d82]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- content-script: 0
- offscreen: 0

UI Startup Metrics (1217 ± 75 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1217	1090	1515	75	1254	1380
			load	1054	946	1321	74	1089	1209
			domContentLoaded	1047	941	1316	74	1084	1203
			domInteractive	17	14	122	11	16	25
			firstPaint	748	131	1326	414	1070	1199
			backgroundConnect	8	4	28	5	7	21
			firstReactRender	20	16	37	3	21	27
			getState	14	5	60	8	20	26
			initialActions	0	0	1	0	0	0
			loadScripts	804	694	1063	71	844	956
			setupStore	8	5	24	3	8	16
	Webpack	Home	uiStartup	2125	1671	2724	191	2237	2460
			load	1633	1240	2144	159	1718	1926
			domContentLoaded	1627	1236	2125	158	1714	1913
			domInteractive	19	11	219	28	13	50
			firstPaint	169	60	790	94	186	352
			backgroundConnect	24	9	335	32	24	38
			firstReactRender	161	47	361	118	301	355
			getState	17	4	315	42	13	28
			initialActions	3	1	5	1	3	4
			loadScripts	1623	1235	2114	156	1712	1903
			setupStore	36	7	320	74	18	299
Firefox	Browserify	Home	uiStartup	1377	1211	1681	112	1426	1633
			load	1213	1050	1431	88	1283	1361
			domContentLoaded	1213	1050	1430	88	1283	1361
			domInteractive	115	35	516	69	116	186
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	22	15	113	11	22	38
			firstReactRender	24	21	56	5	24	29
			getState	10	5	85	10	8	28
			initialActions	0	0	1	0	0	1
			loadScripts	1194	1039	1415	88	1263	1346
			setupStore	9	4	71	10	7	25
	Webpack	Home	uiStartup	1562	1363	2016	154	1659	1939
			load	1359	1183	1780	132	1468	1601
			domContentLoaded	1359	1182	1780	132	1468	1601
			domInteractive	90	30	419	67	84	288
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	20	15	107	9	21	29
			firstReactRender	41	34	51	3	44	47
			getState	10	5	32	7	9	29
			initialActions	0	0	1	0	1	1
			loadScripts	1340	1158	1762	131	1449	1582
			setupStore	8	5	36	5	8	19

Benchmark value 1380 exceeds gate value 1365 for chrome browserify home p95 uiStartup
Benchmark value 1209 exceeds gate value 1190 for chrome browserify home p95 load
Benchmark value 1203 exceeds gate value 1180 for chrome browserify home p95 domContentLoaded
Benchmark value 1199 exceeds gate value 1180 for chrome browserify home p95 firstPaint
Benchmark value 22 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 956 exceeds gate value 940 for chrome browserify home p95 loadScripts
Benchmark value 36 exceeds gate value 32 for chrome webpack home mean setupStore
Benchmark value 2461 exceeds gate value 2454 for chrome webpack home p95 uiStartup
Benchmark value 352 exceeds gate value 334 for chrome webpack home p95 firstPaint
Benchmark value 299 exceeds gate value 65 for chrome webpack home p95 setupStore
Benchmark value 115 exceeds gate value 110 for firefox browserify home mean domInteractive
Benchmark value 28 exceeds gate value 24 for firefox browserify home p95 getState
Benchmark value 42 exceeds gate value 38 for firefox webpack home mean firstReactRender
Benchmark value 1939 exceeds gate value 1935 for firefox webpack home p95 uiStartup
Benchmark value 288 exceeds gate value 156 for firefox webpack home p95 domInteractive
Sum of mean exceeds: 13ms | Sum of p95 exceeds: 495ms
Sum of all benchmark exceeds: 508ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 56 Bytes (0%)
ui: 1.64 KiB (0.02%)
common: 735 Bytes (0.01%)

metamaskbot · 2025-06-18T16:56:41Z

Builds ready [182da20]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- content-script: 0
- offscreen: 0

UI Startup Metrics (1246 ± 67 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1246	1138	1569	67	1288	1354
			load	1072	953	1383	69	1113	1202
			domContentLoaded	1064	944	1374	70	1109	1197
			domInteractive	17	14	36	4	17	28
			firstPaint	783	121	1385	412	1092	1209
			backgroundConnect	9	4	30	5	9	26
			firstReactRender	24	16	143	13	26	38
			getState	16	6	64	9	22	32
			initialActions	0	0	1	0	0	1
			loadScripts	812	694	1090	69	857	944
			setupStore	9	5	21	4	9	18
	Webpack	Home	uiStartup	2253	1772	2757	184	2317	2685
			load	1737	1326	2208	152	1796	1998
			domContentLoaded	1731	1322	2200	151	1792	1986
			domInteractive	19	11	112	20	14	61
			firstPaint	173	67	682	95	200	327
			backgroundConnect	20	12	47	6	22	38
			firstReactRender	218	90	406	102	340	398
			getState	14	4	292	29	13	31
			initialActions	5	1	297	29	3	4
			loadScripts	1728	1321	2188	150	1789	1975
			setupStore	17	7	276	27	17	24
Firefox	Browserify	Home	uiStartup	1429	1213	1794	103	1488	1677
			load	1256	1079	1465	80	1309	1392
			domContentLoaded	1256	1078	1465	81	1309	1392
			domInteractive	120	37	324	49	142	201
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	24	14	96	13	26	55
			firstReactRender	26	22	55	4	26	31
			getState	11	5	97	15	9	20
			initialActions	0	0	1	0	0	1
			loadScripts	1234	1064	1448	79	1287	1366
			setupStore	9	5	84	9	8	18
	Webpack	Home	uiStartup	1527	1345	2060	166	1584	1975
			load	1323	1169	1800	140	1403	1656
			domContentLoaded	1323	1169	1800	140	1403	1656
			domInteractive	95	30	385	66	89	280
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	20	15	45	4	21	28
			firstReactRender	39	30	51	4	42	45
			getState	11	5	102	11	9	29
			initialActions	0	0	2	1	1	1
			loadScripts	1305	1151	1780	140	1387	1631
			setupStore	10	6	101	10	9	22

Benchmark value 1246 exceeds gate value 1234 for chrome browserify home mean uiStartup
Benchmark value 1072 exceeds gate value 1070 for chrome browserify home mean load
Benchmark value 1065 exceeds gate value 1061 for chrome browserify home mean domContentLoaded
Benchmark value 25 exceeds gate value 23 for chrome browserify home mean firstReactRender
Benchmark value 16 exceeds gate value 15 for chrome browserify home mean getState
Benchmark value 1202 exceeds gate value 1190 for chrome browserify home p95 load
Benchmark value 1197 exceeds gate value 1180 for chrome browserify home p95 domContentLoaded
Benchmark value 1210 exceeds gate value 1180 for chrome browserify home p95 firstPaint
Benchmark value 26 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 944 exceeds gate value 940 for chrome browserify home p95 loadScripts
Benchmark value 18 exceeds gate value 17 for chrome browserify home p95 setupStore
Benchmark value 2253 exceeds gate value 2192 for chrome webpack home mean uiStartup
Benchmark value 1737 exceeds gate value 1711 for chrome webpack home mean load
Benchmark value 1732 exceeds gate value 1704 for chrome webpack home mean domContentLoaded
Benchmark value 1728 exceeds gate value 1699 for chrome webpack home mean loadScripts
Benchmark value 2686 exceeds gate value 2454 for chrome webpack home p95 uiStartup
Benchmark value 61 exceeds gate value 57 for chrome webpack home p95 domInteractive
Benchmark value 398 exceeds gate value 370 for chrome webpack home p95 firstReactRender
Benchmark value 1975 exceeds gate value 1970 for chrome webpack home p95 loadScripts
Benchmark value 1430 exceeds gate value 1405 for firefox browserify home mean uiStartup
Benchmark value 1257 exceeds gate value 1245 for firefox browserify home mean load
Benchmark value 1256 exceeds gate value 1239 for firefox browserify home mean domContentLoaded
Benchmark value 121 exceeds gate value 110 for firefox browserify home mean domInteractive
Benchmark value 26 exceeds gate value 25 for firefox browserify home mean firstReactRender
Benchmark value 12 exceeds gate value 11 for firefox browserify home mean getState
Benchmark value 1235 exceeds gate value 1230 for firefox browserify home mean loadScripts
Benchmark value 1677 exceeds gate value 1660 for firefox browserify home p95 uiStartup
Benchmark value 201 exceeds gate value 195 for firefox browserify home p95 domInteractive
Benchmark value 39 exceeds gate value 38 for firefox webpack home mean firstReactRender
Benchmark value 1975 exceeds gate value 1935 for firefox webpack home p95 uiStartup
Benchmark value 280 exceeds gate value 156 for firefox webpack home p95 domInteractive
Benchmark value 1631 exceeds gate value 1630 for firefox webpack home p95 loadScripts
Sum of mean exceeds: 238ms | Sum of p95 exceeds: 529ms
Sum of all benchmark exceeds: 767ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 56 Bytes (0%)
ui: 1.64 KiB (0.02%)
common: 735 Bytes (0.01%)

MajorLift

LGTM! Didn't find any unexpected behavior on manual testing.

ui/pages/settings/security-tab/security-tab.container.js

metamaskbot · 2025-06-18T18:15:38Z

Builds ready [6503361]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- content-script: 0
- offscreen: 0

UI Startup Metrics (1223 ± 69 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1223	1122	1619	69	1257	1332
			load	1055	948	1411	66	1084	1166
			domContentLoaded	1048	934	1403	66	1079	1157
			domInteractive	19	13	127	13	16	39
			firstPaint	776	75	1411	403	1069	1164
			backgroundConnect	8	4	36	5	7	25
			firstReactRender	20	16	35	3	21	27
			getState	13	6	29	6	18	26
			initialActions	0	0	1	0	0	0
			loadScripts	799	688	995	58	828	909
			setupStore	8	5	27	3	8	16
	Webpack	Home	uiStartup	2131	1614	2602	222	2239	2555
			load	1620	1209	1993	184	1725	1924
			domContentLoaded	1614	1205	1988	183	1718	1920
			domInteractive	16	11	61	12	13	49
			firstPaint	156	60	334	59	184	285
			backgroundConnect	22	10	276	26	23	33
			firstReactRender	237	88	439	120	372	399
			getState	14	4	313	31	13	29
			initialActions	3	1	8	1	3	4
			loadScripts	1611	1204	1974	181	1716	1911
			setupStore	23	7	317	49	19	27
Firefox	Browserify	Home	uiStartup	1377	1221	1845	110	1433	1592
			load	1210	1079	1420	78	1260	1355
			domContentLoaded	1209	1079	1420	78	1260	1355
			domInteractive	109	36	319	45	118	176
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	26	13	222	25	25	55
			firstReactRender	24	21	36	3	24	29
			getState	12	4	136	20	8	39
			initialActions	0	0	1	0	0	1
			loadScripts	1190	1063	1394	77	1241	1330
			setupStore	9	4	125	15	7	15
	Webpack	Home	uiStartup	1619	1392	2182	167	1698	1988
			load	1399	1203	1879	142	1484	1658
			domContentLoaded	1399	1202	1878	142	1484	1658
			domInteractive	98	31	357	62	91	289
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	22	16	55	5	23	34
			firstReactRender	43	31	55	4	45	50
			getState	10	5	33	5	10	25
			initialActions	1	0	1	0	1	1
			loadScripts	1380	1182	1856	142	1465	1641
			setupStore	12	7	113	12	11	32

Benchmark value 25 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 238 exceeds gate value 235 for chrome webpack home mean firstReactRender
Benchmark value 2555 exceeds gate value 2454 for chrome webpack home p95 uiStartup
Benchmark value 399 exceeds gate value 370 for chrome webpack home p95 firstReactRender
Benchmark value 27 exceeds gate value 25 for firefox browserify home mean backgroundConnect
Benchmark value 12 exceeds gate value 11 for firefox browserify home mean getState
Benchmark value 10 exceeds gate value 9 for firefox browserify home mean setupStore
Benchmark value 39 exceeds gate value 24 for firefox browserify home p95 getState
Benchmark value 1620 exceeds gate value 1615 for firefox webpack home mean uiStartup
Benchmark value 1400 exceeds gate value 1380 for firefox webpack home mean load
Benchmark value 1400 exceeds gate value 1380 for firefox webpack home mean domContentLoaded
Benchmark value 43 exceeds gate value 38 for firefox webpack home mean firstReactRender
Benchmark value 1380 exceeds gate value 1360 for firefox webpack home mean loadScripts
Benchmark value 1988 exceeds gate value 1935 for firefox webpack home p95 uiStartup
Benchmark value 289 exceeds gate value 156 for firefox webpack home p95 domInteractive
Benchmark value 1641 exceeds gate value 1630 for firefox webpack home p95 loadScripts
Benchmark value 32 exceeds gate value 28 for firefox webpack home p95 setupStore
Sum of mean exceeds: 77ms | Sum of p95 exceeds: 353ms
Sum of all benchmark exceeds: 430ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 56 Bytes (0%)
ui: 1.64 KiB (0.02%)
common: 735 Bytes (0.01%)

davidmurdoch added 2 commits June 12, 2025 16:36

feat: add preference flag skip the up and coming "Deep Link Interstit…

0d38d8a

…ial"

locales

f4b1b51

davidmurdoch added the deeplink Related to deep linking feature label Jun 12, 2025

metamaskbot added the team-extension-platform Extension Platform team label Jun 12, 2025

fix a test

c01fd0a

better position

6b755ad

davidmurdoch marked this pull request as ready for review June 12, 2025 21:24

davidmurdoch added 2 commits June 12, 2025 18:35

not needed

232cfc1

update snapshot

f839f9d

davidmurdoch changed the title ~~feat: add preference flag skip the up and coming "Deep Link Interstitial"~~ feat: add preference flag to skip the (up and coming) "Deep Link Interstitial" Jun 12, 2025

update changelog

bac4e32

davidmurdoch changed the title ~~feat: add preference flag to skip the (up and coming) "Deep Link Interstitial"~~ feat(deeplinks): add preference flag to skip the (up and coming) "Deep Link Interstitial" Jun 13, 2025

davidmurdoch requested a review from a team June 13, 2025 21:59

davidmurdoch added the no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed label Jun 13, 2025

Merge branch 'main' into skipDeepLinkInterstitial

8378437

davidmurdoch added this to PR review queue Jun 14, 2025

github-project-automation bot moved this to Needs dev review in PR review queue Jun 14, 2025

Merge branch 'main' into skipDeepLinkInterstitial

3706d82

Merge branch 'main' into skipDeepLinkInterstitial

182da20

Merge branch 'main' into skipDeepLinkInterstitial

7448e7c

MajorLift previously approved these changes Jun 18, 2025

View reviewed changes

davidmurdoch commented Jun 18, 2025

View reviewed changes

ui/pages/settings/security-tab/security-tab.container.js Outdated Show resolved Hide resolved

Update ui/pages/settings/security-tab/security-tab.container.js

6503361

davidmurdoch dismissed MajorLift’s stale review via 6503361 June 18, 2025 17:50

davidmurdoch requested a review from MajorLift June 18, 2025 17:50

MajorLift approved these changes Jun 18, 2025

View reviewed changes

HowardBraham approved these changes Jun 18, 2025

View reviewed changes

github-project-automation bot moved this from Needs dev review to Review finalised - Ready to be merged in PR review queue Jun 18, 2025

HowardBraham added this pull request to the merge queue Jun 18, 2025

Merged via the queue into main with commit 59f2593 Jun 18, 2025
145 checks passed

HowardBraham deleted the skipDeepLinkInterstitial branch June 18, 2025 19:31

github-actions bot locked and limited conversation to collaborators Jun 18, 2025

metamaskbot added the release-12.22.0 Issue or pull request that will be included in release 12.22.0 label Jun 18, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat(deeplinks): add preference flag to skip the (up and coming) "Deep Link Interstitial" #33634

feat(deeplinks): add preference flag to skip the (up and coming) "Deep Link Interstitial" #33634

davidmurdoch commented Jun 12, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Jun 12, 2025

Uh oh!

metamaskbot commented Jun 12, 2025

Uh oh!

metamaskbot commented Jun 12, 2025

Uh oh!

metamaskbot commented Jun 12, 2025

Uh oh!

metamaskbot commented Jun 12, 2025

Uh oh!

metamaskbot commented Jun 14, 2025

Uh oh!

metamaskbot commented Jun 17, 2025

Uh oh!

metamaskbot commented Jun 18, 2025

Uh oh!

metamaskbot commented Jun 18, 2025

Uh oh!

MajorLift left a comment

Uh oh!

Uh oh!

metamaskbot commented Jun 18, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

feat(deeplinks): add preference flag to skip the (up and coming) "Deep Link Interstitial" #33634

feat(deeplinks): add preference flag to skip the (up and coming) "Deep Link Interstitial" #33634

Conversation

davidmurdoch commented Jun 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Jun 12, 2025

Uh oh!

metamaskbot commented Jun 12, 2025

Uh oh!

metamaskbot commented Jun 12, 2025

Uh oh!

metamaskbot commented Jun 12, 2025

Uh oh!

metamaskbot commented Jun 12, 2025

Uh oh!

metamaskbot commented Jun 14, 2025

Uh oh!

metamaskbot commented Jun 17, 2025

Uh oh!

metamaskbot commented Jun 18, 2025

Uh oh!

metamaskbot commented Jun 18, 2025

Uh oh!

MajorLift left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

metamaskbot commented Jun 18, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

davidmurdoch commented Jun 12, 2025 •

edited

Loading