fix: integrate phishing controller actions into NFT messengers cp-13.0.0 #34216
+41
−20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
…into fix/bulk-scan-nfts
Contributor
Author
|
@metamaskbot update-policies |
Collaborator
|
Policies updated. 🧠 Learn how: https://lavamoat.github.io/guides/policy-diff/#what-to-look-for-when-reviewing-a-policy-diff |
Collaborator
Builds ready [2d9c58c]
UI Startup Metrics (1283 ± 64 ms)
Benchmark value 1091 exceeds gate value 1070 for chrome browserify home mean load Benchmark value 1084 exceeds gate value 1061 for chrome browserify home mean domContentLoaded Benchmark value 265 exceeds gate value 10 for chrome browserify home mean backgroundConnect Benchmark value 4 exceeds gate value 1 for chrome browserify home mean initialActions Benchmark value 1383 exceeds gate value 1365 for chrome browserify home p95 uiStartup Benchmark value 43 exceeds gate value 41 for chrome browserify home p95 domInteractive Benchmark value 278 exceeds gate value 18 for chrome browserify home p95 backgroundConnect Benchmark value 13 exceeds gate value 1.2 for chrome browserify home p95 initialActions Benchmark value 22 exceeds gate value 17 for chrome browserify home p95 setupStore Benchmark value 2241 exceeds gate value 2192 for chrome webpack home mean uiStartup Benchmark value 14 exceeds gate value 7 for chrome webpack home mean initialActions Benchmark value 2652 exceeds gate value 2454 for chrome webpack home p95 uiStartup Benchmark value 64 exceeds gate value 57 for chrome webpack home p95 domInteractive Benchmark value 386 exceeds gate value 370 for chrome webpack home p95 firstReactRender Benchmark value 28 exceeds gate value 7 for chrome webpack home p95 initialActions Benchmark value 1422 exceeds gate value 1405 for firefox browserify home mean uiStartup Benchmark value 27 exceeds gate value 25 for firefox browserify home mean backgroundConnect Benchmark value 5 exceeds gate value 1 for firefox browserify home mean initialActions Benchmark value 11 exceeds gate value 9 for firefox browserify home mean setupStore Benchmark value 207 exceeds gate value 195 for firefox browserify home p95 domInteractive Benchmark value 82 exceeds gate value 70 for firefox browserify home p95 backgroundConnect Benchmark value 28 exceeds gate value 24 for firefox browserify home p95 getState Benchmark value 23 exceeds gate value 2 for firefox browserify home p95 initialActions Benchmark value 38 exceeds gate value 27 for firefox browserify home p95 setupStore Benchmark value 1723 exceeds gate value 1615 for firefox webpack home mean uiStartup Benchmark value 1436 exceeds gate value 1380 for firefox webpack home mean load Benchmark value 1436 exceeds gate value 1380 for firefox webpack home mean domContentLoaded Benchmark value 111 exceeds gate value 100 for firefox webpack home mean domInteractive Benchmark value 52 exceeds gate value 26 for firefox webpack home mean backgroundConnect Benchmark value 56 exceeds gate value 38 for firefox webpack home mean firstReactRender Benchmark value 6 exceeds gate value 1 for firefox webpack home mean initialActions Benchmark value 1416 exceeds gate value 1360 for firefox webpack home mean loadScripts Benchmark value 2115 exceeds gate value 1935 for firefox webpack home p95 uiStartup Benchmark value 1737 exceeds gate value 1660 for firefox webpack home p95 load Benchmark value 1737 exceeds gate value 1660 for firefox webpack home p95 domContentLoaded Benchmark value 345 exceeds gate value 156 for firefox webpack home p95 domInteractive Benchmark value 67 exceeds gate value 50 for firefox webpack home p95 firstReactRender Benchmark value 17 exceeds gate value 2 for firefox webpack home p95 initialActions Benchmark value 1699 exceeds gate value 1630 for firefox webpack home p95 loadScripts Sum of mean exceeds: 768ms | Sum of p95 exceeds: 1222.8ms Sum of all benchmark exceeds: 1990.8ms Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
| "@metamask/address-book-controller": "^6.1.0", | ||
| "@metamask/announcement-controller": "^7.0.3", | ||
| "@metamask/approval-controller": "^7.0.0", | ||
| "@metamask/assets-controllers": "patch:@metamask/assets-controllers@npm%3A70.0.0#~/.yarn/patches/@metamask-assets-controllers-npm-70.0.0-59ac13a5ca.patch", |
Contributor
There was a problem hiding this comment.
Just confirming that the patch that existed is no longer needed. And if that is the case we should probably remove it from .yarn/patches - https://github.com/MetaMask/metamask-extension/blob/main/.yarn/patches/%40metamask-assets-controllers-npm-70.0.0-59ac13a5ca.patch
Contributor
Author
There was a problem hiding this comment.
Looks like this patch is still needed just confirmed with assets team, I have updated the patch to work with the major version bump of assets controller to 72.0.0
Collaborator
Builds ready [e2c97bc]
UI Startup Metrics (1219 ± 73 ms)
Benchmark value 3 exceeds gate value 1 for chrome browserify home mean initialActions Benchmark value 47 exceeds gate value 41 for chrome browserify home p95 domInteractive Benchmark value 267 exceeds gate value 18 for chrome browserify home p95 backgroundConnect Benchmark value 38 exceeds gate value 33 for chrome browserify home p95 getState Benchmark value 11 exceeds gate value 1.2 for chrome browserify home p95 initialActions Benchmark value 2268 exceeds gate value 2192 for chrome webpack home mean uiStartup Benchmark value 252 exceeds gate value 235 for chrome webpack home mean firstReactRender Benchmark value 12 exceeds gate value 7 for chrome webpack home mean initialActions Benchmark value 2653 exceeds gate value 2454 for chrome webpack home p95 uiStartup Benchmark value 62 exceeds gate value 57 for chrome webpack home p95 domInteractive Benchmark value 401 exceeds gate value 370 for chrome webpack home p95 firstReactRender Benchmark value 27 exceeds gate value 7 for chrome webpack home p95 initialActions Benchmark value 7 exceeds gate value 1 for firefox browserify home mean initialActions Benchmark value 12 exceeds gate value 9 for firefox browserify home mean setupStore Benchmark value 245 exceeds gate value 195 for firefox browserify home p95 domInteractive Benchmark value 32 exceeds gate value 24 for firefox browserify home p95 getState Benchmark value 27 exceeds gate value 2 for firefox browserify home p95 initialActions Benchmark value 36 exceeds gate value 27 for firefox browserify home p95 setupStore Benchmark value 1707 exceeds gate value 1615 for firefox webpack home mean uiStartup Benchmark value 1435 exceeds gate value 1380 for firefox webpack home mean load Benchmark value 1434 exceeds gate value 1380 for firefox webpack home mean domContentLoaded Benchmark value 101 exceeds gate value 100 for firefox webpack home mean domInteractive Benchmark value 39 exceeds gate value 26 for firefox webpack home mean backgroundConnect Benchmark value 56 exceeds gate value 38 for firefox webpack home mean firstReactRender Benchmark value 4 exceeds gate value 1 for firefox webpack home mean initialActions Benchmark value 1413 exceeds gate value 1360 for firefox webpack home mean loadScripts Benchmark value 2145 exceeds gate value 1935 for firefox webpack home p95 uiStartup Benchmark value 1721 exceeds gate value 1660 for firefox webpack home p95 load Benchmark value 1720 exceeds gate value 1660 for firefox webpack home p95 domContentLoaded Benchmark value 297 exceeds gate value 156 for firefox webpack home p95 domInteractive Benchmark value 83 exceeds gate value 49 for firefox webpack home p95 backgroundConnect Benchmark value 67 exceeds gate value 50 for firefox webpack home p95 firstReactRender Benchmark value 13 exceeds gate value 2 for firefox webpack home p95 initialActions Benchmark value 1696 exceeds gate value 1630 for firefox webpack home p95 loadScripts Sum of mean exceeds: 641ms | Sum of p95 exceeds: 1216.8ms Sum of all benchmark exceeds: 1857.8ms Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
…g up the repository." This reverts commit 7bdba31.
Contributor
Author
|
@metamaskbot update-policies |
Collaborator
|
Policies updated. 🧠 Learn how: https://lavamoat.github.io/guides/policy-diff/#what-to-look-for-when-reviewing-a-policy-diff |
Collaborator
Builds ready [8eb2926]
UI Startup Metrics (1256 ± 72 ms)
Benchmark value 1080 exceeds gate value 1070 for chrome browserify home mean load Benchmark value 1071 exceeds gate value 1061 for chrome browserify home mean domContentLoaded Benchmark value 262 exceeds gate value 10 for chrome browserify home mean backgroundConnect Benchmark value 3 exceeds gate value 1 for chrome browserify home mean initialActions Benchmark value 1382 exceeds gate value 1365 for chrome browserify home p95 uiStartup Benchmark value 285 exceeds gate value 18 for chrome browserify home p95 backgroundConnect Benchmark value 12 exceeds gate value 1.2 for chrome browserify home p95 initialActions Benchmark value 2350 exceeds gate value 2192 for chrome webpack home mean uiStartup Benchmark value 1775 exceeds gate value 1711 for chrome webpack home mean load Benchmark value 1768 exceeds gate value 1704 for chrome webpack home mean domContentLoaded Benchmark value 247 exceeds gate value 235 for chrome webpack home mean firstReactRender Benchmark value 15 exceeds gate value 7 for chrome webpack home mean initialActions Benchmark value 1764 exceeds gate value 1699 for chrome webpack home mean loadScripts Benchmark value 2737 exceeds gate value 2454 for chrome webpack home p95 uiStartup Benchmark value 2031 exceeds gate value 2030 for chrome webpack home p95 load Benchmark value 2026 exceeds gate value 2005 for chrome webpack home p95 domContentLoaded Benchmark value 64 exceeds gate value 57 for chrome webpack home p95 domInteractive Benchmark value 400 exceeds gate value 370 for chrome webpack home p95 firstReactRender Benchmark value 25 exceeds gate value 7 for chrome webpack home p95 initialActions Benchmark value 2024 exceeds gate value 1970 for chrome webpack home p95 loadScripts Benchmark value 1447 exceeds gate value 1405 for firefox browserify home mean uiStartup Benchmark value 1250 exceeds gate value 1245 for firefox browserify home mean load Benchmark value 1250 exceeds gate value 1239 for firefox browserify home mean domContentLoaded Benchmark value 27 exceeds gate value 25 for firefox browserify home mean backgroundConnect Benchmark value 3 exceeds gate value 1 for firefox browserify home mean initialActions Benchmark value 11 exceeds gate value 9 for firefox browserify home mean setupStore Benchmark value 1745 exceeds gate value 1660 for firefox browserify home p95 uiStartup Benchmark value 236 exceeds gate value 195 for firefox browserify home p95 domInteractive Benchmark value 39 exceeds gate value 24 for firefox browserify home p95 getState Benchmark value 10 exceeds gate value 2 for firefox browserify home p95 initialActions Benchmark value 44 exceeds gate value 27 for firefox browserify home p95 setupStore Benchmark value 1697 exceeds gate value 1615 for firefox webpack home mean uiStartup Benchmark value 1431 exceeds gate value 1380 for firefox webpack home mean load Benchmark value 1431 exceeds gate value 1380 for firefox webpack home mean domContentLoaded Benchmark value 104 exceeds gate value 100 for firefox webpack home mean domInteractive Benchmark value 57 exceeds gate value 38 for firefox webpack home mean firstReactRender Benchmark value 6 exceeds gate value 1 for firefox webpack home mean initialActions Benchmark value 1411 exceeds gate value 1360 for firefox webpack home mean loadScripts Benchmark value 2077 exceeds gate value 1935 for firefox webpack home p95 uiStartup Benchmark value 1704 exceeds gate value 1660 for firefox webpack home p95 load Benchmark value 1704 exceeds gate value 1660 for firefox webpack home p95 domContentLoaded Benchmark value 289 exceeds gate value 156 for firefox webpack home p95 domInteractive Benchmark value 66 exceeds gate value 50 for firefox webpack home p95 firstReactRender Benchmark value 14 exceeds gate value 2 for firefox webpack home p95 initialActions Benchmark value 1685 exceeds gate value 1630 for firefox webpack home p95 loadScripts Sum of mean exceeds: 994ms | Sum of p95 exceeds: 1320.8ms Sum of all benchmark exceeds: 2314.8ms Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Collaborator
Builds ready [fb884f9]
UI Startup Metrics (1231 ± 70 ms)
Benchmark value 3 exceeds gate value 1 for chrome browserify home mean initialActions Benchmark value 836 exceeds gate value 830 for chrome browserify home mean loadScripts Benchmark value 42 exceeds gate value 41 for chrome browserify home p95 domInteractive Benchmark value 223 exceeds gate value 18 for chrome browserify home p95 backgroundConnect Benchmark value 18 exceeds gate value 1.2 for chrome browserify home p95 initialActions Benchmark value 954 exceeds gate value 940 for chrome browserify home p95 loadScripts Benchmark value 2255 exceeds gate value 2192 for chrome webpack home mean uiStartup Benchmark value 240 exceeds gate value 235 for chrome webpack home mean firstReactRender Benchmark value 12 exceeds gate value 7 for chrome webpack home mean initialActions Benchmark value 2578 exceeds gate value 2454 for chrome webpack home p95 uiStartup Benchmark value 390 exceeds gate value 370 for chrome webpack home p95 firstReactRender Benchmark value 17 exceeds gate value 7 for chrome webpack home p95 initialActions Benchmark value 1478 exceeds gate value 1405 for firefox browserify home mean uiStartup Benchmark value 1272 exceeds gate value 1245 for firefox browserify home mean load Benchmark value 1271 exceeds gate value 1239 for firefox browserify home mean domContentLoaded Benchmark value 111 exceeds gate value 110 for firefox browserify home mean domInteractive Benchmark value 30 exceeds gate value 25 for firefox browserify home mean backgroundConnect Benchmark value 26 exceeds gate value 25 for firefox browserify home mean firstReactRender Benchmark value 5 exceeds gate value 1 for firefox browserify home mean initialActions Benchmark value 1246 exceeds gate value 1230 for firefox browserify home mean loadScripts Benchmark value 13 exceeds gate value 9 for firefox browserify home mean setupStore Benchmark value 1746 exceeds gate value 1660 for firefox browserify home p95 uiStartup Benchmark value 245 exceeds gate value 195 for firefox browserify home p95 domInteractive Benchmark value 99 exceeds gate value 70 for firefox browserify home p95 backgroundConnect Benchmark value 18 exceeds gate value 2 for firefox browserify home p95 initialActions Benchmark value 57 exceeds gate value 27 for firefox browserify home p95 setupStore Benchmark value 1698 exceeds gate value 1615 for firefox webpack home mean uiStartup Benchmark value 1446 exceeds gate value 1380 for firefox webpack home mean load Benchmark value 1445 exceeds gate value 1380 for firefox webpack home mean domContentLoaded Benchmark value 104 exceeds gate value 100 for firefox webpack home mean domInteractive Benchmark value 57 exceeds gate value 38 for firefox webpack home mean firstReactRender Benchmark value 5 exceeds gate value 1 for firefox webpack home mean initialActions Benchmark value 1427 exceeds gate value 1360 for firefox webpack home mean loadScripts Benchmark value 14 exceeds gate value 13 for firefox webpack home mean setupStore Benchmark value 2012 exceeds gate value 1935 for firefox webpack home p95 uiStartup Benchmark value 1692 exceeds gate value 1660 for firefox webpack home p95 load Benchmark value 1691 exceeds gate value 1660 for firefox webpack home p95 domContentLoaded Benchmark value 218 exceeds gate value 156 for firefox webpack home p95 domInteractive Benchmark value 66 exceeds gate value 50 for firefox webpack home p95 firstReactRender Benchmark value 13 exceeds gate value 2 for firefox webpack home p95 initialActions Benchmark value 1671 exceeds gate value 1630 for firefox webpack home p95 loadScripts Sum of mean exceeds: 758ms | Sum of p95 exceeds: 871.8ms Sum of all benchmark exceeds: 1629.8ms Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
…into fix/bulk-scan-nfts
Collaborator
Builds ready [8d46f39]
UI Startup Metrics (1270 ± 58 ms)
Benchmark value 1093 exceeds gate value 1070 for chrome browserify home mean load Benchmark value 1086 exceeds gate value 1061 for chrome browserify home mean domContentLoaded Benchmark value 212 exceeds gate value 10 for chrome browserify home mean backgroundConnect Benchmark value 4 exceeds gate value 1 for chrome browserify home mean initialActions Benchmark value 881 exceeds gate value 830 for chrome browserify home mean loadScripts Benchmark value 228 exceeds gate value 18 for chrome browserify home p95 backgroundConnect Benchmark value 14 exceeds gate value 1.2 for chrome browserify home p95 initialActions Benchmark value 967 exceeds gate value 940 for chrome browserify home p95 loadScripts Benchmark value 2363 exceeds gate value 2192 for chrome webpack home mean uiStartup Benchmark value 1856 exceeds gate value 1711 for chrome webpack home mean load Benchmark value 1844 exceeds gate value 1704 for chrome webpack home mean domContentLoaded Benchmark value 57 exceeds gate value 40 for chrome webpack home mean backgroundConnect Benchmark value 35 exceeds gate value 29 for chrome webpack home mean getState Benchmark value 8 exceeds gate value 7 for chrome webpack home mean initialActions Benchmark value 1836 exceeds gate value 1699 for chrome webpack home mean loadScripts Benchmark value 2743 exceeds gate value 2454 for chrome webpack home p95 uiStartup Benchmark value 2154 exceeds gate value 2030 for chrome webpack home p95 load Benchmark value 2139 exceeds gate value 2005 for chrome webpack home p95 domContentLoaded Benchmark value 60 exceeds gate value 57 for chrome webpack home p95 domInteractive Benchmark value 285 exceeds gate value 90 for chrome webpack home p95 backgroundConnect Benchmark value 243 exceeds gate value 195 for chrome webpack home p95 getState Benchmark value 14 exceeds gate value 7 for chrome webpack home p95 initialActions Benchmark value 2128 exceeds gate value 1970 for chrome webpack home p95 loadScripts Benchmark value 1489 exceeds gate value 1405 for firefox browserify home mean uiStartup Benchmark value 1284 exceeds gate value 1245 for firefox browserify home mean load Benchmark value 1284 exceeds gate value 1239 for firefox browserify home mean domContentLoaded Benchmark value 27 exceeds gate value 25 for firefox browserify home mean backgroundConnect Benchmark value 30 exceeds gate value 25 for firefox browserify home mean firstReactRender Benchmark value 13 exceeds gate value 11 for firefox browserify home mean getState Benchmark value 4 exceeds gate value 1 for firefox browserify home mean initialActions Benchmark value 1262 exceeds gate value 1230 for firefox browserify home mean loadScripts Benchmark value 10 exceeds gate value 9 for firefox browserify home mean setupStore Benchmark value 1714 exceeds gate value 1660 for firefox browserify home p95 uiStartup Benchmark value 284 exceeds gate value 195 for firefox browserify home p95 domInteractive Benchmark value 62 exceeds gate value 55 for firefox browserify home p95 firstReactRender Benchmark value 40 exceeds gate value 24 for firefox browserify home p95 getState Benchmark value 15 exceeds gate value 2 for firefox browserify home p95 initialActions Benchmark value 36 exceeds gate value 27 for firefox browserify home p95 setupStore Benchmark value 1808 exceeds gate value 1615 for firefox webpack home mean uiStartup Benchmark value 1512 exceeds gate value 1380 for firefox webpack home mean load Benchmark value 1512 exceeds gate value 1380 for firefox webpack home mean domContentLoaded Benchmark value 101 exceeds gate value 100 for firefox webpack home mean domInteractive Benchmark value 33 exceeds gate value 26 for firefox webpack home mean backgroundConnect Benchmark value 54 exceeds gate value 38 for firefox webpack home mean firstReactRender Benchmark value 16 exceeds gate value 15 for firefox webpack home mean getState Benchmark value 12 exceeds gate value 1 for firefox webpack home mean initialActions Benchmark value 1485 exceeds gate value 1360 for firefox webpack home mean loadScripts Benchmark value 17 exceeds gate value 13 for firefox webpack home mean setupStore Benchmark value 2127 exceeds gate value 1935 for firefox webpack home p95 uiStartup Benchmark value 1796 exceeds gate value 1660 for firefox webpack home p95 load Benchmark value 1796 exceeds gate value 1660 for firefox webpack home p95 domContentLoaded Benchmark value 309 exceeds gate value 156 for firefox webpack home p95 domInteractive Benchmark value 80 exceeds gate value 49 for firefox webpack home p95 backgroundConnect Benchmark value 65 exceeds gate value 50 for firefox webpack home p95 firstReactRender Benchmark value 36 exceeds gate value 32 for firefox webpack home p95 getState Benchmark value 30 exceeds gate value 2 for firefox webpack home p95 initialActions Benchmark value 1766 exceeds gate value 1630 for firefox webpack home p95 loadScripts Benchmark value 34 exceeds gate value 28 for firefox webpack home p95 setupStore Sum of mean exceeds: 1793ms | Sum of p95 exceeds: 2232.8ms Sum of all benchmark exceeds: 4025.8ms Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Collaborator
Builds ready [a0263e3]
UI Startup Metrics (1271 ± 56 ms)
Benchmark value 1089 exceeds gate value 1070 for chrome browserify home mean load Benchmark value 1082 exceeds gate value 1061 for chrome browserify home mean domContentLoaded Benchmark value 212 exceeds gate value 10 for chrome browserify home mean backgroundConnect Benchmark value 4 exceeds gate value 1 for chrome browserify home mean initialActions Benchmark value 877 exceeds gate value 830 for chrome browserify home mean loadScripts Benchmark value 1369 exceeds gate value 1365 for chrome browserify home p95 uiStartup Benchmark value 223 exceeds gate value 18 for chrome browserify home p95 backgroundConnect Benchmark value 14 exceeds gate value 1.2 for chrome browserify home p95 initialActions Benchmark value 957 exceeds gate value 940 for chrome browserify home p95 loadScripts Benchmark value 2441 exceeds gate value 2192 for chrome webpack home mean uiStartup Benchmark value 1959 exceeds gate value 1711 for chrome webpack home mean load Benchmark value 1942 exceeds gate value 1704 for chrome webpack home mean domContentLoaded Benchmark value 22 exceeds gate value 21 for chrome webpack home mean domInteractive Benchmark value 54 exceeds gate value 40 for chrome webpack home mean backgroundConnect Benchmark value 10 exceeds gate value 7 for chrome webpack home mean initialActions Benchmark value 1932 exceeds gate value 1699 for chrome webpack home mean loadScripts Benchmark value 2868 exceeds gate value 2454 for chrome webpack home p95 uiStartup Benchmark value 2463 exceeds gate value 2030 for chrome webpack home p95 load Benchmark value 2275 exceeds gate value 2005 for chrome webpack home p95 domContentLoaded Benchmark value 68 exceeds gate value 57 for chrome webpack home p95 domInteractive Benchmark value 337 exceeds gate value 334 for chrome webpack home p95 firstPaint Benchmark value 277 exceeds gate value 90 for chrome webpack home p95 backgroundConnect Benchmark value 12 exceeds gate value 7 for chrome webpack home p95 initialActions Benchmark value 2259 exceeds gate value 1970 for chrome webpack home p95 loadScripts Benchmark value 1480 exceeds gate value 1405 for firefox browserify home mean uiStartup Benchmark value 1281 exceeds gate value 1245 for firefox browserify home mean load Benchmark value 1281 exceeds gate value 1239 for firefox browserify home mean domContentLoaded Benchmark value 28 exceeds gate value 25 for firefox browserify home mean backgroundConnect Benchmark value 29 exceeds gate value 25 for firefox browserify home mean firstReactRender Benchmark value 6 exceeds gate value 1 for firefox browserify home mean initialActions Benchmark value 1259 exceeds gate value 1230 for firefox browserify home mean loadScripts Benchmark value 14 exceeds gate value 9 for firefox browserify home mean setupStore Benchmark value 1769 exceeds gate value 1660 for firefox browserify home p95 uiStartup Benchmark value 297 exceeds gate value 195 for firefox browserify home p95 domInteractive Benchmark value 57 exceeds gate value 55 for firefox browserify home p95 firstReactRender Benchmark value 42 exceeds gate value 24 for firefox browserify home p95 getState Benchmark value 15 exceeds gate value 2 for firefox browserify home p95 initialActions Benchmark value 61 exceeds gate value 27 for firefox browserify home p95 setupStore Benchmark value 1749 exceeds gate value 1615 for firefox webpack home mean uiStartup Benchmark value 1477 exceeds gate value 1380 for firefox webpack home mean load Benchmark value 1477 exceeds gate value 1380 for firefox webpack home mean domContentLoaded Benchmark value 30 exceeds gate value 26 for firefox webpack home mean backgroundConnect Benchmark value 52 exceeds gate value 38 for firefox webpack home mean firstReactRender Benchmark value 14 exceeds gate value 1 for firefox webpack home mean initialActions Benchmark value 1452 exceeds gate value 1360 for firefox webpack home mean loadScripts Benchmark value 20 exceeds gate value 13 for firefox webpack home mean setupStore Benchmark value 2096 exceeds gate value 1935 for firefox webpack home p95 uiStartup Benchmark value 1763 exceeds gate value 1660 for firefox webpack home p95 load Benchmark value 1763 exceeds gate value 1660 for firefox webpack home p95 domContentLoaded Benchmark value 188 exceeds gate value 156 for firefox webpack home p95 domInteractive Benchmark value 64 exceeds gate value 50 for firefox webpack home p95 firstReactRender Benchmark value 36 exceeds gate value 32 for firefox webpack home p95 getState Benchmark value 31 exceeds gate value 2 for firefox webpack home p95 initialActions Benchmark value 1684 exceeds gate value 1630 for firefox webpack home p95 loadScripts Benchmark value 115 exceeds gate value 28 for firefox webpack home p95 setupStore Sum of mean exceeds: 1973ms | Sum of p95 exceeds: 2715.8ms Sum of all benchmark exceeds: 4688.8ms Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
AugmentedMode
requested review from
imblue-dabadee and
mindofmar
and removed request for
a team
cryptotavares
previously approved these changes
Jul 22, 2025
AugmentedMode
changed the title
Collaborator
Builds ready [6d9d5aa]
UI Startup Metrics (1263 ± 68 ms)
Benchmark value 1264 exceeds gate value 1234 for chrome browserify home mean uiStartup Benchmark value 1086 exceeds gate value 1070 for chrome browserify home mean load Benchmark value 1078 exceeds gate value 1061 for chrome browserify home mean domContentLoaded Benchmark value 213 exceeds gate value 10 for chrome browserify home mean backgroundConnect Benchmark value 3 exceeds gate value 1 for chrome browserify home mean initialActions Benchmark value 873 exceeds gate value 830 for chrome browserify home mean loadScripts Benchmark value 43 exceeds gate value 41 for chrome browserify home p95 domInteractive Benchmark value 231 exceeds gate value 18 for chrome browserify home p95 backgroundConnect Benchmark value 13 exceeds gate value 1.2 for chrome browserify home p95 initialActions Benchmark value 964 exceeds gate value 940 for chrome browserify home p95 loadScripts Benchmark value 2387 exceeds gate value 2192 for chrome webpack home mean uiStartup Benchmark value 1881 exceeds gate value 1711 for chrome webpack home mean load Benchmark value 1872 exceeds gate value 1704 for chrome webpack home mean domContentLoaded Benchmark value 22 exceeds gate value 21 for chrome webpack home mean domInteractive Benchmark value 43 exceeds gate value 40 for chrome webpack home mean backgroundConnect Benchmark value 12 exceeds gate value 7 for chrome webpack home mean initialActions Benchmark value 1867 exceeds gate value 1699 for chrome webpack home mean loadScripts Benchmark value 2786 exceeds gate value 2454 for chrome webpack home p95 uiStartup Benchmark value 2222 exceeds gate value 2030 for chrome webpack home p95 load Benchmark value 2195 exceeds gate value 2005 for chrome webpack home p95 domContentLoaded Benchmark value 64 exceeds gate value 57 for chrome webpack home p95 domInteractive Benchmark value 277 exceeds gate value 90 for chrome webpack home p95 backgroundConnect Benchmark value 21 exceeds gate value 7 for chrome webpack home p95 initialActions Benchmark value 2184 exceeds gate value 1970 for chrome webpack home p95 loadScripts Benchmark value 1509 exceeds gate value 1405 for firefox browserify home mean uiStartup Benchmark value 1301 exceeds gate value 1245 for firefox browserify home mean load Benchmark value 1301 exceeds gate value 1239 for firefox browserify home mean domContentLoaded Benchmark value 113 exceeds gate value 110 for firefox browserify home mean domInteractive Benchmark value 29 exceeds gate value 25 for firefox browserify home mean firstReactRender Benchmark value 14 exceeds gate value 11 for firefox browserify home mean getState Benchmark value 5 exceeds gate value 1 for firefox browserify home mean initialActions Benchmark value 1280 exceeds gate value 1230 for firefox browserify home mean loadScripts Benchmark value 12 exceeds gate value 9 for firefox browserify home mean setupStore Benchmark value 1927 exceeds gate value 1660 for firefox browserify home p95 uiStartup Benchmark value 1509 exceeds gate value 1495 for firefox browserify home p95 load Benchmark value 1508 exceeds gate value 1495 for firefox browserify home p95 domContentLoaded Benchmark value 385 exceeds gate value 195 for firefox browserify home p95 domInteractive Benchmark value 58 exceeds gate value 55 for firefox browserify home p95 firstReactRender Benchmark value 40 exceeds gate value 24 for firefox browserify home p95 getState Benchmark value 13 exceeds gate value 2 for firefox browserify home p95 initialActions Benchmark value 1480 exceeds gate value 1475 for firefox browserify home p95 loadScripts Benchmark value 50 exceeds gate value 27 for firefox browserify home p95 setupStore Benchmark value 1821 exceeds gate value 1615 for firefox webpack home mean uiStartup Benchmark value 1533 exceeds gate value 1380 for firefox webpack home mean load Benchmark value 1533 exceeds gate value 1380 for firefox webpack home mean domContentLoaded Benchmark value 30 exceeds gate value 26 for firefox webpack home mean backgroundConnect Benchmark value 53 exceeds gate value 38 for firefox webpack home mean firstReactRender Benchmark value 13 exceeds gate value 1 for firefox webpack home mean initialActions Benchmark value 1509 exceeds gate value 1360 for firefox webpack home mean loadScripts Benchmark value 22 exceeds gate value 13 for firefox webpack home mean setupStore Benchmark value 2175 exceeds gate value 1935 for firefox webpack home p95 uiStartup Benchmark value 1818 exceeds gate value 1660 for firefox webpack home p95 load Benchmark value 1817 exceeds gate value 1660 for firefox webpack home p95 domContentLoaded Benchmark value 254 exceeds gate value 156 for firefox webpack home p95 domInteractive Benchmark value 63 exceeds gate value 50 for firefox webpack home p95 firstReactRender Benchmark value 33 exceeds gate value 32 for firefox webpack home p95 getState Benchmark value 57 exceeds gate value 2 for firefox webpack home p95 initialActions Benchmark value 1796 exceeds gate value 1630 for firefox webpack home p95 loadScripts Benchmark value 230 exceeds gate value 28 for firefox webpack home p95 setupStore Sum of mean exceeds: 2011ms | Sum of p95 exceeds: 3018.8ms Sum of all benchmark exceeds: 5029.8ms Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
mindofmar
approved these changes
Jul 22, 2025
cryptotavares
approved these changes
Jul 22, 2025
metamaskbot
added
the
release-13.1.0
gauthierpetetin
added
release-13.0.0
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces support for a new phishing detection action (
PhishingControllerBulkScanUrlsAction) within the nft controller messengers to add to the allowedActions to support bulk scanningDependency Updates:
@metamask/assets-controllersto version^72.0.0which removed the Action type that now lives under thephishingController@metamask/phishing-controllerto version^13.1.0which now has the Action TypeChangelog
CHANGELOG entry:
Related issues
Fixes:
Manual testing steps
offscreen.htmland go to the network tabScreenshots/Recordings
Before
Before we would get an error where we were unable to fetch the bulk scan endpoint
After
After we now are able to fetch from the bulk scan endpoint
Pre-merge author checklist
Pre-merge reviewer checklist