fix: change navigation to history.goBack #34245
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hmalik88
added
the
no-changelog
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
metamaskbot
added
team-accounts-framework
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Collaborator
✨ Files requiring CODEOWNER review ✨🔑 @MetaMask/accounts-engineers (2 files, +7 -7)
|
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Collaborator
Builds ready [7f5457f]
UI Startup Metrics (1257 ± 79 ms)
Benchmark value 1081 exceeds gate value 1070 for chrome browserify home mean load Benchmark value 1074 exceeds gate value 1061 for chrome browserify home mean domContentLoaded Benchmark value 24 exceeds gate value 23 for chrome browserify home mean firstReactRender Benchmark value 18 exceeds gate value 15 for chrome browserify home mean getState Benchmark value 5 exceeds gate value 1 for chrome browserify home mean initialActions Benchmark value 1405 exceeds gate value 1365 for chrome browserify home p95 uiStartup Benchmark value 1223 exceeds gate value 1190 for chrome browserify home p95 load Benchmark value 1217 exceeds gate value 1180 for chrome browserify home p95 domContentLoaded Benchmark value 17 exceeds gate value 1.2 for chrome browserify home p95 initialActions Benchmark value 971 exceeds gate value 940 for chrome browserify home p95 loadScripts Benchmark value 19 exceeds gate value 17 for chrome browserify home p95 setupStore Benchmark value 2238 exceeds gate value 2192 for chrome webpack home mean uiStartup Benchmark value 269 exceeds gate value 235 for chrome webpack home mean firstReactRender Benchmark value 9 exceeds gate value 7 for chrome webpack home mean initialActions Benchmark value 2648 exceeds gate value 2454 for chrome webpack home p95 uiStartup Benchmark value 61 exceeds gate value 57 for chrome webpack home p95 domInteractive Benchmark value 403 exceeds gate value 370 for chrome webpack home p95 firstReactRender Benchmark value 21 exceeds gate value 7 for chrome webpack home p95 initialActions Benchmark value 117 exceeds gate value 110 for firefox browserify home mean domInteractive Benchmark value 14 exceeds gate value 11 for firefox browserify home mean getState Benchmark value 7 exceeds gate value 1 for firefox browserify home mean initialActions Benchmark value 12 exceeds gate value 9 for firefox browserify home mean setupStore Benchmark value 1694 exceeds gate value 1660 for firefox browserify home p95 uiStartup Benchmark value 355 exceeds gate value 195 for firefox browserify home p95 domInteractive Benchmark value 38 exceeds gate value 24 for firefox browserify home p95 getState Benchmark value 19 exceeds gate value 2 for firefox browserify home p95 initialActions Benchmark value 37 exceeds gate value 27 for firefox browserify home p95 setupStore Benchmark value 1669 exceeds gate value 1615 for firefox webpack home mean uiStartup Benchmark value 1407 exceeds gate value 1380 for firefox webpack home mean load Benchmark value 1407 exceeds gate value 1380 for firefox webpack home mean domContentLoaded Benchmark value 107 exceeds gate value 100 for firefox webpack home mean domInteractive Benchmark value 57 exceeds gate value 38 for firefox webpack home mean firstReactRender Benchmark value 20 exceeds gate value 15 for firefox webpack home mean getState Benchmark value 9 exceeds gate value 1 for firefox webpack home mean initialActions Benchmark value 1387 exceeds gate value 1360 for firefox webpack home mean loadScripts Benchmark value 2114 exceeds gate value 1935 for firefox webpack home p95 uiStartup Benchmark value 1699 exceeds gate value 1660 for firefox webpack home p95 load Benchmark value 1699 exceeds gate value 1660 for firefox webpack home p95 domContentLoaded Benchmark value 309 exceeds gate value 156 for firefox webpack home p95 domInteractive Benchmark value 67 exceeds gate value 50 for firefox webpack home p95 firstReactRender Benchmark value 92 exceeds gate value 32 for firefox webpack home p95 getState Benchmark value 34 exceeds gate value 2 for firefox webpack home p95 initialActions Benchmark value 1679 exceeds gate value 1630 for firefox webpack home p95 loadScripts Sum of mean exceeds: 331ms | Sum of p95 exceeds: 1206.8ms Sum of all benchmark exceeds: 1537.8ms Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
PatrykLucka
previously approved these changes
Jul 14, 2025
PatrykLucka
approved these changes
Jul 14, 2025
Collaborator
Builds ready [189e5b3]
UI Startup Metrics (1228 ± 69 ms)
Benchmark value 6 exceeds gate value 1 for chrome browserify home mean initialActions Benchmark value 20 exceeds gate value 1.2 for chrome browserify home p95 initialActions Benchmark value 20 exceeds gate value 17 for chrome browserify home p95 setupStore Benchmark value 2202 exceeds gate value 2192 for chrome webpack home mean uiStartup Benchmark value 238 exceeds gate value 235 for chrome webpack home mean firstReactRender Benchmark value 9 exceeds gate value 7 for chrome webpack home mean initialActions Benchmark value 2648 exceeds gate value 2454 for chrome webpack home p95 uiStartup Benchmark value 396 exceeds gate value 370 for chrome webpack home p95 firstReactRender Benchmark value 28 exceeds gate value 7 for chrome webpack home p95 initialActions Benchmark value 1449 exceeds gate value 1405 for firefox browserify home mean uiStartup Benchmark value 1252 exceeds gate value 1245 for firefox browserify home mean load Benchmark value 1252 exceeds gate value 1239 for firefox browserify home mean domContentLoaded Benchmark value 120 exceeds gate value 110 for firefox browserify home mean domInteractive Benchmark value 26 exceeds gate value 25 for firefox browserify home mean firstReactRender Benchmark value 14 exceeds gate value 11 for firefox browserify home mean getState Benchmark value 8 exceeds gate value 1 for firefox browserify home mean initialActions Benchmark value 1233 exceeds gate value 1230 for firefox browserify home mean loadScripts Benchmark value 19 exceeds gate value 9 for firefox browserify home mean setupStore Benchmark value 1770 exceeds gate value 1660 for firefox browserify home p95 uiStartup Benchmark value 314 exceeds gate value 195 for firefox browserify home p95 domInteractive Benchmark value 40 exceeds gate value 24 for firefox browserify home p95 getState Benchmark value 51 exceeds gate value 2 for firefox browserify home p95 initialActions Benchmark value 66 exceeds gate value 27 for firefox browserify home p95 setupStore Benchmark value 1668 exceeds gate value 1615 for firefox webpack home mean uiStartup Benchmark value 1412 exceeds gate value 1380 for firefox webpack home mean load Benchmark value 1411 exceeds gate value 1380 for firefox webpack home mean domContentLoaded Benchmark value 101 exceeds gate value 100 for firefox webpack home mean domInteractive Benchmark value 27 exceeds gate value 26 for firefox webpack home mean backgroundConnect Benchmark value 56 exceeds gate value 38 for firefox webpack home mean firstReactRender Benchmark value 17 exceeds gate value 15 for firefox webpack home mean getState Benchmark value 5 exceeds gate value 1 for firefox webpack home mean initialActions Benchmark value 1390 exceeds gate value 1360 for firefox webpack home mean loadScripts Benchmark value 1980 exceeds gate value 1935 for firefox webpack home p95 uiStartup Benchmark value 1673 exceeds gate value 1660 for firefox webpack home p95 load Benchmark value 1673 exceeds gate value 1660 for firefox webpack home p95 domContentLoaded Benchmark value 262 exceeds gate value 156 for firefox webpack home p95 domInteractive Benchmark value 52 exceeds gate value 49 for firefox webpack home p95 backgroundConnect Benchmark value 65 exceeds gate value 50 for firefox webpack home p95 firstReactRender Benchmark value 69 exceeds gate value 32 for firefox webpack home p95 getState Benchmark value 16 exceeds gate value 2 for firefox webpack home p95 initialActions Benchmark value 1655 exceeds gate value 1630 for firefox webpack home p95 loadScripts Sum of mean exceeds: 291ms | Sum of p95 exceeds: 866.8ms Sum of all benchmark exceeds: 1157.8ms Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Collaborator
Builds ready [da27a7a]
UI Startup Metrics (1193 ± 61 ms)
Benchmark value 3 exceeds gate value 1 for chrome browserify home mean initialActions Benchmark value 260 exceeds gate value 18 for chrome browserify home p95 backgroundConnect Benchmark value 14 exceeds gate value 1.2 for chrome browserify home p95 initialActions Benchmark value 2401 exceeds gate value 2192 for chrome webpack home mean uiStartup Benchmark value 1827 exceeds gate value 1711 for chrome webpack home mean load Benchmark value 1820 exceeds gate value 1704 for chrome webpack home mean domContentLoaded Benchmark value 23 exceeds gate value 21 for chrome webpack home mean domInteractive Benchmark value 12 exceeds gate value 7 for chrome webpack home mean initialActions Benchmark value 1815 exceeds gate value 1699 for chrome webpack home mean loadScripts Benchmark value 2827 exceeds gate value 2454 for chrome webpack home p95 uiStartup Benchmark value 2124 exceeds gate value 2030 for chrome webpack home p95 load Benchmark value 2119 exceeds gate value 2005 for chrome webpack home p95 domContentLoaded Benchmark value 78 exceeds gate value 57 for chrome webpack home p95 domInteractive Benchmark value 396 exceeds gate value 370 for chrome webpack home p95 firstReactRender Benchmark value 32 exceeds gate value 7 for chrome webpack home p95 initialActions Benchmark value 2115 exceeds gate value 1970 for chrome webpack home p95 loadScripts Benchmark value 3 exceeds gate value 1 for firefox browserify home mean initialActions Benchmark value 10 exceeds gate value 9 for firefox browserify home mean setupStore Benchmark value 1663 exceeds gate value 1660 for firefox browserify home p95 uiStartup Benchmark value 217 exceeds gate value 195 for firefox browserify home p95 domInteractive Benchmark value 38 exceeds gate value 24 for firefox browserify home p95 getState Benchmark value 13 exceeds gate value 2 for firefox browserify home p95 initialActions Benchmark value 35 exceeds gate value 27 for firefox browserify home p95 setupStore Benchmark value 1707 exceeds gate value 1615 for firefox webpack home mean uiStartup Benchmark value 1442 exceeds gate value 1380 for firefox webpack home mean load Benchmark value 1442 exceeds gate value 1380 for firefox webpack home mean domContentLoaded Benchmark value 105 exceeds gate value 100 for firefox webpack home mean domInteractive Benchmark value 57 exceeds gate value 38 for firefox webpack home mean firstReactRender Benchmark value 6 exceeds gate value 1 for firefox webpack home mean initialActions Benchmark value 1421 exceeds gate value 1360 for firefox webpack home mean loadScripts Benchmark value 2198 exceeds gate value 1935 for firefox webpack home p95 uiStartup Benchmark value 1880 exceeds gate value 1660 for firefox webpack home p95 load Benchmark value 1880 exceeds gate value 1660 for firefox webpack home p95 domContentLoaded Benchmark value 293 exceeds gate value 156 for firefox webpack home p95 domInteractive Benchmark value 66 exceeds gate value 50 for firefox webpack home p95 firstReactRender Benchmark value 40 exceeds gate value 32 for firefox webpack home p95 getState Benchmark value 14 exceeds gate value 2 for firefox webpack home p95 initialActions Benchmark value 1855 exceeds gate value 1630 for firefox webpack home p95 loadScripts Sum of mean exceeds: 1115ms | Sum of p95 exceeds: 2211.8ms Sum of all benchmark exceeds: 3326.8ms Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
montelaidev
approved these changes
Jul 16, 2025
metamaskbot
added
the
release-13.0.0
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions:
history.goBackManual testing steps
Screenshots/Recordings
Before
nav-old.mov
After
navigation-fix.mov
Pre-merge author checklist
Pre-merge reviewer checklist