fix: use button for quiz words instead of text-field cp-13.0.0 #34280

lionellbriones · 2025-07-15T14:37:17Z

Description

This fixes firefox showing cursor for srp quiz words. Showing cursor makes user think that they can type on the text fields which are readonly on this case.

Changelog

CHANGELOG entry: Show Confirm SRP quiz words as button

Related issues

Fixes:

Manual testing steps

Install metamask on firefox
Create new wallet with SRP
Backup SRP
Reveal SRP
Confirm SRP - test how the quiz words are displayed, there should be no cursor

Screenshots/Recordings

Before

Screenshare.-.2025-07-15.2_14_33.PM.mp4

After

No cursor on Quizwords
https://github.com/user-attachments/assets/3705912b-a8f1-4769-8947-984e5ecf840d

Demo accessibility
https://github.com/user-attachments/assets/80091d04-5110-4499-84fa-bbb09fc9beb0

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

github-actions · 2025-07-15T14:37:27Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

metamaskbot · 2025-07-15T14:39:27Z

✨ Files requiring CODEOWNER review ✨

👨‍🔧 @MetaMask/web3auth (3 files, +74 -93)

📁 ui/
- 📁 pages/
  - 📁 onboarding-flow/
    - 📁 recovery-phrase/
      - 📁 __snapshots__/
        
        📄 recovery-phrase-chips.test.js.snap +12 -24
        
        📄 review-recovery-phrase.test.js.snap +24 -24
        
        📄 recovery-phrase-chips.js +38 -45

metamaskbot · 2025-07-15T15:03:29Z

Builds ready [120d64c]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- content-script: 0
- offscreen: 0

UI Startup Metrics (1237 ± 66 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1237	1136	1545	66	1271	1345
			load	1061	966	1324	62	1095	1160
			domContentLoaded	1054	962	1321	62	1090	1148
			domInteractive	19	13	75	10	17	44
			firstPaint	622	78	1196	426	1061	1148
			backgroundConnect	253	241	278	7	257	265
			firstReactRender	20	14	45	5	21	30
			getState	10	4	33	7	14	25
			initialActions	2	0	19	4	1	13
			loadScripts	807	721	1071	60	842	896
			setupStore	7	4	20	3	7	13
	Webpack	Home	uiStartup	2377	1836	2962	217	2509	2865
			load	1761	1353	2186	186	1889	2139
			domContentLoaded	1754	1349	2170	184	1882	2125
			domInteractive	20	13	87	15	17	64
			firstPaint	170	60	1882	187	172	324
			backgroundConnect	31	11	202	21	35	64
			firstReactRender	236	91	440	117	373	411
			getState	22	4	205	33	20	68
			initialActions	16	2	205	37	9	49
			loadScripts	1749	1346	2152	181	1876	2112
			setupStore	28	7	335	54	21	59
Firefox	Browserify	Home	uiStartup	1414	1190	2091	148	1481	1729
			load	1220	1057	1483	91	1282	1367
			domContentLoaded	1220	1057	1483	91	1281	1367
			domInteractive	110	38	457	66	113	293
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	26	14	193	26	24	58
			firstReactRender	24	19	57	5	25	33
			getState	10	2	235	29	5	24
			initialActions	4	0	81	10	2	17
			loadScripts	1198	1040	1456	90	1259	1349
			setupStore	9	3	211	22	6	26
	Webpack	Home	uiStartup	1724	1399	2613	212	1762	2216
			load	1450	1201	2049	159	1508	1867
			domContentLoaded	1450	1200	2049	159	1508	1867
			domInteractive	106	32	477	73	97	292
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	29	16	253	25	30	47
			firstReactRender	55	46	69	5	59	64
			getState	13	2	252	30	11	26
			initialActions	7	1	234	25	3	27
			loadScripts	1426	1184	2018	154	1487	1838
			setupStore	15	5	249	34	8	51

Benchmark value 1237 exceeds gate value 1234 for chrome browserify home mean uiStartup
Benchmark value 254 exceeds gate value 10 for chrome browserify home mean backgroundConnect
Benchmark value 3 exceeds gate value 1 for chrome browserify home mean initialActions
Benchmark value 44 exceeds gate value 41 for chrome browserify home p95 domInteractive
Benchmark value 265 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 13 exceeds gate value 1.2 for chrome browserify home p95 initialActions
Benchmark value 2377 exceeds gate value 2192 for chrome webpack home mean uiStartup
Benchmark value 1761 exceeds gate value 1711 for chrome webpack home mean load
Benchmark value 1754 exceeds gate value 1704 for chrome webpack home mean domContentLoaded
Benchmark value 237 exceeds gate value 235 for chrome webpack home mean firstReactRender
Benchmark value 16 exceeds gate value 7 for chrome webpack home mean initialActions
Benchmark value 1749 exceeds gate value 1699 for chrome webpack home mean loadScripts
Benchmark value 2865 exceeds gate value 2454 for chrome webpack home p95 uiStartup
Benchmark value 2139 exceeds gate value 2030 for chrome webpack home p95 load
Benchmark value 2125 exceeds gate value 2005 for chrome webpack home p95 domContentLoaded
Benchmark value 64 exceeds gate value 57 for chrome webpack home p95 domInteractive
Benchmark value 411 exceeds gate value 370 for chrome webpack home p95 firstReactRender
Benchmark value 49 exceeds gate value 7 for chrome webpack home p95 initialActions
Benchmark value 2112 exceeds gate value 1970 for chrome webpack home p95 loadScripts
Benchmark value 1415 exceeds gate value 1405 for firefox browserify home mean uiStartup
Benchmark value 111 exceeds gate value 110 for firefox browserify home mean domInteractive
Benchmark value 27 exceeds gate value 25 for firefox browserify home mean backgroundConnect
Benchmark value 4 exceeds gate value 1 for firefox browserify home mean initialActions
Benchmark value 10 exceeds gate value 9 for firefox browserify home mean setupStore
Benchmark value 1729 exceeds gate value 1660 for firefox browserify home p95 uiStartup
Benchmark value 293 exceeds gate value 195 for firefox browserify home p95 domInteractive
Benchmark value 17 exceeds gate value 2 for firefox browserify home p95 initialActions
Benchmark value 1724 exceeds gate value 1615 for firefox webpack home mean uiStartup
Benchmark value 1451 exceeds gate value 1380 for firefox webpack home mean load
Benchmark value 1451 exceeds gate value 1380 for firefox webpack home mean domContentLoaded
Benchmark value 106 exceeds gate value 100 for firefox webpack home mean domInteractive
Benchmark value 29 exceeds gate value 26 for firefox webpack home mean backgroundConnect
Benchmark value 55 exceeds gate value 38 for firefox webpack home mean firstReactRender
Benchmark value 8 exceeds gate value 1 for firefox webpack home mean initialActions
Benchmark value 1427 exceeds gate value 1360 for firefox webpack home mean loadScripts
Benchmark value 15 exceeds gate value 13 for firefox webpack home mean setupStore
Benchmark value 2216 exceeds gate value 1935 for firefox webpack home p95 uiStartup
Benchmark value 1867 exceeds gate value 1660 for firefox webpack home p95 load
Benchmark value 1867 exceeds gate value 1660 for firefox webpack home p95 domContentLoaded
Benchmark value 292 exceeds gate value 156 for firefox webpack home p95 domInteractive
Benchmark value 64 exceeds gate value 50 for firefox webpack home p95 firstReactRender
Benchmark value 27 exceeds gate value 2 for firefox webpack home p95 initialActions
Benchmark value 1838 exceeds gate value 1630 for firefox webpack home p95 loadScripts
Benchmark value 51 exceeds gate value 28 for firefox webpack home p95 setupStore
Sum of mean exceeds: 965ms | Sum of p95 exceeds: 2416.8ms
Sum of all benchmark exceeds: 3381.8ms

Bundle size diffs [🚀 Bundle size reduced!]

background: -150 Bytes (0%)
ui: 252 Bytes (0%)
common: 15 Bytes (0%)

metamaskbot · 2025-07-17T05:04:06Z

Builds ready [8c139ae]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- content-script: 0
- offscreen: 0

UI Startup Metrics (1203 ± 58 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1203	1092	1388	58	1234	1312
			load	1032	940	1235	57	1067	1158
			domContentLoaded	1026	933	1229	56	1061	1153
			domInteractive	18	13	57	8	17	41
			firstPaint	606	68	1238	418	1029	1085
			backgroundConnect	252	237	275	7	256	261
			firstReactRender	21	13	79	8	22	31
			getState	9	3	28	5	10	22
			initialActions	3	0	26	5	4	13
			loadScripts	780	670	979	55	814	897
			setupStore	7	4	19	3	8	14
	Webpack	Home	uiStartup	2207	1677	2663	234	2356	2619
			load	1653	1230	2010	185	1760	1951
			domContentLoaded	1647	1226	1999	184	1757	1942
			domInteractive	18	12	82	14	15	55
			firstPaint	146	60	393	61	175	256
			backgroundConnect	26	10	281	27	27	45
			firstReactRender	260	90	409	120	379	395
			getState	11	4	33	5	12	22
			initialActions	7	2	35	7	7	30
			loadScripts	1643	1224	1987	182	1754	1929
			setupStore	14	6	41	7	17	32
Firefox	Browserify	Home	uiStartup	1409	1180	1917	142	1458	1711
			load	1224	1039	1609	95	1281	1382
			domContentLoaded	1224	1039	1608	95	1280	1381
			domInteractive	114	36	386	67	118	311
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	25	13	182	22	25	56
			firstReactRender	23	20	54	4	23	33
			getState	13	2	186	30	6	54
			initialActions	4	0	82	11	3	20
			loadScripts	1202	1025	1589	90	1251	1354
			setupStore	9	3	93	14	6	38
	Webpack	Home	uiStartup	1735	1468	2502	207	1813	2213
			load	1465	1232	1963	163	1556	1815
			domContentLoaded	1464	1232	1963	162	1556	1815
			domInteractive	107	36	426	71	96	298
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	27	16	146	15	30	50
			firstReactRender	56	42	76	6	60	65
			getState	12	3	215	25	10	25
			initialActions	11	0	246	38	3	20
			loadScripts	1444	1214	1941	161	1536	1780
			setupStore	14	4	284	31	8	58

Benchmark value 252 exceeds gate value 10 for chrome browserify home mean backgroundConnect
Benchmark value 4 exceeds gate value 1 for chrome browserify home mean initialActions
Benchmark value 42 exceeds gate value 41 for chrome browserify home p95 domInteractive
Benchmark value 262 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 13 exceeds gate value 1.2 for chrome browserify home p95 initialActions
Benchmark value 2208 exceeds gate value 2192 for chrome webpack home mean uiStartup
Benchmark value 260 exceeds gate value 235 for chrome webpack home mean firstReactRender
Benchmark value 8 exceeds gate value 7 for chrome webpack home mean initialActions
Benchmark value 2620 exceeds gate value 2454 for chrome webpack home p95 uiStartup
Benchmark value 395 exceeds gate value 370 for chrome webpack home p95 firstReactRender
Benchmark value 30 exceeds gate value 7 for chrome webpack home p95 initialActions
Benchmark value 1410 exceeds gate value 1405 for firefox browserify home mean uiStartup
Benchmark value 115 exceeds gate value 110 for firefox browserify home mean domInteractive
Benchmark value 26 exceeds gate value 25 for firefox browserify home mean backgroundConnect
Benchmark value 13 exceeds gate value 11 for firefox browserify home mean getState
Benchmark value 5 exceeds gate value 1 for firefox browserify home mean initialActions
Benchmark value 1711 exceeds gate value 1660 for firefox browserify home p95 uiStartup
Benchmark value 311 exceeds gate value 195 for firefox browserify home p95 domInteractive
Benchmark value 54 exceeds gate value 24 for firefox browserify home p95 getState
Benchmark value 20 exceeds gate value 2 for firefox browserify home p95 initialActions
Benchmark value 38 exceeds gate value 27 for firefox browserify home p95 setupStore
Benchmark value 1736 exceeds gate value 1615 for firefox webpack home mean uiStartup
Benchmark value 1465 exceeds gate value 1380 for firefox webpack home mean load
Benchmark value 1465 exceeds gate value 1380 for firefox webpack home mean domContentLoaded
Benchmark value 107 exceeds gate value 100 for firefox webpack home mean domInteractive
Benchmark value 27 exceeds gate value 26 for firefox webpack home mean backgroundConnect
Benchmark value 57 exceeds gate value 38 for firefox webpack home mean firstReactRender
Benchmark value 11 exceeds gate value 1 for firefox webpack home mean initialActions
Benchmark value 1445 exceeds gate value 1360 for firefox webpack home mean loadScripts
Benchmark value 14 exceeds gate value 13 for firefox webpack home mean setupStore
Benchmark value 2213 exceeds gate value 1935 for firefox webpack home p95 uiStartup
Benchmark value 1815 exceeds gate value 1660 for firefox webpack home p95 load
Benchmark value 1815 exceeds gate value 1660 for firefox webpack home p95 domContentLoaded
Benchmark value 298 exceeds gate value 156 for firefox webpack home p95 domInteractive
Benchmark value 50 exceeds gate value 49 for firefox webpack home p95 backgroundConnect
Benchmark value 65 exceeds gate value 50 for firefox webpack home p95 firstReactRender
Benchmark value 20 exceeds gate value 2 for firefox webpack home p95 initialActions
Benchmark value 1780 exceeds gate value 1630 for firefox webpack home p95 loadScripts
Benchmark value 58 exceeds gate value 28 for firefox webpack home p95 setupStore
Sum of mean exceeds: 718ms | Sum of p95 exceeds: 1640.8ms
Sum of all benchmark exceeds: 2358.8ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 43 Bytes (0%)
ui: -93 Bytes (0%)
common: 15 Bytes (0%)

cursor

Bug: Recovery Phrase Display Glitches

Multiple issues affect the recovery phrase display:

Box components rendered in the word list are missing the key={index} prop, which can cause React rendering issues.
Quiz words appear blank during the non-confirm (review) phase instead of displaying the actual word.
The TextField component for non-quiz words in the confirm phase is missing inputProps={{ tabIndex: -1 }}.
The onClick handler for quiz words allows interaction (setting focus or removing words) outside of the confirm phase, which is unintended.

ui/pages/onboarding-flow/recovery-phrase/recovery-phrase-chips.js#L146-L202

metamask-extension/ui/pages/onboarding-flow/recovery-phrase/recovery-phrase-chips.js

Lines 146 to 202 in 08250b5

    
           const isTargetIndex = index === indexToFocus; 
        
           return isQuizWord || !confirmPhase ? ( 
        
             <Box 
        
               as={isQuizWord ? 'button' : 'div'} 
        
               data-testid={`recovery-phrase-chip-${index}`} 
        
               className="recovery-phrase__text" 
        
               display={Display.Flex} 
        
               alignItems={AlignItems.center} 
        
               backgroundColor={BackgroundColor.backgroundDefault} 
        
               borderColor={ 
        
                 isTargetIndex 
        
                   ? BorderColor.primaryDefault 
        
                   : BorderColor.borderMuted 
        
               } 
        
               borderWidth={isTargetIndex ? 2 : 1} 
        
               borderRadius={BorderRadius.LG} 
        
               paddingInline={2} 
        
               paddingTop={1} 
        
               paddingBottom={1} 
        
               gap={1} 
        
               onClick={() => { 
        
                 if (!isQuizWord) { 
        
                   return; 
        
                 } 
        
                 if (wordToDisplay === '') { 
        
                   setIndexToFocus(index); 
        
                 } else { 
        
                   removeQuizWord(wordToDisplay); 
        
                 } 
        
               }} 
        
             > 
        
               <Text 
        
                 color={TextColor.textAlternative} 
        
                 className="recovery-phrase__word-index" 
        
               > 
        
                 {index + 1}. 
        
               </Text> 
        
               <Text>{isQuizWord ? wordToDisplay : word}</Text> 
        
             </Box> 
        
           ) : ( 
        
             <TextField 
        
               testId={`recovery-phrase-chip-${index}`} 
        
               key={index} 
        
               value={wordToDisplay} 
        
               startAccessory={ 
        
                 <Text 
        
                   color={TextColor.textAlternative} 
        
                   className="recovery-phrase__word-index" 
        
                 > 
        
                   {index + 1}. 
        
                 </Text> 
        
               } 
        
               type="password" 
        
               disabled 
        
               readOnly 
        
             /> 
        
           );

Fix in Cursor • Fix in Web

Was this report helpful? Give feedback by reacting with 👍 or 👎

metamaskbot · 2025-07-18T05:02:57Z

Builds ready [08250b5]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- content-script: 0
- offscreen: 0

UI Startup Metrics (1266 ± 62 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1266	1126	1414	62	1307	1392
			load	1086	946	1238	59	1125	1189
			domContentLoaded	1079	931	1232	60	1117	1184
			domInteractive	18	14	56	8	16	43
			firstPaint	627	72	1230	438	1095	1152
			backgroundConnect	213	200	251	8	215	234
			firstReactRender	22	15	64	8	24	39
			getState	10	3	48	8	14	29
			initialActions	4	0	61	8	2	16
			loadScripts	873	734	1027	59	913	976
			setupStore	7	4	17	2	7	12
	Webpack	Home	uiStartup	2480	2041	2757	135	2569	2669
			load	1970	1534	2274	145	2054	2210
			domContentLoaded	1960	1528	2225	142	2043	2189
			domInteractive	21	13	229	25	16	60
			firstPaint	179	66	1821	178	200	303
			backgroundConnect	35	12	277	41	34	43
			firstReactRender	180	96	330	67	216	320
			getState	20	3	250	42	17	32
			initialActions	14	2	197	36	7	36
			loadScripts	1955	1524	2213	142	2040	2187
			setupStore	19	6	217	28	18	37
Firefox	Browserify	Home	uiStartup	1442	1296	2471	167	1471	1760
			load	1233	1136	1456	75	1262	1429
			domContentLoaded	1232	1136	1455	75	1262	1429
			domInteractive	102	35	474	60	101	218
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	28	14	145	22	24	78
			firstReactRender	28	20	57	8	30	53
			getState	12	3	164	26	7	57
			initialActions	3	0	31	5	2	12
			loadScripts	1211	1117	1439	72	1241	1383
			setupStore	11	3	162	22	7	50
	Webpack	Home	uiStartup	1748	1511	2321	190	1849	2176
			load	1485	1288	1965	155	1589	1870
			domContentLoaded	1484	1288	1965	155	1589	1869
			domInteractive	103	35	470	79	92	302
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	28	18	75	12	33	57
			firstReactRender	53	41	68	6	56	65
			getState	10	2	199	20	13	24
			initialActions	7	0	203	21	6	21
			loadScripts	1461	1266	1924	152	1558	1825
			setupStore	17	4	264	41	10	35

Benchmark value 1266 exceeds gate value 1234 for chrome browserify home mean uiStartup
Benchmark value 1086 exceeds gate value 1070 for chrome browserify home mean load
Benchmark value 1079 exceeds gate value 1061 for chrome browserify home mean domContentLoaded
Benchmark value 214 exceeds gate value 10 for chrome browserify home mean backgroundConnect
Benchmark value 4 exceeds gate value 1 for chrome browserify home mean initialActions
Benchmark value 873 exceeds gate value 830 for chrome browserify home mean loadScripts
Benchmark value 1392 exceeds gate value 1365 for chrome browserify home p95 uiStartup
Benchmark value 1185 exceeds gate value 1180 for chrome browserify home p95 domContentLoaded
Benchmark value 43 exceeds gate value 41 for chrome browserify home p95 domInteractive
Benchmark value 235 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 16 exceeds gate value 1.2 for chrome browserify home p95 initialActions
Benchmark value 977 exceeds gate value 940 for chrome browserify home p95 loadScripts
Benchmark value 2481 exceeds gate value 2192 for chrome webpack home mean uiStartup
Benchmark value 1970 exceeds gate value 1711 for chrome webpack home mean load
Benchmark value 1960 exceeds gate value 1704 for chrome webpack home mean domContentLoaded
Benchmark value 22 exceeds gate value 21 for chrome webpack home mean domInteractive
Benchmark value 15 exceeds gate value 7 for chrome webpack home mean initialActions
Benchmark value 1955 exceeds gate value 1699 for chrome webpack home mean loadScripts
Benchmark value 2669 exceeds gate value 2454 for chrome webpack home p95 uiStartup
Benchmark value 2210 exceeds gate value 2030 for chrome webpack home p95 load
Benchmark value 2190 exceeds gate value 2005 for chrome webpack home p95 domContentLoaded
Benchmark value 61 exceeds gate value 57 for chrome webpack home p95 domInteractive
Benchmark value 36 exceeds gate value 7 for chrome webpack home p95 initialActions
Benchmark value 2187 exceeds gate value 1970 for chrome webpack home p95 loadScripts
Benchmark value 1442 exceeds gate value 1405 for firefox browserify home mean uiStartup
Benchmark value 28 exceeds gate value 25 for firefox browserify home mean backgroundConnect
Benchmark value 28 exceeds gate value 25 for firefox browserify home mean firstReactRender
Benchmark value 12 exceeds gate value 11 for firefox browserify home mean getState
Benchmark value 4 exceeds gate value 1 for firefox browserify home mean initialActions
Benchmark value 12 exceeds gate value 9 for firefox browserify home mean setupStore
Benchmark value 1760 exceeds gate value 1660 for firefox browserify home p95 uiStartup
Benchmark value 218 exceeds gate value 195 for firefox browserify home p95 domInteractive
Benchmark value 78 exceeds gate value 70 for firefox browserify home p95 backgroundConnect
Benchmark value 57 exceeds gate value 24 for firefox browserify home p95 getState
Benchmark value 12 exceeds gate value 2 for firefox browserify home p95 initialActions
Benchmark value 50 exceeds gate value 27 for firefox browserify home p95 setupStore
Benchmark value 1748 exceeds gate value 1615 for firefox webpack home mean uiStartup
Benchmark value 1485 exceeds gate value 1380 for firefox webpack home mean load
Benchmark value 1485 exceeds gate value 1380 for firefox webpack home mean domContentLoaded
Benchmark value 104 exceeds gate value 100 for firefox webpack home mean domInteractive
Benchmark value 29 exceeds gate value 26 for firefox webpack home mean backgroundConnect
Benchmark value 53 exceeds gate value 38 for firefox webpack home mean firstReactRender
Benchmark value 7 exceeds gate value 1 for firefox webpack home mean initialActions
Benchmark value 1462 exceeds gate value 1360 for firefox webpack home mean loadScripts
Benchmark value 17 exceeds gate value 13 for firefox webpack home mean setupStore
Benchmark value 2176 exceeds gate value 1935 for firefox webpack home p95 uiStartup
Benchmark value 1870 exceeds gate value 1660 for firefox webpack home p95 load
Benchmark value 1869 exceeds gate value 1660 for firefox webpack home p95 domContentLoaded
Benchmark value 302 exceeds gate value 156 for firefox webpack home p95 domInteractive
Benchmark value 57 exceeds gate value 49 for firefox webpack home p95 backgroundConnect
Benchmark value 65 exceeds gate value 50 for firefox webpack home p95 firstReactRender
Benchmark value 21 exceeds gate value 2 for firefox webpack home p95 initialActions
Benchmark value 1825 exceeds gate value 1630 for firefox webpack home p95 loadScripts
Benchmark value 35 exceeds gate value 28 for firefox webpack home p95 setupStore
Sum of mean exceeds: 1912ms | Sum of p95 exceeds: 2379.8ms
Sum of all benchmark exceeds: 4291.8ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 6.71 KiB (0.12%)
ui: 15.21 KiB (0.21%)
common: 63 KiB (0.74%)

fix: use button for quiz words instead of text-field

120d64c

metamaskbot added the team-onboarding Onboarding team label Jul 15, 2025

chaitanyapotti added the area-onboarding label Jul 17, 2025

Merge branch 'main' into fix/confirm-srp-cursor-firefox

a29f0d5

lionellbriones marked this pull request as ready for review July 17, 2025 04:32

lionellbriones requested a review from a team as a code owner July 17, 2025 04:32

fix: update test snapshot

8c139ae

This comment was marked as outdated.

Sign in to view

tuna1207 previously approved these changes Jul 18, 2025

View reviewed changes

fix: update snap shot

08250b5

tuna1207 dismissed their stale review via 08250b5 July 18, 2025 04:36

cursor bot reviewed Jul 18, 2025

View reviewed changes

tuna1207 approved these changes Jul 18, 2025

View reviewed changes

chaitanyapotti approved these changes Jul 18, 2025

View reviewed changes

chaitanyapotti changed the title ~~fix: use button for quiz words instead of text-field~~ fix: use button for quiz words instead of text-field cp-13.0.0 Jul 18, 2025

chaitanyapotti added this pull request to the merge queue Jul 18, 2025

Merged via the queue into main with commit 723a4a5 Jul 18, 2025
403 of 408 checks passed

chaitanyapotti deleted the fix/confirm-srp-cursor-firefox branch July 18, 2025 06:34

github-actions bot locked and limited conversation to collaborators Jul 18, 2025

metamaskbot added the release-13.1.0 Issue or pull request that will be included in release 13.1.0 label Jul 18, 2025

gauthierpetetin added release-13.0.0 Issue or pull request that will be included in release 13.0.0 (also called 12.24.0) and removed release-13.1.0 Issue or pull request that will be included in release 13.1.0 labels Aug 5, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix: use button for quiz words instead of text-field cp-13.0.0 #34280

fix: use button for quiz words instead of text-field cp-13.0.0 #34280

Uh oh!

lionellbriones commented Jul 15, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Jul 15, 2025

Uh oh!

metamaskbot commented Jul 15, 2025 •

edited

Loading

Uh oh!

metamaskbot commented Jul 15, 2025

Uh oh!

This comment was marked as outdated.

Uh oh!

metamaskbot commented Jul 17, 2025

Uh oh!

cursor bot left a comment

Uh oh!

metamaskbot commented Jul 18, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

	const isTargetIndex = index === indexToFocus;
	return isQuizWord \|\| !confirmPhase ? (
	<Box
	as={isQuizWord ? 'button' : 'div'}
	data-testid={`recovery-phrase-chip-${index}`}
	className="recovery-phrase__text"
	display={Display.Flex}
	alignItems={AlignItems.center}
	backgroundColor={BackgroundColor.backgroundDefault}
	borderColor={
	isTargetIndex
	? BorderColor.primaryDefault
	: BorderColor.borderMuted
	}
	borderWidth={isTargetIndex ? 2 : 1}
	borderRadius={BorderRadius.LG}
	paddingInline={2}
	paddingTop={1}
	paddingBottom={1}
	gap={1}
	onClick={() => {
	if (!isQuizWord) {
	return;
	}
	if (wordToDisplay === '') {
	setIndexToFocus(index);
	} else {
	removeQuizWord(wordToDisplay);
	}
	}}
	>
	<Text
	color={TextColor.textAlternative}
	className="recovery-phrase__word-index"
	>
	{index + 1}.
	</Text>
	<Text>{isQuizWord ? wordToDisplay : word}</Text>
	</Box>
	) : (
	<TextField
	testId={`recovery-phrase-chip-${index}`}
	key={index}
	value={wordToDisplay}
	startAccessory={
	<Text
	color={TextColor.textAlternative}
	className="recovery-phrase__word-index"
	>
	{index + 1}.
	</Text>
	}
	type="password"
	disabled
	readOnly
	/>
	);

fix: use button for quiz words instead of text-field cp-13.0.0 #34280

fix: use button for quiz words instead of text-field cp-13.0.0 #34280

Uh oh!

Conversation

lionellbriones commented Jul 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Changelog

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

Uh oh!

github-actions bot commented Jul 15, 2025

Uh oh!

metamaskbot commented Jul 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✨ Files requiring CODEOWNER review ✨

Uh oh!

metamaskbot commented Jul 15, 2025

Uh oh!

This comment was marked as outdated.

Uh oh!

metamaskbot commented Jul 17, 2025

Uh oh!

cursor bot left a comment

Choose a reason for hiding this comment

Bug: Recovery Phrase Display Glitches

Uh oh!

metamaskbot commented Jul 18, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

lionellbriones commented Jul 15, 2025 •

edited

Loading

metamaskbot commented Jul 15, 2025 •

edited

Loading