fix: make bg color on the loading screen in popup match bg of app #34346
+0
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
davidmurdoch
changed the title
Collaborator
✨ Files requiring CODEOWNER review ✨🖥️ @MetaMask/wallet-ux (1 files, +0 -6)
|
davidmurdoch
changed the title
Collaborator
Builds ready [5e6a137]
UI Startup Metrics (1240 ± 79 ms)
Benchmark value 255 exceeds gate value 10 for chrome browserify home mean backgroundConnect Benchmark value 3 exceeds gate value 1 for chrome browserify home mean initialActions Benchmark value 1397 exceeds gate value 1365 for chrome browserify home p95 uiStartup Benchmark value 1221 exceeds gate value 1190 for chrome browserify home p95 load Benchmark value 1211 exceeds gate value 1180 for chrome browserify home p95 domContentLoaded Benchmark value 1192 exceeds gate value 1180 for chrome browserify home p95 firstPaint Benchmark value 268 exceeds gate value 18 for chrome browserify home p95 backgroundConnect Benchmark value 13 exceeds gate value 1.2 for chrome browserify home p95 initialActions Benchmark value 961 exceeds gate value 940 for chrome browserify home p95 loadScripts Benchmark value 2226 exceeds gate value 2192 for chrome webpack home mean uiStartup Benchmark value 237 exceeds gate value 235 for chrome webpack home mean firstReactRender Benchmark value 10 exceeds gate value 7 for chrome webpack home mean initialActions Benchmark value 2633 exceeds gate value 2454 for chrome webpack home p95 uiStartup Benchmark value 389 exceeds gate value 370 for chrome webpack home p95 firstReactRender Benchmark value 27 exceeds gate value 7 for chrome webpack home p95 initialActions Benchmark value 12 exceeds gate value 11 for firefox browserify home mean getState Benchmark value 7 exceeds gate value 1 for firefox browserify home mean initialActions Benchmark value 10 exceeds gate value 9 for firefox browserify home mean setupStore Benchmark value 1694 exceeds gate value 1660 for firefox browserify home p95 uiStartup Benchmark value 299 exceeds gate value 195 for firefox browserify home p95 domInteractive Benchmark value 62 exceeds gate value 24 for firefox browserify home p95 getState Benchmark value 25 exceeds gate value 2 for firefox browserify home p95 initialActions Benchmark value 49 exceeds gate value 27 for firefox browserify home p95 setupStore Benchmark value 1754 exceeds gate value 1615 for firefox webpack home mean uiStartup Benchmark value 1484 exceeds gate value 1380 for firefox webpack home mean load Benchmark value 1484 exceeds gate value 1380 for firefox webpack home mean domContentLoaded Benchmark value 108 exceeds gate value 100 for firefox webpack home mean domInteractive Benchmark value 57 exceeds gate value 38 for firefox webpack home mean firstReactRender Benchmark value 7 exceeds gate value 1 for firefox webpack home mean initialActions Benchmark value 1464 exceeds gate value 1360 for firefox webpack home mean loadScripts Benchmark value 15 exceeds gate value 13 for firefox webpack home mean setupStore Benchmark value 2158 exceeds gate value 1935 for firefox webpack home p95 uiStartup Benchmark value 1769 exceeds gate value 1660 for firefox webpack home p95 load Benchmark value 1768 exceeds gate value 1660 for firefox webpack home p95 domContentLoaded Benchmark value 289 exceeds gate value 156 for firefox webpack home p95 domInteractive Benchmark value 69 exceeds gate value 50 for firefox webpack home p95 firstReactRender Benchmark value 17 exceeds gate value 2 for firefox webpack home p95 initialActions Benchmark value 1745 exceeds gate value 1630 for firefox webpack home p95 loadScripts Benchmark value 36 exceeds gate value 28 for firefox webpack home p95 setupStore Sum of mean exceeds: 786ms | Sum of p95 exceeds: 1557.8ms Sum of all benchmark exceeds: 2343.8ms Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
DDDDDanica
approved these changes
Jul 18, 2025
Contributor
|
LGTM! |
HowardBraham
approved these changes
Jul 18, 2025
vinnyhoward
approved these changes
Jul 22, 2025
github-project-automation
bot
moved this from Needs dev review
to Review finalised - Ready to be merged
in PR review queue
github-project-automation
bot
moved this from Review finalised - Ready to be merged
to Merged, Closed or Archived
in PR review queue
metamaskbot
added
the
release-13.1.0
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The loading screen was previously using a slightly lighter grey only on "small" screens. This was a typo in the CSS rule. I've removed the CSS rule that caused this issue.
Changelog
CHANGELOG entry: fix: background of loading screen now matches rest of application's background