fix: update popup-init.html's background colors to match latest designs #34347
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidmurdoch
added
the
no-changelog
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Collaborator
Builds ready [258eca2]
UI Startup Metrics (1194 ± 62 ms)
Benchmark value 3 exceeds gate value 1 for chrome browserify home mean initialActions Benchmark value 42 exceeds gate value 41 for chrome browserify home p95 domInteractive Benchmark value 262 exceeds gate value 18 for chrome browserify home p95 backgroundConnect Benchmark value 15 exceeds gate value 1.2 for chrome browserify home p95 initialActions Benchmark value 2264 exceeds gate value 2192 for chrome webpack home mean uiStartup Benchmark value 267 exceeds gate value 235 for chrome webpack home mean firstReactRender Benchmark value 13 exceeds gate value 7 for chrome webpack home mean initialActions Benchmark value 2725 exceeds gate value 2454 for chrome webpack home p95 uiStartup Benchmark value 61 exceeds gate value 57 for chrome webpack home p95 domInteractive Benchmark value 339 exceeds gate value 334 for chrome webpack home p95 firstPaint Benchmark value 402 exceeds gate value 370 for chrome webpack home p95 firstReactRender Benchmark value 41 exceeds gate value 7 for chrome webpack home p95 initialActions Benchmark value 1986 exceeds gate value 1970 for chrome webpack home p95 loadScripts Benchmark value 1410 exceeds gate value 1405 for firefox browserify home mean uiStartup Benchmark value 112 exceeds gate value 110 for firefox browserify home mean domInteractive Benchmark value 4 exceeds gate value 1 for firefox browserify home mean initialActions Benchmark value 12 exceeds gate value 9 for firefox browserify home mean setupStore Benchmark value 1726 exceeds gate value 1660 for firefox browserify home p95 uiStartup Benchmark value 328 exceeds gate value 195 for firefox browserify home p95 domInteractive Benchmark value 44 exceeds gate value 24 for firefox browserify home p95 getState Benchmark value 10 exceeds gate value 2 for firefox browserify home p95 initialActions Benchmark value 56 exceeds gate value 27 for firefox browserify home p95 setupStore Benchmark value 1700 exceeds gate value 1615 for firefox webpack home mean uiStartup Benchmark value 1434 exceeds gate value 1380 for firefox webpack home mean load Benchmark value 1434 exceeds gate value 1380 for firefox webpack home mean domContentLoaded Benchmark value 106 exceeds gate value 100 for firefox webpack home mean domInteractive Benchmark value 56 exceeds gate value 38 for firefox webpack home mean firstReactRender Benchmark value 5 exceeds gate value 1 for firefox webpack home mean initialActions Benchmark value 1414 exceeds gate value 1360 for firefox webpack home mean loadScripts Benchmark value 15 exceeds gate value 13 for firefox webpack home mean setupStore Benchmark value 2168 exceeds gate value 1935 for firefox webpack home p95 uiStartup Benchmark value 1837 exceeds gate value 1660 for firefox webpack home p95 load Benchmark value 1837 exceeds gate value 1660 for firefox webpack home p95 domContentLoaded Benchmark value 303 exceeds gate value 156 for firefox webpack home p95 domInteractive Benchmark value 64 exceeds gate value 50 for firefox webpack home p95 firstReactRender Benchmark value 37 exceeds gate value 32 for firefox webpack home p95 getState Benchmark value 14 exceeds gate value 2 for firefox webpack home p95 initialActions Benchmark value 1814 exceeds gate value 1630 for firefox webpack home p95 loadScripts Sum of mean exceeds: 643ms | Sum of p95 exceeds: 1825.8ms Sum of all benchmark exceeds: 2468.8ms Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
DDDDDanica
approved these changes
Jul 18, 2025
github-project-automation
bot
moved this from Needs dev review
to Review finalised - Ready to be merged
in PR review queue
Contributor
|
LGTM! |
metamaskbot
added
the
release-13.1.0
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
popup-init.htmlcan't use CSS, so we manually keep its colors in sync with our design language. This screen only shows for a few milliseconds, so most won't ever notice it.