fix: infinite loading on spending cap when selected chain differs from dapp cp-12.22.3 #34355
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Collaborator
✨ Files requiring CODEOWNER review ✨✅ @MetaMask/confirmations (1 files, +7 -2)
|
Collaborator
Builds ready [09a2f59]
UI Startup Metrics (1215 ± 61 ms)
Benchmark value 3 exceeds gate value 1 for chrome browserify home mean initialActions Benchmark value 262 exceeds gate value 18 for chrome browserify home p95 backgroundConnect Benchmark value 13 exceeds gate value 1.2 for chrome browserify home p95 initialActions Benchmark value 2291 exceeds gate value 2192 for chrome webpack home mean uiStartup Benchmark value 261 exceeds gate value 235 for chrome webpack home mean firstReactRender Benchmark value 14 exceeds gate value 7 for chrome webpack home mean initialActions Benchmark value 2667 exceeds gate value 2454 for chrome webpack home p95 uiStartup Benchmark value 59 exceeds gate value 57 for chrome webpack home p95 domInteractive Benchmark value 402 exceeds gate value 370 for chrome webpack home p95 firstReactRender Benchmark value 30 exceeds gate value 7 for chrome webpack home p95 initialActions Benchmark value 1983 exceeds gate value 1970 for chrome webpack home p95 loadScripts Benchmark value 1415 exceeds gate value 1405 for firefox browserify home mean uiStartup Benchmark value 117 exceeds gate value 110 for firefox browserify home mean domInteractive Benchmark value 34 exceeds gate value 25 for firefox browserify home mean backgroundConnect Benchmark value 13 exceeds gate value 11 for firefox browserify home mean getState Benchmark value 5 exceeds gate value 1 for firefox browserify home mean initialActions Benchmark value 1788 exceeds gate value 1660 for firefox browserify home p95 uiStartup Benchmark value 315 exceeds gate value 195 for firefox browserify home p95 domInteractive Benchmark value 61 exceeds gate value 24 for firefox browserify home p95 getState Benchmark value 25 exceeds gate value 2 for firefox browserify home p95 initialActions Benchmark value 36 exceeds gate value 27 for firefox browserify home p95 setupStore Benchmark value 1778 exceeds gate value 1615 for firefox webpack home mean uiStartup Benchmark value 1482 exceeds gate value 1380 for firefox webpack home mean load Benchmark value 1482 exceeds gate value 1380 for firefox webpack home mean domContentLoaded Benchmark value 112 exceeds gate value 100 for firefox webpack home mean domInteractive Benchmark value 28 exceeds gate value 26 for firefox webpack home mean backgroundConnect Benchmark value 59 exceeds gate value 38 for firefox webpack home mean firstReactRender Benchmark value 8 exceeds gate value 1 for firefox webpack home mean initialActions Benchmark value 1461 exceeds gate value 1360 for firefox webpack home mean loadScripts Benchmark value 23 exceeds gate value 13 for firefox webpack home mean setupStore Benchmark value 2252 exceeds gate value 1935 for firefox webpack home p95 uiStartup Benchmark value 1871 exceeds gate value 1660 for firefox webpack home p95 load Benchmark value 1871 exceeds gate value 1660 for firefox webpack home p95 domContentLoaded Benchmark value 341 exceeds gate value 156 for firefox webpack home p95 domInteractive Benchmark value 59 exceeds gate value 49 for firefox webpack home p95 backgroundConnect Benchmark value 71 exceeds gate value 50 for firefox webpack home p95 firstReactRender Benchmark value 33 exceeds gate value 32 for firefox webpack home p95 getState Benchmark value 25 exceeds gate value 2 for firefox webpack home p95 initialActions Benchmark value 1850 exceeds gate value 1630 for firefox webpack home p95 loadScripts Benchmark value 233 exceeds gate value 28 for firefox webpack home p95 setupStore Sum of mean exceeds: 928ms | Sum of p95 exceeds: 2259.8ms Sum of all benchmark exceeds: 3187.8ms Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
DDDDDanica
changed the title
Collaborator
Builds ready [ebb6f5c]
UI Startup Metrics (1258 ± 63 ms)
Benchmark value 1077 exceeds gate value 1070 for chrome browserify home mean load Benchmark value 1067 exceeds gate value 1061 for chrome browserify home mean domContentLoaded Benchmark value 213 exceeds gate value 10 for chrome browserify home mean backgroundConnect Benchmark value 3 exceeds gate value 1 for chrome browserify home mean initialActions Benchmark value 863 exceeds gate value 830 for chrome browserify home mean loadScripts Benchmark value 232 exceeds gate value 18 for chrome browserify home p95 backgroundConnect Benchmark value 13 exceeds gate value 1.2 for chrome browserify home p95 initialActions Benchmark value 955 exceeds gate value 940 for chrome browserify home p95 loadScripts Benchmark value 2349 exceeds gate value 2192 for chrome webpack home mean uiStartup Benchmark value 1853 exceeds gate value 1711 for chrome webpack home mean load Benchmark value 1846 exceeds gate value 1704 for chrome webpack home mean domContentLoaded Benchmark value 1842 exceeds gate value 1699 for chrome webpack home mean loadScripts Benchmark value 2522 exceeds gate value 2454 for chrome webpack home p95 uiStartup Benchmark value 2092 exceeds gate value 2030 for chrome webpack home p95 load Benchmark value 2085 exceeds gate value 2005 for chrome webpack home p95 domContentLoaded Benchmark value 87 exceeds gate value 57 for chrome webpack home p95 domInteractive Benchmark value 27 exceeds gate value 7 for chrome webpack home p95 initialActions Benchmark value 2073 exceeds gate value 1970 for chrome webpack home p95 loadScripts Benchmark value 1526 exceeds gate value 1405 for firefox browserify home mean uiStartup Benchmark value 1317 exceeds gate value 1245 for firefox browserify home mean load Benchmark value 1316 exceeds gate value 1239 for firefox browserify home mean domContentLoaded Benchmark value 117 exceeds gate value 110 for firefox browserify home mean domInteractive Benchmark value 28 exceeds gate value 25 for firefox browserify home mean backgroundConnect Benchmark value 30 exceeds gate value 25 for firefox browserify home mean firstReactRender Benchmark value 15 exceeds gate value 11 for firefox browserify home mean getState Benchmark value 5 exceeds gate value 1 for firefox browserify home mean initialActions Benchmark value 1294 exceeds gate value 1230 for firefox browserify home mean loadScripts Benchmark value 10 exceeds gate value 9 for firefox browserify home mean setupStore Benchmark value 1818 exceeds gate value 1660 for firefox browserify home p95 uiStartup Benchmark value 325 exceeds gate value 195 for firefox browserify home p95 domInteractive Benchmark value 59 exceeds gate value 55 for firefox browserify home p95 firstReactRender Benchmark value 58 exceeds gate value 24 for firefox browserify home p95 getState Benchmark value 23 exceeds gate value 2 for firefox browserify home p95 initialActions Benchmark value 28 exceeds gate value 27 for firefox browserify home p95 setupStore Benchmark value 1755 exceeds gate value 1615 for firefox webpack home mean uiStartup Benchmark value 1481 exceeds gate value 1380 for firefox webpack home mean load Benchmark value 1481 exceeds gate value 1380 for firefox webpack home mean domContentLoaded Benchmark value 30 exceeds gate value 26 for firefox webpack home mean backgroundConnect Benchmark value 52 exceeds gate value 38 for firefox webpack home mean firstReactRender Benchmark value 7 exceeds gate value 1 for firefox webpack home mean initialActions Benchmark value 1458 exceeds gate value 1360 for firefox webpack home mean loadScripts Benchmark value 16 exceeds gate value 13 for firefox webpack home mean setupStore Benchmark value 2220 exceeds gate value 1935 for firefox webpack home p95 uiStartup Benchmark value 1772 exceeds gate value 1660 for firefox webpack home p95 load Benchmark value 1772 exceeds gate value 1660 for firefox webpack home p95 domContentLoaded Benchmark value 311 exceeds gate value 156 for firefox webpack home p95 domInteractive Benchmark value 62 exceeds gate value 49 for firefox webpack home p95 backgroundConnect Benchmark value 63 exceeds gate value 50 for firefox webpack home p95 firstReactRender Benchmark value 38 exceeds gate value 32 for firefox webpack home p95 getState Benchmark value 23 exceeds gate value 2 for firefox webpack home p95 initialActions Benchmark value 1743 exceeds gate value 1630 for firefox webpack home p95 loadScripts Benchmark value 38 exceeds gate value 28 for firefox webpack home p95 setupStore Sum of mean exceeds: 1685ms | Sum of p95 exceeds: 1791.8ms Sum of all benchmark exceeds: 3476.8ms Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
OGPoyraz
approved these changes
Jul 21, 2025
OGPoyraz
reviewed
Jul 21, 2025
jpuri
approved these changes
Jul 21, 2025
metamaskbot
added
the
release-13.1.0
gauthierpetetin
added
release-12.22.3
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR aims to fix a infinity loading on spending cap confirmation when a dapp initiate a confirmation in X chain and user selected chain is Y.
Changelog
CHANGELOG entry: Fixed infinite loading on spending cap when selected chain differs from dapp
Related issues
Fixes: #34298
Manual testing steps
Screenshots/Recordings
speding-cap.webm
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist