fix: remove loading spinner from create ethereum account flow #34374
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
metamaskbot
added
team-accounts-framework
Collaborator
✨ Files requiring CODEOWNER review ✨🔑 @MetaMask/accounts-engineers (2 files, +7 -4)
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
hmalik88
added
the
no-changelog
Collaborator
Builds ready [e91cab5]
UI Startup Metrics (1259 ± 59 ms)
Benchmark value 1260 exceeds gate value 1234 for chrome browserify home mean uiStartup Benchmark value 1079 exceeds gate value 1070 for chrome browserify home mean load Benchmark value 1070 exceeds gate value 1061 for chrome browserify home mean domContentLoaded Benchmark value 214 exceeds gate value 10 for chrome browserify home mean backgroundConnect Benchmark value 3 exceeds gate value 1 for chrome browserify home mean initialActions Benchmark value 865 exceeds gate value 830 for chrome browserify home mean loadScripts Benchmark value 42 exceeds gate value 41 for chrome browserify home p95 domInteractive Benchmark value 233 exceeds gate value 18 for chrome browserify home p95 backgroundConnect Benchmark value 16 exceeds gate value 1.2 for chrome browserify home p95 initialActions Benchmark value 947 exceeds gate value 940 for chrome browserify home p95 loadScripts Benchmark value 3166 exceeds gate value 2192 for chrome webpack home mean uiStartup Benchmark value 2587 exceeds gate value 1711 for chrome webpack home mean load Benchmark value 2578 exceeds gate value 1704 for chrome webpack home mean domContentLoaded Benchmark value 28 exceeds gate value 21 for chrome webpack home mean domInteractive Benchmark value 268 exceeds gate value 199 for chrome webpack home mean firstPaint Benchmark value 42 exceeds gate value 40 for chrome webpack home mean backgroundConnect Benchmark value 14 exceeds gate value 7 for chrome webpack home mean initialActions Benchmark value 2572 exceeds gate value 1699 for chrome webpack home mean loadScripts Benchmark value 3591 exceeds gate value 2454 for chrome webpack home p95 uiStartup Benchmark value 2965 exceeds gate value 2030 for chrome webpack home p95 load Benchmark value 2960 exceeds gate value 2005 for chrome webpack home p95 domContentLoaded Benchmark value 115 exceeds gate value 57 for chrome webpack home p95 domInteractive Benchmark value 469 exceeds gate value 334 for chrome webpack home p95 firstPaint Benchmark value 97 exceeds gate value 90 for chrome webpack home p95 backgroundConnect Benchmark value 379 exceeds gate value 370 for chrome webpack home p95 firstReactRender Benchmark value 62 exceeds gate value 7 for chrome webpack home p95 initialActions Benchmark value 2958 exceeds gate value 1970 for chrome webpack home p95 loadScripts Benchmark value 1516 exceeds gate value 1405 for firefox browserify home mean uiStartup Benchmark value 1295 exceeds gate value 1245 for firefox browserify home mean load Benchmark value 1295 exceeds gate value 1239 for firefox browserify home mean domContentLoaded Benchmark value 111 exceeds gate value 110 for firefox browserify home mean domInteractive Benchmark value 29 exceeds gate value 25 for firefox browserify home mean backgroundConnect Benchmark value 29 exceeds gate value 25 for firefox browserify home mean firstReactRender Benchmark value 14 exceeds gate value 11 for firefox browserify home mean getState Benchmark value 4 exceeds gate value 1 for firefox browserify home mean initialActions Benchmark value 1271 exceeds gate value 1230 for firefox browserify home mean loadScripts Benchmark value 16 exceeds gate value 9 for firefox browserify home mean setupStore Benchmark value 1925 exceeds gate value 1660 for firefox browserify home p95 uiStartup Benchmark value 1508 exceeds gate value 1495 for firefox browserify home p95 load Benchmark value 1507 exceeds gate value 1495 for firefox browserify home p95 domContentLoaded Benchmark value 332 exceeds gate value 195 for firefox browserify home p95 domInteractive Benchmark value 60 exceeds gate value 55 for firefox browserify home p95 firstReactRender Benchmark value 35 exceeds gate value 24 for firefox browserify home p95 getState Benchmark value 14 exceeds gate value 2 for firefox browserify home p95 initialActions Benchmark value 1483 exceeds gate value 1475 for firefox browserify home p95 loadScripts Benchmark value 60 exceeds gate value 27 for firefox browserify home p95 setupStore Benchmark value 1913 exceeds gate value 1615 for firefox webpack home mean uiStartup Benchmark value 1607 exceeds gate value 1380 for firefox webpack home mean load Benchmark value 1606 exceeds gate value 1380 for firefox webpack home mean domContentLoaded Benchmark value 104 exceeds gate value 100 for firefox webpack home mean domInteractive Benchmark value 38 exceeds gate value 26 for firefox webpack home mean backgroundConnect Benchmark value 57 exceeds gate value 38 for firefox webpack home mean firstReactRender Benchmark value 12 exceeds gate value 1 for firefox webpack home mean initialActions Benchmark value 1581 exceeds gate value 1360 for firefox webpack home mean loadScripts Benchmark value 15 exceeds gate value 13 for firefox webpack home mean setupStore Benchmark value 2281 exceeds gate value 1935 for firefox webpack home p95 uiStartup Benchmark value 1917 exceeds gate value 1660 for firefox webpack home p95 load Benchmark value 1917 exceeds gate value 1660 for firefox webpack home p95 domContentLoaded Benchmark value 321 exceeds gate value 156 for firefox webpack home p95 domInteractive Benchmark value 82 exceeds gate value 49 for firefox webpack home p95 backgroundConnect Benchmark value 69 exceeds gate value 50 for firefox webpack home p95 firstReactRender Benchmark value 38 exceeds gate value 32 for firefox webpack home p95 getState Benchmark value 22 exceeds gate value 2 for firefox webpack home p95 initialActions Benchmark value 1870 exceeds gate value 1630 for firefox webpack home p95 loadScripts Benchmark value 71 exceeds gate value 28 for firefox webpack home p95 setupStore Sum of mean exceeds: 5267ms | Sum of p95 exceeds: 6398.8ms Sum of all benchmark exceeds: 11665.8ms Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Collaborator
Builds ready [bf5f72b]
UI Startup Metrics (1306 ± 63 ms)
Benchmark value 1117 exceeds gate value 1070 for chrome browserify home mean load Benchmark value 1110 exceeds gate value 1061 for chrome browserify home mean domContentLoaded Benchmark value 221 exceeds gate value 10 for chrome browserify home mean backgroundConnect Benchmark value 25 exceeds gate value 23 for chrome browserify home mean firstReactRender Benchmark value 4 exceeds gate value 1 for chrome browserify home mean initialActions Benchmark value 896 exceeds gate value 830 for chrome browserify home mean loadScripts Benchmark value 1412 exceeds gate value 1365 for chrome browserify home p95 uiStartup Benchmark value 1224 exceeds gate value 1190 for chrome browserify home p95 load Benchmark value 1215 exceeds gate value 1180 for chrome browserify home p95 domContentLoaded Benchmark value 42 exceeds gate value 41 for chrome browserify home p95 domInteractive Benchmark value 1203 exceeds gate value 1180 for chrome browserify home p95 firstPaint Benchmark value 241 exceeds gate value 18 for chrome browserify home p95 backgroundConnect Benchmark value 15 exceeds gate value 1.2 for chrome browserify home p95 initialActions Benchmark value 1004 exceeds gate value 940 for chrome browserify home p95 loadScripts Benchmark value 2370 exceeds gate value 2192 for chrome webpack home mean uiStartup Benchmark value 1871 exceeds gate value 1711 for chrome webpack home mean load Benchmark value 1863 exceeds gate value 1704 for chrome webpack home mean domContentLoaded Benchmark value 12 exceeds gate value 7 for chrome webpack home mean initialActions Benchmark value 1854 exceeds gate value 1699 for chrome webpack home mean loadScripts Benchmark value 2585 exceeds gate value 2454 for chrome webpack home p95 uiStartup Benchmark value 2128 exceeds gate value 2030 for chrome webpack home p95 load Benchmark value 2122 exceeds gate value 2005 for chrome webpack home p95 domContentLoaded Benchmark value 59 exceeds gate value 57 for chrome webpack home p95 domInteractive Benchmark value 30 exceeds gate value 7 for chrome webpack home p95 initialActions Benchmark value 2119 exceeds gate value 1970 for chrome webpack home p95 loadScripts Benchmark value 1484 exceeds gate value 1405 for firefox browserify home mean uiStartup Benchmark value 1273 exceeds gate value 1245 for firefox browserify home mean load Benchmark value 1273 exceeds gate value 1239 for firefox browserify home mean domContentLoaded Benchmark value 116 exceeds gate value 110 for firefox browserify home mean domInteractive Benchmark value 30 exceeds gate value 25 for firefox browserify home mean backgroundConnect Benchmark value 31 exceeds gate value 25 for firefox browserify home mean firstReactRender Benchmark value 7 exceeds gate value 1 for firefox browserify home mean initialActions Benchmark value 1251 exceeds gate value 1230 for firefox browserify home mean loadScripts Benchmark value 12 exceeds gate value 9 for firefox browserify home mean setupStore Benchmark value 1822 exceeds gate value 1660 for firefox browserify home p95 uiStartup Benchmark value 298 exceeds gate value 195 for firefox browserify home p95 domInteractive Benchmark value 61 exceeds gate value 55 for firefox browserify home p95 firstReactRender Benchmark value 40 exceeds gate value 24 for firefox browserify home p95 getState Benchmark value 24 exceeds gate value 2 for firefox browserify home p95 initialActions Benchmark value 33 exceeds gate value 27 for firefox browserify home p95 setupStore Benchmark value 1729 exceeds gate value 1615 for firefox webpack home mean uiStartup Benchmark value 1472 exceeds gate value 1380 for firefox webpack home mean load Benchmark value 1472 exceeds gate value 1380 for firefox webpack home mean domContentLoaded Benchmark value 101 exceeds gate value 100 for firefox webpack home mean domInteractive Benchmark value 31 exceeds gate value 26 for firefox webpack home mean backgroundConnect Benchmark value 51 exceeds gate value 38 for firefox webpack home mean firstReactRender Benchmark value 5 exceeds gate value 1 for firefox webpack home mean initialActions Benchmark value 1449 exceeds gate value 1360 for firefox webpack home mean loadScripts Benchmark value 2073 exceeds gate value 1935 for firefox webpack home p95 uiStartup Benchmark value 1772 exceeds gate value 1660 for firefox webpack home p95 load Benchmark value 1771 exceeds gate value 1660 for firefox webpack home p95 domContentLoaded Benchmark value 289 exceeds gate value 156 for firefox webpack home p95 domInteractive Benchmark value 78 exceeds gate value 49 for firefox webpack home p95 backgroundConnect Benchmark value 62 exceeds gate value 50 for firefox webpack home p95 firstReactRender Benchmark value 15 exceeds gate value 2 for firefox webpack home p95 initialActions Benchmark value 1733 exceeds gate value 1630 for firefox webpack home p95 loadScripts Sum of mean exceeds: 1706ms | Sum of p95 exceeds: 1926.8ms Sum of all benchmark exceeds: 3632.8ms Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Collaborator
Builds ready [56ed5d2]
UI Startup Metrics (1277 ± 55 ms)
Benchmark value 1096 exceeds gate value 1070 for chrome browserify home mean load Benchmark value 1088 exceeds gate value 1061 for chrome browserify home mean domContentLoaded Benchmark value 213 exceeds gate value 10 for chrome browserify home mean backgroundConnect Benchmark value 4 exceeds gate value 1 for chrome browserify home mean initialActions Benchmark value 883 exceeds gate value 830 for chrome browserify home mean loadScripts Benchmark value 1379 exceeds gate value 1365 for chrome browserify home p95 uiStartup Benchmark value 44 exceeds gate value 41 for chrome browserify home p95 domInteractive Benchmark value 229 exceeds gate value 18 for chrome browserify home p95 backgroundConnect Benchmark value 16 exceeds gate value 1.2 for chrome browserify home p95 initialActions Benchmark value 962 exceeds gate value 940 for chrome browserify home p95 loadScripts Benchmark value 2337 exceeds gate value 2192 for chrome webpack home mean uiStartup Benchmark value 1863 exceeds gate value 1711 for chrome webpack home mean load Benchmark value 1854 exceeds gate value 1704 for chrome webpack home mean domContentLoaded Benchmark value 11 exceeds gate value 7 for chrome webpack home mean initialActions Benchmark value 1850 exceeds gate value 1699 for chrome webpack home mean loadScripts Benchmark value 2494 exceeds gate value 2454 for chrome webpack home p95 uiStartup Benchmark value 2106 exceeds gate value 2030 for chrome webpack home p95 load Benchmark value 2101 exceeds gate value 2005 for chrome webpack home p95 domContentLoaded Benchmark value 61 exceeds gate value 57 for chrome webpack home p95 domInteractive Benchmark value 199 exceeds gate value 90 for chrome webpack home p95 backgroundConnect Benchmark value 22 exceeds gate value 7 for chrome webpack home p95 initialActions Benchmark value 2099 exceeds gate value 1970 for chrome webpack home p95 loadScripts Benchmark value 1500 exceeds gate value 1405 for firefox browserify home mean uiStartup Benchmark value 1294 exceeds gate value 1245 for firefox browserify home mean load Benchmark value 1294 exceeds gate value 1239 for firefox browserify home mean domContentLoaded Benchmark value 119 exceeds gate value 110 for firefox browserify home mean domInteractive Benchmark value 27 exceeds gate value 25 for firefox browserify home mean backgroundConnect Benchmark value 29 exceeds gate value 25 for firefox browserify home mean firstReactRender Benchmark value 13 exceeds gate value 11 for firefox browserify home mean getState Benchmark value 5 exceeds gate value 1 for firefox browserify home mean initialActions Benchmark value 1271 exceeds gate value 1230 for firefox browserify home mean loadScripts Benchmark value 13 exceeds gate value 9 for firefox browserify home mean setupStore Benchmark value 1794 exceeds gate value 1660 for firefox browserify home p95 uiStartup Benchmark value 416 exceeds gate value 195 for firefox browserify home p95 domInteractive Benchmark value 60 exceeds gate value 55 for firefox browserify home p95 firstReactRender Benchmark value 36 exceeds gate value 24 for firefox browserify home p95 getState Benchmark value 16 exceeds gate value 2 for firefox browserify home p95 initialActions Benchmark value 28 exceeds gate value 27 for firefox browserify home p95 setupStore Benchmark value 1736 exceeds gate value 1615 for firefox webpack home mean uiStartup Benchmark value 1475 exceeds gate value 1380 for firefox webpack home mean load Benchmark value 1474 exceeds gate value 1380 for firefox webpack home mean domContentLoaded Benchmark value 103 exceeds gate value 100 for firefox webpack home mean domInteractive Benchmark value 28 exceeds gate value 26 for firefox webpack home mean backgroundConnect Benchmark value 53 exceeds gate value 38 for firefox webpack home mean firstReactRender Benchmark value 6 exceeds gate value 1 for firefox webpack home mean initialActions Benchmark value 1452 exceeds gate value 1360 for firefox webpack home mean loadScripts Benchmark value 14 exceeds gate value 13 for firefox webpack home mean setupStore Benchmark value 2142 exceeds gate value 1935 for firefox webpack home p95 uiStartup Benchmark value 1792 exceeds gate value 1660 for firefox webpack home p95 load Benchmark value 1791 exceeds gate value 1660 for firefox webpack home p95 domContentLoaded Benchmark value 291 exceeds gate value 156 for firefox webpack home p95 domInteractive Benchmark value 58 exceeds gate value 49 for firefox webpack home p95 backgroundConnect Benchmark value 66 exceeds gate value 50 for firefox webpack home p95 firstReactRender Benchmark value 19 exceeds gate value 2 for firefox webpack home p95 initialActions Benchmark value 1759 exceeds gate value 1630 for firefox webpack home p95 loadScripts Benchmark value 33 exceeds gate value 28 for firefox webpack home p95 setupStore Sum of mean exceeds: 1651ms | Sum of p95 exceeds: 1901.8ms Sum of all benchmark exceeds: 3552.8ms Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Collaborator
Builds ready [00b4905]
UI Startup Metrics (1285 ± 55 ms)
Benchmark value 1101 exceeds gate value 1070 for chrome browserify home mean load Benchmark value 1093 exceeds gate value 1061 for chrome browserify home mean domContentLoaded Benchmark value 216 exceeds gate value 10 for chrome browserify home mean backgroundConnect Benchmark value 4 exceeds gate value 1 for chrome browserify home mean initialActions Benchmark value 885 exceeds gate value 830 for chrome browserify home mean loadScripts Benchmark value 1385 exceeds gate value 1365 for chrome browserify home p95 uiStartup Benchmark value 43 exceeds gate value 41 for chrome browserify home p95 domInteractive Benchmark value 237 exceeds gate value 18 for chrome browserify home p95 backgroundConnect Benchmark value 17 exceeds gate value 1.2 for chrome browserify home p95 initialActions Benchmark value 952 exceeds gate value 940 for chrome browserify home p95 loadScripts Benchmark value 2309 exceeds gate value 2192 for chrome webpack home mean uiStartup Benchmark value 1826 exceeds gate value 1711 for chrome webpack home mean load Benchmark value 1820 exceeds gate value 1704 for chrome webpack home mean domContentLoaded Benchmark value 11 exceeds gate value 7 for chrome webpack home mean initialActions Benchmark value 1816 exceeds gate value 1699 for chrome webpack home mean loadScripts Benchmark value 2503 exceeds gate value 2454 for chrome webpack home p95 uiStartup Benchmark value 2105 exceeds gate value 2030 for chrome webpack home p95 load Benchmark value 2101 exceeds gate value 2005 for chrome webpack home p95 domContentLoaded Benchmark value 237 exceeds gate value 90 for chrome webpack home p95 backgroundConnect Benchmark value 28 exceeds gate value 7 for chrome webpack home p95 initialActions Benchmark value 2099 exceeds gate value 1970 for chrome webpack home p95 loadScripts Benchmark value 1495 exceeds gate value 1405 for firefox browserify home mean uiStartup Benchmark value 1285 exceeds gate value 1245 for firefox browserify home mean load Benchmark value 1285 exceeds gate value 1239 for firefox browserify home mean domContentLoaded Benchmark value 28 exceeds gate value 25 for firefox browserify home mean backgroundConnect Benchmark value 29 exceeds gate value 25 for firefox browserify home mean firstReactRender Benchmark value 13 exceeds gate value 11 for firefox browserify home mean getState Benchmark value 7 exceeds gate value 1 for firefox browserify home mean initialActions Benchmark value 1262 exceeds gate value 1230 for firefox browserify home mean loadScripts Benchmark value 13 exceeds gate value 9 for firefox browserify home mean setupStore Benchmark value 1786 exceeds gate value 1660 for firefox browserify home p95 uiStartup Benchmark value 1509 exceeds gate value 1495 for firefox browserify home p95 load Benchmark value 1509 exceeds gate value 1495 for firefox browserify home p95 domContentLoaded Benchmark value 313 exceeds gate value 195 for firefox browserify home p95 domInteractive Benchmark value 56 exceeds gate value 55 for firefox browserify home p95 firstReactRender Benchmark value 37 exceeds gate value 24 for firefox browserify home p95 getState Benchmark value 26 exceeds gate value 2 for firefox browserify home p95 initialActions Benchmark value 1488 exceeds gate value 1475 for firefox browserify home p95 loadScripts Benchmark value 42 exceeds gate value 27 for firefox browserify home p95 setupStore Benchmark value 1767 exceeds gate value 1615 for firefox webpack home mean uiStartup Benchmark value 1493 exceeds gate value 1380 for firefox webpack home mean load Benchmark value 1492 exceeds gate value 1380 for firefox webpack home mean domContentLoaded Benchmark value 101 exceeds gate value 100 for firefox webpack home mean domInteractive Benchmark value 34 exceeds gate value 26 for firefox webpack home mean backgroundConnect Benchmark value 51 exceeds gate value 38 for firefox webpack home mean firstReactRender Benchmark value 8 exceeds gate value 1 for firefox webpack home mean initialActions Benchmark value 1467 exceeds gate value 1360 for firefox webpack home mean loadScripts Benchmark value 20 exceeds gate value 13 for firefox webpack home mean setupStore Benchmark value 2229 exceeds gate value 1935 for firefox webpack home p95 uiStartup Benchmark value 1850 exceeds gate value 1660 for firefox webpack home p95 load Benchmark value 1850 exceeds gate value 1660 for firefox webpack home p95 domContentLoaded Benchmark value 311 exceeds gate value 156 for firefox webpack home p95 domInteractive Benchmark value 81 exceeds gate value 49 for firefox webpack home p95 backgroundConnect Benchmark value 60 exceeds gate value 50 for firefox webpack home p95 firstReactRender Benchmark value 21 exceeds gate value 2 for firefox webpack home p95 initialActions Benchmark value 1808 exceeds gate value 1630 for firefox webpack home p95 loadScripts Benchmark value 58 exceeds gate value 28 for firefox webpack home p95 setupStore Sum of mean exceeds: 1595ms | Sum of p95 exceeds: 2221.8ms Sum of all benchmark exceeds: 3816.8ms Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
montelaidev
approved these changes
Jul 18, 2025
PatrykLucka
approved these changes
Jul 18, 2025
metamaskbot
added
the
release-13.1.0
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions:
Manual testing steps
Screenshots/Recordings
Before
Screenshare.-.2025-07-09.11_48_24.AM.mp4
After
Screen.Recording.2025-07-17.at.3.05.23.PM.mov
Pre-merge author checklist
Pre-merge reviewer checklist