fix: cp-13.0.0 show solana connected state #34375
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
metamaskbot
added
team-core-extension-ux
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Bug: Unintended Debugging Statement
A debugging console.log statement was accidentally left in the code and should be removed before production.
ui/components/multichain/connected-site-popover/connected-site-popover.tsx#L61-L62
Was this report helpful? Give feedback by reacting with 👍 or 👎
Collaborator
✨ Files requiring CODEOWNER review ✨🖥️ @MetaMask/wallet-ux (3 files, +77 -8)
|
ui/components/multichain/connected-site-popover/connected-site-popover.tsx
Outdated
Show resolved
Hide resolved
Collaborator
Builds ready [575285e]
UI Startup Metrics (1281 ± 64 ms)
Benchmark value 1098 exceeds gate value 1070 for chrome browserify home mean load Benchmark value 1089 exceeds gate value 1061 for chrome browserify home mean domContentLoaded Benchmark value 216 exceeds gate value 10 for chrome browserify home mean backgroundConnect Benchmark value 5 exceeds gate value 1 for chrome browserify home mean initialActions Benchmark value 882 exceeds gate value 830 for chrome browserify home mean loadScripts Benchmark value 1416 exceeds gate value 1365 for chrome browserify home p95 uiStartup Benchmark value 1199 exceeds gate value 1190 for chrome browserify home p95 load Benchmark value 1192 exceeds gate value 1180 for chrome browserify home p95 domContentLoaded Benchmark value 229 exceeds gate value 18 for chrome browserify home p95 backgroundConnect Benchmark value 18 exceeds gate value 1.2 for chrome browserify home p95 initialActions Benchmark value 985 exceeds gate value 940 for chrome browserify home p95 loadScripts Benchmark value 2389 exceeds gate value 2192 for chrome webpack home mean uiStartup Benchmark value 1891 exceeds gate value 1711 for chrome webpack home mean load Benchmark value 1879 exceeds gate value 1704 for chrome webpack home mean domContentLoaded Benchmark value 47 exceeds gate value 40 for chrome webpack home mean backgroundConnect Benchmark value 1874 exceeds gate value 1699 for chrome webpack home mean loadScripts Benchmark value 2561 exceeds gate value 2454 for chrome webpack home p95 uiStartup Benchmark value 2171 exceeds gate value 2030 for chrome webpack home p95 load Benchmark value 2124 exceeds gate value 2005 for chrome webpack home p95 domContentLoaded Benchmark value 62 exceeds gate value 57 for chrome webpack home p95 domInteractive Benchmark value 281 exceeds gate value 90 for chrome webpack home p95 backgroundConnect Benchmark value 371 exceeds gate value 370 for chrome webpack home p95 firstReactRender Benchmark value 27 exceeds gate value 7 for chrome webpack home p95 initialActions Benchmark value 2122 exceeds gate value 1970 for chrome webpack home p95 loadScripts Benchmark value 1487 exceeds gate value 1405 for firefox browserify home mean uiStartup Benchmark value 1289 exceeds gate value 1245 for firefox browserify home mean load Benchmark value 1289 exceeds gate value 1239 for firefox browserify home mean domContentLoaded Benchmark value 117 exceeds gate value 110 for firefox browserify home mean domInteractive Benchmark value 29 exceeds gate value 25 for firefox browserify home mean backgroundConnect Benchmark value 28 exceeds gate value 25 for firefox browserify home mean firstReactRender Benchmark value 4 exceeds gate value 1 for firefox browserify home mean initialActions Benchmark value 1265 exceeds gate value 1230 for firefox browserify home mean loadScripts Benchmark value 11 exceeds gate value 9 for firefox browserify home mean setupStore Benchmark value 1728 exceeds gate value 1660 for firefox browserify home p95 uiStartup Benchmark value 319 exceeds gate value 195 for firefox browserify home p95 domInteractive Benchmark value 12 exceeds gate value 2 for firefox browserify home p95 initialActions Benchmark value 32 exceeds gate value 27 for firefox browserify home p95 setupStore Benchmark value 1874 exceeds gate value 1615 for firefox webpack home mean uiStartup Benchmark value 1578 exceeds gate value 1380 for firefox webpack home mean load Benchmark value 1578 exceeds gate value 1380 for firefox webpack home mean domContentLoaded Benchmark value 101 exceeds gate value 100 for firefox webpack home mean domInteractive Benchmark value 34 exceeds gate value 26 for firefox webpack home mean backgroundConnect Benchmark value 57 exceeds gate value 38 for firefox webpack home mean firstReactRender Benchmark value 7 exceeds gate value 1 for firefox webpack home mean initialActions Benchmark value 1551 exceeds gate value 1360 for firefox webpack home mean loadScripts Benchmark value 14 exceeds gate value 13 for firefox webpack home mean setupStore Benchmark value 2296 exceeds gate value 1935 for firefox webpack home p95 uiStartup Benchmark value 1972 exceeds gate value 1660 for firefox webpack home p95 load Benchmark value 1971 exceeds gate value 1660 for firefox webpack home p95 domContentLoaded Benchmark value 330 exceeds gate value 156 for firefox webpack home p95 domInteractive Benchmark value 61 exceeds gate value 49 for firefox webpack home p95 backgroundConnect Benchmark value 67 exceeds gate value 50 for firefox webpack home p95 firstReactRender Benchmark value 22 exceeds gate value 2 for firefox webpack home p95 initialActions Benchmark value 1944 exceeds gate value 1630 for firefox webpack home p95 loadScripts Benchmark value 41 exceeds gate value 28 for firefox webpack home p95 setupStore Sum of mean exceeds: 2211ms | Sum of p95 exceeds: 2821.8ms Sum of all benchmark exceeds: 5032.8ms Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Prithpal-Sooriya
approved these changes
Jul 17, 2025
darkwing
approved these changes
Jul 17, 2025
Collaborator
Builds ready [e7787c4]
UI Startup Metrics (1268 ± 61 ms)
Benchmark value 1085 exceeds gate value 1070 for chrome browserify home mean load Benchmark value 1077 exceeds gate value 1061 for chrome browserify home mean domContentLoaded Benchmark value 210 exceeds gate value 10 for chrome browserify home mean backgroundConnect Benchmark value 5 exceeds gate value 1 for chrome browserify home mean initialActions Benchmark value 874 exceeds gate value 830 for chrome browserify home mean loadScripts Benchmark value 1374 exceeds gate value 1365 for chrome browserify home p95 uiStartup Benchmark value 43 exceeds gate value 41 for chrome browserify home p95 domInteractive Benchmark value 227 exceeds gate value 18 for chrome browserify home p95 backgroundConnect Benchmark value 16 exceeds gate value 1.2 for chrome browserify home p95 initialActions Benchmark value 961 exceeds gate value 940 for chrome browserify home p95 loadScripts Benchmark value 2468 exceeds gate value 2192 for chrome webpack home mean uiStartup Benchmark value 1966 exceeds gate value 1711 for chrome webpack home mean load Benchmark value 1957 exceeds gate value 1704 for chrome webpack home mean domContentLoaded Benchmark value 11 exceeds gate value 7 for chrome webpack home mean initialActions Benchmark value 1952 exceeds gate value 1699 for chrome webpack home mean loadScripts Benchmark value 2651 exceeds gate value 2454 for chrome webpack home p95 uiStartup Benchmark value 2232 exceeds gate value 2030 for chrome webpack home p95 load Benchmark value 2227 exceeds gate value 2005 for chrome webpack home p95 domContentLoaded Benchmark value 34 exceeds gate value 7 for chrome webpack home p95 initialActions Benchmark value 2224 exceeds gate value 1970 for chrome webpack home p95 loadScripts Benchmark value 1526 exceeds gate value 1405 for firefox browserify home mean uiStartup Benchmark value 1309 exceeds gate value 1245 for firefox browserify home mean load Benchmark value 1309 exceeds gate value 1239 for firefox browserify home mean domContentLoaded Benchmark value 122 exceeds gate value 110 for firefox browserify home mean domInteractive Benchmark value 28 exceeds gate value 25 for firefox browserify home mean backgroundConnect Benchmark value 29 exceeds gate value 25 for firefox browserify home mean firstReactRender Benchmark value 15 exceeds gate value 11 for firefox browserify home mean getState Benchmark value 6 exceeds gate value 1 for firefox browserify home mean initialActions Benchmark value 1287 exceeds gate value 1230 for firefox browserify home mean loadScripts Benchmark value 12 exceeds gate value 9 for firefox browserify home mean setupStore Benchmark value 1834 exceeds gate value 1660 for firefox browserify home p95 uiStartup Benchmark value 1507 exceeds gate value 1495 for firefox browserify home p95 load Benchmark value 1507 exceeds gate value 1495 for firefox browserify home p95 domContentLoaded Benchmark value 340 exceeds gate value 195 for firefox browserify home p95 domInteractive Benchmark value 62 exceeds gate value 24 for firefox browserify home p95 getState Benchmark value 18 exceeds gate value 2 for firefox browserify home p95 initialActions Benchmark value 1478 exceeds gate value 1475 for firefox browserify home p95 loadScripts Benchmark value 42 exceeds gate value 27 for firefox browserify home p95 setupStore Benchmark value 1746 exceeds gate value 1615 for firefox webpack home mean uiStartup Benchmark value 1468 exceeds gate value 1380 for firefox webpack home mean load Benchmark value 1468 exceeds gate value 1380 for firefox webpack home mean domContentLoaded Benchmark value 33 exceeds gate value 26 for firefox webpack home mean backgroundConnect Benchmark value 52 exceeds gate value 38 for firefox webpack home mean firstReactRender Benchmark value 10 exceeds gate value 1 for firefox webpack home mean initialActions Benchmark value 1439 exceeds gate value 1360 for firefox webpack home mean loadScripts Benchmark value 15 exceeds gate value 13 for firefox webpack home mean setupStore Benchmark value 2241 exceeds gate value 1935 for firefox webpack home p95 uiStartup Benchmark value 1824 exceeds gate value 1660 for firefox webpack home p95 load Benchmark value 1824 exceeds gate value 1660 for firefox webpack home p95 domContentLoaded Benchmark value 305 exceeds gate value 156 for firefox webpack home p95 domInteractive Benchmark value 58 exceeds gate value 49 for firefox webpack home p95 backgroundConnect Benchmark value 60 exceeds gate value 50 for firefox webpack home p95 firstReactRender Benchmark value 20 exceeds gate value 2 for firefox webpack home p95 initialActions Benchmark value 1758 exceeds gate value 1630 for firefox webpack home p95 loadScripts Benchmark value 46 exceeds gate value 28 for firefox webpack home p95 setupStore Sum of mean exceeds: 2115ms | Sum of p95 exceeds: 2538.8ms Sum of all benchmark exceeds: 4653.8ms Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
metamaskbot
added
the
release-13.1.0
NidhiKJha
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ensures that when Solana account is connected, it should render connected state in the dapp view
Related issues
Fixes: #34239
Manual testing steps
Screenshots/Recordings
Before
NA
After
Screen.Recording.2025-07-17.at.8.08.58.PM.mov
Pre-merge author checklist
Pre-merge reviewer checklist