fix: update explorer button text in address qr code page to reflect the network's explorer name #34377
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hmalik88
added
the
no-changelog
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
metamaskbot
added
team-accounts-framework
Collaborator
✨ Files requiring CODEOWNER review ✨🔑 @MetaMask/accounts-engineers (3 files, +20 -7)
|
Collaborator
|
❌ test-e2e-chrome-api-specs failed. View the html report here. |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Collaborator
Builds ready [ea9824d]
UI Startup Metrics (1275 ± 67 ms)
Benchmark value 1092 exceeds gate value 1070 for chrome browserify home mean load Benchmark value 1085 exceeds gate value 1061 for chrome browserify home mean domContentLoaded Benchmark value 213 exceeds gate value 10 for chrome browserify home mean backgroundConnect Benchmark value 4 exceeds gate value 1 for chrome browserify home mean initialActions Benchmark value 879 exceeds gate value 830 for chrome browserify home mean loadScripts Benchmark value 1374 exceeds gate value 1365 for chrome browserify home p95 uiStartup Benchmark value 44 exceeds gate value 41 for chrome browserify home p95 domInteractive Benchmark value 224 exceeds gate value 18 for chrome browserify home p95 backgroundConnect Benchmark value 16 exceeds gate value 1.2 for chrome browserify home p95 initialActions Benchmark value 954 exceeds gate value 940 for chrome browserify home p95 loadScripts Benchmark value 2352 exceeds gate value 2192 for chrome webpack home mean uiStartup Benchmark value 1866 exceeds gate value 1711 for chrome webpack home mean load Benchmark value 1857 exceeds gate value 1704 for chrome webpack home mean domContentLoaded Benchmark value 47 exceeds gate value 40 for chrome webpack home mean backgroundConnect Benchmark value 8 exceeds gate value 7 for chrome webpack home mean initialActions Benchmark value 1853 exceeds gate value 1699 for chrome webpack home mean loadScripts Benchmark value 2513 exceeds gate value 2454 for chrome webpack home p95 uiStartup Benchmark value 2130 exceeds gate value 2030 for chrome webpack home p95 load Benchmark value 2124 exceeds gate value 2005 for chrome webpack home p95 domContentLoaded Benchmark value 66 exceeds gate value 57 for chrome webpack home p95 domInteractive Benchmark value 276 exceeds gate value 90 for chrome webpack home p95 backgroundConnect Benchmark value 19 exceeds gate value 7 for chrome webpack home p95 initialActions Benchmark value 2111 exceeds gate value 1970 for chrome webpack home p95 loadScripts Benchmark value 1518 exceeds gate value 1405 for firefox browserify home mean uiStartup Benchmark value 1303 exceeds gate value 1245 for firefox browserify home mean load Benchmark value 1303 exceeds gate value 1239 for firefox browserify home mean domContentLoaded Benchmark value 115 exceeds gate value 110 for firefox browserify home mean domInteractive Benchmark value 30 exceeds gate value 25 for firefox browserify home mean backgroundConnect Benchmark value 29 exceeds gate value 25 for firefox browserify home mean firstReactRender Benchmark value 16 exceeds gate value 11 for firefox browserify home mean getState Benchmark value 6 exceeds gate value 1 for firefox browserify home mean initialActions Benchmark value 1279 exceeds gate value 1230 for firefox browserify home mean loadScripts Benchmark value 13 exceeds gate value 9 for firefox browserify home mean setupStore Benchmark value 1824 exceeds gate value 1660 for firefox browserify home p95 uiStartup Benchmark value 304 exceeds gate value 195 for firefox browserify home p95 domInteractive Benchmark value 56 exceeds gate value 55 for firefox browserify home p95 firstReactRender Benchmark value 47 exceeds gate value 24 for firefox browserify home p95 getState Benchmark value 25 exceeds gate value 2 for firefox browserify home p95 initialActions Benchmark value 50 exceeds gate value 27 for firefox browserify home p95 setupStore Benchmark value 1742 exceeds gate value 1615 for firefox webpack home mean uiStartup Benchmark value 1489 exceeds gate value 1380 for firefox webpack home mean load Benchmark value 1488 exceeds gate value 1380 for firefox webpack home mean domContentLoaded Benchmark value 30 exceeds gate value 26 for firefox webpack home mean backgroundConnect Benchmark value 52 exceeds gate value 38 for firefox webpack home mean firstReactRender Benchmark value 5 exceeds gate value 1 for firefox webpack home mean initialActions Benchmark value 1465 exceeds gate value 1360 for firefox webpack home mean loadScripts Benchmark value 15 exceeds gate value 13 for firefox webpack home mean setupStore Benchmark value 2152 exceeds gate value 1935 for firefox webpack home p95 uiStartup Benchmark value 1806 exceeds gate value 1660 for firefox webpack home p95 load Benchmark value 1806 exceeds gate value 1660 for firefox webpack home p95 domContentLoaded Benchmark value 278 exceeds gate value 156 for firefox webpack home p95 domInteractive Benchmark value 66 exceeds gate value 49 for firefox webpack home p95 backgroundConnect Benchmark value 60 exceeds gate value 50 for firefox webpack home p95 firstReactRender Benchmark value 21 exceeds gate value 2 for firefox webpack home p95 initialActions Benchmark value 1762 exceeds gate value 1630 for firefox webpack home p95 loadScripts Benchmark value 34 exceeds gate value 28 for firefox webpack home p95 setupStore Sum of mean exceeds: 1757ms | Sum of p95 exceeds: 2030.8ms Sum of all benchmark exceeds: 3787.8ms Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Collaborator
Builds ready [35c713c]
UI Startup Metrics (1252 ± 56 ms)
Benchmark value 1079 exceeds gate value 1070 for chrome browserify home mean load Benchmark value 1072 exceeds gate value 1061 for chrome browserify home mean domContentLoaded Benchmark value 208 exceeds gate value 10 for chrome browserify home mean backgroundConnect Benchmark value 4 exceeds gate value 1 for chrome browserify home mean initialActions Benchmark value 871 exceeds gate value 830 for chrome browserify home mean loadScripts Benchmark value 225 exceeds gate value 18 for chrome browserify home p95 backgroundConnect Benchmark value 17 exceeds gate value 1.2 for chrome browserify home p95 initialActions Benchmark value 945 exceeds gate value 940 for chrome browserify home p95 loadScripts Benchmark value 2368 exceeds gate value 2192 for chrome webpack home mean uiStartup Benchmark value 1875 exceeds gate value 1711 for chrome webpack home mean load Benchmark value 1868 exceeds gate value 1704 for chrome webpack home mean domContentLoaded Benchmark value 12 exceeds gate value 7 for chrome webpack home mean initialActions Benchmark value 1861 exceeds gate value 1699 for chrome webpack home mean loadScripts Benchmark value 2572 exceeds gate value 2454 for chrome webpack home p95 uiStartup Benchmark value 2150 exceeds gate value 2030 for chrome webpack home p95 load Benchmark value 2144 exceeds gate value 2005 for chrome webpack home p95 domContentLoaded Benchmark value 156 exceeds gate value 90 for chrome webpack home p95 backgroundConnect Benchmark value 40 exceeds gate value 7 for chrome webpack home p95 initialActions Benchmark value 2131 exceeds gate value 1970 for chrome webpack home p95 loadScripts Benchmark value 1469 exceeds gate value 1405 for firefox browserify home mean uiStartup Benchmark value 1271 exceeds gate value 1245 for firefox browserify home mean load Benchmark value 1271 exceeds gate value 1239 for firefox browserify home mean domContentLoaded Benchmark value 111 exceeds gate value 110 for firefox browserify home mean domInteractive Benchmark value 26 exceeds gate value 25 for firefox browserify home mean backgroundConnect Benchmark value 30 exceeds gate value 25 for firefox browserify home mean firstReactRender Benchmark value 12 exceeds gate value 11 for firefox browserify home mean getState Benchmark value 5 exceeds gate value 1 for firefox browserify home mean initialActions Benchmark value 1250 exceeds gate value 1230 for firefox browserify home mean loadScripts Benchmark value 12 exceeds gate value 9 for firefox browserify home mean setupStore Benchmark value 1783 exceeds gate value 1660 for firefox browserify home p95 uiStartup Benchmark value 309 exceeds gate value 195 for firefox browserify home p95 domInteractive Benchmark value 57 exceeds gate value 55 for firefox browserify home p95 firstReactRender Benchmark value 46 exceeds gate value 24 for firefox browserify home p95 getState Benchmark value 14 exceeds gate value 2 for firefox browserify home p95 initialActions Benchmark value 46 exceeds gate value 27 for firefox browserify home p95 setupStore Benchmark value 1821 exceeds gate value 1615 for firefox webpack home mean uiStartup Benchmark value 1525 exceeds gate value 1380 for firefox webpack home mean load Benchmark value 1524 exceeds gate value 1380 for firefox webpack home mean domContentLoaded Benchmark value 107 exceeds gate value 100 for firefox webpack home mean domInteractive Benchmark value 37 exceeds gate value 26 for firefox webpack home mean backgroundConnect Benchmark value 54 exceeds gate value 38 for firefox webpack home mean firstReactRender Benchmark value 10 exceeds gate value 1 for firefox webpack home mean initialActions Benchmark value 1497 exceeds gate value 1360 for firefox webpack home mean loadScripts Benchmark value 22 exceeds gate value 13 for firefox webpack home mean setupStore Benchmark value 2368 exceeds gate value 1935 for firefox webpack home p95 uiStartup Benchmark value 1892 exceeds gate value 1660 for firefox webpack home p95 load Benchmark value 1891 exceeds gate value 1660 for firefox webpack home p95 domContentLoaded Benchmark value 327 exceeds gate value 156 for firefox webpack home p95 domInteractive Benchmark value 100 exceeds gate value 49 for firefox webpack home p95 backgroundConnect Benchmark value 65 exceeds gate value 50 for firefox webpack home p95 firstReactRender Benchmark value 38 exceeds gate value 32 for firefox webpack home p95 getState Benchmark value 60 exceeds gate value 2 for firefox webpack home p95 initialActions Benchmark value 1811 exceeds gate value 1630 for firefox webpack home p95 loadScripts Benchmark value 110 exceeds gate value 28 for firefox webpack home p95 setupStore Sum of mean exceeds: 1792ms | Sum of p95 exceeds: 2616.8ms Sum of all benchmark exceeds: 4408.8ms Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
montelaidev
reviewed
Jul 18, 2025
ui/pages/multichain-accounts/address-qr-code/address-qr-code.test.tsx
Outdated
Show resolved
Hide resolved
PatrykLucka
previously approved these changes
Jul 18, 2025
There was a problem hiding this comment.
Bug: Block Explorer Button Text Mismatch
The getExplorerButtonText function hardcodes block explorer names (e.g., "Etherscan" for EVM, "Solscan" for Solana) based solely on account type. This creates a mismatch with the actual block explorer URL, which is dynamically determined by the current network. For example, a Polygon account will display "View on Etherscan" but link to Polygonscan. The button text should dynamically reflect the actual block explorer for the current network, which is available via multichainNetwork.blockExplorerUrls.
ui/pages/multichain-accounts/address-qr-code/address-qr-code.tsx#L72-L82
Was this report helpful? Give feedback by reacting with 👍 or 👎
Collaborator
Builds ready [16b328d]
UI Startup Metrics (1229 ± 55 ms)
Benchmark value 4 exceeds gate value 1 for chrome browserify home mean initialActions Benchmark value 848 exceeds gate value 830 for chrome browserify home mean loadScripts Benchmark value 226 exceeds gate value 18 for chrome browserify home p95 backgroundConnect Benchmark value 15 exceeds gate value 1.2 for chrome browserify home p95 initialActions Benchmark value 942 exceeds gate value 940 for chrome browserify home p95 loadScripts Benchmark value 2374 exceeds gate value 2192 for chrome webpack home mean uiStartup Benchmark value 1875 exceeds gate value 1711 for chrome webpack home mean load Benchmark value 1866 exceeds gate value 1704 for chrome webpack home mean domContentLoaded Benchmark value 11 exceeds gate value 7 for chrome webpack home mean initialActions Benchmark value 1861 exceeds gate value 1699 for chrome webpack home mean loadScripts Benchmark value 2592 exceeds gate value 2454 for chrome webpack home p95 uiStartup Benchmark value 2074 exceeds gate value 2030 for chrome webpack home p95 load Benchmark value 2066 exceeds gate value 2005 for chrome webpack home p95 domContentLoaded Benchmark value 60 exceeds gate value 57 for chrome webpack home p95 domInteractive Benchmark value 335 exceeds gate value 334 for chrome webpack home p95 firstPaint Benchmark value 373 exceeds gate value 370 for chrome webpack home p95 firstReactRender Benchmark value 31 exceeds gate value 7 for chrome webpack home p95 initialActions Benchmark value 2057 exceeds gate value 1970 for chrome webpack home p95 loadScripts Benchmark value 1489 exceeds gate value 1405 for firefox browserify home mean uiStartup Benchmark value 1285 exceeds gate value 1245 for firefox browserify home mean load Benchmark value 1284 exceeds gate value 1239 for firefox browserify home mean domContentLoaded Benchmark value 123 exceeds gate value 110 for firefox browserify home mean domInteractive Benchmark value 28 exceeds gate value 25 for firefox browserify home mean backgroundConnect Benchmark value 27 exceeds gate value 25 for firefox browserify home mean firstReactRender Benchmark value 13 exceeds gate value 11 for firefox browserify home mean getState Benchmark value 5 exceeds gate value 1 for firefox browserify home mean initialActions Benchmark value 1261 exceeds gate value 1230 for firefox browserify home mean loadScripts Benchmark value 13 exceeds gate value 9 for firefox browserify home mean setupStore Benchmark value 1833 exceeds gate value 1660 for firefox browserify home p95 uiStartup Benchmark value 339 exceeds gate value 195 for firefox browserify home p95 domInteractive Benchmark value 37 exceeds gate value 24 for firefox browserify home p95 getState Benchmark value 18 exceeds gate value 2 for firefox browserify home p95 initialActions Benchmark value 39 exceeds gate value 27 for firefox browserify home p95 setupStore Benchmark value 1771 exceeds gate value 1615 for firefox webpack home mean uiStartup Benchmark value 1498 exceeds gate value 1380 for firefox webpack home mean load Benchmark value 1498 exceeds gate value 1380 for firefox webpack home mean domContentLoaded Benchmark value 122 exceeds gate value 100 for firefox webpack home mean domInteractive Benchmark value 30 exceeds gate value 26 for firefox webpack home mean backgroundConnect Benchmark value 52 exceeds gate value 38 for firefox webpack home mean firstReactRender Benchmark value 16 exceeds gate value 15 for firefox webpack home mean getState Benchmark value 10 exceeds gate value 1 for firefox webpack home mean initialActions Benchmark value 1475 exceeds gate value 1360 for firefox webpack home mean loadScripts Benchmark value 14 exceeds gate value 13 for firefox webpack home mean setupStore Benchmark value 2151 exceeds gate value 1935 for firefox webpack home p95 uiStartup Benchmark value 1803 exceeds gate value 1660 for firefox webpack home p95 load Benchmark value 1803 exceeds gate value 1660 for firefox webpack home p95 domContentLoaded Benchmark value 323 exceeds gate value 156 for firefox webpack home p95 domInteractive Benchmark value 59 exceeds gate value 49 for firefox webpack home p95 backgroundConnect Benchmark value 62 exceeds gate value 50 for firefox webpack home p95 firstReactRender Benchmark value 38 exceeds gate value 32 for firefox webpack home p95 getState Benchmark value 28 exceeds gate value 2 for firefox webpack home p95 initialActions Benchmark value 1765 exceeds gate value 1630 for firefox webpack home p95 loadScripts Benchmark value 39 exceeds gate value 28 for firefox webpack home p95 setupStore Sum of mean exceeds: 1678ms | Sum of p95 exceeds: 1811.8ms Sum of all benchmark exceeds: 3489.8ms Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
PatrykLucka
approved these changes
Jul 18, 2025
montelaidev
approved these changes
Jul 19, 2025
metamaskbot
added
the
release-13.1.0
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions:
Manual testing steps
Screenshots/Recordings
Before
After
Screen.Recording.2025-07-17.at.3.20.49.PM.mov
Screen.Recording.2025-07-17.at.3.20.12.PM.mov
Pre-merge author checklist
Pre-merge reviewer checklist