-
Notifications
You must be signed in to change notification settings - Fork 5.5k
chore: upgrade @metamask/design-tokens to v8.1.0 #34384
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
✨ Files requiring CODEOWNER review ✨🔑 @MetaMask/accounts-engineers (2 files, +3 -3)
🖥️ @MetaMask/wallet-ux (1 files, +2 -2)
|
Builds ready [b4d9e9e]
UI Startup Metrics (1258 ± 69 ms)
Benchmark value 1083 exceeds gate value 1070 for chrome browserify home mean load Benchmark value 1076 exceeds gate value 1061 for chrome browserify home mean domContentLoaded Benchmark value 211 exceeds gate value 10 for chrome browserify home mean backgroundConnect Benchmark value 5 exceeds gate value 1 for chrome browserify home mean initialActions Benchmark value 872 exceeds gate value 830 for chrome browserify home mean loadScripts Benchmark value 43 exceeds gate value 41 for chrome browserify home p95 domInteractive Benchmark value 230 exceeds gate value 18 for chrome browserify home p95 backgroundConnect Benchmark value 20 exceeds gate value 1.2 for chrome browserify home p95 initialActions Benchmark value 963 exceeds gate value 940 for chrome browserify home p95 loadScripts Benchmark value 2364 exceeds gate value 2192 for chrome webpack home mean uiStartup Benchmark value 1865 exceeds gate value 1711 for chrome webpack home mean load Benchmark value 1859 exceeds gate value 1704 for chrome webpack home mean domContentLoaded Benchmark value 22 exceeds gate value 21 for chrome webpack home mean domInteractive Benchmark value 12 exceeds gate value 7 for chrome webpack home mean initialActions Benchmark value 1854 exceeds gate value 1699 for chrome webpack home mean loadScripts Benchmark value 2538 exceeds gate value 2454 for chrome webpack home p95 uiStartup Benchmark value 2133 exceeds gate value 2030 for chrome webpack home p95 load Benchmark value 2128 exceeds gate value 2005 for chrome webpack home p95 domContentLoaded Benchmark value 66 exceeds gate value 57 for chrome webpack home p95 domInteractive Benchmark value 33 exceeds gate value 7 for chrome webpack home p95 initialActions Benchmark value 2118 exceeds gate value 1970 for chrome webpack home p95 loadScripts Benchmark value 1551 exceeds gate value 1405 for firefox browserify home mean uiStartup Benchmark value 1322 exceeds gate value 1245 for firefox browserify home mean load Benchmark value 1322 exceeds gate value 1239 for firefox browserify home mean domContentLoaded Benchmark value 114 exceeds gate value 110 for firefox browserify home mean domInteractive Benchmark value 28 exceeds gate value 25 for firefox browserify home mean backgroundConnect Benchmark value 30 exceeds gate value 25 for firefox browserify home mean firstReactRender Benchmark value 17 exceeds gate value 11 for firefox browserify home mean getState Benchmark value 6 exceeds gate value 1 for firefox browserify home mean initialActions Benchmark value 1297 exceeds gate value 1230 for firefox browserify home mean loadScripts Benchmark value 15 exceeds gate value 9 for firefox browserify home mean setupStore Benchmark value 1843 exceeds gate value 1660 for firefox browserify home p95 uiStartup Benchmark value 1513 exceeds gate value 1495 for firefox browserify home p95 load Benchmark value 1513 exceeds gate value 1495 for firefox browserify home p95 domContentLoaded Benchmark value 318 exceeds gate value 195 for firefox browserify home p95 domInteractive Benchmark value 61 exceeds gate value 55 for firefox browserify home p95 firstReactRender Benchmark value 64 exceeds gate value 24 for firefox browserify home p95 getState Benchmark value 10 exceeds gate value 2 for firefox browserify home p95 initialActions Benchmark value 1491 exceeds gate value 1475 for firefox browserify home p95 loadScripts Benchmark value 66 exceeds gate value 27 for firefox browserify home p95 setupStore Benchmark value 1702 exceeds gate value 1615 for firefox webpack home mean uiStartup Benchmark value 1435 exceeds gate value 1380 for firefox webpack home mean load Benchmark value 1435 exceeds gate value 1380 for firefox webpack home mean domContentLoaded Benchmark value 28 exceeds gate value 26 for firefox webpack home mean backgroundConnect Benchmark value 51 exceeds gate value 38 for firefox webpack home mean firstReactRender Benchmark value 7 exceeds gate value 1 for firefox webpack home mean initialActions Benchmark value 1413 exceeds gate value 1360 for firefox webpack home mean loadScripts Benchmark value 18 exceeds gate value 13 for firefox webpack home mean setupStore Benchmark value 2035 exceeds gate value 1935 for firefox webpack home p95 uiStartup Benchmark value 1755 exceeds gate value 1660 for firefox webpack home p95 load Benchmark value 1755 exceeds gate value 1660 for firefox webpack home p95 domContentLoaded Benchmark value 294 exceeds gate value 156 for firefox webpack home p95 domInteractive Benchmark value 62 exceeds gate value 50 for firefox webpack home p95 firstReactRender Benchmark value 20 exceeds gate value 2 for firefox webpack home p95 initialActions Benchmark value 1714 exceeds gate value 1630 for firefox webpack home p95 loadScripts Benchmark value 44 exceeds gate value 28 for firefox webpack home p95 setupStore Sum of mean exceeds: 1619ms | Sum of p95 exceeds: 1757.8ms Sum of all benchmark exceeds: 3376.8ms Bundle size diffs [🚀 Bundle size reduced!]
|
b4d9e9e to
01efb57
Compare
| "@metamask/design-system-react": "^0.1.0", | ||
| "@metamask/design-system-tailwind-preset": "^0.5.0", | ||
| "@metamask/design-tokens": "^8.0.0", | ||
| "@metamask/design-tokens": "^8.1.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Upgrading design tokens to latest
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The CTA buttons on the home screen seems to have changed. Is this intended? They look kind of weird being inconsistent in size
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm let me check. None of the changes in this PR should effect the size of a button. The changes in this upgrade of the design tokens mostly effect color and add some new typography CSS variables.
Builds ready [01efb57]
UI Startup Metrics (1267 ± 77 ms)
Benchmark value 1092 exceeds gate value 1070 for chrome browserify home mean load Benchmark value 1085 exceeds gate value 1061 for chrome browserify home mean domContentLoaded Benchmark value 212 exceeds gate value 10 for chrome browserify home mean backgroundConnect Benchmark value 3 exceeds gate value 1 for chrome browserify home mean initialActions Benchmark value 881 exceeds gate value 830 for chrome browserify home mean loadScripts Benchmark value 1370 exceeds gate value 1365 for chrome browserify home p95 uiStartup Benchmark value 228 exceeds gate value 18 for chrome browserify home p95 backgroundConnect Benchmark value 14 exceeds gate value 1.2 for chrome browserify home p95 initialActions Benchmark value 959 exceeds gate value 940 for chrome browserify home p95 loadScripts Benchmark value 2552 exceeds gate value 2192 for chrome webpack home mean uiStartup Benchmark value 2046 exceeds gate value 1711 for chrome webpack home mean load Benchmark value 2039 exceeds gate value 1704 for chrome webpack home mean domContentLoaded Benchmark value 43 exceeds gate value 40 for chrome webpack home mean backgroundConnect Benchmark value 12 exceeds gate value 7 for chrome webpack home mean initialActions Benchmark value 2029 exceeds gate value 1699 for chrome webpack home mean loadScripts Benchmark value 2747 exceeds gate value 2454 for chrome webpack home p95 uiStartup Benchmark value 2345 exceeds gate value 2030 for chrome webpack home p95 load Benchmark value 2341 exceeds gate value 2005 for chrome webpack home p95 domContentLoaded Benchmark value 70 exceeds gate value 57 for chrome webpack home p95 domInteractive Benchmark value 223 exceeds gate value 90 for chrome webpack home p95 backgroundConnect Benchmark value 45 exceeds gate value 7 for chrome webpack home p95 initialActions Benchmark value 2305 exceeds gate value 1970 for chrome webpack home p95 loadScripts Benchmark value 1483 exceeds gate value 1405 for firefox browserify home mean uiStartup Benchmark value 1274 exceeds gate value 1245 for firefox browserify home mean load Benchmark value 1274 exceeds gate value 1239 for firefox browserify home mean domContentLoaded Benchmark value 27 exceeds gate value 25 for firefox browserify home mean backgroundConnect Benchmark value 28 exceeds gate value 25 for firefox browserify home mean firstReactRender Benchmark value 12 exceeds gate value 11 for firefox browserify home mean getState Benchmark value 4 exceeds gate value 1 for firefox browserify home mean initialActions Benchmark value 1252 exceeds gate value 1230 for firefox browserify home mean loadScripts Benchmark value 11 exceeds gate value 9 for firefox browserify home mean setupStore Benchmark value 1820 exceeds gate value 1660 for firefox browserify home p95 uiStartup Benchmark value 298 exceeds gate value 195 for firefox browserify home p95 domInteractive Benchmark value 26 exceeds gate value 24 for firefox browserify home p95 getState Benchmark value 14 exceeds gate value 2 for firefox browserify home p95 initialActions Benchmark value 45 exceeds gate value 27 for firefox browserify home p95 setupStore Benchmark value 1766 exceeds gate value 1615 for firefox webpack home mean uiStartup Benchmark value 1484 exceeds gate value 1380 for firefox webpack home mean load Benchmark value 1484 exceeds gate value 1380 for firefox webpack home mean domContentLoaded Benchmark value 102 exceeds gate value 100 for firefox webpack home mean domInteractive Benchmark value 30 exceeds gate value 26 for firefox webpack home mean backgroundConnect Benchmark value 52 exceeds gate value 38 for firefox webpack home mean firstReactRender Benchmark value 18 exceeds gate value 15 for firefox webpack home mean getState Benchmark value 9 exceeds gate value 1 for firefox webpack home mean initialActions Benchmark value 1460 exceeds gate value 1360 for firefox webpack home mean loadScripts Benchmark value 16 exceeds gate value 13 for firefox webpack home mean setupStore Benchmark value 2140 exceeds gate value 1935 for firefox webpack home p95 uiStartup Benchmark value 1746 exceeds gate value 1660 for firefox webpack home p95 load Benchmark value 1746 exceeds gate value 1660 for firefox webpack home p95 domContentLoaded Benchmark value 294 exceeds gate value 156 for firefox webpack home p95 domInteractive Benchmark value 65 exceeds gate value 49 for firefox webpack home p95 backgroundConnect Benchmark value 64 exceeds gate value 50 for firefox webpack home p95 firstReactRender Benchmark value 39 exceeds gate value 32 for firefox webpack home p95 getState Benchmark value 21 exceeds gate value 2 for firefox webpack home p95 initialActions Benchmark value 1725 exceeds gate value 1630 for firefox webpack home p95 loadScripts Benchmark value 42 exceeds gate value 28 for firefox webpack home p95 setupStore Sum of mean exceeds: 2370ms | Sum of p95 exceeds: 2684.8ms Sum of all benchmark exceeds: 5054.8ms Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Description
This PR upgrades the @metamask/design-tokens package from version 8.0.0 to 8.1.0 to incorporate the latest design system updates and improvements.
The upgrade includes:
This change ensures the extension stays current with the latest MetaMask design system standards.
Changelog
CHANGELOG entry: Updated design tokens to version 8.1.0 with improved color specifications
Related issues
Fixes: N/A (routine dependency upgrade)
Manual testing steps
Screenshots/Recordings
Before
Colors using design tokens v8.0.0
before720.mov
After
Colors using design tokens v8.1.0 (subtle color refinements)
Screen.Recording.2025-07-18.at.9.08.56.AM.mov
Pre-merge author checklist
Pre-merge reviewer checklist