Skip to content

Conversation

@lwin-kyaw
Copy link
Contributor

@lwin-kyaw lwin-kyaw commented Jul 18, 2025

Description

This PR fixes and handle the ratelimit error during the social-import flow.

Open in GitHub Codespaces

Changelog

CHANGELOG entry:

Related issues

Fixes: #34393

Manual testing steps

  1. Login to existing wallet using the social login
  2. At the unlock page, type incorrect password for 4 times straight
  3. After 4th failure, you should see the error message with timer
Too many failed attempts. Please try again in 30s.

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@metamaskbot metamaskbot added the team-onboarding Onboarding team label Jul 18, 2025
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@lwin-kyaw lwin-kyaw changed the title fix:handle recovery ratelimit error fix: handle recovery ratelimit error Jul 18, 2025
@chaitanyapotti chaitanyapotti changed the title fix: handle recovery ratelimit error fix: handle recovery ratelimit error cp-13.0.0 Jul 18, 2025
@metamaskbot
Copy link
Collaborator

Builds ready [eb28ab4]
UI Startup Metrics (1265 ± 59 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1265117114435913071385
load108499213025911251183
domContentLoaded107798412985911191176
domInteractive18146781738
firstPaint678142121543410851173
backgroundConnect2111962648214226
firstReactRender20153752133
getState1045581128
initialActions40729218
loadScripts872782103757913968
setupStore74193814
WebpackHomeuiStartup23912030287115624842604
load18931463243418319982192
domContentLoaded18791458242918119832153
domInteractive2013239251662
firstPaint1636541171186310
backgroundConnect54113248034280
firstReactRender1738936077210336
getState1143951320
initialActions8219019723
loadScripts18741454241818119802151
setupStore1364861526
FirefoxBrowserifyHomeuiStartup14781311199813615071808
load1279114615848913121491
domContentLoaded1279114615838913121491
domInteractive1123946972105319
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect2714111152863
firstReactRender28216383056
getState11319122740
initialActions6017925214
loadScripts1257111615568712871465
setupStore10310517731
WebpackHomeuiStartup17351493256218018132149
load14681294189413315541764
domContentLoaded14681294189313315541763
domInteractive100603976393302
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect3217228243671
firstReactRender52416765662
getState837291026
initialActions10125135722
loadScripts14441274185013015281743
setupStore1257714940
Benchmark value 1265 exceeds gate value 1234 for chrome browserify home mean uiStartup
Benchmark value 1084 exceeds gate value 1070 for chrome browserify home mean load
Benchmark value 1078 exceeds gate value 1061 for chrome browserify home mean domContentLoaded
Benchmark value 212 exceeds gate value 10 for chrome browserify home mean backgroundConnect
Benchmark value 4 exceeds gate value 1 for chrome browserify home mean initialActions
Benchmark value 873 exceeds gate value 830 for chrome browserify home mean loadScripts
Benchmark value 1385 exceeds gate value 1365 for chrome browserify home p95 uiStartup
Benchmark value 226 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 18 exceeds gate value 1.2 for chrome browserify home p95 initialActions
Benchmark value 968 exceeds gate value 940 for chrome browserify home p95 loadScripts
Benchmark value 2391 exceeds gate value 2192 for chrome webpack home mean uiStartup
Benchmark value 1893 exceeds gate value 1711 for chrome webpack home mean load
Benchmark value 1879 exceeds gate value 1704 for chrome webpack home mean domContentLoaded
Benchmark value 55 exceeds gate value 40 for chrome webpack home mean backgroundConnect
Benchmark value 8 exceeds gate value 7 for chrome webpack home mean initialActions
Benchmark value 1875 exceeds gate value 1699 for chrome webpack home mean loadScripts
Benchmark value 2605 exceeds gate value 2454 for chrome webpack home p95 uiStartup
Benchmark value 2192 exceeds gate value 2030 for chrome webpack home p95 load
Benchmark value 2154 exceeds gate value 2005 for chrome webpack home p95 domContentLoaded
Benchmark value 63 exceeds gate value 57 for chrome webpack home p95 domInteractive
Benchmark value 280 exceeds gate value 90 for chrome webpack home p95 backgroundConnect
Benchmark value 23 exceeds gate value 7 for chrome webpack home p95 initialActions
Benchmark value 2151 exceeds gate value 1970 for chrome webpack home p95 loadScripts
Benchmark value 1478 exceeds gate value 1405 for firefox browserify home mean uiStartup
Benchmark value 1280 exceeds gate value 1245 for firefox browserify home mean load
Benchmark value 1279 exceeds gate value 1239 for firefox browserify home mean domContentLoaded
Benchmark value 113 exceeds gate value 110 for firefox browserify home mean domInteractive
Benchmark value 28 exceeds gate value 25 for firefox browserify home mean backgroundConnect
Benchmark value 29 exceeds gate value 25 for firefox browserify home mean firstReactRender
Benchmark value 6 exceeds gate value 1 for firefox browserify home mean initialActions
Benchmark value 1258 exceeds gate value 1230 for firefox browserify home mean loadScripts
Benchmark value 11 exceeds gate value 9 for firefox browserify home mean setupStore
Benchmark value 1808 exceeds gate value 1660 for firefox browserify home p95 uiStartup
Benchmark value 319 exceeds gate value 195 for firefox browserify home p95 domInteractive
Benchmark value 56 exceeds gate value 55 for firefox browserify home p95 firstReactRender
Benchmark value 40 exceeds gate value 24 for firefox browserify home p95 getState
Benchmark value 14 exceeds gate value 2 for firefox browserify home p95 initialActions
Benchmark value 31 exceeds gate value 27 for firefox browserify home p95 setupStore
Benchmark value 1736 exceeds gate value 1615 for firefox webpack home mean uiStartup
Benchmark value 1469 exceeds gate value 1380 for firefox webpack home mean load
Benchmark value 1468 exceeds gate value 1380 for firefox webpack home mean domContentLoaded
Benchmark value 101 exceeds gate value 100 for firefox webpack home mean domInteractive
Benchmark value 32 exceeds gate value 26 for firefox webpack home mean backgroundConnect
Benchmark value 52 exceeds gate value 38 for firefox webpack home mean firstReactRender
Benchmark value 11 exceeds gate value 1 for firefox webpack home mean initialActions
Benchmark value 1444 exceeds gate value 1360 for firefox webpack home mean loadScripts
Benchmark value 2149 exceeds gate value 1935 for firefox webpack home p95 uiStartup
Benchmark value 1764 exceeds gate value 1660 for firefox webpack home p95 load
Benchmark value 1763 exceeds gate value 1660 for firefox webpack home p95 domContentLoaded
Benchmark value 302 exceeds gate value 156 for firefox webpack home p95 domInteractive
Benchmark value 71 exceeds gate value 49 for firefox webpack home p95 backgroundConnect
Benchmark value 62 exceeds gate value 50 for firefox webpack home p95 firstReactRender
Benchmark value 22 exceeds gate value 2 for firefox webpack home p95 initialActions
Benchmark value 1743 exceeds gate value 1630 for firefox webpack home p95 loadScripts
Benchmark value 40 exceeds gate value 28 for firefox webpack home p95 setupStore
Sum of mean exceeds: 1664ms | Sum of p95 exceeds: 2178.8ms
Sum of all benchmark exceeds: 3842.8ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 218 Bytes (0%)
  • ui: -182 Bytes (0%)
  • common: 15 Bytes (0%)

@lwin-kyaw lwin-kyaw added this pull request to the merge queue Jul 18, 2025
Merged via the queue into main with commit aa3968f Jul 18, 2025
280 of 288 checks passed
@lwin-kyaw lwin-kyaw deleted the fix/rehyrate-ratelimit-error branch July 18, 2025 10:38
@github-actions github-actions bot locked and limited conversation to collaborators Jul 18, 2025
@metamaskbot metamaskbot added the release-13.1.0 Issue or pull request that will be included in release 13.1.0 label Jul 18, 2025
@gauthierpetetin gauthierpetetin added release-13.0.0 Issue or pull request that will be included in release 13.0.0 (also called 12.24.0) and removed release-13.1.0 Issue or pull request that will be included in release 13.1.0 labels Aug 5, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-onboarding release-13.0.0 Issue or pull request that will be included in release 13.0.0 (also called 12.24.0) team-onboarding Onboarding team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Missing timer for Rehydrate flow

6 participants