feat: enable SeedlessOnboarding feature cp-13.0.0 #34429
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Collaborator
Builds ready [b8050cc]
UI Startup Metrics (1257 ± 60 ms)
Benchmark value 1080 exceeds gate value 1070 for chrome browserify home mean load Benchmark value 1074 exceeds gate value 1061 for chrome browserify home mean domContentLoaded Benchmark value 210 exceeds gate value 10 for chrome browserify home mean backgroundConnect Benchmark value 3 exceeds gate value 1 for chrome browserify home mean initialActions Benchmark value 870 exceeds gate value 830 for chrome browserify home mean loadScripts Benchmark value 1370 exceeds gate value 1365 for chrome browserify home p95 uiStartup Benchmark value 219 exceeds gate value 18 for chrome browserify home p95 backgroundConnect Benchmark value 15 exceeds gate value 1.2 for chrome browserify home p95 initialActions Benchmark value 952 exceeds gate value 940 for chrome browserify home p95 loadScripts Benchmark value 2488 exceeds gate value 2192 for chrome webpack home mean uiStartup Benchmark value 1994 exceeds gate value 1711 for chrome webpack home mean load Benchmark value 1983 exceeds gate value 1704 for chrome webpack home mean domContentLoaded Benchmark value 1978 exceeds gate value 1699 for chrome webpack home mean loadScripts Benchmark value 2759 exceeds gate value 2454 for chrome webpack home p95 uiStartup Benchmark value 2317 exceeds gate value 2030 for chrome webpack home p95 load Benchmark value 2241 exceeds gate value 2005 for chrome webpack home p95 domContentLoaded Benchmark value 61 exceeds gate value 57 for chrome webpack home p95 domInteractive Benchmark value 209 exceeds gate value 90 for chrome webpack home p95 backgroundConnect Benchmark value 25 exceeds gate value 7 for chrome webpack home p95 initialActions Benchmark value 2238 exceeds gate value 1970 for chrome webpack home p95 loadScripts Benchmark value 1516 exceeds gate value 1405 for firefox browserify home mean uiStartup Benchmark value 1298 exceeds gate value 1245 for firefox browserify home mean load Benchmark value 1298 exceeds gate value 1239 for firefox browserify home mean domContentLoaded Benchmark value 111 exceeds gate value 110 for firefox browserify home mean domInteractive Benchmark value 29 exceeds gate value 25 for firefox browserify home mean backgroundConnect Benchmark value 29 exceeds gate value 25 for firefox browserify home mean firstReactRender Benchmark value 17 exceeds gate value 11 for firefox browserify home mean getState Benchmark value 6 exceeds gate value 1 for firefox browserify home mean initialActions Benchmark value 1275 exceeds gate value 1230 for firefox browserify home mean loadScripts Benchmark value 13 exceeds gate value 9 for firefox browserify home mean setupStore Benchmark value 1828 exceeds gate value 1660 for firefox browserify home p95 uiStartup Benchmark value 1499 exceeds gate value 1495 for firefox browserify home p95 load Benchmark value 1499 exceeds gate value 1495 for firefox browserify home p95 domContentLoaded Benchmark value 309 exceeds gate value 195 for firefox browserify home p95 domInteractive Benchmark value 77 exceeds gate value 24 for firefox browserify home p95 getState Benchmark value 14 exceeds gate value 2 for firefox browserify home p95 initialActions Benchmark value 55 exceeds gate value 27 for firefox browserify home p95 setupStore Benchmark value 1748 exceeds gate value 1615 for firefox webpack home mean uiStartup Benchmark value 1483 exceeds gate value 1380 for firefox webpack home mean load Benchmark value 1483 exceeds gate value 1380 for firefox webpack home mean domContentLoaded Benchmark value 108 exceeds gate value 100 for firefox webpack home mean domInteractive Benchmark value 29 exceeds gate value 26 for firefox webpack home mean backgroundConnect Benchmark value 54 exceeds gate value 38 for firefox webpack home mean firstReactRender Benchmark value 8 exceeds gate value 1 for firefox webpack home mean initialActions Benchmark value 1459 exceeds gate value 1360 for firefox webpack home mean loadScripts Benchmark value 15 exceeds gate value 13 for firefox webpack home mean setupStore Benchmark value 2192 exceeds gate value 1935 for firefox webpack home p95 uiStartup Benchmark value 1859 exceeds gate value 1660 for firefox webpack home p95 load Benchmark value 1859 exceeds gate value 1660 for firefox webpack home p95 domContentLoaded Benchmark value 348 exceeds gate value 156 for firefox webpack home p95 domInteractive Benchmark value 58 exceeds gate value 49 for firefox webpack home p95 backgroundConnect Benchmark value 63 exceeds gate value 50 for firefox webpack home p95 firstReactRender Benchmark value 17 exceeds gate value 2 for firefox webpack home p95 initialActions Benchmark value 1817 exceeds gate value 1630 for firefox webpack home p95 loadScripts Sum of mean exceeds: 2192ms | Sum of p95 exceeds: 2922.8ms Sum of all benchmark exceeds: 5114.8ms Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Bug: Social Login Interferes with Vault Decryption Tests
The removal of socialLoginEnabled: false from vault decryption tests, coupled with SEEDLESS_ONBOARDING_ENABLED now defaulting to true, causes these tests to use social login onboarding. This is problematic because these tests require traditional password-based wallet creation to properly test vault decryption functionality, leading to test failures or incorrect functionality being tested.
test/e2e/vault-decryption-chrome.spec.ts#L179-L184
metamask-extension/test/e2e/vault-decryption-chrome.spec.ts
Lines 179 to 184 in 38e9232
test/e2e/vault-decryption-chrome.spec.ts#L239-L244
metamask-extension/test/e2e/vault-decryption-chrome.spec.ts
Lines 239 to 244 in 38e9232
Was this report helpful? Give feedback by reacting with 👍 or 👎
chaitanyapotti
approved these changes
Jul 21, 2025
lwin-kyaw
changed the title
Collaborator
Builds ready [38e9232]
UI Startup Metrics (1320 ± 64 ms)
Benchmark value 1131 exceeds gate value 1070 for chrome browserify home mean load Benchmark value 1122 exceeds gate value 1061 for chrome browserify home mean domContentLoaded Benchmark value 21 exceeds gate value 20 for chrome browserify home mean domInteractive Benchmark value 220 exceeds gate value 10 for chrome browserify home mean backgroundConnect Benchmark value 3 exceeds gate value 1 for chrome browserify home mean initialActions Benchmark value 911 exceeds gate value 830 for chrome browserify home mean loadScripts Benchmark value 1412 exceeds gate value 1365 for chrome browserify home p95 uiStartup Benchmark value 1229 exceeds gate value 1190 for chrome browserify home p95 load Benchmark value 1222 exceeds gate value 1180 for chrome browserify home p95 domContentLoaded Benchmark value 44 exceeds gate value 41 for chrome browserify home p95 domInteractive Benchmark value 1233 exceeds gate value 1180 for chrome browserify home p95 firstPaint Benchmark value 240 exceeds gate value 18 for chrome browserify home p95 backgroundConnect Benchmark value 9 exceeds gate value 1.2 for chrome browserify home p95 initialActions Benchmark value 1010 exceeds gate value 940 for chrome browserify home p95 loadScripts Benchmark value 2381 exceeds gate value 2192 for chrome webpack home mean uiStartup Benchmark value 1878 exceeds gate value 1711 for chrome webpack home mean load Benchmark value 1868 exceeds gate value 1704 for chrome webpack home mean domContentLoaded Benchmark value 42 exceeds gate value 40 for chrome webpack home mean backgroundConnect Benchmark value 13 exceeds gate value 7 for chrome webpack home mean initialActions Benchmark value 1863 exceeds gate value 1699 for chrome webpack home mean loadScripts Benchmark value 2593 exceeds gate value 2454 for chrome webpack home p95 uiStartup Benchmark value 2162 exceeds gate value 2030 for chrome webpack home p95 load Benchmark value 2158 exceeds gate value 2005 for chrome webpack home p95 domContentLoaded Benchmark value 58 exceeds gate value 57 for chrome webpack home p95 domInteractive Benchmark value 239 exceeds gate value 90 for chrome webpack home p95 backgroundConnect Benchmark value 42 exceeds gate value 7 for chrome webpack home p95 initialActions Benchmark value 2156 exceeds gate value 1970 for chrome webpack home p95 loadScripts Benchmark value 1539 exceeds gate value 1405 for firefox browserify home mean uiStartup Benchmark value 1320 exceeds gate value 1245 for firefox browserify home mean load Benchmark value 1319 exceeds gate value 1239 for firefox browserify home mean domContentLoaded Benchmark value 29 exceeds gate value 25 for firefox browserify home mean backgroundConnect Benchmark value 29 exceeds gate value 25 for firefox browserify home mean firstReactRender Benchmark value 15 exceeds gate value 11 for firefox browserify home mean getState Benchmark value 4 exceeds gate value 1 for firefox browserify home mean initialActions Benchmark value 1294 exceeds gate value 1230 for firefox browserify home mean loadScripts Benchmark value 14 exceeds gate value 9 for firefox browserify home mean setupStore Benchmark value 1819 exceeds gate value 1660 for firefox browserify home p95 uiStartup Benchmark value 1519 exceeds gate value 1495 for firefox browserify home p95 load Benchmark value 1519 exceeds gate value 1495 for firefox browserify home p95 domContentLoaded Benchmark value 300 exceeds gate value 195 for firefox browserify home p95 domInteractive Benchmark value 70 exceeds gate value 24 for firefox browserify home p95 getState Benchmark value 15 exceeds gate value 2 for firefox browserify home p95 initialActions Benchmark value 1483 exceeds gate value 1475 for firefox browserify home p95 loadScripts Benchmark value 46 exceeds gate value 27 for firefox browserify home p95 setupStore Benchmark value 1835 exceeds gate value 1615 for firefox webpack home mean uiStartup Benchmark value 1550 exceeds gate value 1380 for firefox webpack home mean load Benchmark value 1550 exceeds gate value 1380 for firefox webpack home mean domContentLoaded Benchmark value 101 exceeds gate value 100 for firefox webpack home mean domInteractive Benchmark value 35 exceeds gate value 26 for firefox webpack home mean backgroundConnect Benchmark value 52 exceeds gate value 38 for firefox webpack home mean firstReactRender Benchmark value 12 exceeds gate value 1 for firefox webpack home mean initialActions Benchmark value 1523 exceeds gate value 1360 for firefox webpack home mean loadScripts Benchmark value 19 exceeds gate value 13 for firefox webpack home mean setupStore Benchmark value 2184 exceeds gate value 1935 for firefox webpack home p95 uiStartup Benchmark value 1886 exceeds gate value 1660 for firefox webpack home p95 load Benchmark value 1886 exceeds gate value 1660 for firefox webpack home p95 domContentLoaded Benchmark value 295 exceeds gate value 156 for firefox webpack home p95 domInteractive Benchmark value 81 exceeds gate value 49 for firefox webpack home p95 backgroundConnect Benchmark value 62 exceeds gate value 50 for firefox webpack home p95 firstReactRender Benchmark value 28 exceeds gate value 2 for firefox webpack home p95 initialActions Benchmark value 1848 exceeds gate value 1630 for firefox webpack home p95 loadScripts Benchmark value 65 exceeds gate value 28 for firefox webpack home p95 setupStore Sum of mean exceeds: 2332ms | Sum of p95 exceeds: 2841.8ms Sum of all benchmark exceeds: 5173.8ms Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
metamaskbot
added
the
release-13.1.0
gauthierpetetin
added
release-13.0.0
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR enables
SEEDLESS_ONBOARDINGfeature by settingSEEDLESS_ONBOARDING_ENABLEDto'true'.Changelog
CHANGELOG entry: Enabled seedless onboarding
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist