Skip to content

fix: optimize unlock performance cp-13.0.0 #34436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lwin-kyaw merged 4 commits into from
Jul 21, 2025
Merged

fix: optimize unlock performance cp-13.0.0 #34436

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4c246b0
fix: removed passwordOutdated check on wallet lock
lwin-kyaw Jul 21, 2025
32aee8a
feat: check password outdated on unlock page load
lwin-kyaw Jul 21, 2025
5d4dcbd
fix: fixed unit tests
lwin-kyaw Jul 21, 2025
4caa0fb
fix: handle checkIsSeedlessPasswordOutdated error in unlock page
lwin-kyaw Jul 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: fixed unit tests
  • Loading branch information
@lwin-kyaw
lwin-kyaw committed Jul 21, 2025
commit 5d4dcbd79e32d80cc58cd20b52bef36758f2440a
4 changes: 3 additions & 1 deletion app/scripts/metamask-controller.actions.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -443,13 +443,14 @@ describe('MetaMaskController', function () {
FirstTimeFlowType.create,
);
const result = await metamaskController.checkIsSeedlessPasswordOutdated();
expect(result).toBeUndefined();
expect(result).toBeFalsy();
});

it('should return false if firstTimeFlowType is seedless and password is not outdated', async function () {
metamaskController.onboardingController.setFirstTimeFlowType(
FirstTimeFlowType.socialCreate,
);
metamaskController.onboardingController.completeOnboarding();
jest
.spyOn(
metamaskController.seedlessOnboardingController,
Expand All @@ -467,6 +468,7 @@ describe('MetaMaskController', function () {
metamaskController.onboardingController.setFirstTimeFlowType(
FirstTimeFlowType.socialCreate,
);
metamaskController.onboardingController.completeOnboarding();
jest
.spyOn(
metamaskController.seedlessOnboardingController,
Expand Down
Loading