fix: updated reset wallet content for social account cp-13.0.0 #34466
+120
−41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Collaborator
|
❌ test-e2e-chrome-api-specs failed. View the html report here. |
Collaborator
Builds ready [13c8d14]
UI Startup Metrics (1343 ± 104 ms)
Benchmark value 1143 exceeds gate value 1070 for chrome browserify home mean load Benchmark value 1132 exceeds gate value 1061 for chrome browserify home mean domContentLoaded Benchmark value 228 exceeds gate value 10 for chrome browserify home mean backgroundConnect Benchmark value 24 exceeds gate value 23 for chrome browserify home mean firstReactRender Benchmark value 4 exceeds gate value 1 for chrome browserify home mean initialActions Benchmark value 915 exceeds gate value 830 for chrome browserify home mean loadScripts Benchmark value 1512 exceeds gate value 1365 for chrome browserify home p95 uiStartup Benchmark value 1307 exceeds gate value 1190 for chrome browserify home p95 load Benchmark value 1289 exceeds gate value 1180 for chrome browserify home p95 domContentLoaded Benchmark value 46 exceeds gate value 41 for chrome browserify home p95 domInteractive Benchmark value 1288 exceeds gate value 1180 for chrome browserify home p95 firstPaint Benchmark value 255 exceeds gate value 18 for chrome browserify home p95 backgroundConnect Benchmark value 13 exceeds gate value 1.2 for chrome browserify home p95 initialActions Benchmark value 1066 exceeds gate value 940 for chrome browserify home p95 loadScripts Benchmark value 2417 exceeds gate value 2192 for chrome webpack home mean uiStartup Benchmark value 1916 exceeds gate value 1711 for chrome webpack home mean load Benchmark value 1906 exceeds gate value 1704 for chrome webpack home mean domContentLoaded Benchmark value 44 exceeds gate value 40 for chrome webpack home mean backgroundConnect Benchmark value 13 exceeds gate value 7 for chrome webpack home mean initialActions Benchmark value 1900 exceeds gate value 1699 for chrome webpack home mean loadScripts Benchmark value 2637 exceeds gate value 2454 for chrome webpack home p95 uiStartup Benchmark value 2167 exceeds gate value 2030 for chrome webpack home p95 load Benchmark value 2163 exceeds gate value 2005 for chrome webpack home p95 domContentLoaded Benchmark value 65 exceeds gate value 57 for chrome webpack home p95 domInteractive Benchmark value 255 exceeds gate value 90 for chrome webpack home p95 backgroundConnect Benchmark value 33 exceeds gate value 7 for chrome webpack home p95 initialActions Benchmark value 2161 exceeds gate value 1970 for chrome webpack home p95 loadScripts Benchmark value 184 exceeds gate value 65 for chrome webpack home p95 setupStore Benchmark value 1466 exceeds gate value 1405 for firefox browserify home mean uiStartup Benchmark value 1267 exceeds gate value 1245 for firefox browserify home mean load Benchmark value 1266 exceeds gate value 1239 for firefox browserify home mean domContentLoaded Benchmark value 120 exceeds gate value 110 for firefox browserify home mean domInteractive Benchmark value 26 exceeds gate value 25 for firefox browserify home mean backgroundConnect Benchmark value 28 exceeds gate value 25 for firefox browserify home mean firstReactRender Benchmark value 5 exceeds gate value 1 for firefox browserify home mean initialActions Benchmark value 1245 exceeds gate value 1230 for firefox browserify home mean loadScripts Benchmark value 13 exceeds gate value 9 for firefox browserify home mean setupStore Benchmark value 1741 exceeds gate value 1660 for firefox browserify home p95 uiStartup Benchmark value 329 exceeds gate value 195 for firefox browserify home p95 domInteractive Benchmark value 38 exceeds gate value 24 for firefox browserify home p95 getState Benchmark value 18 exceeds gate value 2 for firefox browserify home p95 initialActions Benchmark value 51 exceeds gate value 27 for firefox browserify home p95 setupStore Benchmark value 1713 exceeds gate value 1615 for firefox webpack home mean uiStartup Benchmark value 1454 exceeds gate value 1380 for firefox webpack home mean load Benchmark value 1454 exceeds gate value 1380 for firefox webpack home mean domContentLoaded Benchmark value 101 exceeds gate value 100 for firefox webpack home mean domInteractive Benchmark value 30 exceeds gate value 26 for firefox webpack home mean backgroundConnect Benchmark value 51 exceeds gate value 38 for firefox webpack home mean firstReactRender Benchmark value 7 exceeds gate value 1 for firefox webpack home mean initialActions Benchmark value 1430 exceeds gate value 1360 for firefox webpack home mean loadScripts Benchmark value 15 exceeds gate value 13 for firefox webpack home mean setupStore Benchmark value 2070 exceeds gate value 1935 for firefox webpack home p95 uiStartup Benchmark value 1768 exceeds gate value 1660 for firefox webpack home p95 load Benchmark value 1768 exceeds gate value 1660 for firefox webpack home p95 domContentLoaded Benchmark value 288 exceeds gate value 156 for firefox webpack home p95 domInteractive Benchmark value 71 exceeds gate value 49 for firefox webpack home p95 backgroundConnect Benchmark value 60 exceeds gate value 50 for firefox webpack home p95 firstReactRender Benchmark value 21 exceeds gate value 2 for firefox webpack home p95 initialActions Benchmark value 1732 exceeds gate value 1630 for firefox webpack home p95 loadScripts Benchmark value 32 exceeds gate value 28 for firefox webpack home p95 setupStore Sum of mean exceeds: 1892ms | Sum of p95 exceeds: 2756.8ms Sum of all benchmark exceeds: 4648.8ms Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
lionellbriones
force-pushed
the
fix/reset-wallet-copywriting
branch
from
13c8d14 to
b597848
Compare
Collaborator
Builds ready [02fba3e]
UI Startup Metrics (1257 ± 52 ms)
Benchmark value 1258 exceeds gate value 1234 for chrome browserify home mean uiStartup Benchmark value 1080 exceeds gate value 1070 for chrome browserify home mean load Benchmark value 1073 exceeds gate value 1061 for chrome browserify home mean domContentLoaded Benchmark value 211 exceeds gate value 10 for chrome browserify home mean backgroundConnect Benchmark value 5 exceeds gate value 1 for chrome browserify home mean initialActions Benchmark value 868 exceeds gate value 830 for chrome browserify home mean loadScripts Benchmark value 227 exceeds gate value 18 for chrome browserify home p95 backgroundConnect Benchmark value 18 exceeds gate value 1.2 for chrome browserify home p95 initialActions Benchmark value 2940 exceeds gate value 2192 for chrome webpack home mean uiStartup Benchmark value 2396 exceeds gate value 1711 for chrome webpack home mean load Benchmark value 2387 exceeds gate value 1704 for chrome webpack home mean domContentLoaded Benchmark value 26 exceeds gate value 21 for chrome webpack home mean domInteractive Benchmark value 262 exceeds gate value 199 for chrome webpack home mean firstPaint Benchmark value 12 exceeds gate value 7 for chrome webpack home mean initialActions Benchmark value 2382 exceeds gate value 1699 for chrome webpack home mean loadScripts Benchmark value 3327 exceeds gate value 2454 for chrome webpack home p95 uiStartup Benchmark value 2784 exceeds gate value 2030 for chrome webpack home p95 load Benchmark value 2780 exceeds gate value 2005 for chrome webpack home p95 domContentLoaded Benchmark value 67 exceeds gate value 57 for chrome webpack home p95 domInteractive Benchmark value 417 exceeds gate value 334 for chrome webpack home p95 firstPaint Benchmark value 44 exceeds gate value 7 for chrome webpack home p95 initialActions Benchmark value 2777 exceeds gate value 1970 for chrome webpack home p95 loadScripts Benchmark value 1465 exceeds gate value 1405 for firefox browserify home mean uiStartup Benchmark value 1261 exceeds gate value 1245 for firefox browserify home mean load Benchmark value 1260 exceeds gate value 1239 for firefox browserify home mean domContentLoaded Benchmark value 29 exceeds gate value 25 for firefox browserify home mean backgroundConnect Benchmark value 27 exceeds gate value 25 for firefox browserify home mean firstReactRender Benchmark value 14 exceeds gate value 11 for firefox browserify home mean getState Benchmark value 6 exceeds gate value 1 for firefox browserify home mean initialActions Benchmark value 1237 exceeds gate value 1230 for firefox browserify home mean loadScripts Benchmark value 11 exceeds gate value 9 for firefox browserify home mean setupStore Benchmark value 1831 exceeds gate value 1660 for firefox browserify home p95 uiStartup Benchmark value 249 exceeds gate value 195 for firefox browserify home p95 domInteractive Benchmark value 32 exceeds gate value 24 for firefox browserify home p95 getState Benchmark value 14 exceeds gate value 2 for firefox browserify home p95 initialActions Benchmark value 53 exceeds gate value 27 for firefox browserify home p95 setupStore Benchmark value 1741 exceeds gate value 1615 for firefox webpack home mean uiStartup Benchmark value 1480 exceeds gate value 1380 for firefox webpack home mean load Benchmark value 1479 exceeds gate value 1380 for firefox webpack home mean domContentLoaded Benchmark value 101 exceeds gate value 100 for firefox webpack home mean domInteractive Benchmark value 30 exceeds gate value 26 for firefox webpack home mean backgroundConnect Benchmark value 52 exceeds gate value 38 for firefox webpack home mean firstReactRender Benchmark value 11 exceeds gate value 1 for firefox webpack home mean initialActions Benchmark value 1457 exceeds gate value 1360 for firefox webpack home mean loadScripts Benchmark value 14 exceeds gate value 13 for firefox webpack home mean setupStore Benchmark value 2070 exceeds gate value 1935 for firefox webpack home p95 uiStartup Benchmark value 1733 exceeds gate value 1660 for firefox webpack home p95 load Benchmark value 1732 exceeds gate value 1660 for firefox webpack home p95 domContentLoaded Benchmark value 276 exceeds gate value 156 for firefox webpack home p95 domInteractive Benchmark value 77 exceeds gate value 49 for firefox webpack home p95 backgroundConnect Benchmark value 59 exceeds gate value 50 for firefox webpack home p95 firstReactRender Benchmark value 24 exceeds gate value 2 for firefox webpack home p95 initialActions Benchmark value 1699 exceeds gate value 1630 for firefox webpack home p95 loadScripts Sum of mean exceeds: 3733ms | Sum of p95 exceeds: 4363.8ms Sum of all benchmark exceeds: 8096.8ms Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Contributor
|
lgtm |
chaitanyapotti
changed the title
lwin-kyaw
approved these changes
Jul 22, 2025
chaitanyapotti
approved these changes
Jul 22, 2025
metamaskbot
added
the
release-13.1.0
gauthierpetetin
added
release-13.0.0
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Current
Reset wallet pagecontent is only applicable for SRP account but not for Seedless accounts. This PR changes the content of the page when user is logged-in with a social account.Figma: https://www.figma.com/design/pViOUcmjwhEzFsdrwknpNc/Onboarding-redesign--Main-?node-id=8481-95908&t=lrllG076uuLTwVXC-4
Changelog
CHANGELOG entry: Update reset wallet content for seedless accounts
Related issues
Fixes:
Manual testing steps
Reset walletScreenshots/Recordings
Before
This content is showing for both SRP and Seedless accounts
After
This will show for Seedless account and the Before will show for SRP account
Pre-merge author checklist
Pre-merge reviewer checklist