fix: cp-12.22.3 Stop polling multichain rates while idle #34474

Gudahtt · 2025-07-21T17:37:53Z

Description

The MultichainRatesController now stops polling when the UI is closed, and starts up again when the first UI instance is opened (conditionally, if a non-EVM account is selected).

The method for starting polling is slightly different from other polling controllers because this controller doesn't use the same polling mixin as elsewhere. This controller is deprecated and soon to be removed.

Changelog

CHANGELOG entry: Prevent frequent writes while the wallet UI is closed

Related issues

Relates to #33879

Manual testing steps

Proceed through onboarding
Close all UI instances
Monitor the background console, putting a logpoint here conditional on this.persist being true:

metamask-extension/app/scripts/lib/ComposableObservableStore.js

Line 111 in f2104e9

this.updateState({ [controllerKey]: newState });

Screenshots/Recordings

N/A

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

sentry · 2025-07-21T17:38:22Z

🔍 Existing Issues For Review

Your pull request is modifying functions with the following pre-existing issues:

📄 File: app/scripts/background.js

Function	Unhandled Issue
`setupController`	TypeError: Cannot read properties of undefined (reading 'getAll') /sc... `Event Count:` 1 `Affected Users:` 0

_{Did you find this useful? React with a 👍 or 👎}

metamaskbot · 2025-07-21T18:12:48Z

Builds ready [1d6b5a0]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- content-script: 0
- offscreen: 0

UI Startup Metrics (1242 ± 51 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1242	1133	1384	51	1270	1329
			load	1064	948	1211	47	1103	1136
			domContentLoaded	1058	943	1203	47	1097	1124
			domInteractive	18	13	59	8	16	39
			firstPaint	716	82	1211	430	1081	1130
			backgroundConnect	210	198	238	7	212	231
			firstReactRender	20	13	45	6	21	38
			getState	11	3	97	12	12	28
			initialActions	3	0	32	6	2	16
			loadScripts	854	740	985	46	892	924
			setupStore	7	3	93	9	7	13
	Webpack	Home	uiStartup	2377	1941	2841	130	2459	2549
			load	1889	1345	2335	150	1967	2125
			domContentLoaded	1882	1338	2325	151	1963	2121
			domInteractive	19	12	88	16	15	71
			firstPaint	158	61	603	80	173	302
			backgroundConnect	29	10	287	36	30	40
			firstReactRender	182	89	455	85	228	346
			getState	13	4	290	28	13	19
			initialActions	10	2	205	25	7	28
			loadScripts	1878	1335	2312	151	1961	2119
			setupStore	17	6	195	26	16	31
Firefox	Browserify	Home	uiStartup	1507	1284	2401	180	1581	1790
			load	1291	1102	2166	131	1335	1488
			domContentLoaded	1291	1102	2166	131	1335	1487
			domInteractive	105	37	380	59	108	295
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	30	14	192	27	28	71
			firstReactRender	28	21	66	8	29	50
			getState	8	3	47	7	7	24
			initialActions	3	1	31	5	2	13
			loadScripts	1266	1089	2136	127	1308	1462
			setupStore	17	3	186	31	10	90
	Webpack	Home	uiStartup	1716	1478	2417	188	1785	2119
			load	1462	1271	2091	147	1533	1772
			domContentLoaded	1461	1271	2091	147	1533	1772
			domInteractive	101	36	401	67	93	277
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	28	16	123	17	26	70
			firstReactRender	51	39	69	6	54	61
			getState	11	3	227	25	12	24
			initialActions	6	1	84	10	6	22
			loadScripts	1439	1252	2067	143	1515	1752
			setupStore	12	5	202	23	12	24

Benchmark value 1242 exceeds gate value 1234 for chrome browserify home mean uiStartup
Benchmark value 211 exceeds gate value 10 for chrome browserify home mean backgroundConnect
Benchmark value 4 exceeds gate value 1 for chrome browserify home mean initialActions
Benchmark value 854 exceeds gate value 830 for chrome browserify home mean loadScripts
Benchmark value 231 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 16 exceeds gate value 1.2 for chrome browserify home p95 initialActions
Benchmark value 2378 exceeds gate value 2192 for chrome webpack home mean uiStartup
Benchmark value 1889 exceeds gate value 1711 for chrome webpack home mean load
Benchmark value 1883 exceeds gate value 1704 for chrome webpack home mean domContentLoaded
Benchmark value 11 exceeds gate value 7 for chrome webpack home mean initialActions
Benchmark value 1878 exceeds gate value 1699 for chrome webpack home mean loadScripts
Benchmark value 2550 exceeds gate value 2454 for chrome webpack home p95 uiStartup
Benchmark value 2125 exceeds gate value 2030 for chrome webpack home p95 load
Benchmark value 2121 exceeds gate value 2005 for chrome webpack home p95 domContentLoaded
Benchmark value 71 exceeds gate value 57 for chrome webpack home p95 domInteractive
Benchmark value 28 exceeds gate value 7 for chrome webpack home p95 initialActions
Benchmark value 2119 exceeds gate value 1970 for chrome webpack home p95 loadScripts
Benchmark value 1507 exceeds gate value 1405 for firefox browserify home mean uiStartup
Benchmark value 1292 exceeds gate value 1245 for firefox browserify home mean load
Benchmark value 1292 exceeds gate value 1239 for firefox browserify home mean domContentLoaded
Benchmark value 30 exceeds gate value 25 for firefox browserify home mean backgroundConnect
Benchmark value 28 exceeds gate value 25 for firefox browserify home mean firstReactRender
Benchmark value 4 exceeds gate value 1 for firefox browserify home mean initialActions
Benchmark value 1266 exceeds gate value 1230 for firefox browserify home mean loadScripts
Benchmark value 17 exceeds gate value 9 for firefox browserify home mean setupStore
Benchmark value 1790 exceeds gate value 1660 for firefox browserify home p95 uiStartup
Benchmark value 295 exceeds gate value 195 for firefox browserify home p95 domInteractive
Benchmark value 71 exceeds gate value 70 for firefox browserify home p95 backgroundConnect
Benchmark value 13 exceeds gate value 2 for firefox browserify home p95 initialActions
Benchmark value 90 exceeds gate value 27 for firefox browserify home p95 setupStore
Benchmark value 1716 exceeds gate value 1615 for firefox webpack home mean uiStartup
Benchmark value 1462 exceeds gate value 1380 for firefox webpack home mean load
Benchmark value 1462 exceeds gate value 1380 for firefox webpack home mean domContentLoaded
Benchmark value 101 exceeds gate value 100 for firefox webpack home mean domInteractive
Benchmark value 28 exceeds gate value 26 for firefox webpack home mean backgroundConnect
Benchmark value 51 exceeds gate value 38 for firefox webpack home mean firstReactRender
Benchmark value 6 exceeds gate value 1 for firefox webpack home mean initialActions
Benchmark value 1440 exceeds gate value 1360 for firefox webpack home mean loadScripts
Benchmark value 2119 exceeds gate value 1935 for firefox webpack home p95 uiStartup
Benchmark value 1772 exceeds gate value 1660 for firefox webpack home p95 load
Benchmark value 1772 exceeds gate value 1660 for firefox webpack home p95 domContentLoaded
Benchmark value 277 exceeds gate value 156 for firefox webpack home p95 domInteractive
Benchmark value 70 exceeds gate value 49 for firefox webpack home p95 backgroundConnect
Benchmark value 61 exceeds gate value 50 for firefox webpack home p95 firstReactRender
Benchmark value 22 exceeds gate value 2 for firefox webpack home p95 initialActions
Benchmark value 1752 exceeds gate value 1630 for firefox webpack home p95 loadScripts
Sum of mean exceeds: 1585ms | Sum of p95 exceeds: 1726.8ms
Sum of all benchmark exceeds: 3311.8ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 327 Bytes (0.01%)
ui: 0 Bytes (0%)
common: 15 Bytes (0%)

metamaskbot · 2025-07-21T20:55:28Z

Builds ready [087e861]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- content-script: 0
- offscreen: 0

UI Startup Metrics (1297 ± 71 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1297	1160	1569	71	1328	1452
			load	1107	1003	1357	63	1143	1242
			domContentLoaded	1099	995	1351	64	1137	1232
			domInteractive	18	14	43	7	17	39
			firstPaint	709	78	1258	448	1123	1179
			backgroundConnect	216	203	244	8	219	234
			firstReactRender	24	16	193	19	25	44
			getState	10	3	44	7	12	22
			initialActions	3	0	33	5	3	16
			loadScripts	890	785	1146	63	929	1016
			setupStore	7	4	19	3	8	12
	Webpack	Home	uiStartup	2342	1781	2925	176	2451	2543
			load	1849	1339	2344	184	1949	2137
			domContentLoaded	1840	1333	2324	184	1943	2131
			domInteractive	23	12	232	35	15	61
			firstPaint	165	61	425	79	206	307
			backgroundConnect	44	10	294	66	30	271
			firstReactRender	166	87	397	77	197	344
			getState	16	3	436	48	13	18
			initialActions	9	2	179	23	7	20
			loadScripts	1836	1329	2311	183	1939	2122
			setupStore	20	6	255	41	15	30
Firefox	Browserify	Home	uiStartup	1600	1414	2235	162	1665	1928
			load	1366	1197	1732	107	1419	1573
			domContentLoaded	1366	1197	1732	107	1418	1573
			domInteractive	125	36	576	98	117	451
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	30	16	202	20	31	51
			firstReactRender	30	23	71	10	30	62
			getState	20	3	215	45	10	174
			initialActions	5	1	91	11	4	26
			loadScripts	1341	1179	1709	105	1388	1543
			setupStore	11	4	194	21	8	34
	Webpack	Home	uiStartup	1747	1534	3879	262	1756	2103
			load	1461	1299	1914	120	1489	1748
			domContentLoaded	1461	1299	1914	120	1488	1748
			domInteractive	98	35	382	64	93	272
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	43	19	1365	133	34	64
			firstReactRender	52	42	72	6	56	63
			getState	11	3	43	10	16	36
			initialActions	10	1	314	32	8	29
			loadScripts	1437	1280	1880	118	1469	1707
			setupStore	18	5	246	39	15	75

Benchmark value 1297 exceeds gate value 1234 for chrome browserify home mean uiStartup
Benchmark value 1107 exceeds gate value 1070 for chrome browserify home mean load
Benchmark value 1100 exceeds gate value 1061 for chrome browserify home mean domContentLoaded
Benchmark value 217 exceeds gate value 10 for chrome browserify home mean backgroundConnect
Benchmark value 25 exceeds gate value 23 for chrome browserify home mean firstReactRender
Benchmark value 4 exceeds gate value 1 for chrome browserify home mean initialActions
Benchmark value 890 exceeds gate value 830 for chrome browserify home mean loadScripts
Benchmark value 1452 exceeds gate value 1365 for chrome browserify home p95 uiStartup
Benchmark value 1242 exceeds gate value 1190 for chrome browserify home p95 load
Benchmark value 1232 exceeds gate value 1180 for chrome browserify home p95 domContentLoaded
Benchmark value 234 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 16 exceeds gate value 1.2 for chrome browserify home p95 initialActions
Benchmark value 1016 exceeds gate value 940 for chrome browserify home p95 loadScripts
Benchmark value 2342 exceeds gate value 2192 for chrome webpack home mean uiStartup
Benchmark value 1849 exceeds gate value 1711 for chrome webpack home mean load
Benchmark value 1841 exceeds gate value 1704 for chrome webpack home mean domContentLoaded
Benchmark value 23 exceeds gate value 21 for chrome webpack home mean domInteractive
Benchmark value 44 exceeds gate value 40 for chrome webpack home mean backgroundConnect
Benchmark value 10 exceeds gate value 7 for chrome webpack home mean initialActions
Benchmark value 1837 exceeds gate value 1699 for chrome webpack home mean loadScripts
Benchmark value 2544 exceeds gate value 2454 for chrome webpack home p95 uiStartup
Benchmark value 2137 exceeds gate value 2030 for chrome webpack home p95 load
Benchmark value 2132 exceeds gate value 2005 for chrome webpack home p95 domContentLoaded
Benchmark value 62 exceeds gate value 57 for chrome webpack home p95 domInteractive
Benchmark value 271 exceeds gate value 90 for chrome webpack home p95 backgroundConnect
Benchmark value 20 exceeds gate value 7 for chrome webpack home p95 initialActions
Benchmark value 2122 exceeds gate value 1970 for chrome webpack home p95 loadScripts
Benchmark value 1600 exceeds gate value 1405 for firefox browserify home mean uiStartup
Benchmark value 1367 exceeds gate value 1245 for firefox browserify home mean load
Benchmark value 1367 exceeds gate value 1239 for firefox browserify home mean domContentLoaded
Benchmark value 126 exceeds gate value 110 for firefox browserify home mean domInteractive
Benchmark value 31 exceeds gate value 25 for firefox browserify home mean backgroundConnect
Benchmark value 31 exceeds gate value 25 for firefox browserify home mean firstReactRender
Benchmark value 21 exceeds gate value 11 for firefox browserify home mean getState
Benchmark value 6 exceeds gate value 1 for firefox browserify home mean initialActions
Benchmark value 1341 exceeds gate value 1230 for firefox browserify home mean loadScripts
Benchmark value 12 exceeds gate value 9 for firefox browserify home mean setupStore
Benchmark value 1928 exceeds gate value 1660 for firefox browserify home p95 uiStartup
Benchmark value 1573 exceeds gate value 1495 for firefox browserify home p95 load
Benchmark value 1573 exceeds gate value 1495 for firefox browserify home p95 domContentLoaded
Benchmark value 451 exceeds gate value 195 for firefox browserify home p95 domInteractive
Benchmark value 62 exceeds gate value 55 for firefox browserify home p95 firstReactRender
Benchmark value 174 exceeds gate value 24 for firefox browserify home p95 getState
Benchmark value 26 exceeds gate value 2 for firefox browserify home p95 initialActions
Benchmark value 1543 exceeds gate value 1475 for firefox browserify home p95 loadScripts
Benchmark value 34 exceeds gate value 27 for firefox browserify home p95 setupStore
Benchmark value 1747 exceeds gate value 1615 for firefox webpack home mean uiStartup
Benchmark value 1461 exceeds gate value 1380 for firefox webpack home mean load
Benchmark value 1461 exceeds gate value 1380 for firefox webpack home mean domContentLoaded
Benchmark value 43 exceeds gate value 26 for firefox webpack home mean backgroundConnect
Benchmark value 52 exceeds gate value 38 for firefox webpack home mean firstReactRender
Benchmark value 10 exceeds gate value 1 for firefox webpack home mean initialActions
Benchmark value 1438 exceeds gate value 1360 for firefox webpack home mean loadScripts
Benchmark value 19 exceeds gate value 13 for firefox webpack home mean setupStore
Benchmark value 2103 exceeds gate value 1935 for firefox webpack home p95 uiStartup
Benchmark value 1748 exceeds gate value 1660 for firefox webpack home p95 load
Benchmark value 1748 exceeds gate value 1660 for firefox webpack home p95 domContentLoaded
Benchmark value 272 exceeds gate value 156 for firefox webpack home p95 domInteractive
Benchmark value 64 exceeds gate value 49 for firefox webpack home p95 backgroundConnect
Benchmark value 63 exceeds gate value 50 for firefox webpack home p95 firstReactRender
Benchmark value 36 exceeds gate value 32 for firefox webpack home p95 getState
Benchmark value 29 exceeds gate value 2 for firefox webpack home p95 initialActions
Benchmark value 1707 exceeds gate value 1630 for firefox webpack home p95 loadScripts
Benchmark value 75 exceeds gate value 28 for firefox webpack home p95 setupStore
Sum of mean exceeds: 2003ms | Sum of p95 exceeds: 2751.8ms
Sum of all benchmark exceeds: 4754.8ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 114 Bytes (0%)
ui: 0 Bytes (0%)
common: 15 Bytes (0%)

The `MultichainRatesController` now stops polling when the UI is closed, and starts up again when the first UI instance is opened (conditionally, if a non-EVM account is selected). The method for starting polling is slightly different from other polling controllers because this controller doesn't use the same polling mixin as elsewhere. This controller is deprecated and soon to be removed. Relates to #33879

metamaskbot · 2025-07-21T23:28:54Z

Builds ready [10132ba]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- content-script: 0
- offscreen: 0

UI Startup Metrics (1275 ± 72 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1275	1130	1607	72	1313	1390
			load	1096	971	1485	72	1132	1200
			domContentLoaded	1089	966	1474	72	1126	1195
			domInteractive	18	13	48	8	17	43
			firstPaint	630	78	1480	444	1097	1176
			backgroundConnect	211	199	239	7	213	227
			firstReactRender	20	14	50	5	21	31
			getState	12	4	92	14	11	37
			initialActions	2	0	22	3	2	9
			loadScripts	885	769	1271	72	919	991
			setupStore	7	4	22	3	7	12
	Webpack	Home	uiStartup	2434	1983	2922	155	2543	2652
			load	1934	1482	2334	179	2054	2197
			domContentLoaded	1925	1475	2322	179	2048	2191
			domInteractive	25	13	225	38	16	76
			firstPaint	177	62	801	102	195	348
			backgroundConnect	36	10	296	48	35	56
			firstReactRender	168	91	379	74	207	324
			getState	14	3	238	24	16	25
			initialActions	11	2	228	24	9	34
			loadScripts	1920	1471	2309	179	2046	2188
			setupStore	22	7	231	39	18	40
Firefox	Browserify	Home	uiStartup	1477	1279	1985	127	1517	1706
			load	1284	1120	1695	91	1332	1465
			domContentLoaded	1284	1120	1695	91	1332	1464
			domInteractive	119	36	459	86	109	320
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	27	14	120	14	28	47
			firstReactRender	28	21	63	9	29	56
			getState	11	2	167	24	8	42
			initialActions	3	0	55	6	2	14
			loadScripts	1263	1101	1676	89	1313	1439
			setupStore	11	3	202	23	7	36
	Webpack	Home	uiStartup	1798	1559	2578	199	1891	2182
			load	1516	1311	1946	149	1620	1835
			domContentLoaded	1516	1310	1946	149	1619	1835
			domInteractive	106	34	393	73	95	316
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	32	16	116	17	37	73
			firstReactRender	52	43	63	5	55	60
			getState	12	3	255	26	14	33
			initialActions	8	1	205	22	4	22
			loadScripts	1492	1291	1887	146	1595	1809
			setupStore	20	5	256	46	12	110

Benchmark value 1276 exceeds gate value 1234 for chrome browserify home mean uiStartup
Benchmark value 1097 exceeds gate value 1070 for chrome browserify home mean load
Benchmark value 1090 exceeds gate value 1061 for chrome browserify home mean domContentLoaded
Benchmark value 211 exceeds gate value 10 for chrome browserify home mean backgroundConnect
Benchmark value 3 exceeds gate value 1 for chrome browserify home mean initialActions
Benchmark value 885 exceeds gate value 830 for chrome browserify home mean loadScripts
Benchmark value 1390 exceeds gate value 1365 for chrome browserify home p95 uiStartup
Benchmark value 1200 exceeds gate value 1190 for chrome browserify home p95 load
Benchmark value 1195 exceeds gate value 1180 for chrome browserify home p95 domContentLoaded
Benchmark value 44 exceeds gate value 41 for chrome browserify home p95 domInteractive
Benchmark value 228 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 37 exceeds gate value 33 for chrome browserify home p95 getState
Benchmark value 9 exceeds gate value 1.2 for chrome browserify home p95 initialActions
Benchmark value 992 exceeds gate value 940 for chrome browserify home p95 loadScripts
Benchmark value 2434 exceeds gate value 2192 for chrome webpack home mean uiStartup
Benchmark value 1935 exceeds gate value 1711 for chrome webpack home mean load
Benchmark value 1925 exceeds gate value 1704 for chrome webpack home mean domContentLoaded
Benchmark value 26 exceeds gate value 21 for chrome webpack home mean domInteractive
Benchmark value 11 exceeds gate value 7 for chrome webpack home mean initialActions
Benchmark value 1920 exceeds gate value 1699 for chrome webpack home mean loadScripts
Benchmark value 2653 exceeds gate value 2454 for chrome webpack home p95 uiStartup
Benchmark value 2198 exceeds gate value 2030 for chrome webpack home p95 load
Benchmark value 2191 exceeds gate value 2005 for chrome webpack home p95 domContentLoaded
Benchmark value 76 exceeds gate value 57 for chrome webpack home p95 domInteractive
Benchmark value 349 exceeds gate value 334 for chrome webpack home p95 firstPaint
Benchmark value 34 exceeds gate value 7 for chrome webpack home p95 initialActions
Benchmark value 2189 exceeds gate value 1970 for chrome webpack home p95 loadScripts
Benchmark value 1478 exceeds gate value 1405 for firefox browserify home mean uiStartup
Benchmark value 1285 exceeds gate value 1245 for firefox browserify home mean load
Benchmark value 1285 exceeds gate value 1239 for firefox browserify home mean domContentLoaded
Benchmark value 120 exceeds gate value 110 for firefox browserify home mean domInteractive
Benchmark value 27 exceeds gate value 25 for firefox browserify home mean backgroundConnect
Benchmark value 29 exceeds gate value 25 for firefox browserify home mean firstReactRender
Benchmark value 12 exceeds gate value 11 for firefox browserify home mean getState
Benchmark value 4 exceeds gate value 1 for firefox browserify home mean initialActions
Benchmark value 1263 exceeds gate value 1230 for firefox browserify home mean loadScripts
Benchmark value 11 exceeds gate value 9 for firefox browserify home mean setupStore
Benchmark value 1706 exceeds gate value 1660 for firefox browserify home p95 uiStartup
Benchmark value 320 exceeds gate value 195 for firefox browserify home p95 domInteractive
Benchmark value 56 exceeds gate value 55 for firefox browserify home p95 firstReactRender
Benchmark value 42 exceeds gate value 24 for firefox browserify home p95 getState
Benchmark value 14 exceeds gate value 2 for firefox browserify home p95 initialActions
Benchmark value 36 exceeds gate value 27 for firefox browserify home p95 setupStore
Benchmark value 1798 exceeds gate value 1615 for firefox webpack home mean uiStartup
Benchmark value 1517 exceeds gate value 1380 for firefox webpack home mean load
Benchmark value 1517 exceeds gate value 1380 for firefox webpack home mean domContentLoaded
Benchmark value 106 exceeds gate value 100 for firefox webpack home mean domInteractive
Benchmark value 32 exceeds gate value 26 for firefox webpack home mean backgroundConnect
Benchmark value 52 exceeds gate value 38 for firefox webpack home mean firstReactRender
Benchmark value 8 exceeds gate value 1 for firefox webpack home mean initialActions
Benchmark value 1493 exceeds gate value 1360 for firefox webpack home mean loadScripts
Benchmark value 21 exceeds gate value 13 for firefox webpack home mean setupStore
Benchmark value 2182 exceeds gate value 1935 for firefox webpack home p95 uiStartup
Benchmark value 1835 exceeds gate value 1660 for firefox webpack home p95 load
Benchmark value 1835 exceeds gate value 1660 for firefox webpack home p95 domContentLoaded
Benchmark value 316 exceeds gate value 156 for firefox webpack home p95 domInteractive
Benchmark value 73 exceeds gate value 49 for firefox webpack home p95 backgroundConnect
Benchmark value 60 exceeds gate value 50 for firefox webpack home p95 firstReactRender
Benchmark value 33 exceeds gate value 32 for firefox webpack home p95 getState
Benchmark value 22 exceeds gate value 2 for firefox webpack home p95 initialActions
Benchmark value 1809 exceeds gate value 1630 for firefox webpack home p95 loadScripts
Benchmark value 110 exceeds gate value 28 for firefox webpack home p95 setupStore
Sum of mean exceeds: 2118ms | Sum of p95 exceeds: 2443.8ms
Sum of all benchmark exceeds: 4561.8ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 114 Bytes (0%)
ui: 0 Bytes (0%)
common: 15 Bytes (0%)

metamaskbot added the team-wallet-framework label Jul 21, 2025

Gudahtt force-pushed the stop-polling-multichain-rates-while-idle branch from 08b8a34 to 1d6b5a0 Compare July 21, 2025 17:46

Gudahtt force-pushed the stop-polling-multichain-rates-while-idle branch 2 times, most recently from 99610a1 to 087e861 Compare July 21, 2025 20:29

Gudahtt marked this pull request as ready for review July 21, 2025 22:44

darkwing approved these changes Jul 21, 2025

View reviewed changes

Gudahtt added 2 commits July 21, 2025 20:32

Use activeConnections rather than isClientOpen

10132ba

Gudahtt force-pushed the stop-polling-multichain-rates-while-idle branch from 087e861 to 10132ba Compare July 21, 2025 23:02

Gudahtt changed the title ~~fix: Stop polling multichain rates while idle~~ fix: cp-12.22.3 Stop polling multichain rates while idle Jul 21, 2025

GuillaumeRx approved these changes Jul 22, 2025

View reviewed changes

Gudahtt enabled auto-merge July 22, 2025 11:43

Gudahtt added this pull request to the merge queue Jul 22, 2025

Merged via the queue into main with commit 49d7ef2 Jul 22, 2025
276 of 278 checks passed

Gudahtt deleted the stop-polling-multichain-rates-while-idle branch July 22, 2025 12:18

github-actions bot locked and limited conversation to collaborators Jul 22, 2025

metamaskbot added the release-13.1.0 Issue or pull request that will be included in release 13.1.0 label Jul 22, 2025

gauthierpetetin added release-12.22.3 Issue or pull request that will be included in release 12.22.3 and removed release-13.1.0 Issue or pull request that will be included in release 13.1.0 labels Aug 5, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix: cp-12.22.3 Stop polling multichain rates while idle #34474

fix: cp-12.22.3 Stop polling multichain rates while idle #34474

Uh oh!

Gudahtt commented Jul 21, 2025 •

edited

Loading

Uh oh!

sentry bot commented Jul 21, 2025

Uh oh!

metamaskbot commented Jul 21, 2025

Uh oh!

metamaskbot commented Jul 21, 2025

Uh oh!

metamaskbot commented Jul 21, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

fix: cp-12.22.3 Stop polling multichain rates while idle #34474

fix: cp-12.22.3 Stop polling multichain rates while idle #34474

Uh oh!

Conversation

Gudahtt commented Jul 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Changelog

Related issues

Manual testing steps

Screenshots/Recordings

Pre-merge author checklist

Pre-merge reviewer checklist

Uh oh!

sentry bot commented Jul 21, 2025

🔍 Existing Issues For Review

Uh oh!

metamaskbot commented Jul 21, 2025

Uh oh!

metamaskbot commented Jul 21, 2025

Uh oh!

metamaskbot commented Jul 21, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Gudahtt commented Jul 21, 2025 •

edited

Loading