fix: changes default label of bridge originated txs to swap from send #34476
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Collaborator
✨ Files requiring CODEOWNER review ✨🔄 @MetaMask/swaps-engineers (1 files, +9 -2)
|
Collaborator
Builds ready [d39e9bc]
UI Startup Metrics (1257 ± 59 ms)
Benchmark value 1081 exceeds gate value 1070 for chrome browserify home mean load Benchmark value 1073 exceeds gate value 1061 for chrome browserify home mean domContentLoaded Benchmark value 212 exceeds gate value 10 for chrome browserify home mean backgroundConnect Benchmark value 3 exceeds gate value 1 for chrome browserify home mean initialActions Benchmark value 869 exceeds gate value 830 for chrome browserify home mean loadScripts Benchmark value 230 exceeds gate value 18 for chrome browserify home p95 backgroundConnect Benchmark value 12 exceeds gate value 1.2 for chrome browserify home p95 initialActions Benchmark value 962 exceeds gate value 940 for chrome browserify home p95 loadScripts Benchmark value 2411 exceeds gate value 2192 for chrome webpack home mean uiStartup Benchmark value 1900 exceeds gate value 1711 for chrome webpack home mean load Benchmark value 1892 exceeds gate value 1704 for chrome webpack home mean domContentLoaded Benchmark value 24 exceeds gate value 21 for chrome webpack home mean domInteractive Benchmark value 20 exceeds gate value 7 for chrome webpack home mean initialActions Benchmark value 1885 exceeds gate value 1699 for chrome webpack home mean loadScripts Benchmark value 2627 exceeds gate value 2454 for chrome webpack home p95 uiStartup Benchmark value 2092 exceeds gate value 2030 for chrome webpack home p95 load Benchmark value 2088 exceeds gate value 2005 for chrome webpack home p95 domContentLoaded Benchmark value 68 exceeds gate value 57 for chrome webpack home p95 domInteractive Benchmark value 177 exceeds gate value 7 for chrome webpack home p95 initialActions Benchmark value 2085 exceeds gate value 1970 for chrome webpack home p95 loadScripts Benchmark value 1450 exceeds gate value 1405 for firefox browserify home mean uiStartup Benchmark value 1246 exceeds gate value 1245 for firefox browserify home mean load Benchmark value 1245 exceeds gate value 1239 for firefox browserify home mean domContentLoaded Benchmark value 120 exceeds gate value 110 for firefox browserify home mean domInteractive Benchmark value 26 exceeds gate value 25 for firefox browserify home mean backgroundConnect Benchmark value 29 exceeds gate value 25 for firefox browserify home mean firstReactRender Benchmark value 5 exceeds gate value 1 for firefox browserify home mean initialActions Benchmark value 16 exceeds gate value 9 for firefox browserify home mean setupStore Benchmark value 1754 exceeds gate value 1660 for firefox browserify home p95 uiStartup Benchmark value 352 exceeds gate value 195 for firefox browserify home p95 domInteractive Benchmark value 56 exceeds gate value 55 for firefox browserify home p95 firstReactRender Benchmark value 34 exceeds gate value 24 for firefox browserify home p95 getState Benchmark value 18 exceeds gate value 2 for firefox browserify home p95 initialActions Benchmark value 71 exceeds gate value 27 for firefox browserify home p95 setupStore Benchmark value 1720 exceeds gate value 1615 for firefox webpack home mean uiStartup Benchmark value 1459 exceeds gate value 1380 for firefox webpack home mean load Benchmark value 1459 exceeds gate value 1380 for firefox webpack home mean domContentLoaded Benchmark value 32 exceeds gate value 26 for firefox webpack home mean backgroundConnect Benchmark value 53 exceeds gate value 38 for firefox webpack home mean firstReactRender Benchmark value 10 exceeds gate value 1 for firefox webpack home mean initialActions Benchmark value 1434 exceeds gate value 1360 for firefox webpack home mean loadScripts Benchmark value 2053 exceeds gate value 1935 for firefox webpack home p95 uiStartup Benchmark value 1759 exceeds gate value 1660 for firefox webpack home p95 load Benchmark value 1759 exceeds gate value 1660 for firefox webpack home p95 domContentLoaded Benchmark value 259 exceeds gate value 156 for firefox webpack home p95 domInteractive Benchmark value 80 exceeds gate value 49 for firefox webpack home p95 backgroundConnect Benchmark value 63 exceeds gate value 50 for firefox webpack home p95 firstReactRender Benchmark value 36 exceeds gate value 32 for firefox webpack home p95 getState Benchmark value 26 exceeds gate value 2 for firefox webpack home p95 initialActions Benchmark value 1695 exceeds gate value 1630 for firefox webpack home p95 loadScripts Benchmark value 32 exceeds gate value 28 for firefox webpack home p95 setupStore Sum of mean exceeds: 1532ms | Sum of p95 exceeds: 1740.8ms Sum of all benchmark exceeds: 3272.8ms Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
micaelae
reviewed
Jul 21, 2025
…nd-label-activitylist
Collaborator
Builds ready [3eda04b]
UI Startup Metrics (1289 ± 61 ms)
Benchmark value 1107 exceeds gate value 1070 for chrome browserify home mean load Benchmark value 1100 exceeds gate value 1061 for chrome browserify home mean domContentLoaded Benchmark value 216 exceeds gate value 10 for chrome browserify home mean backgroundConnect Benchmark value 24 exceeds gate value 23 for chrome browserify home mean firstReactRender Benchmark value 6 exceeds gate value 1 for chrome browserify home mean initialActions Benchmark value 892 exceeds gate value 830 for chrome browserify home mean loadScripts Benchmark value 1403 exceeds gate value 1365 for chrome browserify home p95 uiStartup Benchmark value 1209 exceeds gate value 1190 for chrome browserify home p95 load Benchmark value 1195 exceeds gate value 1180 for chrome browserify home p95 domContentLoaded Benchmark value 1195 exceeds gate value 1180 for chrome browserify home p95 firstPaint Benchmark value 230 exceeds gate value 18 for chrome browserify home p95 backgroundConnect Benchmark value 17 exceeds gate value 1.2 for chrome browserify home p95 initialActions Benchmark value 992 exceeds gate value 940 for chrome browserify home p95 loadScripts Benchmark value 2319 exceeds gate value 2192 for chrome webpack home mean uiStartup Benchmark value 1843 exceeds gate value 1711 for chrome webpack home mean load Benchmark value 1835 exceeds gate value 1704 for chrome webpack home mean domContentLoaded Benchmark value 9 exceeds gate value 7 for chrome webpack home mean initialActions Benchmark value 1831 exceeds gate value 1699 for chrome webpack home mean loadScripts Benchmark value 2492 exceeds gate value 2454 for chrome webpack home p95 uiStartup Benchmark value 2114 exceeds gate value 2030 for chrome webpack home p95 load Benchmark value 2111 exceeds gate value 2005 for chrome webpack home p95 domContentLoaded Benchmark value 62 exceeds gate value 57 for chrome webpack home p95 domInteractive Benchmark value 217 exceeds gate value 90 for chrome webpack home p95 backgroundConnect Benchmark value 29 exceeds gate value 7 for chrome webpack home p95 initialActions Benchmark value 2108 exceeds gate value 1970 for chrome webpack home p95 loadScripts Benchmark value 1502 exceeds gate value 1405 for firefox browserify home mean uiStartup Benchmark value 1284 exceeds gate value 1245 for firefox browserify home mean load Benchmark value 1284 exceeds gate value 1239 for firefox browserify home mean domContentLoaded Benchmark value 28 exceeds gate value 25 for firefox browserify home mean backgroundConnect Benchmark value 30 exceeds gate value 25 for firefox browserify home mean firstReactRender Benchmark value 8 exceeds gate value 1 for firefox browserify home mean initialActions Benchmark value 1262 exceeds gate value 1230 for firefox browserify home mean loadScripts Benchmark value 16 exceeds gate value 9 for firefox browserify home mean setupStore Benchmark value 1782 exceeds gate value 1660 for firefox browserify home p95 uiStartup Benchmark value 307 exceeds gate value 195 for firefox browserify home p95 domInteractive Benchmark value 60 exceeds gate value 55 for firefox browserify home p95 firstReactRender Benchmark value 27 exceeds gate value 24 for firefox browserify home p95 getState Benchmark value 21 exceeds gate value 2 for firefox browserify home p95 initialActions Benchmark value 70 exceeds gate value 27 for firefox browserify home p95 setupStore Benchmark value 1736 exceeds gate value 1615 for firefox webpack home mean uiStartup Benchmark value 1464 exceeds gate value 1380 for firefox webpack home mean load Benchmark value 1464 exceeds gate value 1380 for firefox webpack home mean domContentLoaded Benchmark value 30 exceeds gate value 26 for firefox webpack home mean backgroundConnect Benchmark value 52 exceeds gate value 38 for firefox webpack home mean firstReactRender Benchmark value 16 exceeds gate value 15 for firefox webpack home mean getState Benchmark value 8 exceeds gate value 1 for firefox webpack home mean initialActions Benchmark value 1440 exceeds gate value 1360 for firefox webpack home mean loadScripts Benchmark value 17 exceeds gate value 13 for firefox webpack home mean setupStore Benchmark value 2107 exceeds gate value 1935 for firefox webpack home p95 uiStartup Benchmark value 1791 exceeds gate value 1660 for firefox webpack home p95 load Benchmark value 1790 exceeds gate value 1660 for firefox webpack home p95 domContentLoaded Benchmark value 274 exceeds gate value 156 for firefox webpack home p95 domInteractive Benchmark value 71 exceeds gate value 49 for firefox webpack home p95 backgroundConnect Benchmark value 62 exceeds gate value 50 for firefox webpack home p95 firstReactRender Benchmark value 39 exceeds gate value 32 for firefox webpack home p95 getState Benchmark value 22 exceeds gate value 2 for firefox webpack home p95 initialActions Benchmark value 1762 exceeds gate value 1630 for firefox webpack home p95 loadScripts Benchmark value 56 exceeds gate value 28 for firefox webpack home p95 setupStore Sum of mean exceeds: 1564ms | Sum of p95 exceeds: 1962.8ms Sum of all benchmark exceeds: 3526.8ms Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
micaelae
approved these changes
Jul 21, 2025
SteP-n-s
approved these changes
Jul 22, 2025
…nd-label-activitylist
Collaborator
Builds ready [b793c5b]
UI Startup Metrics (1262 ± 63 ms)
Benchmark value 1084 exceeds gate value 1070 for chrome browserify home mean load Benchmark value 1077 exceeds gate value 1061 for chrome browserify home mean domContentLoaded Benchmark value 213 exceeds gate value 10 for chrome browserify home mean backgroundConnect Benchmark value 4 exceeds gate value 1 for chrome browserify home mean initialActions Benchmark value 871 exceeds gate value 830 for chrome browserify home mean loadScripts Benchmark value 1368 exceeds gate value 1365 for chrome browserify home p95 uiStartup Benchmark value 1202 exceeds gate value 1190 for chrome browserify home p95 load Benchmark value 1196 exceeds gate value 1180 for chrome browserify home p95 domContentLoaded Benchmark value 44 exceeds gate value 41 for chrome browserify home p95 domInteractive Benchmark value 227 exceeds gate value 18 for chrome browserify home p95 backgroundConnect Benchmark value 41 exceeds gate value 33 for chrome browserify home p95 getState Benchmark value 18 exceeds gate value 1.2 for chrome browserify home p95 initialActions Benchmark value 987 exceeds gate value 940 for chrome browserify home p95 loadScripts Benchmark value 2398 exceeds gate value 2192 for chrome webpack home mean uiStartup Benchmark value 1904 exceeds gate value 1711 for chrome webpack home mean load Benchmark value 1885 exceeds gate value 1704 for chrome webpack home mean domContentLoaded Benchmark value 62 exceeds gate value 40 for chrome webpack home mean backgroundConnect Benchmark value 34 exceeds gate value 29 for chrome webpack home mean getState Benchmark value 1881 exceeds gate value 1699 for chrome webpack home mean loadScripts Benchmark value 2770 exceeds gate value 2454 for chrome webpack home p95 uiStartup Benchmark value 2243 exceeds gate value 2030 for chrome webpack home p95 load Benchmark value 2173 exceeds gate value 2005 for chrome webpack home p95 domContentLoaded Benchmark value 289 exceeds gate value 90 for chrome webpack home p95 backgroundConnect Benchmark value 239 exceeds gate value 195 for chrome webpack home p95 getState Benchmark value 15 exceeds gate value 7 for chrome webpack home p95 initialActions Benchmark value 2170 exceeds gate value 1970 for chrome webpack home p95 loadScripts Benchmark value 180 exceeds gate value 65 for chrome webpack home p95 setupStore Benchmark value 1497 exceeds gate value 1405 for firefox browserify home mean uiStartup Benchmark value 1291 exceeds gate value 1245 for firefox browserify home mean load Benchmark value 1291 exceeds gate value 1239 for firefox browserify home mean domContentLoaded Benchmark value 116 exceeds gate value 110 for firefox browserify home mean domInteractive Benchmark value 27 exceeds gate value 25 for firefox browserify home mean backgroundConnect Benchmark value 30 exceeds gate value 25 for firefox browserify home mean firstReactRender Benchmark value 6 exceeds gate value 1 for firefox browserify home mean initialActions Benchmark value 1269 exceeds gate value 1230 for firefox browserify home mean loadScripts Benchmark value 10 exceeds gate value 9 for firefox browserify home mean setupStore Benchmark value 1733 exceeds gate value 1660 for firefox browserify home p95 uiStartup Benchmark value 350 exceeds gate value 195 for firefox browserify home p95 domInteractive Benchmark value 62 exceeds gate value 55 for firefox browserify home p95 firstReactRender Benchmark value 38 exceeds gate value 24 for firefox browserify home p95 getState Benchmark value 16 exceeds gate value 2 for firefox browserify home p95 initialActions Benchmark value 34 exceeds gate value 27 for firefox browserify home p95 setupStore Benchmark value 1742 exceeds gate value 1615 for firefox webpack home mean uiStartup Benchmark value 1466 exceeds gate value 1380 for firefox webpack home mean load Benchmark value 1466 exceeds gate value 1380 for firefox webpack home mean domContentLoaded Benchmark value 101 exceeds gate value 100 for firefox webpack home mean domInteractive Benchmark value 43 exceeds gate value 26 for firefox webpack home mean backgroundConnect Benchmark value 52 exceeds gate value 38 for firefox webpack home mean firstReactRender Benchmark value 7 exceeds gate value 1 for firefox webpack home mean initialActions Benchmark value 1443 exceeds gate value 1360 for firefox webpack home mean loadScripts Benchmark value 15 exceeds gate value 13 for firefox webpack home mean setupStore Benchmark value 2153 exceeds gate value 1935 for firefox webpack home p95 uiStartup Benchmark value 1786 exceeds gate value 1660 for firefox webpack home p95 load Benchmark value 1785 exceeds gate value 1660 for firefox webpack home p95 domContentLoaded Benchmark value 301 exceeds gate value 156 for firefox webpack home p95 domInteractive Benchmark value 63 exceeds gate value 49 for firefox webpack home p95 backgroundConnect Benchmark value 59 exceeds gate value 50 for firefox webpack home p95 firstReactRender Benchmark value 21 exceeds gate value 2 for firefox webpack home p95 initialActions Benchmark value 1766 exceeds gate value 1630 for firefox webpack home p95 loadScripts Benchmark value 30 exceeds gate value 28 for firefox webpack home p95 setupStore Sum of mean exceeds: 1765ms | Sum of p95 exceeds: 2641.8ms Sum of all benchmark exceeds: 4406.8ms Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jul 22, 2025
…#34476) <!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> [](https://codespaces.new/MetaMask/metamask-extension/pull/34476?quickstart=1) ## **Changelog** <!-- If this PR is not End-User-Facing and should not show up in the CHANGELOG, you can choose to either: 1. Write `CHANGELOG entry: null` 2. Label with `no-changelog` If this PR is End-User-Facing, please write a short User-Facing description in the past tense like: `CHANGELOG entry: Added a new tab for users to see their NFTs` `CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker` (This helps the Release Engineer do their job more quickly and accurately) --> CHANGELOG entry: ## **Related issues** Fixes: ## **Manual testing steps** 1. Go to this page... 2. 3. ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [ ] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
ghgoodreau
deleted the
SWAPS-2589-unified-swaps-solana-incorrect-send-label-activitylist
branch
metamaskbot
added
the
release-13.1.0
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
](https://codespaces.new/MetaMask/metamask-extension/pull/34476?quickstart=1){kind=link}
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes the default label of cross-chain swaps transactions in activity list from 'swap' to 'send' when they are still populating their information. Previously, it would show 'send' initially which may be confusing.
Changelog
CHANGELOG entry:
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist