chore: put comments back in .yarnrc.yml
#34641
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Collaborator
✨ Files requiring CODEOWNER review ✨👨🔧 @MetaMask/extension-platform (1 files, +124 -22)
|
davidmurdoch
commented
Jul 25, 2025
davidmurdoch
added
the
no-changelog
davidmurdoch
changed the title
.yarnrc.yml
HowardBraham
approved these changes
Jul 25, 2025
Collaborator
Builds ready [2c85db7]
UI Startup Metrics (1302 ± 55 ms)
Benchmark value 1120 exceeds gate value 1070 for chrome browserify home mean load Benchmark value 1110 exceeds gate value 1061 for chrome browserify home mean domContentLoaded Benchmark value 255 exceeds gate value 10 for chrome browserify home mean backgroundConnect Benchmark value 3 exceeds gate value 1 for chrome browserify home mean initialActions Benchmark value 865 exceeds gate value 830 for chrome browserify home mean loadScripts Benchmark value 1392 exceeds gate value 1365 for chrome browserify home p95 uiStartup Benchmark value 1200 exceeds gate value 1190 for chrome browserify home p95 load Benchmark value 1194 exceeds gate value 1180 for chrome browserify home p95 domContentLoaded Benchmark value 1198 exceeds gate value 1180 for chrome browserify home p95 firstPaint Benchmark value 271 exceeds gate value 18 for chrome browserify home p95 backgroundConnect Benchmark value 13 exceeds gate value 1.2 for chrome browserify home p95 initialActions Benchmark value 946 exceeds gate value 940 for chrome browserify home p95 loadScripts Benchmark value 2463 exceeds gate value 2192 for chrome webpack home mean uiStartup Benchmark value 1988 exceeds gate value 1711 for chrome webpack home mean load Benchmark value 1973 exceeds gate value 1704 for chrome webpack home mean domContentLoaded Benchmark value 23 exceeds gate value 21 for chrome webpack home mean domInteractive Benchmark value 55 exceeds gate value 40 for chrome webpack home mean backgroundConnect Benchmark value 8 exceeds gate value 7 for chrome webpack home mean initialActions Benchmark value 1959 exceeds gate value 1699 for chrome webpack home mean loadScripts Benchmark value 2869 exceeds gate value 2454 for chrome webpack home p95 uiStartup Benchmark value 2424 exceeds gate value 2030 for chrome webpack home p95 load Benchmark value 2298 exceeds gate value 2005 for chrome webpack home p95 domContentLoaded Benchmark value 62 exceeds gate value 57 for chrome webpack home p95 domInteractive Benchmark value 288 exceeds gate value 90 for chrome webpack home p95 backgroundConnect Benchmark value 233 exceeds gate value 195 for chrome webpack home p95 getState Benchmark value 18 exceeds gate value 7 for chrome webpack home p95 initialActions Benchmark value 2257 exceeds gate value 1970 for chrome webpack home p95 loadScripts Benchmark value 1501 exceeds gate value 1405 for firefox browserify home mean uiStartup Benchmark value 1292 exceeds gate value 1245 for firefox browserify home mean load Benchmark value 1291 exceeds gate value 1239 for firefox browserify home mean domContentLoaded Benchmark value 118 exceeds gate value 110 for firefox browserify home mean domInteractive Benchmark value 28 exceeds gate value 25 for firefox browserify home mean backgroundConnect Benchmark value 31 exceeds gate value 25 for firefox browserify home mean firstReactRender Benchmark value 12 exceeds gate value 11 for firefox browserify home mean getState Benchmark value 7 exceeds gate value 1 for firefox browserify home mean initialActions Benchmark value 1268 exceeds gate value 1230 for firefox browserify home mean loadScripts Benchmark value 12 exceeds gate value 9 for firefox browserify home mean setupStore Benchmark value 1787 exceeds gate value 1660 for firefox browserify home p95 uiStartup Benchmark value 347 exceeds gate value 195 for firefox browserify home p95 domInteractive Benchmark value 60 exceeds gate value 55 for firefox browserify home p95 firstReactRender Benchmark value 24 exceeds gate value 2 for firefox browserify home p95 initialActions Benchmark value 33 exceeds gate value 27 for firefox browserify home p95 setupStore Benchmark value 1763 exceeds gate value 1615 for firefox webpack home mean uiStartup Benchmark value 1491 exceeds gate value 1380 for firefox webpack home mean load Benchmark value 1491 exceeds gate value 1380 for firefox webpack home mean domContentLoaded Benchmark value 115 exceeds gate value 100 for firefox webpack home mean domInteractive Benchmark value 29 exceeds gate value 26 for firefox webpack home mean backgroundConnect Benchmark value 54 exceeds gate value 38 for firefox webpack home mean firstReactRender Benchmark value 9 exceeds gate value 1 for firefox webpack home mean initialActions Benchmark value 1467 exceeds gate value 1360 for firefox webpack home mean loadScripts Benchmark value 14 exceeds gate value 13 for firefox webpack home mean setupStore Benchmark value 2067 exceeds gate value 1935 for firefox webpack home p95 uiStartup Benchmark value 1799 exceeds gate value 1660 for firefox webpack home p95 load Benchmark value 1799 exceeds gate value 1660 for firefox webpack home p95 domContentLoaded Benchmark value 351 exceeds gate value 156 for firefox webpack home p95 domInteractive Benchmark value 64 exceeds gate value 50 for firefox webpack home p95 firstReactRender Benchmark value 29 exceeds gate value 2 for firefox webpack home p95 initialActions Benchmark value 1762 exceeds gate value 1630 for firefox webpack home p95 loadScripts Benchmark value 43 exceeds gate value 28 for firefox webpack home p95 setupStore Sum of mean exceeds: 2324ms | Sum of p95 exceeds: 3085.8ms Sum of all benchmark exceeds: 5409.8ms Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| - 'safe-event-emitter (deprecation)' # via eth-block-tracker and others | ||
|
|
||
| npmRegistryServer: 'https://registry.npmjs.org/' | ||
| # @metamask-institutional relies upon crypto which is deprecated |
There was a problem hiding this comment.
Bug: Yarn Configuration Loss Affects Package Management
The npmRegistryServer: 'https://registry.npmjs.org/' configuration line is accidentally removed from .yarnrc.yml. This line, previously located between the npmAuditIgnoreAdvisories and plugins sections, is not restored, which could disrupt Yarn's package resolution and registry selection.
Locations (2)
Contributor
Author
There was a problem hiding this comment.
it was accidentally added. i'm removing it on purpose.
metamaskbot
added
the
release-13.2.0
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I accidentally removed comments from
.yarnrc.ymlin #33463This PR restores them.