style: tell VSCode to end all files with a newline #34673
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
HowardBraham
added
the
no-changelog
Collaborator
Builds ready [61ee57a]
UI Startup Metrics (1309 ± 67 ms)
Benchmark value 1133 exceeds gate value 1070 for chrome browserify home mean load Benchmark value 1124 exceeds gate value 1061 for chrome browserify home mean domContentLoaded Benchmark value 256 exceeds gate value 10 for chrome browserify home mean backgroundConnect Benchmark value 4 exceeds gate value 1 for chrome browserify home mean initialActions Benchmark value 877 exceeds gate value 830 for chrome browserify home mean loadScripts Benchmark value 1435 exceeds gate value 1365 for chrome browserify home p95 uiStartup Benchmark value 1229 exceeds gate value 1190 for chrome browserify home p95 load Benchmark value 1223 exceeds gate value 1180 for chrome browserify home p95 domContentLoaded Benchmark value 1201 exceeds gate value 1180 for chrome browserify home p95 firstPaint Benchmark value 275 exceeds gate value 18 for chrome browserify home p95 backgroundConnect Benchmark value 13 exceeds gate value 1.2 for chrome browserify home p95 initialActions Benchmark value 974 exceeds gate value 940 for chrome browserify home p95 loadScripts Benchmark value 2354 exceeds gate value 2192 for chrome webpack home mean uiStartup Benchmark value 1867 exceeds gate value 1711 for chrome webpack home mean load Benchmark value 1849 exceeds gate value 1704 for chrome webpack home mean domContentLoaded Benchmark value 22 exceeds gate value 21 for chrome webpack home mean domInteractive Benchmark value 61 exceeds gate value 40 for chrome webpack home mean backgroundConnect Benchmark value 8 exceeds gate value 7 for chrome webpack home mean initialActions Benchmark value 1844 exceeds gate value 1699 for chrome webpack home mean loadScripts Benchmark value 2785 exceeds gate value 2454 for chrome webpack home p95 uiStartup Benchmark value 2305 exceeds gate value 2030 for chrome webpack home p95 load Benchmark value 2161 exceeds gate value 2005 for chrome webpack home p95 domContentLoaded Benchmark value 61 exceeds gate value 57 for chrome webpack home p95 domInteractive Benchmark value 302 exceeds gate value 90 for chrome webpack home p95 backgroundConnect Benchmark value 229 exceeds gate value 195 for chrome webpack home p95 getState Benchmark value 12 exceeds gate value 7 for chrome webpack home p95 initialActions Benchmark value 2150 exceeds gate value 1970 for chrome webpack home p95 loadScripts Benchmark value 1455 exceeds gate value 1405 for firefox browserify home mean uiStartup Benchmark value 1255 exceeds gate value 1245 for firefox browserify home mean load Benchmark value 1255 exceeds gate value 1239 for firefox browserify home mean domContentLoaded Benchmark value 29 exceeds gate value 25 for firefox browserify home mean firstReactRender Benchmark value 15 exceeds gate value 11 for firefox browserify home mean getState Benchmark value 5 exceeds gate value 1 for firefox browserify home mean initialActions Benchmark value 1233 exceeds gate value 1230 for firefox browserify home mean loadScripts Benchmark value 1705 exceeds gate value 1660 for firefox browserify home p95 uiStartup Benchmark value 299 exceeds gate value 195 for firefox browserify home p95 domInteractive Benchmark value 59 exceeds gate value 55 for firefox browserify home p95 firstReactRender Benchmark value 70 exceeds gate value 24 for firefox browserify home p95 getState Benchmark value 26 exceeds gate value 2 for firefox browserify home p95 initialActions Benchmark value 1856 exceeds gate value 1615 for firefox webpack home mean uiStartup Benchmark value 1574 exceeds gate value 1380 for firefox webpack home mean load Benchmark value 1574 exceeds gate value 1380 for firefox webpack home mean domContentLoaded Benchmark value 114 exceeds gate value 100 for firefox webpack home mean domInteractive Benchmark value 33 exceeds gate value 26 for firefox webpack home mean backgroundConnect Benchmark value 56 exceeds gate value 38 for firefox webpack home mean firstReactRender Benchmark value 9 exceeds gate value 1 for firefox webpack home mean initialActions Benchmark value 1548 exceeds gate value 1360 for firefox webpack home mean loadScripts Benchmark value 19 exceeds gate value 13 for firefox webpack home mean setupStore Benchmark value 2272 exceeds gate value 1935 for firefox webpack home p95 uiStartup Benchmark value 1920 exceeds gate value 1660 for firefox webpack home p95 load Benchmark value 1920 exceeds gate value 1660 for firefox webpack home p95 domContentLoaded Benchmark value 310 exceeds gate value 156 for firefox webpack home p95 domInteractive Benchmark value 68 exceeds gate value 50 for firefox webpack home p95 firstReactRender Benchmark value 29 exceeds gate value 2 for firefox webpack home p95 initialActions Benchmark value 1892 exceeds gate value 1630 for firefox webpack home p95 loadScripts Benchmark value 71 exceeds gate value 28 for firefox webpack home p95 setupStore Sum of mean exceeds: 2090ms | Sum of p95 exceeds: 3256.8ms Sum of all benchmark exceeds: 5346.8ms Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
davidmurdoch
approved these changes
Jul 29, 2025
Contributor
davidmurdoch
left a comment
davidmurdoch
left a comment
There was a problem hiding this comment.
it's probably fine :-)
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
metamaskbot
added
the
release-13.1.0
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is an excellent example of MetaMask/MetaMask-planning#2676 where we should be skipping most CI steps.
Changelog
CHANGELOG entry: null
Related issues
Fixes problem in: #34530
Example of: MetaMask/MetaMask-planning#2676