-
Notifications
You must be signed in to change notification settings - Fork 5.5k
chore: updated release workflows to eliminate confusion #34717
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Builds ready [996e2af]
UI Startup Metrics (1277 ± 66 ms)
Benchmark value 1095 exceeds gate value 1070 for chrome browserify home mean load Benchmark value 1088 exceeds gate value 1061 for chrome browserify home mean domContentLoaded Benchmark value 217 exceeds gate value 10 for chrome browserify home mean backgroundConnect Benchmark value 3 exceeds gate value 1 for chrome browserify home mean initialActions Benchmark value 879 exceeds gate value 830 for chrome browserify home mean loadScripts Benchmark value 1397 exceeds gate value 1365 for chrome browserify home p95 uiStartup Benchmark value 235 exceeds gate value 18 for chrome browserify home p95 backgroundConnect Benchmark value 37 exceeds gate value 33 for chrome browserify home p95 getState Benchmark value 14 exceeds gate value 1.2 for chrome browserify home p95 initialActions Benchmark value 965 exceeds gate value 940 for chrome browserify home p95 loadScripts Benchmark value 2561 exceeds gate value 2192 for chrome webpack home mean uiStartup Benchmark value 2087 exceeds gate value 1711 for chrome webpack home mean load Benchmark value 2060 exceeds gate value 1704 for chrome webpack home mean domContentLoaded Benchmark value 25 exceeds gate value 21 for chrome webpack home mean domInteractive Benchmark value 71 exceeds gate value 40 for chrome webpack home mean backgroundConnect Benchmark value 10 exceeds gate value 7 for chrome webpack home mean initialActions Benchmark value 2047 exceeds gate value 1699 for chrome webpack home mean loadScripts Benchmark value 2924 exceeds gate value 2454 for chrome webpack home p95 uiStartup Benchmark value 2488 exceeds gate value 2030 for chrome webpack home p95 load Benchmark value 2433 exceeds gate value 2005 for chrome webpack home p95 domContentLoaded Benchmark value 87 exceeds gate value 57 for chrome webpack home p95 domInteractive Benchmark value 376 exceeds gate value 334 for chrome webpack home p95 firstPaint Benchmark value 279 exceeds gate value 90 for chrome webpack home p95 backgroundConnect Benchmark value 15 exceeds gate value 7 for chrome webpack home p95 initialActions Benchmark value 2304 exceeds gate value 1970 for chrome webpack home p95 loadScripts Benchmark value 1455 exceeds gate value 1405 for firefox browserify home mean uiStartup Benchmark value 1259 exceeds gate value 1245 for firefox browserify home mean load Benchmark value 1259 exceeds gate value 1239 for firefox browserify home mean domContentLoaded Benchmark value 28 exceeds gate value 25 for firefox browserify home mean backgroundConnect Benchmark value 13 exceeds gate value 11 for firefox browserify home mean getState Benchmark value 7 exceeds gate value 1 for firefox browserify home mean initialActions Benchmark value 1235 exceeds gate value 1230 for firefox browserify home mean loadScripts Benchmark value 1674 exceeds gate value 1660 for firefox browserify home p95 uiStartup Benchmark value 199 exceeds gate value 195 for firefox browserify home p95 domInteractive Benchmark value 62 exceeds gate value 24 for firefox browserify home p95 getState Benchmark value 17 exceeds gate value 2 for firefox browserify home p95 initialActions Benchmark value 1753 exceeds gate value 1615 for firefox webpack home mean uiStartup Benchmark value 1486 exceeds gate value 1380 for firefox webpack home mean load Benchmark value 1486 exceeds gate value 1380 for firefox webpack home mean domContentLoaded Benchmark value 114 exceeds gate value 100 for firefox webpack home mean domInteractive Benchmark value 30 exceeds gate value 26 for firefox webpack home mean backgroundConnect Benchmark value 54 exceeds gate value 38 for firefox webpack home mean firstReactRender Benchmark value 10 exceeds gate value 1 for firefox webpack home mean initialActions Benchmark value 1462 exceeds gate value 1360 for firefox webpack home mean loadScripts Benchmark value 2121 exceeds gate value 1935 for firefox webpack home p95 uiStartup Benchmark value 1771 exceeds gate value 1660 for firefox webpack home p95 load Benchmark value 1770 exceeds gate value 1660 for firefox webpack home p95 domContentLoaded Benchmark value 291 exceeds gate value 156 for firefox webpack home p95 domInteractive Benchmark value 51 exceeds gate value 49 for firefox webpack home p95 backgroundConnect Benchmark value 64 exceeds gate value 50 for firefox webpack home p95 firstReactRender Benchmark value 29 exceeds gate value 2 for firefox webpack home p95 initialActions Benchmark value 1744 exceeds gate value 1630 for firefox webpack home p95 loadScripts Benchmark value 34 exceeds gate value 28 for firefox webpack home p95 setupStore Sum of mean exceeds: 2435ms | Sum of p95 exceeds: 3025.8ms Sum of all benchmark exceeds: 5460.8ms Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
gauthierpetetin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (documentation needs to be updated accordingly once this PR is merged)
…e-release-workflows
4576410
gauthierpetetin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Builds ready [d51f526]
UI Startup Metrics (1151 ± 80 ms)
Benchmark value 4 exceeds gate value 1 for chrome browserify home mean initialActions Benchmark value 232 exceeds gate value 18 for chrome browserify home p95 backgroundConnect Benchmark value 17 exceeds gate value 1.2 for chrome browserify home p95 initialActions Benchmark value 2202 exceeds gate value 2192 for chrome webpack home mean uiStartup Benchmark value 2563 exceeds gate value 2454 for chrome webpack home p95 uiStartup Benchmark value 67 exceeds gate value 57 for chrome webpack home p95 domInteractive Benchmark value 388 exceeds gate value 370 for chrome webpack home p95 firstReactRender Benchmark value 9 exceeds gate value 7 for chrome webpack home p95 initialActions Benchmark value 28 exceeds gate value 25 for firefox browserify home mean backgroundConnect Benchmark value 5 exceeds gate value 1 for firefox browserify home mean initialActions Benchmark value 11 exceeds gate value 9 for firefox browserify home mean setupStore Benchmark value 205 exceeds gate value 195 for firefox browserify home p95 domInteractive Benchmark value 40 exceeds gate value 24 for firefox browserify home p95 getState Benchmark value 11 exceeds gate value 2 for firefox browserify home p95 initialActions Benchmark value 29 exceeds gate value 27 for firefox browserify home p95 setupStore Benchmark value 103 exceeds gate value 100 for firefox webpack home mean domInteractive Benchmark value 33 exceeds gate value 26 for firefox webpack home mean backgroundConnect Benchmark value 51 exceeds gate value 38 for firefox webpack home mean firstReactRender Benchmark value 5 exceeds gate value 1 for firefox webpack home mean initialActions Benchmark value 260 exceeds gate value 156 for firefox webpack home p95 domInteractive Benchmark value 86 exceeds gate value 49 for firefox webpack home p95 backgroundConnect Benchmark value 63 exceeds gate value 50 for firefox webpack home p95 firstReactRender Benchmark value 13 exceeds gate value 2 for firefox webpack home p95 initialActions Benchmark value 31 exceeds gate value 28 for firefox webpack home p95 setupStore Sum of mean exceeds: 255ms | Sum of p95 exceeds: 573.8ms Sum of all benchmark exceeds: 828.8ms Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
e6a448b
MajorLift
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Builds ready [dfc942a]
UI Startup Metrics (1151 ± 68 ms)
Benchmark value 3 exceeds gate value 1 for chrome browserify home mean initialActions Benchmark value 233 exceeds gate value 18 for chrome browserify home p95 backgroundConnect Benchmark value 11 exceeds gate value 1.2 for chrome browserify home p95 initialActions Benchmark value 2242 exceeds gate value 2192 for chrome webpack home mean uiStartup Benchmark value 236 exceeds gate value 235 for chrome webpack home mean firstReactRender Benchmark value 2566 exceeds gate value 2454 for chrome webpack home p95 uiStartup Benchmark value 62 exceeds gate value 57 for chrome webpack home p95 domInteractive Benchmark value 395 exceeds gate value 370 for chrome webpack home p95 firstReactRender Benchmark value 256 exceeds gate value 195 for chrome webpack home p95 getState Benchmark value 9 exceeds gate value 7 for chrome webpack home p95 initialActions Benchmark value 31 exceeds gate value 25 for firefox browserify home mean backgroundConnect Benchmark value 5 exceeds gate value 1 for firefox browserify home mean initialActions Benchmark value 220 exceeds gate value 195 for firefox browserify home p95 domInteractive Benchmark value 77 exceeds gate value 70 for firefox browserify home p95 backgroundConnect Benchmark value 41 exceeds gate value 24 for firefox browserify home p95 getState Benchmark value 11 exceeds gate value 2 for firefox browserify home p95 initialActions Benchmark value 35 exceeds gate value 27 for firefox browserify home p95 setupStore Benchmark value 31 exceeds gate value 26 for firefox webpack home mean backgroundConnect Benchmark value 54 exceeds gate value 38 for firefox webpack home mean firstReactRender Benchmark value 6 exceeds gate value 1 for firefox webpack home mean initialActions Benchmark value 248 exceeds gate value 156 for firefox webpack home p95 domInteractive Benchmark value 67 exceeds gate value 49 for firefox webpack home p95 backgroundConnect Benchmark value 68 exceeds gate value 50 for firefox webpack home p95 firstReactRender Benchmark value 41 exceeds gate value 32 for firefox webpack home p95 getState Benchmark value 13 exceeds gate value 2 for firefox webpack home p95 initialActions Benchmark value 29 exceeds gate value 28 for firefox webpack home p95 setupStore Sum of mean exceeds: 295ms | Sum of p95 exceeds: 644.8ms Sum of all benchmark exceeds: 939.8ms Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Description
Updated workflows for creating release PRs to avoid confusion.
Related issues
Fixes: https://consensyssoftware.atlassian.net/browse/INFRA-2772
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist