Skip to content

Conversation

@bsgrigorov
Copy link
Contributor

Description

Updated workflows for creating release PRs to avoid confusion.

Related issues

Fixes: https://consensyssoftware.atlassian.net/browse/INFRA-2772

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • [ x] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • [ x] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@bsgrigorov bsgrigorov self-assigned this Jul 30, 2025
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-dev-ops DevOps team label Jul 30, 2025
@bsgrigorov bsgrigorov added the no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed label Jul 30, 2025
@metamaskbot metamaskbot added the INVALID-PR-TEMPLATE PR's body doesn't match template label Jul 30, 2025
@metamaskbot
Copy link
Collaborator

Builds ready [996e2af]
UI Startup Metrics (1277 ± 66 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1277114116166613181396
load109499314656311301186
domContentLoaded108898914596211251166
domInteractive18144261735
firstPaint65779146344910901155
backgroundConnect21619945725216234
firstReactRender2214175162134
getState12390141337
initialActions30174214
loadScripts878788100851916965
setupStore74203712
WebpackHomeuiStartup25602208307215926132923
load20871572268219522072488
domContentLoaded20601515250118021762433
domInteractive2513228381686
firstPaint1796652985208376
backgroundConnect70124629939278
firstReactRender1469438065192311
getState184226411429
initialActions9219827715
loadScripts20471509249017621582304
setupStore216243381737
FirefoxBrowserifyHomeuiStartup14541264190512415331674
load1258111314717913131395
domContentLoaded1258111214717913131394
domInteractive983527943107199
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect2816111143056
firstReactRender25203842732
getState13221426962
initialActions6022123317
loadScripts1235109314497712901366
setupStore83517623
WebpackHomeuiStartup17521507247917018292121
load14861298189513515551771
domContentLoaded14851297189513515551770
domInteractive1136136856110291
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect301578113751
firstReactRender53426965864
getState103159161225
initialActions9121726929
loadScripts14611275186013315261744
setupStore124144181034
Benchmark value 1277 exceeds gate value 1234 for chrome browserify home mean uiStartup
Benchmark value 1095 exceeds gate value 1070 for chrome browserify home mean load
Benchmark value 1088 exceeds gate value 1061 for chrome browserify home mean domContentLoaded
Benchmark value 217 exceeds gate value 10 for chrome browserify home mean backgroundConnect
Benchmark value 3 exceeds gate value 1 for chrome browserify home mean initialActions
Benchmark value 879 exceeds gate value 830 for chrome browserify home mean loadScripts
Benchmark value 1397 exceeds gate value 1365 for chrome browserify home p95 uiStartup
Benchmark value 235 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 37 exceeds gate value 33 for chrome browserify home p95 getState
Benchmark value 14 exceeds gate value 1.2 for chrome browserify home p95 initialActions
Benchmark value 965 exceeds gate value 940 for chrome browserify home p95 loadScripts
Benchmark value 2561 exceeds gate value 2192 for chrome webpack home mean uiStartup
Benchmark value 2087 exceeds gate value 1711 for chrome webpack home mean load
Benchmark value 2060 exceeds gate value 1704 for chrome webpack home mean domContentLoaded
Benchmark value 25 exceeds gate value 21 for chrome webpack home mean domInteractive
Benchmark value 71 exceeds gate value 40 for chrome webpack home mean backgroundConnect
Benchmark value 10 exceeds gate value 7 for chrome webpack home mean initialActions
Benchmark value 2047 exceeds gate value 1699 for chrome webpack home mean loadScripts
Benchmark value 2924 exceeds gate value 2454 for chrome webpack home p95 uiStartup
Benchmark value 2488 exceeds gate value 2030 for chrome webpack home p95 load
Benchmark value 2433 exceeds gate value 2005 for chrome webpack home p95 domContentLoaded
Benchmark value 87 exceeds gate value 57 for chrome webpack home p95 domInteractive
Benchmark value 376 exceeds gate value 334 for chrome webpack home p95 firstPaint
Benchmark value 279 exceeds gate value 90 for chrome webpack home p95 backgroundConnect
Benchmark value 15 exceeds gate value 7 for chrome webpack home p95 initialActions
Benchmark value 2304 exceeds gate value 1970 for chrome webpack home p95 loadScripts
Benchmark value 1455 exceeds gate value 1405 for firefox browserify home mean uiStartup
Benchmark value 1259 exceeds gate value 1245 for firefox browserify home mean load
Benchmark value 1259 exceeds gate value 1239 for firefox browserify home mean domContentLoaded
Benchmark value 28 exceeds gate value 25 for firefox browserify home mean backgroundConnect
Benchmark value 13 exceeds gate value 11 for firefox browserify home mean getState
Benchmark value 7 exceeds gate value 1 for firefox browserify home mean initialActions
Benchmark value 1235 exceeds gate value 1230 for firefox browserify home mean loadScripts
Benchmark value 1674 exceeds gate value 1660 for firefox browserify home p95 uiStartup
Benchmark value 199 exceeds gate value 195 for firefox browserify home p95 domInteractive
Benchmark value 62 exceeds gate value 24 for firefox browserify home p95 getState
Benchmark value 17 exceeds gate value 2 for firefox browserify home p95 initialActions
Benchmark value 1753 exceeds gate value 1615 for firefox webpack home mean uiStartup
Benchmark value 1486 exceeds gate value 1380 for firefox webpack home mean load
Benchmark value 1486 exceeds gate value 1380 for firefox webpack home mean domContentLoaded
Benchmark value 114 exceeds gate value 100 for firefox webpack home mean domInteractive
Benchmark value 30 exceeds gate value 26 for firefox webpack home mean backgroundConnect
Benchmark value 54 exceeds gate value 38 for firefox webpack home mean firstReactRender
Benchmark value 10 exceeds gate value 1 for firefox webpack home mean initialActions
Benchmark value 1462 exceeds gate value 1360 for firefox webpack home mean loadScripts
Benchmark value 2121 exceeds gate value 1935 for firefox webpack home p95 uiStartup
Benchmark value 1771 exceeds gate value 1660 for firefox webpack home p95 load
Benchmark value 1770 exceeds gate value 1660 for firefox webpack home p95 domContentLoaded
Benchmark value 291 exceeds gate value 156 for firefox webpack home p95 domInteractive
Benchmark value 51 exceeds gate value 49 for firefox webpack home p95 backgroundConnect
Benchmark value 64 exceeds gate value 50 for firefox webpack home p95 firstReactRender
Benchmark value 29 exceeds gate value 2 for firefox webpack home p95 initialActions
Benchmark value 1744 exceeds gate value 1630 for firefox webpack home p95 loadScripts
Benchmark value 34 exceeds gate value 28 for firefox webpack home p95 setupStore
Sum of mean exceeds: 2435ms | Sum of p95 exceeds: 3025.8ms
Sum of all benchmark exceeds: 5460.8ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 43 Bytes (0%)
  • ui: 0 Bytes (0%)
  • common: 15 Bytes (0%)

Copy link
Contributor

@gauthierpetetin gauthierpetetin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (documentation needs to be updated accordingly once this PR is merged)

DDDDDanica
DDDDDanica previously approved these changes Jul 30, 2025
@DDDDDanica DDDDDanica added this pull request to the merge queue Jul 30, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 30, 2025
@bsgrigorov bsgrigorov added this pull request to the merge queue Jul 30, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Jul 30, 2025
@gauthierpetetin gauthierpetetin dismissed stale reviews from DDDDDanica and themself via 4576410 August 1, 2025 16:28
gauthierpetetin
gauthierpetetin previously approved these changes Aug 1, 2025
Copy link
Contributor

@gauthierpetetin gauthierpetetin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@metamaskbot
Copy link
Collaborator

Builds ready [d51f526]
UI Startup Metrics (1151 ± 80 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1151103415638011921264
load97186412516010021077
domContentLoaded9638581236609951068
domInteractive17134951630
firstPaint6187612443889791047
backgroundConnect2152002608217231
firstReactRender20144462134
getState843051020
initialActions40648217
loadScripts755655101959787852
setupStore74223711
WebpackHomeuiStartup22021670262919723012562
load16601206196416017261904
domContentLoaded16531201194915817221888
domInteractive1812102171466
firstPaint1736547073183330
backgroundConnect24146492741
firstReactRender20591403101326388
getState164308411029
initialActions5220269
loadScripts16491195193715717201876
setupStore226285511530
FirefoxBrowserifyHomeuiStartup13331139174711213881591
load114397913828012061290
domContentLoaded114397913818012061290
domInteractive993426744111205
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect271475133061
firstReactRender23205162333
getState928613640
initialActions4015916211
loadScripts112196513608111821275
setupStore11319026729
WebpackHomeuiStartup15961349199314316851870
load13351140173911814101561
domContentLoaded13341140173711814101561
domInteractive1023228556101260
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect3218133213186
firstReactRender51437155463
getState10213816730
initialActions4110711313
loadScripts13081122172311713671537
setupStore11512618831
Benchmark value 216 exceeds gate value 10 for chrome browserify home mean backgroundConnect
Benchmark value 4 exceeds gate value 1 for chrome browserify home mean initialActions
Benchmark value 232 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 17 exceeds gate value 1.2 for chrome browserify home p95 initialActions
Benchmark value 2202 exceeds gate value 2192 for chrome webpack home mean uiStartup
Benchmark value 2563 exceeds gate value 2454 for chrome webpack home p95 uiStartup
Benchmark value 67 exceeds gate value 57 for chrome webpack home p95 domInteractive
Benchmark value 388 exceeds gate value 370 for chrome webpack home p95 firstReactRender
Benchmark value 9 exceeds gate value 7 for chrome webpack home p95 initialActions
Benchmark value 28 exceeds gate value 25 for firefox browserify home mean backgroundConnect
Benchmark value 5 exceeds gate value 1 for firefox browserify home mean initialActions
Benchmark value 11 exceeds gate value 9 for firefox browserify home mean setupStore
Benchmark value 205 exceeds gate value 195 for firefox browserify home p95 domInteractive
Benchmark value 40 exceeds gate value 24 for firefox browserify home p95 getState
Benchmark value 11 exceeds gate value 2 for firefox browserify home p95 initialActions
Benchmark value 29 exceeds gate value 27 for firefox browserify home p95 setupStore
Benchmark value 103 exceeds gate value 100 for firefox webpack home mean domInteractive
Benchmark value 33 exceeds gate value 26 for firefox webpack home mean backgroundConnect
Benchmark value 51 exceeds gate value 38 for firefox webpack home mean firstReactRender
Benchmark value 5 exceeds gate value 1 for firefox webpack home mean initialActions
Benchmark value 260 exceeds gate value 156 for firefox webpack home p95 domInteractive
Benchmark value 86 exceeds gate value 49 for firefox webpack home p95 backgroundConnect
Benchmark value 63 exceeds gate value 50 for firefox webpack home p95 firstReactRender
Benchmark value 13 exceeds gate value 2 for firefox webpack home p95 initialActions
Benchmark value 31 exceeds gate value 28 for firefox webpack home p95 setupStore
Sum of mean exceeds: 255ms | Sum of p95 exceeds: 573.8ms
Sum of all benchmark exceeds: 828.8ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 43 Bytes (0%)
  • ui: 0 Bytes (0%)
  • common: 10 Bytes (0%)

itsyoboieltr
itsyoboieltr previously approved these changes Aug 1, 2025
@gauthierpetetin gauthierpetetin dismissed stale reviews from itsyoboieltr and themself via e6a448b August 1, 2025 17:42
Copy link
Contributor

@MajorLift MajorLift left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@metamaskbot
Copy link
Collaborator

Builds ready [dfc942a]
UI Startup Metrics (1151 ± 68 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1151102914556811861282
load97686011546310151104
domContentLoaded96885511486310081086
domInteractive17134041723
firstPaint6617811433819921061
backgroundConnect2162022548219233
firstReactRender20144142030
getState10475111024
initialActions20224211
loadScripts76065093163804874
setupStore74142711
WebpackHomeuiStartup22421668264619523592566
load16711203198615417501923
domContentLoaded16631199197515217431888
domInteractive1812109171461
firstPaint1705950271204301
backgroundConnect271472113058
firstReactRender23693406120380395
getState2743026413256
initialActions721691769
loadScripts16591196196315117391886
setupStore216306451629
FirefoxBrowserifyHomeuiStartup13751187184211614331581
load1180102414618112371325
domContentLoaded1180102314608112371324
domInteractive1023532749112220
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect3016142193277
firstReactRender24215052529
getState929414641
initialActions4018618211
loadScripts115699414388112121302
setupStore8310713635
WebpackHomeuiStartup15891375223115816451889
load13181115166911413911545
domContentLoaded13181115166911413911545
domInteractive98304586395248
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect3117137183267
firstReactRender53419195668
getState10214417741
initialActions6115619313
loadScripts12931097164611113571510
setupStore1149613829
Benchmark value 216 exceeds gate value 10 for chrome browserify home mean backgroundConnect
Benchmark value 3 exceeds gate value 1 for chrome browserify home mean initialActions
Benchmark value 233 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 11 exceeds gate value 1.2 for chrome browserify home p95 initialActions
Benchmark value 2242 exceeds gate value 2192 for chrome webpack home mean uiStartup
Benchmark value 236 exceeds gate value 235 for chrome webpack home mean firstReactRender
Benchmark value 2566 exceeds gate value 2454 for chrome webpack home p95 uiStartup
Benchmark value 62 exceeds gate value 57 for chrome webpack home p95 domInteractive
Benchmark value 395 exceeds gate value 370 for chrome webpack home p95 firstReactRender
Benchmark value 256 exceeds gate value 195 for chrome webpack home p95 getState
Benchmark value 9 exceeds gate value 7 for chrome webpack home p95 initialActions
Benchmark value 31 exceeds gate value 25 for firefox browserify home mean backgroundConnect
Benchmark value 5 exceeds gate value 1 for firefox browserify home mean initialActions
Benchmark value 220 exceeds gate value 195 for firefox browserify home p95 domInteractive
Benchmark value 77 exceeds gate value 70 for firefox browserify home p95 backgroundConnect
Benchmark value 41 exceeds gate value 24 for firefox browserify home p95 getState
Benchmark value 11 exceeds gate value 2 for firefox browserify home p95 initialActions
Benchmark value 35 exceeds gate value 27 for firefox browserify home p95 setupStore
Benchmark value 31 exceeds gate value 26 for firefox webpack home mean backgroundConnect
Benchmark value 54 exceeds gate value 38 for firefox webpack home mean firstReactRender
Benchmark value 6 exceeds gate value 1 for firefox webpack home mean initialActions
Benchmark value 248 exceeds gate value 156 for firefox webpack home p95 domInteractive
Benchmark value 67 exceeds gate value 49 for firefox webpack home p95 backgroundConnect
Benchmark value 68 exceeds gate value 50 for firefox webpack home p95 firstReactRender
Benchmark value 41 exceeds gate value 32 for firefox webpack home p95 getState
Benchmark value 13 exceeds gate value 2 for firefox webpack home p95 initialActions
Benchmark value 29 exceeds gate value 28 for firefox webpack home p95 setupStore
Sum of mean exceeds: 295ms | Sum of p95 exceeds: 644.8ms
Sum of all benchmark exceeds: 939.8ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 43 Bytes (0%)
  • ui: 0 Bytes (0%)
  • common: 10 Bytes (0%)

@gauthierpetetin gauthierpetetin added this pull request to the merge queue Aug 1, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 1, 2025
@Gudahtt Gudahtt changed the title feat(INFRA-2772): updated release workflows to eliminate confusion chore: updated release workflows to eliminate confusion Aug 1, 2025
@Gudahtt Gudahtt added this pull request to the merge queue Aug 1, 2025
Merged via the queue into main with commit ba0fb3d Aug 1, 2025
148 checks passed
@Gudahtt Gudahtt deleted the feat/INFRA-2772-update-release-workflows branch August 1, 2025 21:03
@github-actions github-actions bot locked and limited conversation to collaborators Aug 1, 2025
@metamaskbot metamaskbot added the release-13.2.0 Issue or pull request that will be included in release 13.2.0 label Aug 1, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

INVALID-PR-TEMPLATE PR's body doesn't match template no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed release-13.2.0 Issue or pull request that will be included in release 13.2.0 team-dev-ops DevOps team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants