test(e2e): Deflake onStart lifecycle hook test

[Mrtenz]

Description

This deflakes the onStart lifecycle hook test by removing a race condition.

Changelog

CHANGELOG entry:

Related issues

Fixes: #34767

Manual testing steps

1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

• I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[metamaskbot]

✨ Files requiring CODEOWNER review ✨

👨‍🔧 @MetaMask/core-platform (1 files, +14 -2)

• 📁 test/
  • 📁 e2e/
    • 📁 snaps/
      • 📄 test-snap-lifecycle.spec.ts +14 -2

[metamaskbot]

Builds ready [fd3460f]

• builds: chrome, firefox
• builds (beta): chrome, firefox
• builds (flask): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• bundle size: Bundle Size Stats
• user-actions-benchmark: User Actions Stats
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5, 6, 7, 8
  • common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
  • ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
  • content-script: 0
  • offscreen: 0

UI Startup Metrics (1280 ± 66 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1280	1160	1520	66	1314	1409
			load	1093	987	1334	61	1122	1210
			domContentLoaded	1085	974	1323	60	1115	1202
			domInteractive	19	14	63	8	18	40
			firstPaint	710	104	1332	438	1111	1154
			backgroundConnect	226	212	257	8	229	237
			firstReactRender	21	15	121	11	20	37
			getState	10	3	82	9	13	23
			initialActions	3	0	57	7	2	10
			loadScripts	866	750	1095	60	895	988
			setupStore	7	4	16	2	7	14
	Webpack	Home	uiStartup	2302	1741	2883	174	2348	2625
			load	1844	1305	2512	193	1892	2273
			domContentLoaded	1835	1299	2495	189	1886	2255
			domInteractive	21	11	246	33	14	67
			firstPaint	164	56	473	70	180	306
			backgroundConnect	44	11	300	69	28	273
			firstReactRender	152	89	343	50	169	228
			getState	9	4	33	4	10	17
			initialActions	5	2	28	4	5	11
			loadScripts	1823	1296	2483	183	1870	2163
			setupStore	19	6	253	41	14	25
Firefox	Browserify	Home	uiStartup	1495	1256	1910	123	1552	1747
			load	1285	1107	1584	88	1341	1468
			domContentLoaded	1285	1106	1583	88	1339	1467
			domInteractive	106	34	426	53	114	232
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	27	16	103	13	29	54
			firstReactRender	27	21	82	9	28	52
			getState	8	2	84	11	6	32
			initialActions	6	0	191	21	3	17
			loadScripts	1264	1091	1559	86	1318	1420
			setupStore	9	3	56	10	7	37
	Webpack	Home	uiStartup	1639	1422	2172	156	1710	2011
			load	1379	1202	1711	118	1450	1623
			domContentLoaded	1379	1202	1711	118	1450	1622
			domInteractive	93	31	277	47	98	233
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	34	21	104	11	35	57
			firstReactRender	52	41	67	5	55	61
			getState	10	3	108	13	11	31
			initialActions	6	0	113	14	3	21
			loadScripts	1353	1178	1685	115	1426	1582
			setupStore	12	5	162	20	10	25

Benchmark value 1280 exceeds gate value 1234 for chrome browserify home mean uiStartup
Benchmark value 1093 exceeds gate value 1070 for chrome browserify home mean load
Benchmark value 1086 exceeds gate value 1061 for chrome browserify home mean domContentLoaded
Benchmark value 226 exceeds gate value 10 for chrome browserify home mean backgroundConnect
Benchmark value 3 exceeds gate value 1 for chrome browserify home mean initialActions
Benchmark value 867 exceeds gate value 830 for chrome browserify home mean loadScripts
Benchmark value 1409 exceeds gate value 1365 for chrome browserify home p95 uiStartup
Benchmark value 1211 exceeds gate value 1190 for chrome browserify home p95 load
Benchmark value 1202 exceeds gate value 1180 for chrome browserify home p95 domContentLoaded
Benchmark value 237 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 10 exceeds gate value 1.2 for chrome browserify home p95 initialActions
Benchmark value 988 exceeds gate value 940 for chrome browserify home p95 loadScripts
Benchmark value 2303 exceeds gate value 2192 for chrome webpack home mean uiStartup
Benchmark value 1845 exceeds gate value 1711 for chrome webpack home mean load
Benchmark value 1835 exceeds gate value 1704 for chrome webpack home mean domContentLoaded
Benchmark value 22 exceeds gate value 21 for chrome webpack home mean domInteractive
Benchmark value 44 exceeds gate value 40 for chrome webpack home mean backgroundConnect
Benchmark value 1823 exceeds gate value 1699 for chrome webpack home mean loadScripts
Benchmark value 2625 exceeds gate value 2454 for chrome webpack home p95 uiStartup
Benchmark value 2273 exceeds gate value 2030 for chrome webpack home p95 load
Benchmark value 2255 exceeds gate value 2005 for chrome webpack home p95 domContentLoaded
Benchmark value 67 exceeds gate value 57 for chrome webpack home p95 domInteractive
Benchmark value 274 exceeds gate value 90 for chrome webpack home p95 backgroundConnect
Benchmark value 11 exceeds gate value 7 for chrome webpack home p95 initialActions
Benchmark value 2163 exceeds gate value 1970 for chrome webpack home p95 loadScripts
Benchmark value 1496 exceeds gate value 1405 for firefox browserify home mean uiStartup
Benchmark value 1286 exceeds gate value 1245 for firefox browserify home mean load
Benchmark value 1285 exceeds gate value 1239 for firefox browserify home mean domContentLoaded
Benchmark value 28 exceeds gate value 25 for firefox browserify home mean backgroundConnect
Benchmark value 28 exceeds gate value 25 for firefox browserify home mean firstReactRender
Benchmark value 6 exceeds gate value 1 for firefox browserify home mean initialActions
Benchmark value 1264 exceeds gate value 1230 for firefox browserify home mean loadScripts
Benchmark value 1747 exceeds gate value 1660 for firefox browserify home p95 uiStartup
Benchmark value 232 exceeds gate value 195 for firefox browserify home p95 domInteractive
Benchmark value 32 exceeds gate value 24 for firefox browserify home p95 getState
Benchmark value 17 exceeds gate value 2 for firefox browserify home p95 initialActions
Benchmark value 37 exceeds gate value 27 for firefox browserify home p95 setupStore
Benchmark value 1639 exceeds gate value 1615 for firefox webpack home mean uiStartup
Benchmark value 34 exceeds gate value 26 for firefox webpack home mean backgroundConnect
Benchmark value 52 exceeds gate value 38 for firefox webpack home mean firstReactRender
Benchmark value 6 exceeds gate value 1 for firefox webpack home mean initialActions
Benchmark value 2011 exceeds gate value 1935 for firefox webpack home p95 uiStartup
Benchmark value 233 exceeds gate value 156 for firefox webpack home p95 domInteractive
Benchmark value 57 exceeds gate value 49 for firefox webpack home p95 backgroundConnect
Benchmark value 61 exceeds gate value 50 for firefox webpack home p95 firstReactRender
Benchmark value 21 exceeds gate value 2 for firefox webpack home p95 initialActions
Sum of mean exceeds: 1128ms | Sum of p95 exceeds: 1765.8ms
Sum of all benchmark exceeds: 2893.8ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

• background: 43 Bytes (0%)
• ui: 332 Bytes (0%)
• common: 15 Bytes (0%)

[metamaskbot]

Builds ready [c00ae22]

• builds: chrome, firefox
• builds (beta): chrome, firefox
• builds (flask): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• bundle size: Bundle Size Stats
• user-actions-benchmark: User Actions Stats
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5, 6, 7, 8
  • common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
  • ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
  • content-script: 0
  • offscreen: 0

UI Startup Metrics (1239 ± 69 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1239	1124	1684	69	1267	1353
			load	1063	976	1488	64	1093	1158
			domContentLoaded	1056	970	1480	63	1086	1152
			domInteractive	18	13	55	7	17	37
			firstPaint	574	85	1179	422	1051	1122
			backgroundConnect	221	209	245	6	224	231
			firstReactRender	20	14	49	6	20	34
			getState	11	4	75	9	13	27
			initialActions	2	0	20	3	2	11
			loadScripts	841	759	1259	62	870	941
			setupStore	7	4	17	2	7	12
	Webpack	Home	uiStartup	2356	1918	2823	168	2439	2685
			load	1879	1451	2356	174	1975	2212
			domContentLoaded	1869	1444	2337	169	1967	2199
			domInteractive	19	11	186	23	14	57
			firstPaint	173	61	1891	186	177	317
			backgroundConnect	43	10	303	65	34	279
			firstReactRender	153	90	351	55	180	273
			getState	20	4	248	46	12	35
			initialActions	7	2	193	19	6	15
			loadScripts	1862	1441	2327	164	1964	2180
			setupStore	15	6	238	23	14	26
Firefox	Browserify	Home	uiStartup	1395	1214	1802	108	1438	1590
			load	1209	1057	1392	76	1266	1360
			domContentLoaded	1209	1057	1391	76	1265	1360
			domInteractive	99	32	289	40	106	185
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	26	14	91	13	28	56
			firstReactRender	24	20	60	6	26	33
			getState	8	2	119	15	5	42
			initialActions	5	0	205	21	2	12
			loadScripts	1189	1038	1371	73	1242	1339
			setupStore	7	3	36	6	6	22
	Webpack	Home	uiStartup	1630	1427	2110	151	1734	1940
			load	1377	1208	1746	125	1467	1623
			domContentLoaded	1376	1208	1746	125	1466	1623
			domInteractive	92	32	278	48	93	233
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	33	18	92	13	33	65
			firstReactRender	53	41	74	6	57	63
			getState	9	3	38	7	12	23
			initialActions	4	0	22	5	3	15
			loadScripts	1351	1188	1714	123	1441	1600
			setupStore	10	5	73	11	9	26

Benchmark value 1240 exceeds gate value 1234 for chrome browserify home mean uiStartup
Benchmark value 221 exceeds gate value 10 for chrome browserify home mean backgroundConnect
Benchmark value 3 exceeds gate value 1 for chrome browserify home mean initialActions
Benchmark value 842 exceeds gate value 830 for chrome browserify home mean loadScripts
Benchmark value 232 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 11 exceeds gate value 1.2 for chrome browserify home p95 initialActions
Benchmark value 941 exceeds gate value 940 for chrome browserify home p95 loadScripts
Benchmark value 2357 exceeds gate value 2192 for chrome webpack home mean uiStartup
Benchmark value 1879 exceeds gate value 1711 for chrome webpack home mean load
Benchmark value 1869 exceeds gate value 1704 for chrome webpack home mean domContentLoaded
Benchmark value 44 exceeds gate value 40 for chrome webpack home mean backgroundConnect
Benchmark value 8 exceeds gate value 7 for chrome webpack home mean initialActions
Benchmark value 1862 exceeds gate value 1699 for chrome webpack home mean loadScripts
Benchmark value 2685 exceeds gate value 2454 for chrome webpack home p95 uiStartup
Benchmark value 2212 exceeds gate value 2030 for chrome webpack home p95 load
Benchmark value 2199 exceeds gate value 2005 for chrome webpack home p95 domContentLoaded
Benchmark value 58 exceeds gate value 57 for chrome webpack home p95 domInteractive
Benchmark value 279 exceeds gate value 90 for chrome webpack home p95 backgroundConnect
Benchmark value 15 exceeds gate value 7 for chrome webpack home p95 initialActions
Benchmark value 2180 exceeds gate value 1970 for chrome webpack home p95 loadScripts
Benchmark value 26 exceeds gate value 25 for firefox browserify home mean backgroundConnect
Benchmark value 5 exceeds gate value 1 for firefox browserify home mean initialActions
Benchmark value 42 exceeds gate value 24 for firefox browserify home p95 getState
Benchmark value 12 exceeds gate value 2 for firefox browserify home p95 initialActions
Benchmark value 1631 exceeds gate value 1615 for firefox webpack home mean uiStartup
Benchmark value 33 exceeds gate value 26 for firefox webpack home mean backgroundConnect
Benchmark value 53 exceeds gate value 38 for firefox webpack home mean firstReactRender
Benchmark value 4 exceeds gate value 1 for firefox webpack home mean initialActions
Benchmark value 1940 exceeds gate value 1935 for firefox webpack home p95 uiStartup
Benchmark value 233 exceeds gate value 156 for firefox webpack home p95 domInteractive
Benchmark value 65 exceeds gate value 49 for firefox webpack home p95 backgroundConnect
Benchmark value 63 exceeds gate value 50 for firefox webpack home p95 firstReactRender
Benchmark value 15 exceeds gate value 2 for firefox webpack home p95 initialActions
Sum of mean exceeds: 943ms | Sum of p95 exceeds: 1391.8ms
Sum of all benchmark exceeds: 2334.8ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

• background: 43 Bytes (0%)
• ui: 1.2 KiB (0.02%)
• common: 15 Bytes (0%)