fix: Fix misleading console warning #34816
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The policy override has been updated to correct the identifier for `@ethersproject/random`. The ID changed to start with `ethers`, which resulted in the override not being applied correctly. This resulted in this console message every time the wallet started: `WARNING: Missing strong random number source`. The warning should no longer appear upon startup. Fixes #21926
Gudahtt
force-pushed
the
fix-misleading-console-warning
branch
from
ec0c453 to
f07f058
Compare
Member
Author
|
@metamaskbot update-policies |
Collaborator
✨ Files requiring CODEOWNER review ✨🧩 @MetaMask/extension-devs (5 files, +9 -17)
📜 @MetaMask/policy-reviewers (5 files, +9 -17)
Tip Follow the policy review process outlined in the LavaMoat Policy Review Process doc before expecting an approval from Policy Reviewers. 🔗 @MetaMask/supply-chain (5 files, +9 -17)
|
Collaborator
|
Policies updated. 🧠 Learn how: https://lavamoat.github.io/guides/policy-diff/#what-to-look-for-when-reviewing-a-policy-diff |
Collaborator
Builds ready [ae29561]
UI Startup Metrics (1149 ± 63 ms)
Benchmark value 3 exceeds gate value 1 for chrome browserify home mean initialActions Benchmark value 233 exceeds gate value 18 for chrome browserify home p95 backgroundConnect Benchmark value 15 exceeds gate value 1.2 for chrome browserify home p95 initialActions Benchmark value 2233 exceeds gate value 2192 for chrome webpack home mean uiStartup Benchmark value 2573 exceeds gate value 2454 for chrome webpack home p95 uiStartup Benchmark value 400 exceeds gate value 370 for chrome webpack home p95 firstReactRender Benchmark value 9 exceeds gate value 7 for chrome webpack home p95 initialActions Benchmark value 26 exceeds gate value 25 for firefox browserify home mean backgroundConnect Benchmark value 4 exceeds gate value 1 for firefox browserify home mean initialActions Benchmark value 210 exceeds gate value 195 for firefox browserify home p95 domInteractive Benchmark value 40 exceeds gate value 24 for firefox browserify home p95 getState Benchmark value 20 exceeds gate value 2 for firefox browserify home p95 initialActions Benchmark value 29 exceeds gate value 27 for firefox browserify home p95 setupStore Benchmark value 1634 exceeds gate value 1615 for firefox webpack home mean uiStartup Benchmark value 34 exceeds gate value 26 for firefox webpack home mean backgroundConnect Benchmark value 55 exceeds gate value 38 for firefox webpack home mean firstReactRender Benchmark value 5 exceeds gate value 1 for firefox webpack home mean initialActions Benchmark value 1968 exceeds gate value 1935 for firefox webpack home p95 uiStartup Benchmark value 1662 exceeds gate value 1660 for firefox webpack home p95 load Benchmark value 1662 exceeds gate value 1660 for firefox webpack home p95 domContentLoaded Benchmark value 262 exceeds gate value 156 for firefox webpack home p95 domInteractive Benchmark value 87 exceeds gate value 49 for firefox webpack home p95 backgroundConnect Benchmark value 63 exceeds gate value 50 for firefox webpack home p95 firstReactRender Benchmark value 14 exceeds gate value 2 for firefox webpack home p95 initialActions Sum of mean exceeds: 301ms | Sum of p95 exceeds: 636.8ms Sum of all benchmark exceeds: 937.8ms Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
davidmurdoch
approved these changes
Aug 1, 2025
itsyoboieltr
approved these changes
Aug 1, 2025
github-project-automation
bot
moved this from Needs dev review
to Review finalised - Ready to be merged
in PR review queue
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-project-automation
bot
moved this from Review finalised - Ready to be merged
to Merged, Closed or Archived
in PR review queue
metamaskbot
added
the
release-13.2.0
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The policy override has been updated to correct the identifier for
@ethersproject/random. The ID changed to start withethers, which resulted in the override not being applied correctly. This resulted in this console message every time the wallet started:WARNING: Missing strong random number source.The warning should no longer appear upon startup.
Changelog
CHANGELOG entry: Remove misleading console warning
Related issues
Fixes #21926
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist