Skip to content

Conversation

@seaona
Copy link
Member

@seaona seaona commented Aug 5, 2025

Description

This test uses an anti-pattern that we should avoid.
See more context on this issue here: #19870

There's a work being done to avoid this as a lint rule, but it hasn't been finished yet

Open in GitHub Codespaces

Changelog

CHANGELOG entry:

Related issues

Fixes: #34798

Manual testing steps

  1. yarn test:e2e:single --browser chrome test/e2e/tests/multichain/aggregated-balances.spec.ts --leave-running=true

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 5, 2025

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-qa QA team label Aug 5, 2025
@seaona seaona marked this pull request as ready for review August 5, 2025 08:20
@seaona seaona requested a review from a team as a code owner August 5, 2025 08:20
@metamaskbot
Copy link
Collaborator

✨ Files requiring CODEOWNER review ✨

👨‍🔧 @MetaMask/qa (1 files, +4 -8)
  • 📁 test/
    • 📁 e2e/
      • 📁 page-objects/
        • 📁 pages/
          • 📁 send/
            • 📄 send-token-page.ts +4 -8

@seaona seaona self-assigned this Aug 5, 2025
@seaona seaona added flaky tests no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed labels Aug 5, 2025
@metamaskbot
Copy link
Collaborator

Builds ready [58d379c]
UI Startup Metrics (1165 ± 61 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1165103314086111951303
load98388012095910131092
domContentLoaded97587512005910061082
domInteractive17144051732
firstPaint60314712083959851052
backgroundConnect2172022397220231
firstReactRender20145062033
getState1043771328
initialActions506612333
loadScripts76666498158797879
setupStore74152811
WebpackHomeuiStartup21661629261321622992495
load16251198195217617111865
domContentLoaded16181194194817517041849
domInteractive171170141463
firstPaint1616144761183272
backgroundConnect24125482938
firstReactRender21189403113371391
getState183319451039
initialActions52314515
loadScripts16141188193817317011840
setupStore3073096814268
FirefoxBrowserifyHomeuiStartup13371137176312413991639
load114899914859412071341
domContentLoaded114899914849412071341
domInteractive1013432852107220
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect271596152766
firstReactRender25205882450
getState8216017625
initialActions30335210
loadScripts112698414659311891309
setupStore83529632
WebpackHomeuiStartup15821388197713616521873
load13211147165511113971524
domContentLoaded13211147165511113971524
domInteractive953026844101211
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect301789153165
firstReactRender52427975568
getState83447724
initialActions6113316328
loadScripts12961131163311313751502
setupStore94497825
Benchmark value 217 exceeds gate value 10 for chrome browserify home mean backgroundConnect
Benchmark value 6 exceeds gate value 1 for chrome browserify home mean initialActions
Benchmark value 231 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 33 exceeds gate value 1.2 for chrome browserify home p95 initialActions
Benchmark value 2495 exceeds gate value 2454 for chrome webpack home p95 uiStartup
Benchmark value 63 exceeds gate value 57 for chrome webpack home p95 domInteractive
Benchmark value 391 exceeds gate value 370 for chrome webpack home p95 firstReactRender
Benchmark value 15 exceeds gate value 7 for chrome webpack home p95 initialActions
Benchmark value 268 exceeds gate value 65 for chrome webpack home p95 setupStore
Benchmark value 27 exceeds gate value 25 for firefox browserify home mean backgroundConnect
Benchmark value 3 exceeds gate value 1 for firefox browserify home mean initialActions
Benchmark value 220 exceeds gate value 195 for firefox browserify home p95 domInteractive
Benchmark value 25 exceeds gate value 24 for firefox browserify home p95 getState
Benchmark value 10 exceeds gate value 2 for firefox browserify home p95 initialActions
Benchmark value 32 exceeds gate value 27 for firefox browserify home p95 setupStore
Benchmark value 31 exceeds gate value 26 for firefox webpack home mean backgroundConnect
Benchmark value 53 exceeds gate value 38 for firefox webpack home mean firstReactRender
Benchmark value 7 exceeds gate value 1 for firefox webpack home mean initialActions
Benchmark value 211 exceeds gate value 156 for firefox webpack home p95 domInteractive
Benchmark value 65 exceeds gate value 49 for firefox webpack home p95 backgroundConnect
Benchmark value 68 exceeds gate value 50 for firefox webpack home p95 firstReactRender
Benchmark value 28 exceeds gate value 2 for firefox webpack home p95 initialActions
Sum of mean exceeds: 242ms | Sum of p95 exceeds: 677.8ms
Sum of all benchmark exceeds: 919.8ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 43 Bytes (0%)
  • ui: 0 Bytes (0%)
  • common: 10 Bytes (0%)

@seaona seaona enabled auto-merge August 5, 2025 08:47
@seaona seaona added this pull request to the merge queue Aug 5, 2025
Merged via the queue into main with commit dae3100 Aug 5, 2025
307 of 312 checks passed
@seaona seaona deleted the flaky-aggregated-balances branch August 5, 2025 09:26
@github-actions github-actions bot locked and limited conversation to collaborators Aug 5, 2025
@gauthierpetetin gauthierpetetin added release-13.2.0 Issue or pull request that will be included in release 13.2.0 and removed release-13.3.0 labels Aug 12, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

flaky tests no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed release-13.2.0 Issue or pull request that will be included in release 13.2.0 team-qa QA team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Flaky test: Multichain Aggregated Balances shows correct aggregated balance when "Current Network" is selected

6 participants