-
Notifications
You must be signed in to change notification settings - Fork 5.5k
fix: flaky test Multichain Aggregated Balances shows correct aggregated balance when "Current Network" is selected
#34856
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
9 tasks
Collaborator
✨ Files requiring CODEOWNER review ✨👨🔧 @MetaMask/qa (1 files, +4 -8)
|
Collaborator
Builds ready [58d379c]
UI Startup Metrics (1165 ± 61 ms)
Benchmark value 6 exceeds gate value 1 for chrome browserify home mean initialActions Benchmark value 231 exceeds gate value 18 for chrome browserify home p95 backgroundConnect Benchmark value 33 exceeds gate value 1.2 for chrome browserify home p95 initialActions Benchmark value 2495 exceeds gate value 2454 for chrome webpack home p95 uiStartup Benchmark value 63 exceeds gate value 57 for chrome webpack home p95 domInteractive Benchmark value 391 exceeds gate value 370 for chrome webpack home p95 firstReactRender Benchmark value 15 exceeds gate value 7 for chrome webpack home p95 initialActions Benchmark value 268 exceeds gate value 65 for chrome webpack home p95 setupStore Benchmark value 27 exceeds gate value 25 for firefox browserify home mean backgroundConnect Benchmark value 3 exceeds gate value 1 for firefox browserify home mean initialActions Benchmark value 220 exceeds gate value 195 for firefox browserify home p95 domInteractive Benchmark value 25 exceeds gate value 24 for firefox browserify home p95 getState Benchmark value 10 exceeds gate value 2 for firefox browserify home p95 initialActions Benchmark value 32 exceeds gate value 27 for firefox browserify home p95 setupStore Benchmark value 31 exceeds gate value 26 for firefox webpack home mean backgroundConnect Benchmark value 53 exceeds gate value 38 for firefox webpack home mean firstReactRender Benchmark value 7 exceeds gate value 1 for firefox webpack home mean initialActions Benchmark value 211 exceeds gate value 156 for firefox webpack home p95 domInteractive Benchmark value 65 exceeds gate value 49 for firefox webpack home p95 backgroundConnect Benchmark value 68 exceeds gate value 50 for firefox webpack home p95 firstReactRender Benchmark value 28 exceeds gate value 2 for firefox webpack home p95 initialActions Sum of mean exceeds: 242ms | Sum of p95 exceeds: 677.8ms Sum of all benchmark exceeds: 919.8ms Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
jvbriones
approved these changes
Aug 5, 2025
pnarayanaswamy
approved these changes
Aug 5, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
flaky tests
no-changelog
no-changelog Indicates no external facing user changes, therefore no changelog documentation needed
release-13.2.0
Issue or pull request that will be included in release 13.2.0
team-qa
QA team
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This test uses an anti-pattern that we should avoid.
See more context on this issue here: #19870
There's a work being done to avoid this as a lint rule, but it hasn't been finished yet
Changelog
CHANGELOG entry:
Related issues
Fixes: #34798
Manual testing steps
yarn test:e2e:single --browser chrome test/e2e/tests/multichain/aggregated-balances.spec.ts --leave-running=trueScreenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist