fix(snaps): Catch handleSnapRequest error in SnapInterfaceContext

[GuillaumeRx]

Description

Handle errors thrown by handleSnapRequest in SnapInterfaceContext to avoid unhandled errors caught by Sentry.

Changelog

CHANGELOG entry:null

Related issues

Fixes: #22286

Manual testing steps

1. Have a test snap that triggers an error when clicking a button in a home-page
2. Click the button
3. Look at the UI console to ensure the good error is thrown

Screenshots/Recordings

Before

After

Pre-merge author checklist

• I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[metamaskbot]

✨ Files requiring CODEOWNER review ✨

👨‍🔧 @MetaMask/core-platform (1 files, +8 -1)

• 📁 ui/
  • 📁 contexts/
    • 📁 snaps/
      • 📄 snap-interface.tsx +8 -1

[FrederikBolding]

We should port this change to mobile too

[metamaskbot]

Builds ready [05f0470]

• builds: chrome, firefox
• builds (beta): chrome, firefox
• builds (flask): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• bundle size: Bundle Size Stats
• user-actions-benchmark: User Actions Stats
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5, 6, 7, 8
  • common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
  • ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
  • content-script: 0
  • offscreen: 0

UI Startup Metrics (1137 ± 73 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1137	1024	1476	73	1165	1274
			load	966	855	1271	70	995	1100
			domContentLoaded	958	846	1264	71	989	1089
			domInteractive	17	13	72	7	16	25
			firstPaint	563	72	1097	386	972	1039
			backgroundConnect	215	201	249	9	217	231
			firstReactRender	20	15	44	5	21	36
			getState	10	4	60	8	14	26
			initialActions	3	0	52	7	2	14
			loadScripts	751	631	1044	70	780	881
			setupStore	6	4	22	2	7	10
	Webpack	Home	uiStartup	2248	1658	2676	234	2403	2632
			load	1674	1204	2016	200	1792	1948
			domContentLoaded	1666	1200	2002	199	1787	1937
			domInteractive	19	12	99	18	14	83
			firstPaint	166	66	453	69	194	291
			backgroundConnect	29	12	234	23	33	47
			firstReactRender	212	94	421	109	352	395
			getState	20	4	277	45	12	46
			initialActions	8	2	297	29	6	11
			loadScripts	1662	1198	1999	197	1784	1926
			setupStore	31	7	291	66	16	263
Firefox	Browserify	Home	uiStartup	1313	1150	1773	117	1372	1556
			load	1134	983	1463	91	1187	1316
			domContentLoaded	1134	983	1462	91	1186	1316
			domInteractive	98	34	288	47	103	221
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	25	15	112	14	27	43
			firstReactRender	25	19	59	9	24	54
			getState	6	2	41	6	5	14
			initialActions	4	0	57	9	2	19
			loadScripts	1113	968	1446	86	1166	1293
			setupStore	9	3	183	19	5	24
	Webpack	Home	uiStartup	1591	1364	2269	151	1665	1908
			load	1325	1152	1710	112	1387	1539
			domContentLoaded	1325	1152	1710	112	1387	1538
			domInteractive	94	31	260	44	100	230
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	33	18	164	23	33	92
			firstReactRender	51	43	76	6	55	60
			getState	9	2	56	9	8	26
			initialActions	5	1	127	13	4	17
			loadScripts	1298	1133	1597	106	1366	1503
			setupStore	15	4	230	32	9	49

Benchmark value 215 exceeds gate value 10 for chrome browserify home mean backgroundConnect
Benchmark value 4 exceeds gate value 1 for chrome browserify home mean initialActions
Benchmark value 232 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 14 exceeds gate value 1.2 for chrome browserify home p95 initialActions
Benchmark value 2248 exceeds gate value 2192 for chrome webpack home mean uiStartup
Benchmark value 9 exceeds gate value 7 for chrome webpack home mean initialActions
Benchmark value 2632 exceeds gate value 2454 for chrome webpack home p95 uiStartup
Benchmark value 83 exceeds gate value 57 for chrome webpack home p95 domInteractive
Benchmark value 395 exceeds gate value 370 for chrome webpack home p95 firstReactRender
Benchmark value 11 exceeds gate value 7 for chrome webpack home p95 initialActions
Benchmark value 263 exceeds gate value 65 for chrome webpack home p95 setupStore
Benchmark value 26 exceeds gate value 25 for firefox browserify home mean backgroundConnect
Benchmark value 26 exceeds gate value 25 for firefox browserify home mean firstReactRender
Benchmark value 4 exceeds gate value 1 for firefox browserify home mean initialActions
Benchmark value 221 exceeds gate value 195 for firefox browserify home p95 domInteractive
Benchmark value 19 exceeds gate value 2 for firefox browserify home p95 initialActions
Benchmark value 34 exceeds gate value 26 for firefox webpack home mean backgroundConnect
Benchmark value 52 exceeds gate value 38 for firefox webpack home mean firstReactRender
Benchmark value 6 exceeds gate value 1 for firefox webpack home mean initialActions
Benchmark value 16 exceeds gate value 13 for firefox webpack home mean setupStore
Benchmark value 230 exceeds gate value 156 for firefox webpack home p95 domInteractive
Benchmark value 92 exceeds gate value 49 for firefox webpack home p95 backgroundConnect
Benchmark value 60 exceeds gate value 50 for firefox webpack home p95 firstReactRender
Benchmark value 17 exceeds gate value 2 for firefox webpack home p95 initialActions
Benchmark value 49 exceeds gate value 28 for firefox webpack home p95 setupStore
Sum of mean exceeds: 301ms | Sum of p95 exceeds: 863.8ms
Sum of all benchmark exceeds: 1164.8ms

Bundle size diffs [🚀 Bundle size reduced!]

• background: -309.44 KiB (-5.65%)
• ui: -472.73 KiB (-6.36%)
• common: -1.1 MiB (-13.16%)