-
Notifications
You must be signed in to change notification settings - Fork 5.5k
test: Force exit after running E2E test #34966
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Builds ready [0f587cf]
UI Startup Metrics (1175 ± 60 ms)
Benchmark value 4 exceeds gate value 1 for chrome browserify home mean initialActions Benchmark value 248 exceeds gate value 18 for chrome browserify home p95 backgroundConnect Benchmark value 11 exceeds gate value 1.2 for chrome browserify home p95 initialActions Benchmark value 2223 exceeds gate value 2192 for chrome webpack home mean uiStartup Benchmark value 44 exceeds gate value 29 for chrome webpack home mean getState Benchmark value 2556 exceeds gate value 2454 for chrome webpack home p95 uiStartup Benchmark value 401 exceeds gate value 370 for chrome webpack home p95 firstReactRender Benchmark value 296 exceeds gate value 195 for chrome webpack home p95 getState Benchmark value 10 exceeds gate value 7 for chrome webpack home p95 initialActions Benchmark value 28 exceeds gate value 25 for firefox browserify home mean backgroundConnect Benchmark value 4 exceeds gate value 1 for firefox browserify home mean initialActions Benchmark value 224 exceeds gate value 195 for firefox browserify home p95 domInteractive Benchmark value 42 exceeds gate value 24 for firefox browserify home p95 getState Benchmark value 13 exceeds gate value 2 for firefox browserify home p95 initialActions Benchmark value 32 exceeds gate value 27 for firefox browserify home p95 setupStore Benchmark value 33 exceeds gate value 26 for firefox webpack home mean backgroundConnect Benchmark value 53 exceeds gate value 38 for firefox webpack home mean firstReactRender Benchmark value 5 exceeds gate value 1 for firefox webpack home mean initialActions Benchmark value 221 exceeds gate value 156 for firefox webpack home p95 domInteractive Benchmark value 75 exceeds gate value 49 for firefox webpack home p95 backgroundConnect Benchmark value 63 exceeds gate value 50 for firefox webpack home p95 firstReactRender Benchmark value 46 exceeds gate value 32 for firefox webpack home p95 getState Benchmark value 23 exceeds gate value 2 for firefox webpack home p95 initialActions Benchmark value 36 exceeds gate value 28 for firefox webpack home p95 setupStore Sum of mean exceeds: 293ms | Sum of p95 exceeds: 686.8ms Sum of all benchmark exceeds: 979.8ms Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Collaborator
Builds ready [bc0d64c]
UI Startup Metrics (1165 ± 60 ms)
Benchmark value 5 exceeds gate value 1 for chrome browserify home mean initialActions Benchmark value 238 exceeds gate value 18 for chrome browserify home p95 backgroundConnect Benchmark value 14 exceeds gate value 1.2 for chrome browserify home p95 initialActions Benchmark value 2199 exceeds gate value 2192 for chrome webpack home mean uiStartup Benchmark value 2519 exceeds gate value 2454 for chrome webpack home p95 uiStartup Benchmark value 386 exceeds gate value 370 for chrome webpack home p95 firstReactRender Benchmark value 281 exceeds gate value 195 for chrome webpack home p95 getState Benchmark value 11 exceeds gate value 7 for chrome webpack home p95 initialActions Benchmark value 29 exceeds gate value 25 for firefox browserify home mean backgroundConnect Benchmark value 5 exceeds gate value 1 for firefox browserify home mean initialActions Benchmark value 229 exceeds gate value 195 for firefox browserify home p95 domInteractive Benchmark value 13 exceeds gate value 2 for firefox browserify home p95 initialActions Benchmark value 33 exceeds gate value 26 for firefox webpack home mean backgroundConnect Benchmark value 53 exceeds gate value 38 for firefox webpack home mean firstReactRender Benchmark value 5 exceeds gate value 1 for firefox webpack home mean initialActions Benchmark value 260 exceeds gate value 156 for firefox webpack home p95 domInteractive Benchmark value 68 exceeds gate value 49 for firefox webpack home p95 backgroundConnect Benchmark value 62 exceeds gate value 50 for firefox webpack home p95 firstReactRender Benchmark value 16 exceeds gate value 2 for firefox webpack home p95 initialActions Benchmark value 45 exceeds gate value 28 for firefox webpack home p95 setupStore Sum of mean exceeds: 253ms | Sum of p95 exceeds: 614.8ms Sum of all benchmark exceeds: 867.8ms Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Collaborator
Builds ready [f0804cb]
UI Startup Metrics (1203 ± 80 ms)
Benchmark value 6 exceeds gate value 1 for chrome browserify home mean initialActions Benchmark value 244 exceeds gate value 18 for chrome browserify home p95 backgroundConnect Benchmark value 18 exceeds gate value 1.2 for chrome browserify home p95 initialActions Benchmark value 2343 exceeds gate value 2192 for chrome webpack home mean uiStartup Benchmark value 1751 exceeds gate value 1711 for chrome webpack home mean load Benchmark value 1743 exceeds gate value 1704 for chrome webpack home mean domContentLoaded Benchmark value 39 exceeds gate value 29 for chrome webpack home mean getState Benchmark value 8 exceeds gate value 7 for chrome webpack home mean initialActions Benchmark value 1739 exceeds gate value 1699 for chrome webpack home mean loadScripts Benchmark value 2648 exceeds gate value 2454 for chrome webpack home p95 uiStartup Benchmark value 392 exceeds gate value 370 for chrome webpack home p95 firstReactRender Benchmark value 287 exceeds gate value 195 for chrome webpack home p95 getState Benchmark value 10 exceeds gate value 7 for chrome webpack home p95 initialActions Benchmark value 30 exceeds gate value 25 for firefox browserify home mean backgroundConnect Benchmark value 26 exceeds gate value 25 for firefox browserify home mean firstReactRender Benchmark value 3 exceeds gate value 1 for firefox browserify home mean initialActions Benchmark value 11 exceeds gate value 9 for firefox browserify home mean setupStore Benchmark value 204 exceeds gate value 195 for firefox browserify home p95 domInteractive Benchmark value 26 exceeds gate value 24 for firefox browserify home p95 getState Benchmark value 6 exceeds gate value 2 for firefox browserify home p95 initialActions Benchmark value 38 exceeds gate value 27 for firefox browserify home p95 setupStore Benchmark value 101 exceeds gate value 100 for firefox webpack home mean domInteractive Benchmark value 33 exceeds gate value 26 for firefox webpack home mean backgroundConnect Benchmark value 54 exceeds gate value 38 for firefox webpack home mean firstReactRender Benchmark value 3 exceeds gate value 1 for firefox webpack home mean initialActions Benchmark value 260 exceeds gate value 156 for firefox webpack home p95 domInteractive Benchmark value 70 exceeds gate value 49 for firefox webpack home p95 backgroundConnect Benchmark value 67 exceeds gate value 50 for firefox webpack home p95 firstReactRender Benchmark value 37 exceeds gate value 32 for firefox webpack home p95 getState Benchmark value 10 exceeds gate value 2 for firefox webpack home p95 initialActions Benchmark value 37 exceeds gate value 28 for firefox webpack home p95 setupStore Sum of mean exceeds: 536ms | Sum of p95 exceeds: 743.8ms Sum of all benchmark exceeds: 1279.8ms Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
f0804cb to
489c96a
Compare
Collaborator
Builds ready [489c96a]
UI Startup Metrics (1167 ± 56 ms)
Benchmark value 3 exceeds gate value 1 for chrome browserify home mean initialActions Benchmark value 236 exceeds gate value 18 for chrome browserify home p95 backgroundConnect Benchmark value 10 exceeds gate value 1.2 for chrome browserify home p95 initialActions Benchmark value 31 exceeds gate value 29 for chrome webpack home mean getState Benchmark value 2477 exceeds gate value 2454 for chrome webpack home p95 uiStartup Benchmark value 346 exceeds gate value 334 for chrome webpack home p95 firstPaint Benchmark value 394 exceeds gate value 370 for chrome webpack home p95 firstReactRender Benchmark value 282 exceeds gate value 195 for chrome webpack home p95 getState Benchmark value 10 exceeds gate value 7 for chrome webpack home p95 initialActions Benchmark value 30 exceeds gate value 25 for firefox browserify home mean backgroundConnect Benchmark value 3 exceeds gate value 1 for firefox browserify home mean initialActions Benchmark value 14 exceeds gate value 9 for firefox browserify home mean setupStore Benchmark value 258 exceeds gate value 195 for firefox browserify home p95 domInteractive Benchmark value 35 exceeds gate value 24 for firefox browserify home p95 getState Benchmark value 14 exceeds gate value 2 for firefox browserify home p95 initialActions Benchmark value 37 exceeds gate value 27 for firefox browserify home p95 setupStore Benchmark value 1632 exceeds gate value 1615 for firefox webpack home mean uiStartup Benchmark value 102 exceeds gate value 100 for firefox webpack home mean domInteractive Benchmark value 32 exceeds gate value 26 for firefox webpack home mean backgroundConnect Benchmark value 59 exceeds gate value 38 for firefox webpack home mean firstReactRender Benchmark value 5 exceeds gate value 1 for firefox webpack home mean initialActions Benchmark value 1943 exceeds gate value 1935 for firefox webpack home p95 uiStartup Benchmark value 260 exceeds gate value 156 for firefox webpack home p95 domInteractive Benchmark value 72 exceeds gate value 50 for firefox webpack home p95 firstReactRender Benchmark value 17 exceeds gate value 2 for firefox webpack home p95 initialActions Sum of mean exceeds: 274ms | Sum of p95 exceeds: 620.8ms Sum of all benchmark exceeds: 894.8ms Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
seaona
approved these changes
Aug 11, 2025
Member
seaona
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
jvbriones
approved these changes
Aug 11, 2025
Collaborator
Builds ready [8859319]
UI Startup Metrics (1227 ± 65 ms)
Benchmark value 3 exceeds gate value 1 for chrome browserify home mean initialActions Benchmark value 243 exceeds gate value 18 for chrome browserify home p95 backgroundConnect Benchmark value 34 exceeds gate value 33 for chrome browserify home p95 getState Benchmark value 8 exceeds gate value 1.2 for chrome browserify home p95 initialActions Benchmark value 2275 exceeds gate value 2192 for chrome webpack home mean uiStartup Benchmark value 39 exceeds gate value 29 for chrome webpack home mean getState Benchmark value 2614 exceeds gate value 2454 for chrome webpack home p95 uiStartup Benchmark value 394 exceeds gate value 370 for chrome webpack home p95 firstReactRender Benchmark value 282 exceeds gate value 195 for chrome webpack home p95 getState Benchmark value 9 exceeds gate value 7 for chrome webpack home p95 initialActions Benchmark value 1408 exceeds gate value 1405 for firefox browserify home mean uiStartup Benchmark value 34 exceeds gate value 25 for firefox browserify home mean backgroundConnect Benchmark value 6 exceeds gate value 1 for firefox browserify home mean initialActions Benchmark value 220 exceeds gate value 195 for firefox browserify home p95 domInteractive Benchmark value 72 exceeds gate value 70 for firefox browserify home p95 backgroundConnect Benchmark value 34 exceeds gate value 24 for firefox browserify home p95 getState Benchmark value 9 exceeds gate value 2 for firefox browserify home p95 initialActions Benchmark value 37 exceeds gate value 27 for firefox browserify home p95 setupStore Benchmark value 1637 exceeds gate value 1615 for firefox webpack home mean uiStartup Benchmark value 103 exceeds gate value 100 for firefox webpack home mean domInteractive Benchmark value 30 exceeds gate value 26 for firefox webpack home mean backgroundConnect Benchmark value 58 exceeds gate value 38 for firefox webpack home mean firstReactRender Benchmark value 7 exceeds gate value 1 for firefox webpack home mean initialActions Benchmark value 258 exceeds gate value 156 for firefox webpack home p95 domInteractive Benchmark value 70 exceeds gate value 50 for firefox webpack home p95 firstReactRender Benchmark value 16 exceeds gate value 2 for firefox webpack home p95 initialActions Sum of mean exceeds: 382ms | Sum of p95 exceeds: 695.8ms Sum of all benchmark exceeds: 1077.8ms Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Collaborator
|
Missing release label release-13.1.0 on PR. Adding release label release-13.1.0 on PR and removing other release labels(release-13.2.0), as PR was cherry-picked in branch 13.1.0. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
INVALID-PR-TEMPLATE
PR's body doesn't match template
release-13.1.0
Issue or pull request that will be included in release 13.1.0
team-snaps-platform-deprecated
DEPRECATED: please use "team-core-platform" instead (or "team-new-networks" for Solana snap issues)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Force exit after running an E2E test in an attempt to improve CI stability.
Fixes: #34962