cherry-pick: chore: bump institutional snap #35056
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
<!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** Bumps institutional snap, to fix an issue with custodians who have cycling refresh tokens (see [snap PR](MetaMask/snap-institutional-wallet#70)) [](https://codespaces.new/MetaMask/metamask-extension/pull/35053?quickstart=1) ## **Changelog** CHANGELOG entry: null ## **Related issues** N/A ## **Manual testing steps** N/A ## **Screenshots/Recordings** N/A ### **Before** N/A ### **After** N/A ## **Pre-merge author checklist** - [X] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [X] I've completed the PR template to the best of my ability - [X] I’ve included tests if applicable - [X] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [X] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
shane-t
changed the title
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Collaborator
Builds ready [80add09]
UI Startup Metrics (1151 ± 65 ms)
Benchmark value 3 exceeds gate value 1 for chrome browserify home mean initialActions Benchmark value 228 exceeds gate value 18 for chrome browserify home p95 backgroundConnect Benchmark value 6 exceeds gate value 1.2 for chrome browserify home p95 initialActions Benchmark value 2379 exceeds gate value 2192 for chrome webpack home mean uiStartup Benchmark value 1785 exceeds gate value 1711 for chrome webpack home mean load Benchmark value 1777 exceeds gate value 1704 for chrome webpack home mean domContentLoaded Benchmark value 22 exceeds gate value 21 for chrome webpack home mean domInteractive Benchmark value 46 exceeds gate value 29 for chrome webpack home mean getState Benchmark value 11 exceeds gate value 7 for chrome webpack home mean initialActions Benchmark value 1773 exceeds gate value 1699 for chrome webpack home mean loadScripts Benchmark value 2666 exceeds gate value 2454 for chrome webpack home p95 uiStartup Benchmark value 86 exceeds gate value 57 for chrome webpack home p95 domInteractive Benchmark value 395 exceeds gate value 370 for chrome webpack home p95 firstReactRender Benchmark value 275 exceeds gate value 195 for chrome webpack home p95 getState Benchmark value 15 exceeds gate value 7 for chrome webpack home p95 initialActions Benchmark value 1971 exceeds gate value 1970 for chrome webpack home p95 loadScripts Benchmark value 28 exceeds gate value 25 for firefox browserify home mean backgroundConnect Benchmark value 5 exceeds gate value 1 for firefox browserify home mean initialActions Benchmark value 10 exceeds gate value 9 for firefox browserify home mean setupStore Benchmark value 207 exceeds gate value 195 for firefox browserify home p95 domInteractive Benchmark value 30 exceeds gate value 24 for firefox browserify home p95 getState Benchmark value 16 exceeds gate value 2 for firefox browserify home p95 initialActions Benchmark value 33 exceeds gate value 27 for firefox browserify home p95 setupStore Benchmark value 29 exceeds gate value 26 for firefox webpack home mean backgroundConnect Benchmark value 50 exceeds gate value 38 for firefox webpack home mean firstReactRender Benchmark value 4 exceeds gate value 1 for firefox webpack home mean initialActions Benchmark value 1937 exceeds gate value 1935 for firefox webpack home p95 uiStartup Benchmark value 229 exceeds gate value 156 for firefox webpack home p95 domInteractive Benchmark value 61 exceeds gate value 50 for firefox webpack home p95 firstReactRender Benchmark value 39 exceeds gate value 32 for firefox webpack home p95 getState Benchmark value 13 exceeds gate value 2 for firefox webpack home p95 initialActions Benchmark value 31 exceeds gate value 28 for firefox webpack home p95 setupStore Sum of mean exceeds: 663ms | Sum of p95 exceeds: 714.8ms Sum of all benchmark exceeds: 1377.8ms |
gauthierpetetin
deleted the
shane-t/cherry-pick-13.1.0/insto-snap-1.3.4
branch
metamaskbot
added
the
release-13.1.0
Collaborator
|
No release label on PR. Adding release label release-13.1.0 on PR, as PR was cherry-picked in branch 13.1.0. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
](https://codespaces.new/MetaMask/metamask-extension/pull/35053?quickstart=1){kind=link}
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Bumps institutional snap, to fix an issue with custodians who have cycling refresh tokens (see snap PR)
Changelog
CHANGELOG entry: null
Related issues
N/A
Manual testing steps
N/A
Screenshots/Recordings
N/A
Before
N/A
After
N/A
Pre-merge author checklist
Pre-merge reviewer checklist