release(runway): cherry-pick fix: show effective gas in swaps QuoteCard #35059
+275
−77
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
<!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> Changes - patch bridge-controller and bridge-status-controller so that the effective gas fees for quotes are used for quote metadata calculations - show the `totalNetworkFee` instead of the `totalMaxNetworkFee` in the QuoteCard for accuracy - fix the token alert scanning payload for optimism (typo) <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> [](https://codespaces.new/MetaMask/metamask-extension/pull/35038?quickstart=1) <!-- If this PR is not End-User-Facing and should not show up in the CHANGELOG, you can choose to either: 1. Write `CHANGELOG entry: null` 2. Label with `no-changelog` If this PR is End-User-Facing, please write a short User-Facing description in the past tense like: `CHANGELOG entry: Added a new tab for users to see their NFTs` `CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker` (This helps the Release Engineer do their job more quickly and accurately) --> CHANGELOG entry: Fixes: #35006 1. Get an EVM swap quote 2. The quoted network fee should be close to the swap fees on mobile or other aggregators 3. Get an EVM bridge quote 2. The quoted network fee should be close to the fees from other aggregators 3. Get a solana swap quote 2. The quoted network fee should be close to the fees from other aggregators <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> <!-- [screenshots/recordings] --> <!-- [screenshots/recordings] --> - [ ] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
metamaskbot
added
the
team-runway-bot-deprecated
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Collaborator
✨ Files requiring CODEOWNER review ✨🧩 @MetaMask/extension-devs (4 files, +108 -12)
📜 @MetaMask/policy-reviewers (4 files, +108 -12)
Tip Follow the policy review process outlined in the LavaMoat Policy Review Process doc before expecting an approval from Policy Reviewers. 🔗 @MetaMask/supply-chain (4 files, +108 -12)
🔄 @MetaMask/swaps-engineers (6 files, +72 -24)
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Collaborator
Builds ready [4bd6992]
UI Startup Metrics (1178 ± 74 ms)
Benchmark value 3 exceeds gate value 1 for chrome browserify home mean initialActions Benchmark value 237 exceeds gate value 18 for chrome browserify home p95 backgroundConnect Benchmark value 6 exceeds gate value 1.2 for chrome browserify home p95 initialActions Benchmark value 2241 exceeds gate value 2192 for chrome webpack home mean uiStartup Benchmark value 36 exceeds gate value 29 for chrome webpack home mean getState Benchmark value 2584 exceeds gate value 2454 for chrome webpack home p95 uiStartup Benchmark value 74 exceeds gate value 57 for chrome webpack home p95 domInteractive Benchmark value 350 exceeds gate value 334 for chrome webpack home p95 firstPaint Benchmark value 382 exceeds gate value 370 for chrome webpack home p95 firstReactRender Benchmark value 279 exceeds gate value 195 for chrome webpack home p95 getState Benchmark value 9 exceeds gate value 7 for chrome webpack home p95 initialActions Benchmark value 27 exceeds gate value 25 for firefox browserify home mean backgroundConnect Benchmark value 3 exceeds gate value 1 for firefox browserify home mean initialActions Benchmark value 10 exceeds gate value 9 for firefox browserify home mean setupStore Benchmark value 218 exceeds gate value 195 for firefox browserify home p95 domInteractive Benchmark value 28 exceeds gate value 24 for firefox browserify home p95 getState Benchmark value 12 exceeds gate value 2 for firefox browserify home p95 initialActions Benchmark value 37 exceeds gate value 27 for firefox browserify home p95 setupStore Benchmark value 1638 exceeds gate value 1615 for firefox webpack home mean uiStartup Benchmark value 29 exceeds gate value 26 for firefox webpack home mean backgroundConnect Benchmark value 57 exceeds gate value 38 for firefox webpack home mean firstReactRender Benchmark value 3 exceeds gate value 1 for firefox webpack home mean initialActions Benchmark value 1975 exceeds gate value 1935 for firefox webpack home p95 uiStartup Benchmark value 241 exceeds gate value 156 for firefox webpack home p95 domInteractive Benchmark value 67 exceeds gate value 50 for firefox webpack home p95 firstReactRender Benchmark value 15 exceeds gate value 2 for firefox webpack home p95 initialActions Sum of mean exceeds: 320ms | Sum of p95 exceeds: 686.8ms Sum of all benchmark exceeds: 1006.8ms |
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Collaborator
Builds ready [579e7b0]
UI Startup Metrics (1183 ± 61 ms)
Benchmark value 4 exceeds gate value 1 for chrome browserify home mean initialActions Benchmark value 232 exceeds gate value 18 for chrome browserify home p95 backgroundConnect Benchmark value 6 exceeds gate value 1.2 for chrome browserify home p95 initialActions Benchmark value 2324 exceeds gate value 2192 for chrome webpack home mean uiStartup Benchmark value 1745 exceeds gate value 1711 for chrome webpack home mean load Benchmark value 1736 exceeds gate value 1704 for chrome webpack home mean domContentLoaded Benchmark value 240 exceeds gate value 235 for chrome webpack home mean firstReactRender Benchmark value 11 exceeds gate value 7 for chrome webpack home mean initialActions Benchmark value 1732 exceeds gate value 1699 for chrome webpack home mean loadScripts Benchmark value 2684 exceeds gate value 2454 for chrome webpack home p95 uiStartup Benchmark value 66 exceeds gate value 57 for chrome webpack home p95 domInteractive Benchmark value 403 exceeds gate value 370 for chrome webpack home p95 firstReactRender Benchmark value 251 exceeds gate value 195 for chrome webpack home p95 getState Benchmark value 22 exceeds gate value 7 for chrome webpack home p95 initialActions Benchmark value 27 exceeds gate value 25 for firefox browserify home mean backgroundConnect Benchmark value 4 exceeds gate value 1 for firefox browserify home mean initialActions Benchmark value 11 exceeds gate value 9 for firefox browserify home mean setupStore Benchmark value 206 exceeds gate value 195 for firefox browserify home p95 domInteractive Benchmark value 25 exceeds gate value 24 for firefox browserify home p95 getState Benchmark value 14 exceeds gate value 2 for firefox browserify home p95 initialActions Benchmark value 33 exceeds gate value 27 for firefox browserify home p95 setupStore Benchmark value 1661 exceeds gate value 1615 for firefox webpack home mean uiStartup Benchmark value 102 exceeds gate value 100 for firefox webpack home mean domInteractive Benchmark value 30 exceeds gate value 26 for firefox webpack home mean backgroundConnect Benchmark value 60 exceeds gate value 38 for firefox webpack home mean firstReactRender Benchmark value 4 exceeds gate value 1 for firefox webpack home mean initialActions Benchmark value 2001 exceeds gate value 1935 for firefox webpack home p95 uiStartup Benchmark value 260 exceeds gate value 156 for firefox webpack home p95 domInteractive Benchmark value 77 exceeds gate value 50 for firefox webpack home p95 firstReactRender Benchmark value 15 exceeds gate value 2 for firefox webpack home p95 initialActions Benchmark value 35 exceeds gate value 28 for firefox webpack home p95 setupStore Sum of mean exceeds: 536ms | Sum of p95 exceeds: 808.8ms Sum of all benchmark exceeds: 1344.8ms |
Contributor
|
Thank you for resolving the conflicts @micaelae. I reviewed the cherry-pick PR and it looks good overall, but I noticed something.
As a result, this changes several dependencies in yarn.lock ( I posted a message on Slack to clarify that and will report back here once I have the answer. |
7 tasks
7 tasks
Collaborator
Builds ready [d467460]
UI Startup Metrics (1233 ± 77 ms)
Benchmark value 4 exceeds gate value 1 for chrome browserify home mean initialActions Benchmark value 1396 exceeds gate value 1365 for chrome browserify home p95 uiStartup Benchmark value 1216 exceeds gate value 1190 for chrome browserify home p95 load Benchmark value 1210 exceeds gate value 1180 for chrome browserify home p95 domContentLoaded Benchmark value 239 exceeds gate value 18 for chrome browserify home p95 backgroundConnect Benchmark value 11 exceeds gate value 1.2 for chrome browserify home p95 initialActions Benchmark value 985 exceeds gate value 940 for chrome browserify home p95 loadScripts Benchmark value 2220 exceeds gate value 2192 for chrome webpack home mean uiStartup Benchmark value 35 exceeds gate value 29 for chrome webpack home mean getState Benchmark value 2500 exceeds gate value 2454 for chrome webpack home p95 uiStartup Benchmark value 393 exceeds gate value 370 for chrome webpack home p95 firstReactRender Benchmark value 277 exceeds gate value 195 for chrome webpack home p95 getState Benchmark value 8 exceeds gate value 7 for chrome webpack home p95 initialActions Benchmark value 28 exceeds gate value 25 for firefox browserify home mean backgroundConnect Benchmark value 5 exceeds gate value 1 for firefox browserify home mean initialActions Benchmark value 199 exceeds gate value 195 for firefox browserify home p95 domInteractive Benchmark value 22 exceeds gate value 2 for firefox browserify home p95 initialActions Benchmark value 32 exceeds gate value 27 for firefox browserify home p95 setupStore Benchmark value 27 exceeds gate value 26 for firefox webpack home mean backgroundConnect Benchmark value 55 exceeds gate value 38 for firefox webpack home mean firstReactRender Benchmark value 6 exceeds gate value 1 for firefox webpack home mean initialActions Benchmark value 239 exceeds gate value 156 for firefox webpack home p95 domInteractive Benchmark value 65 exceeds gate value 50 for firefox webpack home p95 firstReactRender Benchmark value 15 exceeds gate value 2 for firefox webpack home p95 initialActions Sum of mean exceeds: 282ms | Sum of p95 exceeds: 654.8ms Sum of all benchmark exceeds: 936.8ms |
Contributor
|
Replaced by #35112 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
](https://codespaces.new/MetaMask/metamask-extension/pull/35038?quickstart=1){kind=link}
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes
effective gas fees for quotes are used for quote metadata calculations
totalNetworkFeeinstead of thetotalMaxNetworkFeein theQuoteCard for accuracy
Changelog
CHANGELOG entry:
Related issues
Fixes: #35006
Manual testing steps
other aggregators
aggregators
aggregators
Screenshots/Recordings
Before
After
Pre-merge author checklist
Docs and MetaMask
Extension Coding
Standards.
if applicable
guidelines).
Not required for external contributors.
Pre-merge reviewer checklist
app, test code being changed).
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots. b58539e