release(runway): cherry-pick fix: sanitize sensitive items from UI state #35063
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
<!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> This PR ensures that several sensitive items are removed from the flat state that is made available to the frontend. <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> <!-- If this PR is not End-User-Facing and should not show up in the CHANGELOG, you can choose to either: 1. Write `CHANGELOG entry: null` 2. Label with `no-changelog` If this PR is End-User-Facing, please write a short User-Facing description in the past tense like: `CHANGELOG entry: Added a new tab for users to see their NFTs` `CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker` (This helps the Release Engineer do their job more quickly and accurately) --> CHANGELOG entry: tbd Fixes: no issue logged so far 1. Open extension settings. 2. Go to "Advanced" and click "Download state logs". 3. Check whether sensitive fields have been sanitized. <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> <!-- [screenshots/recordings] --> <!-- [screenshots/recordings] --> - [ ] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. - [x] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. [](https://codespaces.new/MetaMask/metamask-extension/pull/35003?quickstart=1)
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
metamaskbot
added
the
team-runway-bot-deprecated
Collaborator
Builds ready [ad8df64]
UI Startup Metrics (1155 ± 59 ms)
Benchmark value 4 exceeds gate value 1 for chrome browserify home mean initialActions Benchmark value 233 exceeds gate value 18 for chrome browserify home p95 backgroundConnect Benchmark value 12 exceeds gate value 1.2 for chrome browserify home p95 initialActions Benchmark value 2227 exceeds gate value 2192 for chrome webpack home mean uiStartup Benchmark value 8 exceeds gate value 7 for chrome webpack home mean initialActions Benchmark value 2592 exceeds gate value 2454 for chrome webpack home p95 uiStartup Benchmark value 61 exceeds gate value 57 for chrome webpack home p95 domInteractive Benchmark value 389 exceeds gate value 370 for chrome webpack home p95 firstReactRender Benchmark value 268 exceeds gate value 195 for chrome webpack home p95 getState Benchmark value 10 exceeds gate value 7 for chrome webpack home p95 initialActions Benchmark value 26 exceeds gate value 25 for firefox browserify home mean backgroundConnect Benchmark value 5 exceeds gate value 1 for firefox browserify home mean initialActions Benchmark value 208 exceeds gate value 195 for firefox browserify home p95 domInteractive Benchmark value 23 exceeds gate value 2 for firefox browserify home p95 initialActions Benchmark value 31 exceeds gate value 27 for firefox browserify home p95 setupStore Benchmark value 34 exceeds gate value 26 for firefox webpack home mean backgroundConnect Benchmark value 53 exceeds gate value 38 for firefox webpack home mean firstReactRender Benchmark value 5 exceeds gate value 1 for firefox webpack home mean initialActions Benchmark value 256 exceeds gate value 156 for firefox webpack home p95 domInteractive Benchmark value 88 exceeds gate value 49 for firefox webpack home p95 backgroundConnect Benchmark value 64 exceeds gate value 50 for firefox webpack home p95 firstReactRender Benchmark value 48 exceeds gate value 32 for firefox webpack home p95 getState Benchmark value 24 exceeds gate value 2 for firefox webpack home p95 initialActions Sum of mean exceeds: 277ms | Sum of p95 exceeds: 691.8ms Sum of all benchmark exceeds: 968.8ms |
metamaskbot
added
the
release-13.1.0
Collaborator
|
No release label on PR. Adding release label release-13.1.0 on PR, as PR was cherry-picked in branch 13.1.0. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
](https://codespaces.new/MetaMask/metamask-extension/pull/35003?quickstart=1){kind=link}
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR ensures that several sensitive items are removed from the flat
state that is made available to the frontend.
Changelog
CHANGELOG entry: tbd
Related issues
Fixes: no issue logged so far
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Docs and MetaMask
Extension Coding
Standards.
if applicable
guidelines).
Not required for external contributors.
Pre-merge reviewer checklist
app, test code being changed).
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.