Skip to content

Conversation

@himanshuchawla009
Copy link
Contributor

@himanshuchawla009 himanshuchawla009 commented Aug 14, 2025

  • fix: sanitize sensitive email from state logs

Description

This PR ensures that user's email is removed from the state logs.

Changelog

CHANGELOG entry: tbd

Related issues

Fixes: no issue logged so far

Manual testing steps

  1. Open extension settings.
  2. Go to "Advanced" and click "Download state logs".
  3. Check whether login email is have been redacted.
Screenshot 2025-08-14 at 10 19 14 PM

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the
    app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described
    in the ticket it closes and includes the necessary testing evidence such
    as recordings and or screenshots.

@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-onboarding Onboarding team label Aug 14, 2025
@himanshuchawla009 himanshuchawla009 changed the title remove email from state logs fix: remove email from state logs Aug 14, 2025
@himanshuchawla009 himanshuchawla009 marked this pull request as ready for review August 14, 2025 15:36
@himanshuchawla009 himanshuchawla009 changed the title fix: remove email from state logs fix: redact email from state logs Aug 14, 2025
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@himanshuchawla009 himanshuchawla009 force-pushed the fix/hide-email-from-logs branch from 41d904f to 058921a Compare August 14, 2025 16:14
@metamaskbot
Copy link
Collaborator

Builds ready [058921a]
UI Startup Metrics (1184 ± 70 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1184106114037012361310
load100788111876710531124
domContentLoaded99987611806810461117
domInteractive17134361833
firstPaint66286118639810101107
backgroundConnect2142022377218231
firstReactRender18153231927
getState1152961127
initialActions2018328
loadScripts79267495466839912
setupStore85313812
WebpackHomeuiStartup21731593254919222942482
load16261159190615817041861
domContentLoaded16191154189815717011843
domInteractive171182151461
firstPaint1625835660185306
backgroundConnect3015436423048
firstReactRender19584401114364384
getState3443068012283
initialActions621661669
loadScripts16151152188515616981837
setupStore2863066715290
FirefoxBrowserifyHomeuiStartup1404122317829814641566
load1205107213937512591337
domContentLoaded1205107113937512591337
domInteractive1053126145117212
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect3318147193574
firstReactRender25215552533
getState8220025511
initialActions30557210
loadScripts1183105313727612441314
setupStore935511738
WebpackHomeuiStartup15951391204714516921877
load13281152172412314171565
domContentLoaded13281152172412314161565
domInteractive1043130559102258
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect29186073441
firstReactRender54396865765
getState1144891131
initialActions40204314
loadScripts13071136170512313941545
setupStore10416517825
Benchmark value 214 exceeds gate value 10 for chrome browserify home mean backgroundConnect
Benchmark value 3 exceeds gate value 1 for chrome browserify home mean initialActions
Benchmark value 231 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 8 exceeds gate value 1.2 for chrome browserify home p95 initialActions
Benchmark value 35 exceeds gate value 29 for chrome webpack home mean getState
Benchmark value 2482 exceeds gate value 2454 for chrome webpack home p95 uiStartup
Benchmark value 61 exceeds gate value 57 for chrome webpack home p95 domInteractive
Benchmark value 384 exceeds gate value 370 for chrome webpack home p95 firstReactRender
Benchmark value 283 exceeds gate value 195 for chrome webpack home p95 getState
Benchmark value 9 exceeds gate value 7 for chrome webpack home p95 initialActions
Benchmark value 290 exceeds gate value 65 for chrome webpack home p95 setupStore
Benchmark value 34 exceeds gate value 25 for firefox browserify home mean backgroundConnect
Benchmark value 26 exceeds gate value 25 for firefox browserify home mean firstReactRender
Benchmark value 4 exceeds gate value 1 for firefox browserify home mean initialActions
Benchmark value 10 exceeds gate value 9 for firefox browserify home mean setupStore
Benchmark value 212 exceeds gate value 195 for firefox browserify home p95 domInteractive
Benchmark value 74 exceeds gate value 70 for firefox browserify home p95 backgroundConnect
Benchmark value 10 exceeds gate value 2 for firefox browserify home p95 initialActions
Benchmark value 38 exceeds gate value 27 for firefox browserify home p95 setupStore
Benchmark value 105 exceeds gate value 100 for firefox webpack home mean domInteractive
Benchmark value 29 exceeds gate value 26 for firefox webpack home mean backgroundConnect
Benchmark value 54 exceeds gate value 38 for firefox webpack home mean firstReactRender
Benchmark value 4 exceeds gate value 1 for firefox webpack home mean initialActions
Benchmark value 258 exceeds gate value 156 for firefox webpack home p95 domInteractive
Benchmark value 65 exceeds gate value 50 for firefox webpack home p95 firstReactRender
Benchmark value 14 exceeds gate value 2 for firefox webpack home p95 initialActions
Sum of mean exceeds: 253ms | Sum of p95 exceeds: 749.8ms
Sum of all benchmark exceeds: 1002.8ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 95 Bytes (0%)
  • ui: 0 Bytes (0%)
  • common: 10 Bytes (0%)

@himanshuchawla009 himanshuchawla009 added this pull request to the merge queue Aug 14, 2025
Merged via the queue into main with commit 771a3cc Aug 14, 2025
147 checks passed
@himanshuchawla009 himanshuchawla009 deleted the fix/hide-email-from-logs branch August 14, 2025 17:17
@github-actions github-actions bot locked and limited conversation to collaborators Aug 14, 2025
@metamaskbot metamaskbot added the release-13.2.0 Issue or pull request that will be included in release 13.2.0 label Aug 14, 2025
@himanshuchawla009 himanshuchawla009 changed the title fix: redact email from state logs fix: redact email from state logs cp-13.1.0 Aug 15, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-13.2.0 Issue or pull request that will be included in release 13.2.0 size-XS team-onboarding Onboarding team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants