release(runway): cherry-pick fix: cp-13.1.0 Prevent dapp network change from network manager #35129
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ge from network manager (#35126) ## **Description** The NetworkManager was calling `setNetworkClientIdForDomain` which would signal a network change to the dapp. This is undesirable as it can cause confusion with the user <-> dapp experience. This PR removes that update. [](https://codespaces.new/MetaMask/metamask-extension/pull/35126?quickstart=1) ## **Changelog** CHANGELOG entry: Prevented the NetworkManager from changing the dapp-selected network. ## **Related issues** Fixes: #35124 ## **Manual testing steps** 1. Go to PancakeSwap 2. Connect with Linea 3. Open MetaMask, then the network manager, click the BSC checkbox 4. DO NOT see the dapp change -- continues to cite Linea 1. Go to PancakeSwap 2. Open MetaMask, then click the favicon at the top right of the extension 3. Change networks 4. See network change reflected on dapp ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** https://github.com/user-attachments/assets/bea630c7-7f4e-41b2-99c9-47f26e8b3141 ## **Pre-merge author checklist** - [ ] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. --------- Co-authored-by: Nicholas Gambino <[email protected]>
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
metamaskbot
added
the
team-runway-bot-deprecated
Collaborator
✨ Files requiring CODEOWNER review ✨🖥️ @MetaMask/wallet-ux (2 files, +4 -49)
|
Collaborator
Builds ready [e0071b8]
UI Startup Metrics (1155 ± 79 ms)
Benchmark value 3 exceeds gate value 1 for chrome browserify home mean initialActions Benchmark value 232 exceeds gate value 18 for chrome browserify home p95 backgroundConnect Benchmark value 9 exceeds gate value 1.2 for chrome browserify home p95 initialActions Benchmark value 32 exceeds gate value 29 for chrome webpack home mean getState Benchmark value 8 exceeds gate value 7 for chrome webpack home mean initialActions Benchmark value 2506 exceeds gate value 2454 for chrome webpack home p95 uiStartup Benchmark value 387 exceeds gate value 370 for chrome webpack home p95 firstReactRender Benchmark value 274 exceeds gate value 195 for chrome webpack home p95 getState Benchmark value 12 exceeds gate value 7 for chrome webpack home p95 initialActions Benchmark value 282 exceeds gate value 65 for chrome webpack home p95 setupStore Benchmark value 30 exceeds gate value 25 for firefox browserify home mean backgroundConnect Benchmark value 7 exceeds gate value 1 for firefox browserify home mean initialActions Benchmark value 215 exceeds gate value 195 for firefox browserify home p95 domInteractive Benchmark value 32 exceeds gate value 24 for firefox browserify home p95 getState Benchmark value 23 exceeds gate value 2 for firefox browserify home p95 initialActions Benchmark value 29 exceeds gate value 27 for firefox browserify home p95 setupStore Benchmark value 33 exceeds gate value 26 for firefox webpack home mean backgroundConnect Benchmark value 51 exceeds gate value 38 for firefox webpack home mean firstReactRender Benchmark value 4 exceeds gate value 1 for firefox webpack home mean initialActions Benchmark value 257 exceeds gate value 156 for firefox webpack home p95 domInteractive Benchmark value 85 exceeds gate value 49 for firefox webpack home p95 backgroundConnect Benchmark value 59 exceeds gate value 50 for firefox webpack home p95 firstReactRender Benchmark value 39 exceeds gate value 32 for firefox webpack home p95 getState Benchmark value 9 exceeds gate value 2 for firefox webpack home p95 initialActions Benchmark value 29 exceeds gate value 28 for firefox webpack home p95 setupStore Sum of mean exceeds: 244ms | Sum of p95 exceeds: 803.8ms Sum of all benchmark exceeds: 1047.8ms |
metamaskbot
added
the
release-13.1.0
Collaborator
|
No release label on PR. Adding release label release-13.1.0 on PR, as PR was cherry-picked in branch 13.1.0. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
](https://codespaces.new/MetaMask/metamask-extension/pull/35126?quickstart=1){kind=link}
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The NetworkManager was calling
setNetworkClientIdForDomainwhich wouldsignal a network change to the dapp. This is undesirable as it can cause
confusion with the user <-> dapp experience. This PR removes that
update.
Changelog
CHANGELOG entry: Prevented the NetworkManager from changing the
dapp-selected network.
Related issues
Fixes: #35124
Manual testing steps
Go to PancakeSwap
Connect with Linea
Open MetaMask, then the network manager, click the BSC checkbox
DO NOT see the dapp change -- continues to cite Linea
Go to PancakeSwap
Open MetaMask, then click the favicon at the top right of the
extension
Change networks
See network change reflected on dapp
Screenshots/Recordings
Before
After
Screen.Recording.2025-08-14.at.4.23.47.PM.mov
Pre-merge author checklist
Docs and MetaMask
Extension Coding
Standards.
if applicable
guidelines).
Not required for external contributors.
Pre-merge reviewer checklist
app, test code being changed).
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
Co-authored-by: Nicholas Gambino [email protected] c3acc5b