Skip to content

Conversation

@mcbridemarci
Copy link
Contributor

@mcbridemarci mcbridemarci commented Aug 27, 2025

Description

Added a LaunchDarkly flag to disable/enable carousel banners completely.

Thread for the request here: https://consensys.slack.com/archives/C09ARN5362F/p1755701853276849
Flag here: https://app.launchdarkly.com/projects/metamask-client-config-api-extension/flags/carousel-banners/targeting?env=beta-dev&env=beta-prod&env=main-dev&env=production&env=flask-prod&env=test&env=beta-rc&env=flask-dev&env=flask-qa&selected-env=main-dev

Open in GitHub Codespaces

Changelog

CHANGELOG entry:

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

Screenshot 2025-08-27 at 11 12 53 PM

After

Screenshot 2025-08-27 at 11 10 08 PM

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@mcbridemarci mcbridemarci requested review from a team as code owners August 27, 2025 21:15
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@mcbridemarci mcbridemarci changed the title hotfix: Launchdarkly flag added carousel-banners fix: Launchdarkly flag added carousel-banners Aug 27, 2025
@metamaskbot
Copy link
Collaborator

✨ Files requiring CODEOWNER review ✨

🔑 @MetaMask/accounts-engineers (1 files, +14 -8)
  • 📁 ui/
    • 📁 components/
      • 📁 multichain/
        • 📁 account-overview/
          • 📄 account-overview-layout.tsx +14 -8

🖥️ @MetaMask/wallet-ux (1 files, +14 -8)
  • 📁 ui/
    • 📁 components/
      • 📁 multichain/
        • 📁 account-overview/
          • 📄 account-overview-layout.tsx +14 -8

@metamaskbot
Copy link
Collaborator

Builds ready [d3676bd]
UI Startup Metrics (1231 ± 65 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1231109513776512771334
load108196012056411321187
domContentLoaded107395311976511251180
domInteractive19146581838
firstPaint67584120543710831170
backgroundConnect2412282708244261
firstReactRender23164352435
getState1156171523
initialActions30395312
loadScripts84072396064892951
setupStore84243916
WebpackHomeuiStartup20751561249322922212450
load16051199192517317011836
domContentLoaded15951195191417516951818
domInteractive161180101441
firstPaint1686549171183282
backgroundConnect3114369432849
firstReactRender19488403102302390
getState3332987511269
initialActions52172610
loadScripts15911191190017416911806
setupStore196303431433
FirefoxBrowserifyHomeuiStartup13411135173110714001560
load1179101213667212381286
domContentLoaded1178101213657212381286
domInteractive1123233057122262
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect3317394383261
firstReactRender26226142631
getState62799522
initialActions5018520214
loadScripts115599713497112131268
setupStore937711831
WebpackHomeuiStartup15511325201014516431858
load13221145168312214081590
domContentLoaded13211145168212214081590
domInteractive1073039255106259
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect27195863139
firstReactRender57446956167
getState72377823
initialActions3019338
loadScripts13011127166012213911570
setupStore114121151028
Benchmark value 1081 exceeds gate value 1070 for chrome browserify home mean load
Benchmark value 1074 exceeds gate value 1061 for chrome browserify home mean domContentLoaded
Benchmark value 241 exceeds gate value 10 for chrome browserify home mean backgroundConnect
Benchmark value 24 exceeds gate value 23 for chrome browserify home mean firstReactRender
Benchmark value 3 exceeds gate value 1 for chrome browserify home mean initialActions
Benchmark value 841 exceeds gate value 830 for chrome browserify home mean loadScripts
Benchmark value 1181 exceeds gate value 1180 for chrome browserify home p95 domContentLoaded
Benchmark value 261 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 12 exceeds gate value 1.2 for chrome browserify home p95 initialActions
Benchmark value 951 exceeds gate value 940 for chrome browserify home p95 loadScripts
Benchmark value 33 exceeds gate value 29 for chrome webpack home mean getState
Benchmark value 390 exceeds gate value 370 for chrome webpack home p95 firstReactRender
Benchmark value 269 exceeds gate value 195 for chrome webpack home p95 getState
Benchmark value 10 exceeds gate value 7 for chrome webpack home p95 initialActions
Benchmark value 113 exceeds gate value 110 for firefox browserify home mean domInteractive
Benchmark value 33 exceeds gate value 25 for firefox browserify home mean backgroundConnect
Benchmark value 26 exceeds gate value 25 for firefox browserify home mean firstReactRender
Benchmark value 6 exceeds gate value 1 for firefox browserify home mean initialActions
Benchmark value 262 exceeds gate value 195 for firefox browserify home p95 domInteractive
Benchmark value 14 exceeds gate value 2 for firefox browserify home p95 initialActions
Benchmark value 31 exceeds gate value 27 for firefox browserify home p95 setupStore
Benchmark value 107 exceeds gate value 100 for firefox webpack home mean domInteractive
Benchmark value 28 exceeds gate value 26 for firefox webpack home mean backgroundConnect
Benchmark value 58 exceeds gate value 38 for firefox webpack home mean firstReactRender
Benchmark value 3 exceeds gate value 1 for firefox webpack home mean initialActions
Benchmark value 259 exceeds gate value 156 for firefox webpack home p95 domInteractive
Benchmark value 67 exceeds gate value 50 for firefox webpack home p95 firstReactRender
Benchmark value 8 exceeds gate value 2 for firefox webpack home p95 initialActions
Sum of mean exceeds: 321ms | Sum of p95 exceeds: 571.8ms
Sum of all benchmark exceeds: 892.8ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 43 Bytes (0%)
  • ui: 216 Bytes (0%)
  • common: 10 Bytes (0%)

@vpintorico vpintorico changed the title fix: Launchdarkly flag added carousel-banners fix: cp-13.2.0 Launchdarkly flag added carousel-banners Aug 28, 2025
@metamaskbot
Copy link
Collaborator

Builds ready [7f27979]
UI Startup Metrics (1184 ± 70 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1184105513577012261327
load104393912126710841182
domContentLoaded103793512026610801175
domInteractive17134661635
firstPaint682133120841310431137
backgroundConnect2352222597239247
firstReactRender22174552534
getState12589101327
initialActions3016339
loadScripts80870697467849946
setupStore84253913
WebpackHomeuiStartup21941622270822923232574
load16981253201618218101936
domContentLoaded16911249200918118041929
domInteractive1712100121446
firstPaint1726467085190297
backgroundConnect3115314322871
firstReactRender1959340489199389
getState2642966411271
initialActions621551569
loadScripts16861247200418018011916
setupStore147211211527
FirefoxBrowserifyHomeuiStartup13401162178010513751564
load1179104514327212231314
domContentLoaded1178104514327212221314
domInteractive1103433849117228
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect291784123260
firstReactRender27227172847
getState62517617
initialActions30828211
loadScripts1156103114077112001289
setupStore939613731
WebpackHomeuiStartup15951368221817616821962
load13551168171313314391636
domContentLoaded13551168171213314381636
domInteractive1143240563116278
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect3020114113447
firstReactRender59487666369
getState818010723
initialActions6020323313
loadScripts13321151167313214201611
setupStore145219251127
Benchmark value 236 exceeds gate value 10 for chrome browserify home mean backgroundConnect
Benchmark value 3 exceeds gate value 1 for chrome browserify home mean initialActions
Benchmark value 247 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 9 exceeds gate value 1.2 for chrome browserify home p95 initialActions
Benchmark value 946 exceeds gate value 940 for chrome browserify home p95 loadScripts
Benchmark value 2195 exceeds gate value 2192 for chrome webpack home mean uiStartup
Benchmark value 2575 exceeds gate value 2454 for chrome webpack home p95 uiStartup
Benchmark value 389 exceeds gate value 370 for chrome webpack home p95 firstReactRender
Benchmark value 271 exceeds gate value 195 for chrome webpack home p95 getState
Benchmark value 9 exceeds gate value 7 for chrome webpack home p95 initialActions
Benchmark value 30 exceeds gate value 25 for firefox browserify home mean backgroundConnect
Benchmark value 27 exceeds gate value 25 for firefox browserify home mean firstReactRender
Benchmark value 4 exceeds gate value 1 for firefox browserify home mean initialActions
Benchmark value 10 exceeds gate value 9 for firefox browserify home mean setupStore
Benchmark value 228 exceeds gate value 195 for firefox browserify home p95 domInteractive
Benchmark value 11 exceeds gate value 2 for firefox browserify home p95 initialActions
Benchmark value 31 exceeds gate value 27 for firefox browserify home p95 setupStore
Benchmark value 114 exceeds gate value 100 for firefox webpack home mean domInteractive
Benchmark value 31 exceeds gate value 26 for firefox webpack home mean backgroundConnect
Benchmark value 60 exceeds gate value 38 for firefox webpack home mean firstReactRender
Benchmark value 7 exceeds gate value 1 for firefox webpack home mean initialActions
Benchmark value 14 exceeds gate value 13 for firefox webpack home mean setupStore
Benchmark value 1962 exceeds gate value 1935 for firefox webpack home p95 uiStartup
Benchmark value 278 exceeds gate value 156 for firefox webpack home p95 domInteractive
Benchmark value 69 exceeds gate value 50 for firefox webpack home p95 firstReactRender
Benchmark value 13 exceeds gate value 2 for firefox webpack home p95 initialActions
Sum of mean exceeds: 290ms | Sum of p95 exceeds: 685.8ms
Sum of all benchmark exceeds: 975.8ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 43 Bytes (0%)
  • ui: 216 Bytes (0%)
  • common: 10 Bytes (0%)

@Prithpal-Sooriya Prithpal-Sooriya added this pull request to the merge queue Aug 28, 2025
Merged via the queue into main with commit 98b2323 Aug 28, 2025
144 checks passed
@Prithpal-Sooriya Prithpal-Sooriya deleted the hotfix/completelyDisableCarousels branch August 28, 2025 13:23
@github-actions github-actions bot locked and limited conversation to collaborators Aug 28, 2025
@metamaskbot metamaskbot added the release-13.3.0 Issue or pull request that will be included in release 13.3.0 label Aug 28, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-13.3.0 Issue or pull request that will be included in release 13.3.0 size-S team-phosphor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants