-
Notifications
You must be signed in to change notification settings - Fork 5.5k
feat: bump solana snap #35695
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
feat: bump solana snap #35695
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Collaborator
📊 Page Load Benchmark ResultsCurrent Commit: 📄 https://metamask.github.io/test-dapp/Samples: 100 Summary
📈 Detailed Results
Results generated automatically by MetaMask CI |
zone-live
approved these changes
Sep 5, 2025
Collaborator
Builds ready [faf9d77]
UI Startup Metrics (1249 ± 66 ms)
Benchmark value 1085 exceeds gate value 1070 for chrome browserify home mean load Benchmark value 1077 exceeds gate value 1061 for chrome browserify home mean domContentLoaded Benchmark value 246 exceeds gate value 10 for chrome browserify home mean backgroundConnect Benchmark value 25 exceeds gate value 23 for chrome browserify home mean firstReactRender Benchmark value 6 exceeds gate value 1 for chrome browserify home mean initialActions Benchmark value 839 exceeds gate value 830 for chrome browserify home mean loadScripts Benchmark value 1200 exceeds gate value 1190 for chrome browserify home p95 load Benchmark value 1193 exceeds gate value 1180 for chrome browserify home p95 domContentLoaded Benchmark value 261 exceeds gate value 18 for chrome browserify home p95 backgroundConnect Benchmark value 11 exceeds gate value 1.2 for chrome browserify home p95 initialActions Benchmark value 952 exceeds gate value 940 for chrome browserify home p95 loadScripts Benchmark value 32 exceeds gate value 29 for chrome webpack home mean getState Benchmark value 238 exceeds gate value 195 for chrome webpack home p95 getState Benchmark value 11 exceeds gate value 7 for chrome webpack home p95 initialActions Benchmark value 1437 exceeds gate value 1405 for firefox browserify home mean uiStartup Benchmark value 1243 exceeds gate value 1239 for firefox browserify home mean domContentLoaded Benchmark value 34 exceeds gate value 25 for firefox browserify home mean backgroundConnect Benchmark value 28 exceeds gate value 25 for firefox browserify home mean firstReactRender Benchmark value 4 exceeds gate value 1 for firefox browserify home mean initialActions Benchmark value 10 exceeds gate value 9 for firefox browserify home mean setupStore Benchmark value 201 exceeds gate value 195 for firefox browserify home p95 domInteractive Benchmark value 10 exceeds gate value 2 for firefox browserify home p95 initialActions Benchmark value 103 exceeds gate value 100 for firefox webpack home mean domInteractive Benchmark value 35 exceeds gate value 26 for firefox webpack home mean backgroundConnect Benchmark value 45 exceeds gate value 38 for firefox webpack home mean firstReactRender Benchmark value 4 exceeds gate value 1 for firefox webpack home mean initialActions Benchmark value 270 exceeds gate value 156 for firefox webpack home p95 domInteractive Benchmark value 52 exceeds gate value 50 for firefox webpack home p95 firstReactRender Benchmark value 7 exceeds gate value 2 for firefox webpack home p95 initialActions Sum of mean exceeds: 375ms | Sum of p95 exceeds: 469.8ms Sum of all benchmark exceeds: 844.8ms Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
aganglada
approved these changes
Sep 5, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
release-13.4.0
Issue or pull request that will be included in release 13.4.0
size-XS
team-new-networks
PRs from the New Networks team
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR bumps the Solana Wallet Snap to its latest version
2.3.7.Changelog
CHANGELOG entry: Added support to Solana tokens with multiplier (#509)
CHANGELOG entry: Fix a bug that was causing to show spam Solana transactions in the activity list (#515)
CHANGELOG entry: Fixed an issue that was causing to show an empty symbol instead of
UNKNOWNin activity list for Solana tokens with no metadata (#517)Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist