Skip to content

Conversation

@xavier-brochard
Copy link
Contributor

@xavier-brochard xavier-brochard commented Sep 5, 2025

Description

This PR bumps the Solana Wallet Snap to its latest version 2.3.7.

Changelog

CHANGELOG entry: Added support to Solana tokens with multiplier (#509)
CHANGELOG entry: Fix a bug that was causing to show spam Solana transactions in the activity list (#515)
CHANGELOG entry: Fixed an issue that was causing to show an empty symbol instead of UNKNOWN in activity list for Solana tokens with no metadata (#517)

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 5, 2025

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-new-networks PRs from the New Networks team label Sep 5, 2025
@socket-security
Copy link

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Updated@​metamask/​solana-wallet-snap@​2.3.6 ⏵ 2.3.7100 +110088 +1100 +1100

View full report

@metamaskbot
Copy link
Collaborator

📊 Page Load Benchmark Results

Current Commit: ccf0524 | Date: 9/5/2025

📄 https://metamask.github.io/test-dapp/

Samples: 100

Summary

  • pageLoadTime-> current mean value: 1.31s (±90ms) 🟡 | historical mean value: 1.32s ⬇️ (historical data)
  • domContentLoaded-> current mean value: 986ms (±88ms) 🟢 | historical mean value: 995ms ⬇️ (historical data)
  • firstContentfulPaint-> current mean value: 95ms (±42ms) 🟢 | historical mean value: 96ms ⬇️ (historical data)
📈 Detailed Results
Metric Mean Std Dev Min Max P95 P99
pageLoadTime 1.31s 90ms 1.27s 1.88s 1.35s 1.88s
domContentLoaded 986ms 88ms 950ms 1.55s 1.02s 1.55s
firstPaint 95ms 42ms 76ms 336ms 132ms 336ms
firstContentfulPaint 95ms 42ms 76ms 336ms 132ms 336ms
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms

Results generated automatically by MetaMask CI

@metamaskbot
Copy link
Collaborator

Builds ready [faf9d77]
UI Startup Metrics (1249 ± 66 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1249113215016612851360
load108597313006511261200
domContentLoaded107796312946711201192
domInteractive18144961735
firstPaint63284120543810931177
backgroundConnect2462322778249260
firstReactRender25175672739
getState1457891828
initialActions51234711
loadScripts839725104666880951
setupStore1061931016
WebpackHomeuiStartup20001520251225321592416
load16031233190318817291859
domContentLoaded15921217189018817221842
domInteractive1711122151444
firstPaint1606140057179275
backgroundConnect3416327373263
firstReactRender83363275982282
getState3153096814238
initialActions52183611
loadScripts15881214187818617171839
setupStore146163161426
FirefoxBrowserifyHomeuiStartup14371226197610815031616
load1243107314427312851374
domContentLoaded1242107314427312851374
domInteractive1023428643109201
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect3419146183564
firstReactRender28234153039
getState10320327616
initialActions41425310
loadScripts1218105614257412621356
setupStore94527927
WebpackHomeuiStartup15961401218116516951935
load13521184163412714641606
domContentLoaded13521183163312714621606
domInteractive103392915597270
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect3523103114048
firstReactRender44385744652
getState62152710
initialActions3012237
loadScripts13271151160012614421542
setupStore11623923917
Benchmark value 1249 exceeds gate value 1234 for chrome browserify home mean uiStartup
Benchmark value 1085 exceeds gate value 1070 for chrome browserify home mean load
Benchmark value 1077 exceeds gate value 1061 for chrome browserify home mean domContentLoaded
Benchmark value 246 exceeds gate value 10 for chrome browserify home mean backgroundConnect
Benchmark value 25 exceeds gate value 23 for chrome browserify home mean firstReactRender
Benchmark value 6 exceeds gate value 1 for chrome browserify home mean initialActions
Benchmark value 839 exceeds gate value 830 for chrome browserify home mean loadScripts
Benchmark value 1200 exceeds gate value 1190 for chrome browserify home p95 load
Benchmark value 1193 exceeds gate value 1180 for chrome browserify home p95 domContentLoaded
Benchmark value 261 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 11 exceeds gate value 1.2 for chrome browserify home p95 initialActions
Benchmark value 952 exceeds gate value 940 for chrome browserify home p95 loadScripts
Benchmark value 32 exceeds gate value 29 for chrome webpack home mean getState
Benchmark value 238 exceeds gate value 195 for chrome webpack home p95 getState
Benchmark value 11 exceeds gate value 7 for chrome webpack home p95 initialActions
Benchmark value 1437 exceeds gate value 1405 for firefox browserify home mean uiStartup
Benchmark value 1243 exceeds gate value 1239 for firefox browserify home mean domContentLoaded
Benchmark value 34 exceeds gate value 25 for firefox browserify home mean backgroundConnect
Benchmark value 28 exceeds gate value 25 for firefox browserify home mean firstReactRender
Benchmark value 4 exceeds gate value 1 for firefox browserify home mean initialActions
Benchmark value 10 exceeds gate value 9 for firefox browserify home mean setupStore
Benchmark value 201 exceeds gate value 195 for firefox browserify home p95 domInteractive
Benchmark value 10 exceeds gate value 2 for firefox browserify home p95 initialActions
Benchmark value 103 exceeds gate value 100 for firefox webpack home mean domInteractive
Benchmark value 35 exceeds gate value 26 for firefox webpack home mean backgroundConnect
Benchmark value 45 exceeds gate value 38 for firefox webpack home mean firstReactRender
Benchmark value 4 exceeds gate value 1 for firefox webpack home mean initialActions
Benchmark value 270 exceeds gate value 156 for firefox webpack home p95 domInteractive
Benchmark value 52 exceeds gate value 50 for firefox webpack home p95 firstReactRender
Benchmark value 7 exceeds gate value 2 for firefox webpack home p95 initialActions
Sum of mean exceeds: 375ms | Sum of p95 exceeds: 469.8ms
Sum of all benchmark exceeds: 844.8ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 43 Bytes (0%)
  • ui: 0 Bytes (0%)
  • common: 10 Bytes (0%)

@xavier-brochard xavier-brochard added this pull request to the merge queue Sep 5, 2025
Merged via the queue into main with commit 83d7c7e Sep 5, 2025
156 of 157 checks passed
@xavier-brochard xavier-brochard deleted the bump-solana-snap branch September 5, 2025 14:31
@github-actions github-actions bot locked and limited conversation to collaborators Sep 5, 2025
@metamaskbot metamaskbot added the release-13.4.0 Issue or pull request that will be included in release 13.4.0 label Sep 5, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-13.4.0 Issue or pull request that will be included in release 13.4.0 size-XS team-new-networks PRs from the New Networks team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants