updated selector

app/scripts/controllers/app-state-controller.ts

@@ -101,8 +101,6 @@ export type AppStateControllerState = {
   networkConnectionBanner: NetworkConnectionBanner;
   newPrivacyPolicyToastClickedOrClosed: boolean | null;
   newPrivacyPolicyToastShownDate: number | null;
-  pna25BannerClickedOrClosed: boolean | null;
-  pna25BannerDismissedDate: number | null;
   pna25Acknowledged: boolean | null;
   nftsDetectionNoticeDismissed: boolean;
   nftsDropdownState: Json;
@@ -272,8 +270,6 @@ const getDefaultAppStateControllerState = (): AppStateControllerState => ({
   lastViewedUserSurvey: null,
   newPrivacyPolicyToastClickedOrClosed: null,
   newPrivacyPolicyToastShownDate: null,
-  pna25BannerClickedOrClosed: null,
-  pna25BannerDismissedDate: null,
   pna25Acknowledged: null,
   nftsDetectionNoticeDismissed: false,
   notificationGasPollTokens: [],
@@ -472,18 +468,6 @@ const controllerMetadata: StateMetadata<AppStateControllerState> = {
     includeInDebugSnapshot: true,
     usedInUi: true,
   },
-  pna25BannerClickedOrClosed: {
-    includeInStateLogs: true,
-    persist: true,
-    includeInDebugSnapshot: true,
-    usedInUi: true,
-  },
-  pna25BannerDismissedDate: {
-    includeInStateLogs: true,
-    persist: true,
-    includeInDebugSnapshot: true,
-    usedInUi: true,
-  },
   pna25Acknowledged: {
     includeInStateLogs: true,
     persist: true,
@@ -898,18 +882,6 @@ export class AppStateController extends BaseController<
     });
   }
 
-  setPna25BannerClickedOrClosed(): void {
-    this.update((state) => {
-      state.pna25BannerClickedOrClosed = true;
-    });
-  }
-
-  setPna25BannerDismissedDate(time: number): void {
-    this.update((state) => {
-      state.pna25BannerDismissedDate = time;
-    });
-  }
-
   setPna25Acknowledged(acknowledged: boolean): void {
     this.update((state) => {
       state.pna25Acknowledged = acknowledged;

ui/components/app/toast-master/selectors.ts

@@ -252,15 +252,13 @@ export function selectShowPna25Banner(state: Pick<State, 'metamask'>): boolean {
   const { participateInMetaMetrics, pna25Acknowledged } = state.metamask || {};
 
   // Get the feature flag from LaunchDarkly
-  // extension-ux-pna25 is now a boolean, not a timestamp
+  // extension-ux-pna25 is a boolean flag
   // eslint-disable-next-line @typescript-eslint/no-explicit-any
   const remoteFeatureFlags = getRemoteFeatureFlags(state as any);
-  const isMetametricsOnchainDataEnabled = Boolean(
-    remoteFeatureFlags?.['extension-ux-pna25'],
-  );
+  const isPna25Enabled = Boolean(remoteFeatureFlags?.['extension-ux-pna25']);
 
   // Check all conditions
-  if (!isMetametricsOnchainDataEnabled) {
+  if (!isPna25Enabled) {
     return false; // LD flag not enabled
   }
 

ui/pages/onboarding-flow/metametrics/metametrics.js

@@ -69,11 +69,9 @@ export default function OnboardingMetametrics() {
   const dataCollectionForMarketing = useSelector(getDataCollectionForMarketing);
   const remoteFeatureFlags = useSelector(getRemoteFeatureFlags);
 
-  // Check if the MetaMetrics on-chain data collection feature is enabled
-  // extension-ux-pna25 is now a boolean, not a timestamp
-  const isMetametricsOnchainDataEnabled = Boolean(
-    remoteFeatureFlags?.['extension-ux-pna25'],
-  );
+  // Check if the PNA25 feature is enabled
+  // extension-ux-pna25 is a boolean LaunchDarkly flag
+  const isPna25Enabled = Boolean(remoteFeatureFlags?.['extension-ux-pna25']);
 
   const [
     isParticipateInMetaMetricsChecked,
@@ -129,7 +127,7 @@ export default function OnboardingMetametrics() {
 
         // If LD flag is enabled, set pna25Acknowledged to true
         // This means they saw the updated policy during onboarding
-        if (isMetametricsOnchainDataEnabled) {
+        if (isPna25Enabled) {
           await submitRequestToBackgroundAndCatch('setPna25Acknowledged', [
             true,
           ]);
@@ -153,7 +151,7 @@ export default function OnboardingMetametrics() {
         dispatch(setDataCollectionForMarketing(false));
 
         // If user opts out, set to false (no need to show banner later)
-        if (isMetametricsOnchainDataEnabled) {
+        if (isPna25Enabled) {
           await submitRequestToBackgroundAndCatch('setPna25Acknowledged', [
             false,
           ]);
@@ -253,7 +251,7 @@ export default function OnboardingMetametrics() {
           color={TextColor.textAlternative}
           textAlign={TextAlign.Left}
         >
-          {isMetametricsOnchainDataEnabled
+          {isPna25Enabled
             ? t('onboardingMetametricCheckboxDescriptionOneUpdated')
             : t('onboardingMetametricCheckboxDescriptionOne')}
         </Text>