feat(perf): Optimize use{,Multi}Polling by defining useSyncEqualityCheck
#38339
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
MajorLift
changed the title
useSyncEqualityCheck and use in polling hooksuseSyncEqualityCheck and use in polling hooks
MajorLift
force-pushed
the
jongsun/perf/react/251127-useSyncEqualityCheck
branch
2 times, most recently
from
be2dc85 to
bb0ee4b
Compare
MajorLift
added
the
no-changelog
Collaborator
Builds ready [bb0ee4b]
UI Startup Metrics (1328 ± 116 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
MajorLift
changed the title
useSyncEqualityCheck and use in polling hooksuseSyncEqualityCheck to fix polling hooks
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
MajorLift
force-pushed
the
jongsun/perf/react/251127-useSyncEqualityCheck
branch
from
bb0ee4b to
f577186
Compare
Collaborator
Builds ready [e7f895d]
UI Startup Metrics (1274 ± 125 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
MajorLift
changed the title
useSyncEqualityCheck to fix polling hooksuseSyncEqualityCheck to fix polling hooks
MajorLift
force-pushed
the
jongsun/perf/react/251127-useSyncEqualityCheck
branch
from
ae28b07 to
702c081
Compare
Contributor
Author
|
@metamaskbot update-policies |
Collaborator
|
Policies updated. 🧠 Learn how: https://lavamoat.github.io/guides/policy-diff/#what-to-look-for-when-reviewing-a-policy-diff |
Collaborator
✨ Files requiring CODEOWNER review ✨📜 @MetaMask/policy-reviewers (7 files, +32 -32)
Tip Follow the policy review process outlined in the LavaMoat Policy Review Process doc before expecting an approval from Policy Reviewers. |
Collaborator
Builds ready [c7904b5]
UI Startup Metrics (1301 ± 112 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
MajorLift
force-pushed
the
jongsun/perf/react/251127-useSyncEqualityCheck
branch
from
65055ba to
c26e7e3
Compare
Contributor
Author
|
@metamaskbot update-policies |
Collaborator
|
Policies updated. 🧠 Learn how: https://lavamoat.github.io/guides/policy-diff/#what-to-look-for-when-reviewing-a-policy-diff |
Collaborator
Builds ready [0ba59c7]
UI Startup Metrics (1269 ± 126 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
MajorLift
changed the title
use{,Multi}Polling by defining useSyncEqualityCheckuse{,Multi}Polling by defining useSyncEqualityCheck
Gudahtt
reviewed
Dec 12, 2025
Gudahtt
previously approved these changes
Dec 12, 2025
Member
Gudahtt
left a comment
Gudahtt
left a comment
There was a problem hiding this comment.
One nit comment left, but otherwise LGTM!
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Collaborator
Builds ready [cd2559b]
UI Startup Metrics (1301 ± 108 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Collaborator
Builds ready [3551aaa]
UI Startup Metrics (1299 ± 98 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
MajorLift
moved this from Review in progress
to Has approvals, needs CODEOWNER
in PR review queue
Contributor
Builds ready [460939c]
UI Startup Metrics (1293 ± 111 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Prithpal-Sooriya
approved these changes
Jan 7, 2026
github-project-automation
bot
moved this from Has approvals, needs CODEOWNER
to Review finalised - Ready to be merged
in PR review queue
metamaskbot
added
the
release-13.14.0
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Dependency arrays containing complex expressions e.g.
JSON.stringifyis an anti-pattern and explicitly forbidden by React rules of hooks.useEqualityCheckprovides change detection logic, but it triggers an extra re-render due to its being implemented withuseState. For the purposes of stabilizing hook dependency references, this extra render is often unnecessary.Description
useSyncEqualityCheckOptimizations:
useEqualityCheck, runs without triggering extra re-renders.JSON.stringifywithfast-json-stable-stringify(consistent with@metamask/polling-controller).JSON.parseto handle mutation)Example: Stringify overhead reduction
usePollingFixes:
callIdReftracks effect generations, stops stale promisesisMountedcheck before storing tokenenabled=falsedidn't stop active pollsuseSyncEqualityCheckprovides stable refsuseMultiPollingOptimizations:
inputKeyMap-> Time complexity: Quadratic -> Linear(N = existing polls, M = inputs, k = serialized size)
Fixes (Race Conditions):
pendingPollsSetfinallyclears pending, making inputs available for retriesChangelog
CHANGELOG entry: Optimized network polling requests for tokens, rates, currencies, gas fees etc.
Related issues
useMultiPollingeffect cleanup #38405Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Improves polling reliability and performance via reference-stable inputs and race-safe behavior.
useSyncEqualityCheck(usesfast-json-stable-stringify) to stabilize JSON-serializable deps without extra rendersusePollingto cleanly stop stale tokens, handle unmount/disabled states, and prevent orphaned pollsuseMultiPollingwithinputKeyMapandpendingPollsto de-dupe starts, stop removed inputs, and resolve races; linear-time diffsfast-json-stable-stringifydependency; updates LavaMoat policies and yarn.lock accordinglyWritten by Cursor Bugbot for commit 460939c. This will update automatically on new commits. Configure here.