fix: fix scroll focus #38439
Merged
fix: fix scroll focus #38439
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Collaborator
✨ Files requiring CODEOWNER review ✨👨🔧 @MetaMask/core-extension-ux (2 files, +3 -0)
|
Prithpal-Sooriya
approved these changes
Dec 1, 2025
| name={network.name} | ||
| iconSrc={iconSrc} | ||
| iconSize={AvatarNetworkSize.Md} | ||
| focus={false} |
Contributor
There was a problem hiding this comment.
good fix. Does this mean we won't have focusing/scrolling to bottom if you have a network added in the bottom of the list?
E.g. if you've only selected TRON?
I think that this might be an acceptable
Contributor
Author
There was a problem hiding this comment.
Yes if you select TRON and re-open this modal; it will be already scrolled to top
Collaborator
Builds ready [14a6151]
UI Startup Metrics (1274 ± 112 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
salimtb
approved these changes
Dec 2, 2025
DDDDDanica
approved these changes
Dec 2, 2025
vinnyhoward
approved these changes
Dec 2, 2025
metamaskbot
added
the
release-13.13.0
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix scroll issue on network modal
Changelog
CHANGELOG entry: fix scroll issue on network modal.
Related issues
Fixes: #38145
Manual testing steps
Screenshots/Recordings
Before
Screen.Recording.2025-12-01.at.16.11.10.mov
After
Screen.Recording.2025-12-01.at.16.09.28.mov
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Sets
focus={false}onNetworkListItemacross custom and default network lists (including "All popular networks") to avoid auto-scroll on open.focus={false}onNetworkListItemin:custom-networks.tsxfor custom networks entries.default-networks.tsxfor each default network entry.default-networks.tsx"allPopularNetworks" aggregate item.Written by Cursor Bugbot for commit 14a6151. This will update automatically on new commits. Configure here.