Skip to content

chore: INFRA-3180:Fix create pr workflow commit.csv issue #38526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
XxdpavelxX merged 3 commits into from
Dec 3, 2025
Merged

chore: INFRA-3180:Fix create pr workflow commit.csv issue #38526

XxdpavelxX merged 3 commits into from
Dec 3, 2025
+1 −1

Conversation

@XxdpavelxX
Copy link
Contributor

@XxdpavelxX XxdpavelxX commented Dec 3, 2025 •
edited by cursor bot
Loading

Description

Ticket: https://consensyssoftware.atlassian.net/browse/INFRA-3180
Create-release-pr workflow currently uses teams.json file which was deprecated instead of new topology.json to generate commits.csv. Causes issues with commits.csv. Fixed in this Pr

Discussed here: https://consensys.slack.com/archives/C09B64PEHAQ/p1764576026224679

Open in GitHub Codespaces

Changelog

CHANGELOG entry: null

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Update workflow to use MetaMask/github-tools create-release-pr action v1.1.2 instead of v1.1.0.

Written by Cursor Bugbot for commit bff89c8. This will update automatically on new commits. Configure here.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 3, 2025

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-dev-ops DevOps team label Dec 3, 2025
gauthierpetetin
gauthierpetetin reviewed Dec 3, 2025
View reviewed changes
.github/workflows/create-release-pr.yml Outdated
steps:
- name: Create Release PR
uses: MetaMask/github-tools/.github/actions/create-release-pr@v1.1.0
uses: MetaMask/github-tools/.github/actions/create-release-pr@265e8b3632a5b42a5d4f5c08e549c1f47aa9b898
Copy link
Contributor

@gauthierpetetin gauthierpetetin Dec 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Qbandev I wonder what's the new process with regards to versioning. Shall we now always create a new github-tools release when updating github-tools?

Copy link
Contributor Author

@XxdpavelxX XxdpavelxX Dec 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, are we manually cutting a new release version whenever there's an update in github-tools?

gauthierpetetin
gauthierpetetin previously approved these changes Dec 3, 2025
View reviewed changes
@gauthierpetetin gauthierpetetin self-requested a review December 3, 2025 15:53
gauthierpetetin
gauthierpetetin reviewed Dec 3, 2025
View reviewed changes
.github/workflows/create-release-pr.yml Outdated
steps:
- name: Create Release PR
uses: MetaMask/github-tools/.github/actions/[email protected].0
uses: MetaMask/github-tools/.github/actions/[email protected].1
Copy link
Contributor

@gauthierpetetin gauthierpetetin Dec 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems we haven't added 1.1.1 to github-tools changelog. Here's an example PR for github-tools release: MetaMask/github-tools#176

@metamaskbot
Copy link
Collaborator

metamaskbot commented Dec 3, 2025

Builds ready [85a4e2d]
UI Startup Metrics (1302 ± 119 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyStandard HomeuiStartup13021058162711913911485
load1085879138210711501271
domContentLoaded1079872137610611431264
domInteractive2916164262395
firstPaint52397128342210431233
backgroundConnect23020426915242259
firstReactRender3320171173755
getState3717122194475
initialActions107113
loadScripts85566911641029261036
setupStore1253151324
numNetworkReqs1157318568
BrowserifyPower User HomeuiStartup20121712274824521892518
load1013878139912810441317
domContentLoaded1002870138612710291304
domInteractive3017139212782
firstPaint5158314044099541277
backgroundConnect250198736100231528
firstReactRender5540265235577
getState20214572993198294
initialActions103112
loadScripts79266911431228171085
setupStore1694681638
numNetworkReqs81632343076152
WebpackStandard HomeuiStartup80770198369833956
load62956279964650781
domContentLoaded62455879364645774
domInteractive2715102212391
firstPaint21379780145209636
backgroundConnect1053551322
firstReactRender27204363236
getState271291123645
initialActions103111
loadScripts62155578562642765
setupStore1153241217
numNetworkReqs1157317562
WebpackPower User HomeuiStartup16121239219224918542002
load6715831256100679881
domContentLoaded662577124699671874
domInteractive31171092328102
firstPaint31785918233593835
backgroundConnect1528653234504572
firstReactRender58458686372
getState17514035127183223
initialActions102112
loadScripts660575123798669870
setupStore1774691641
numNetworkReqs77312523074141
FirefoxBrowserifyStandard HomeuiStartup13111081171614013731636
load1088931141710411471383
domContentLoaded1088931141710411451383
domInteractive62272003485134
firstPaint------
backgroundConnect46221613245140
firstReactRender22183942336
getState1168691023
initialActions103012
loadScripts106291713769311161294
setupStore135208241028
numNetworkReqs1256817662
BrowserifyPower User HomeuiStartup30721897507994340484807
load1389926269652014632590
domContentLoaded1388920269652014622590
domInteractive993244266101244
firstPaint------
backgroundConnect3362320304294291193
firstReactRender62371742664133
getState330841384294466989
initialActions213123
loadScripts1199909254130413022029
setupStore14741201235111770
numNetworkReqs87512154176201
WebpackStandard HomeuiStartup14921221209315015911784
load12351070164511213001453
domContentLoaded12351070164411213001453
domInteractive59271683581141
firstPaint------
backgroundConnect48201683146115
firstReactRender27194653038
getState14789131347
initialActions103122
loadScripts1204105515119812671393
setupStore146176211142
numNetworkReqs1257017762
WebpackPower User HomeuiStartup------
load------
domContentLoaded------
domInteractive------
firstPaint------
backgroundConnect------
firstReactRender------
getState------
initialActions------
loadScripts------
setupStore------
numNetworkReqs------
📊 Page Load Benchmark Results

Current Commit: 85a4e2d | Date: 12/3/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

  • pageLoadTime-> current mean value: 1.04s (±114ms) 🟡 | historical mean value: 1.04s ⬇️ (historical data)
  • domContentLoaded-> current mean value: 728ms (±112ms) 🟢 | historical mean value: 727ms ⬆️ (historical data)
  • firstContentfulPaint-> current mean value: 85ms (±95ms) 🟢 | historical mean value: 77ms ⬆️ (historical data)

📈 Detailed Results

Metric Mean Std Dev Min Max P95 P99
pageLoadTime 1.04s 114ms 1.00s 2.15s 1.05s 2.15s
domContentLoaded 728ms 112ms 697ms 1.82s 739ms 1.82s
firstPaint 85ms 95ms 56ms 1.03s 88ms 1.03s
firstContentfulPaint 85ms 95ms 56ms 1.03s 88ms 1.03s
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 58 Bytes (0%)
  • ui: 0 Bytes (0%)
  • common: 20 Bytes (0%)

@XxdpavelxX XxdpavelxX self-assigned this Dec 3, 2025
@XxdpavelxX XxdpavelxX enabled auto-merge December 3, 2025 18:27
@metamaskbot
Copy link
Collaborator

metamaskbot commented Dec 3, 2025

Builds ready [bff89c8]
UI Startup Metrics (1214 ± 119 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyStandard HomeuiStartup12141010156211913071405
load1012829134210710761209
domContentLoaded1006822133210610721193
domInteractive2613172242186
firstPaint630117134339710131145
backgroundConnect20717725315215233
firstReactRender26186172843
getState3414122193886
initialActions102112
loadScripts8066351110100867985
setupStore1062631116
numNetworkReqs1156918564
BrowserifyPower User HomeuiStartup21161724284922822252585
load1083935168513611021355
domContentLoaded1072924167713710921346
domInteractive35192072831107
firstPaint57798138241110151329
backgroundConnect266213811102246527
firstReactRender6044334296385
getState21015973679213314
initialActions103112
loadScripts84771514521368641124
setupStore18114281838
numNetworkReqs78641612174137
WebpackStandard HomeuiStartup837709141788872966
load649573103575687796
domContentLoaded645568102574683789
domInteractive2615157232295
firstPaint23292825172214742
backgroundConnect12570111331
firstReactRender27205663140
getState281397143454
initialActions104111
loadScripts642565101673681783
setupStore1163741218
numNetworkReqs1057116559
WebpackPower User HomeuiStartup16771253225527419462181
load7106031223115715956
domContentLoaded7025951200114706946
domInteractive42192724433144
firstPaint297931209212339713
backgroundConnect85760717223568
firstReactRender6247163156684
getState19214778280192233
initialActions103112
loadScripts6995931190113703943
setupStore21769141951
numNetworkReqs78621592374146
FirefoxBrowserifyStandard HomeuiStartup13011073189416213671665
load1073924152410211271236
domContentLoaded1072924152310211271236
domInteractive57301462883108
firstPaint------
backgroundConnect46182053345119
firstReactRender23185772434
getState165161261082
initialActions103112
loadScripts104490515039510961195
setupStore145171211146
numNetworkReqs1256717664
BrowserifyPower User HomeuiStartup28601923453772636364197
load1320988254941812832301
domContentLoaded1319983254941812832301
domInteractive973534859109247
firstPaint------
backgroundConnect173241048236153917
firstReactRender58361231860104
getState264691017245332853
initialActions3049623
loadScripts1230963237734012462161
setupStore15091101227141688
numNetworkReqs845022335101168
WebpackStandard HomeuiStartup15011291197414115861822
load12471082151410013121458
domContentLoaded12461081151310013121458
domInteractive62271493286128
firstPaint------
backgroundConnect46201622747100
firstReactRender3020164183072
getState137104111427
initialActions102122
loadScripts1217105914509212901393
setupStore166158221142
numNetworkReqs1256717763
WebpackPower User HomeuiStartup32632037656099242064901
load17041128493264522352766
domContentLoaded17031127493264522342765
domInteractive174283357392110994
firstPaint------
backgroundConnect2372415973461931170
firstReactRender66392353365149
getState275871242239270847
initialActions207126
loadScripts15771114491758416552669
setupStore13151089202129685
numNetworkReqs78601312273128
📊 Page Load Benchmark Results

Current Commit: bff89c8 | Date: 12/3/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

  • pageLoadTime-> current mean value: 1.04s (±42ms) 🟡 | historical mean value: 1.04s ⬆️ (historical data)
  • domContentLoaded-> current mean value: 729ms (±61ms) 🟢 | historical mean value: 724ms ⬆️ (historical data)
  • firstContentfulPaint-> current mean value: 90ms (±127ms) 🟢 | historical mean value: 77ms ⬆️ (historical data)

📈 Detailed Results

Metric Mean Std Dev Min Max P95 P99
pageLoadTime 1.04s 42ms 1.01s 1.37s 1.06s 1.37s
domContentLoaded 729ms 61ms 697ms 1.29s 744ms 1.29s
firstPaint 90ms 127ms 60ms 1.35s 88ms 1.35s
firstContentfulPaint 90ms 127ms 60ms 1.35s 88ms 1.35s
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 124 Bytes (0%)
  • ui: 2.46 KiB (0.03%)
  • common: 309 Bytes (0%)

@XxdpavelxX XxdpavelxX added this pull request to the merge queue Dec 3, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 3, 2025
@XxdpavelxX XxdpavelxX added this pull request to the merge queue Dec 3, 2025
Merged via the queue into main with commit 74e5896 Dec 3, 2025
647 of 653 checks passed
@XxdpavelxX XxdpavelxX deleted the INFRA-3180-CreatePRTeamJsonFix branch December 3, 2025 21:02
@github-actions github-actions bot locked and limited conversation to collaborators Dec 3, 2025
@metamaskbot metamaskbot added the release-13.13.0 Issue or pull request that will be included in release 13.13.0 label Dec 3, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@gauthierpetetin gauthierpetetin gauthierpetetin approved these changes

@bsgrigorov bsgrigorov bsgrigorov approved these changes

@jake-perkins jake-perkins jake-perkins approved these changes

Assignees

@XxdpavelxX XxdpavelxX

Labels

release-13.13.0 Issue or pull request that will be included in release 13.13.0 size-XS team-dev-ops DevOps team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@XxdpavelxX @metamaskbot @gauthierpetetin @bsgrigorov @jake-perkins