fix: add favicon to html head to fix missing icon on firefox #38632
+3
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Collaborator
Builds ready [f699eed]
UI Startup Metrics (1278 ± 79 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
n3ps
approved these changes
Dec 8, 2025
Collaborator
Builds ready [2c4efbe]
UI Startup Metrics (1273 ± 92 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
NidhiKJha
approved these changes
Dec 9, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
metamaskbot
added
the
release-13.14.0
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Favicons don't show on Firefox when MM is in extended view. It looks like this is only a Firefox problem because in Chrome, the icons supplied in the manifest also get used as the favicon in the extension's pages. On Firefox it doesn't seem to be the case.
Therefore this PR adds in a favicon in the normal way, by adding an icon link tag in the HTML head.
On Firefox this ensures a favicon shows when MM is in extended view. On Chrome it also uses the favicon (no visible difference to how it is currently).
64x64 size was picked over 16x16 (which is normal for favicons) as the quality looked poor up to this size.
Changelog
CHANGELOG entry: adds favicon for Firefox expanded view page
Related issues
Fixes: #25420
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Add favicon to HTML head and update build script to rewrite its path in generated HTML.
app/html/partials/partial-head.htmlreferencing../../images/icon-64.png.development/build/scripts.jsto replace../../images/icon-64.pngwith./images/icon-64.pngin generated HTML.Written by Cursor Bugbot for commit 2c4efbe. This will update automatically on new commits. Configure here.