refactor: remove transaction `history` and `sendFlowHistory` #38665

vinistevam · 2025-12-09T11:36:19Z

Description

Changelog

CHANGELOG entry: https://github.com/MetaMask/MetaMask-planning/issues/2465

Related issues

Fixes:

Manual testing steps

Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

github-actions · 2025-12-09T11:36:29Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

metamaskbot · 2025-12-09T11:39:44Z

✨ Files requiring CODEOWNER review ✨

✅ @MetaMask/confirmations (1 files, +0 -2)

📁 app/
- 📁 scripts/
  - 📁 controller-init/
    - 📁 confirmations/
      - 📄 transaction-controller-init.ts +0 -2

📜 @MetaMask/policy-reviewers (5 files, +611 -16)

📁 lavamoat/
- 📁 browserify/
  - 📁 beta/
    - 📄 policy.json +152 -3
  - 📁 experimental/
    - 📄 policy.json +152 -3
  - 📁 flask/
    - 📄 policy.json +152 -3
  - 📁 main/
    - 📄 policy.json +152 -3
- 📁 webpack/
  - 📁 mv2/
    - 📄 policy.json +3 -4

Tip

Follow the policy review process outlined in the LavaMoat Policy Review Process doc before expecting an approval from Policy Reviewers.

metamaskbot · 2025-12-09T12:04:12Z

Builds ready [38907ab]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18
- content-script: 0
- offscreen: 0

📊 Page Load Benchmark Results

Current Commit: 38907ab | Date: 12/9/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.01s (±73ms) 🟡 | historical mean value: 1.06s ⬇️ (historical data)
domContentLoaded-> current mean value: 704ms (±69ms) 🟢 | historical mean value: 739ms ⬇️ (historical data)
firstContentfulPaint-> current mean value: 77ms (±10ms) 🟢 | historical mean value: 80ms ⬇️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.01s	73ms	968ms	1.29s	1.26s	1.29s
domContentLoaded	704ms	69ms	660ms	978ms	921ms	978ms
firstPaint	77ms	10ms	64ms	160ms	84ms	160ms
firstContentfulPaint	77ms	10ms	64ms	160ms	84ms	160ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 545.83 KiB (10.35%)
ui: 28 Bytes (0%)
common: 458.43 KiB (5.15%)

metamaskbot · 2025-12-09T15:09:09Z

Builds ready [7813fa6]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
lavamoat build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18
- content-script: 0
- offscreen: 0

📊 Page Load Benchmark Results

Current Commit: 7813fa6 | Date: 12/9/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.10s (±122ms) 🟡 | historical mean value: 1.05s ⬆️ (historical data)
domContentLoaded-> current mean value: 787ms (±119ms) 🟢 | historical mean value: 736ms ⬆️ (historical data)
firstContentfulPaint-> current mean value: 79ms (±28ms) 🟢 | historical mean value: 80ms ⬇️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.10s	122ms	1.01s	1.49s	1.32s	1.49s
domContentLoaded	787ms	119ms	699ms	1.16s	999ms	1.16s
firstPaint	79ms	28ms	60ms	344ms	88ms	344ms
firstContentfulPaint	79ms	28ms	60ms	344ms	88ms	344ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 544.3 KiB (10.32%)
ui: 7 Bytes (0%)
common: 458.29 KiB (5.14%)

metamaskbot · 2025-12-11T10:28:41Z

Builds ready [04968ec]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
lavamoat build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18
- content-script: 0
- offscreen: 0

UI Startup Metrics (1302 ± 115 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Standard Home	uiStartup	1302	1008	1650	115	1379	1477
			load	1064	854	1358	99	1119	1226
			domContentLoaded	1057	849	1343	99	1113	1222
			domInteractive	27	15	117	21	22	94
			firstPaint	516	98	1354	405	1015	1186
			backgroundConnect	223	197	283	17	232	255
			firstReactRender	48	32	127	16	55	79
			getState	39	17	106	15	47	66
			initialActions	1	0	3	1	1	2
			loadScripts	842	645	1119	91	896	985
			setupStore	13	7	75	8	15	25
			numNetworkReqs	13	6	83	20	6	72
	Browserify	Power User Home	uiStartup	1854	1499	2445	157	1933	2147
			load	1083	894	1677	124	1152	1287
			domContentLoaded	1073	889	1669	124	1146	1274
			domInteractive	31	18	141	24	28	94
			firstPaint	590	89	1320	427	1058	1255
			backgroundConnect	245	205	711	82	232	526
			firstReactRender	49	37	87	8	50	67
			getState	179	141	309	27	191	232
			initialActions	1	0	2	1	1	2
			loadScripts	857	687	1428	122	925	1062
			setupStore	16	9	46	8	15	36
			numNetworkReqs	70	58	133	15	68	117
	Webpack	Standard Home	uiStartup	836	681	1291	96	901	1022
			load	671	574	1132	88	710	827
			domContentLoaded	665	570	1122	87	704	819
			domInteractive	30	16	420	44	23	94
			firstPaint	261	80	746	186	247	699
			backgroundConnect	13	5	85	11	13	30
			firstReactRender	56	33	190	34	61	137
			getState	32	15	95	16	39	62
			initialActions	1	0	3	1	1	2
			loadScripts	661	567	1112	86	702	811
			setupStore	12	6	36	5	14	22
			numNetworkReqs	13	6	85	19	6	69
	Webpack	Power User Home	uiStartup	1404	1076	2089	180	1502	1720
			load	766	602	1089	109	862	921
			domContentLoaded	757	595	1082	108	850	915
			domInteractive	33	19	137	26	28	106
			firstPaint	301	94	911	226	281	865
			backgroundConnect	86	8	628	173	22	550
			firstReactRender	53	42	78	7	54	69
			getState	170	133	666	56	171	235
			initialActions	1	0	2	1	1	1
			loadScripts	754	593	1074	107	847	911
			setupStore	16	6	48	11	15	41
			numNetworkReqs	71	57	158	22	68	134
Firefox	Browserify	Standard Home	uiStartup	1460	1175	2180	162	1524	1746
			load	1170	995	1795	104	1218	1340
			domContentLoaded	1170	994	1795	104	1218	1340
			domInteractive	77	33	168	34	91	150
			firstPaint	-	-	-	-	-	-
			backgroundConnect	58	23	224	41	68	151
			firstReactRender	42	33	69	8	44	60
			getState	13	6	46	7	14	32
			initialActions	1	0	2	1	2	2
			loadScripts	1135	978	1765	96	1187	1270
			setupStore	13	6	50	9	12	42
			numNetworkReqs	15	6	83	20	8	76
	Browserify	Power User Home	uiStartup	2534	1516	3954	574	2918	3416
			load	1596	929	2751	512	2035	2393
			domContentLoaded	1596	929	2750	512	2035	2393
			domInteractive	132	32	1153	234	79	934
			firstPaint	-	-	-	-	-	-
			backgroundConnect	209	22	1228	258	207	996
			firstReactRender	53	34	97	11	58	82
			getState	112	50	253	38	135	184
			initialActions	3	1	38	5	3	7
			loadScripts	1486	917	2576	478	1882	2325
			setupStore	43	5	313	67	29	218
			numNetworkReqs	74	58	130	19	76	117
	Webpack	Standard Home	uiStartup	-	-	-	-	-	-
			load	-	-	-	-	-	-
			domContentLoaded	-	-	-	-	-	-
			domInteractive	-	-	-	-	-	-
			firstPaint	-	-	-	-	-	-
			backgroundConnect	-	-	-	-	-	-
			firstReactRender	-	-	-	-	-	-
			getState	-	-	-	-	-	-
			initialActions	-	-	-	-	-	-
			loadScripts	-	-	-	-	-	-
			setupStore	-	-	-	-	-	-
			numNetworkReqs	-	-	-	-	-	-
	Webpack	Power User Home	uiStartup	-	-	-	-	-	-
			load	-	-	-	-	-	-
			domContentLoaded	-	-	-	-	-	-
			domInteractive	-	-	-	-	-	-
			firstPaint	-	-	-	-	-	-
			backgroundConnect	-	-	-	-	-	-
			firstReactRender	-	-	-	-	-	-
			getState	-	-	-	-	-	-
			initialActions	-	-	-	-	-	-
			loadScripts	-	-	-	-	-	-
			setupStore	-	-	-	-	-	-
			numNetworkReqs	-	-	-	-	-	-

📊 Page Load Benchmark Results

Current Commit: 04968ec | Date: 12/11/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.04s (±106ms) 🟡 | historical mean value: 1.04s ⬇️ (historical data)
domContentLoaded-> current mean value: 731ms (±104ms) 🟢 | historical mean value: 729ms ⬆️ (historical data)
firstContentfulPaint-> current mean value: 81ms (±69ms) 🟢 | historical mean value: 80ms ⬆️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.04s	106ms	1.00s	1.88s	1.26s	1.88s
domContentLoaded	731ms	104ms	692ms	1.56s	949ms	1.56s
firstPaint	81ms	69ms	56ms	760ms	84ms	760ms
firstContentfulPaint	81ms	69ms	56ms	760ms	84ms	760ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 251.38 KiB (4.9%)
ui: 6 Bytes (0%)
common: 463.11 KiB (5.19%)

vinistevam · 2025-12-11T10:40:01Z

@metamaskbot update-policies

metamaskbot · 2025-12-11T10:57:45Z

Policies updated.
👀 Please review the diff for suspicious new powers.

🧠 Learn how: https://lavamoat.github.io/guides/policy-diff/#what-to-look-for-when-reviewing-a-policy-diff

….com/MetaMask/metamask-extension into fix/remove-history-send-flow-history

metamaskbot · 2025-12-11T11:42:13Z

Builds ready [158c503]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
lavamoat build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18
- content-script: 0
- offscreen: 0

UI Startup Metrics (1211 ± 100 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Standard Home	uiStartup	1211	956	1503	100	1285	1361
			load	988	809	1148	82	1041	1118
			domContentLoaded	980	803	1140	81	1034	1111
			domInteractive	24	15	107	19	19	80
			firstPaint	609	92	1159	406	1033	1125
			backgroundConnect	195	177	257	12	200	218
			firstReactRender	43	29	147	15	46	71
			getState	37	16	130	22	40	101
			initialActions	1	0	3	1	1	3
			loadScripts	794	631	950	78	844	922
			setupStore	11	6	28	4	12	21
			numNetworkReqs	14	6	80	21	6	78
	Browserify	Power User Home	uiStartup	1856	1487	2522	177	1965	2197
			load	1074	881	1669	139	1149	1325
			domContentLoaded	1064	876	1659	139	1133	1315
			domInteractive	30	17	127	21	27	92
			firstPaint	538	109	1292	399	1008	1180
			backgroundConnect	229	201	728	60	226	258
			firstReactRender	46	37	55	4	48	54
			getState	191	135	731	80	201	256
			initialActions	1	0	2	1	1	1
			loadScripts	853	673	1398	136	925	1107
			setupStore	16	8	39	8	15	35
			numNetworkReqs	71	59	148	18	67	123
	Webpack	Standard Home	uiStartup	804	651	1117	85	858	954
			load	652	554	964	82	709	805
			domContentLoaded	646	549	948	81	701	797
			domInteractive	26	15	103	20	22	90
			firstPaint	279	91	962	197	278	677
			backgroundConnect	15	6	87	12	16	41
			firstReactRender	48	31	196	26	49	101
			getState	27	14	80	11	33	49
			initialActions	1	0	4	1	1	2
			loadScripts	643	546	942	81	693	791
			setupStore	11	6	29	5	12	23
			numNetworkReqs	14	6	93	21	6	73
	Webpack	Power User Home	uiStartup	1426	1108	2199	191	1530	1726
			load	763	616	998	105	877	932
			domContentLoaded	754	608	991	104	868	916
			domInteractive	34	18	145	28	27	114
			firstPaint	355	103	946	258	648	907
			backgroundConnect	85	9	635	176	27	605
			firstReactRender	50	41	72	5	52	63
			getState	178	143	696	58	180	229
			initialActions	1	0	3	1	1	2
			loadScripts	750	606	981	103	865	906
			setupStore	16	6	54	10	14	40
			numNetworkReqs	71	59	153	22	67	135
Firefox	Browserify	Standard Home	uiStartup	1406	1102	2210	197	1483	1720
			load	1113	937	1828	121	1185	1338
			domContentLoaded	1112	936	1828	122	1185	1338
			domInteractive	66	32	218	35	88	133
			firstPaint	-	-	-	-	-	-
			backgroundConnect	53	21	349	45	61	146
			firstReactRender	39	31	85	7	40	53
			getState	15	7	178	21	11	31
			initialActions	1	0	2	1	2	2
			loadScripts	1083	922	1802	114	1153	1260
			setupStore	14	6	192	20	12	37
			numNetworkReqs	15	6	80	21	7	76
	Browserify	Power User Home	uiStartup	2602	1542	4010	544	2953	3415
			load	1654	964	2588	464	2003	2309
			domContentLoaded	1653	964	2588	464	2002	2309
			domInteractive	164	32	1178	274	91	930
			firstPaint	-	-	-	-	-	-
			backgroundConnect	200	21	1092	223	226	937
			firstReactRender	52	38	104	11	56	77
			getState	132	54	1009	127	140	185
			initialActions	3	0	36	6	2	8
			loadScripts	1560	948	2568	441	1887	2211
			setupStore	49	5	1004	115	36	261
			numNetworkReqs	74	52	124	18	84	113
	Webpack	Standard Home	uiStartup	1602	1340	2826	199	1652	1874
			load	1323	1154	2562	157	1364	1526
			domContentLoaded	1322	1154	2562	157	1364	1526
			domInteractive	78	28	221	40	107	134
			firstPaint	-	-	-	-	-	-
			backgroundConnect	59	22	173	39	69	154
			firstReactRender	44	35	100	10	46	57
			getState	18	7	141	23	15	60
			initialActions	1	0	3	1	2	2
			loadScripts	1292	1138	2542	153	1337	1481
			setupStore	19	6	204	25	16	74
			numNetworkReqs	15	6	82	21	9	75
	Webpack	Power User Home	uiStartup	2701	1704	6206	664	3036	3611
			load	1894	1090	5310	604	2278	2629
			domContentLoaded	1894	1090	5310	604	2277	2628
			domInteractive	257	28	1124	366	290	1020
			firstPaint	-	-	-	-	-	-
			backgroundConnect	145	24	1091	180	184	308
			firstReactRender	55	36	123	13	60	71
			getState	125	74	272	45	157	217
			initialActions	2	0	8	1	2	3
			loadScripts	1828	1074	5213	586	2184	2587
			setupStore	51	4	440	82	53	282
			numNetworkReqs	70	47	126	21	68	116

📊 Page Load Benchmark Results

Current Commit: 158c503 | Date: 12/11/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.05s (±59ms) 🟡 | historical mean value: 1.03s ⬆️ (historical data)
domContentLoaded-> current mean value: 731ms (±54ms) 🟢 | historical mean value: 722ms ⬆️ (historical data)
firstContentfulPaint-> current mean value: 78ms (±14ms) 🟢 | historical mean value: 80ms ⬇️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.05s	59ms	1.02s	1.42s	1.09s	1.42s
domContentLoaded	731ms	54ms	706ms	1.06s	757ms	1.06s
firstPaint	78ms	14ms	64ms	200ms	88ms	200ms
firstContentfulPaint	78ms	14ms	64ms	200ms	88ms	200ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 252.08 KiB (4.92%)
ui: 593 Bytes (0.01%)
common: 464.48 KiB (5.21%)

vinistevam added 2 commits December 9, 2025 11:22

refactor: remove transaction history and sendFlowHistory

22f0209

fix lint

38907ab

vinistevam added the team-confirmations Push issues to confirmations team label Dec 9, 2025

github-actions bot added the size-XL label Dec 9, 2025

vinistevam added 2 commits December 9, 2025 14:18

Merge branch 'main' into fix/remove-history-send-flow-history

138b84f

apply policy for tests

7813fa6

vinistevam added 3 commits December 11, 2025 09:38

bump transaction preview

1f28612

Merge branch 'main' into fix/remove-history-send-flow-history

b5ef3cd

policy

04968ec

Update LavaMoat policies

99da21b

vinistevam added 2 commits December 11, 2025 11:10

fix e2e tests

598af59

Merge branch 'fix/remove-history-send-flow-history' of https://github…

158c503

….com/MetaMask/metamask-extension into fix/remove-history-send-flow-history

vinistevam mentioned this pull request Dec 11, 2025

refactor: deprecate transaction history and sendFlowHistory properties MetaMask/core#7326

Open

4 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

refactor: remove transaction `history` and `sendFlowHistory` #38665

refactor: remove transaction `history` and `sendFlowHistory` #38665

vinistevam commented Dec 9, 2025 •

edited by github-actions bot

Loading

Uh oh!

github-actions bot commented Dec 9, 2025

Uh oh!

metamaskbot commented Dec 9, 2025 •

edited

Loading

Uh oh!

metamaskbot commented Dec 9, 2025

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

metamaskbot commented Dec 9, 2025

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

metamaskbot commented Dec 11, 2025

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

vinistevam commented Dec 11, 2025

Uh oh!

metamaskbot commented Dec 11, 2025

Uh oh!

metamaskbot commented Dec 11, 2025

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

refactor: remove transaction history and sendFlowHistory #38665

Are you sure you want to change the base?

refactor: remove transaction history and sendFlowHistory #38665

Conversation

vinistevam commented Dec 9, 2025 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Changelog

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

Uh oh!

github-actions bot commented Dec 9, 2025

Uh oh!

metamaskbot commented Dec 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✨ Files requiring CODEOWNER review ✨

Uh oh!

metamaskbot commented Dec 9, 2025

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

metamaskbot commented Dec 9, 2025

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

metamaskbot commented Dec 11, 2025

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

vinistevam commented Dec 11, 2025

Uh oh!

metamaskbot commented Dec 11, 2025

Uh oh!

metamaskbot commented Dec 11, 2025

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

refactor: remove transaction `history` and `sendFlowHistory` #38665

refactor: remove transaction `history` and `sendFlowHistory` #38665

vinistevam commented Dec 9, 2025 •

edited by github-actions bot

Loading

metamaskbot commented Dec 9, 2025 •

edited

Loading