fix: added virtualization to nfts list #38773
Merged
+116
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
✨ Files requiring CODEOWNER review ✨💎 @MetaMask/metamask-assets (1 files, +111 -18)
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Collaborator
Builds ready [40f721c]
UI Startup Metrics (1291 ± 118 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Collaborator
Builds ready [caddf96]
UI Startup Metrics (1287 ± 119 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Collaborator
Builds ready [f3fe616]
UI Startup Metrics (1251 ± 103 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Collaborator
Builds ready [828c4c5]
UI Startup Metrics (1276 ± 104 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Collaborator
Builds ready [a4099ab]
UI Startup Metrics (1265 ± 112 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Collaborator
Builds ready [c41aa56]
UI Startup Metrics (1266 ± 108 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Collaborator
Builds ready [b18e657]
UI Startup Metrics (1284 ± 103 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Collaborator
Builds ready [2081b66]
UI Startup Metrics (1341 ± 99 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Collaborator
Builds ready [da8b645]
UI Startup Metrics (1299 ± 112 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Prithpal-Sooriya
approved these changes
Dec 15, 2025
salimtb
approved these changes
Dec 15, 2025
metamaskbot
added
the
release-13.14.0
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
@Montoya raised the following issue he was experiencing:
Auto detection on mainnet is working, it's just very slow and it fails to replace the content when switching networks so it's basically not possible to view NFTs on different networks, see belowvideo_1280.mp4
After an investigation into the matter I found out we were not virtualizing the list of NFTs which meant that every time the NFTs tab was opened, we were rendering all NFTs at once. For a wallet that has hundreds of NFTs this can be very noticeable. After adding virtualization to the list, no degradation can be seen (Look at the before and after videos)
NOTE: in the benchmarking videos you will see that the initil load time has been reduces by a LOT. In my test we have moved from 20+ seconds load time to 2 second. Since my test had hundreds of NFTs it was taking 20+ seconds but with more NFTs it would have taken even longer
Changelog
CHANGELOG entry: add virtualization to NFTs list
Related issues
Fixes: https://consensyssoftware.atlassian.net/browse/ASSETS-2118
Manual testing steps
Screenshots/Recordings
Before
Screen.Recording.2025-12-11.at.15.00.23.mov
before.mov
After
Screen.Recording.2025-12-11.at.14.57.19.mov
after.mov
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Virtualizes the NFT grid using
@tanstack/react-virtual, grouping NFTs into responsive rows and stubbingwindow.matchMediain tests.ui/components/app/assets/nfts/nft-grid/nft-grid.tsxwithuseVirtualizerto render rows of NFTs.window.matchMedia(4 cols > 767px, else 3) anditemsPerRowstate.useScrollContainer) or whennfts.length <= 20.test/helpers/setup-helper.jsto stubwindow.matchMediawithaddEventListenersupport for virtualization.Written by Cursor Bugbot for commit da8b645. This will update automatically on new commits. Configure here.