fix: chart history date label when older than current year #38853
+83
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Cursor Agent can help with this pull request. Just |
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
cursor
bot
force-pushed
the
cursor/asset-chart-date-formatting-380d
branch
from
3e9441a to
48c475c
Compare
Prithpal-Sooriya
changed the title
cursor
bot
force-pushed
the
cursor/asset-chart-date-formatting-380d
branch
from
48c475c to
46c212f
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Contributor
Author
|
@cursor can you resolve this comment please? I agree that to be safe we should use jest fake timers. |
|
Done! I've updated the tests to use Jest fake timers to mock the system time, ensuring the tests won't become flaky after 2025. Changes made:
Updated test structure:describe('getDynamicShortDate', () => {
const originalNavigatorLanguage = navigator.language;
// Use a fixed "current year" for testing - mock system time to ensure tests don't become flaky
const MOCKED_CURRENT_DATE = new Date(2025, 6, 1, 12, 0, 0); // July 1, 2025
beforeAll(() => {
jest.useFakeTimers();
jest.setSystemTime(MOCKED_CURRENT_DATE);
Object.defineProperty(navigator, 'language', {
value: 'en-US',
configurable: true,
});
});
afterAll(() => {
jest.useRealTimers();
Object.defineProperty(navigator, 'language', {
value: originalNavigatorLanguage,
configurable: true,
});
});
// ... test cases
});All 15 tests pass and TypeScript checks pass. The changes have been pushed to the branch. Learn more about Cursor Agents |
Co-authored-by: prithpal.sooriya <[email protected]>
cursor
bot
force-pushed
the
cursor/asset-chart-date-formatting-380d
branch
from
46c212f to
8b363c9
Compare
Collaborator
Builds ready [8b363c9]
UI Startup Metrics (1290 ± 101 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
sahar-fehri
approved these changes
Dec 16, 2025
salimtb
approved these changes
Dec 16, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
metamaskbot
added
the
release-13.14.0
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Dynamically format asset chart dates to omit the year for current year dates and include it for past/future years to improve readability.
Changelog
CHANGELOG entry: fix: chart history date label when older than current year
Related issues
Fixes: #38736 https://consensyssoftware.atlassian.net/browse/ASSETS-2116
Manual testing steps
See issue comment
Screenshots/Recordings
Before
After
https://www.loom.com/share/83ad9a83ccc9422cb24086452034ba6f
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Use a dynamic short date for chart labels (time for current year, year for other years) and add unit tests.
ui/pages/asset/components/chart/asset-chart-price.tsxto usegetDynamicShortDate(date)for the hovered date label.getDynamicShortDate(date)inui/pages/asset/util.tsto switch betweengetShortDateFormatterandgetShortDateFormatterV2based on year.ui/pages/asset/util.test.tscovering multiple current/past/future year and timestamp scenarios forgetDynamicShortDate.Written by Cursor Bugbot for commit 8b363c9. This will update automatically on new commits. Configure here.