Skip to content

Conversation

@jeffsmale90
Copy link
Contributor

@jeffsmale90 jeffsmale90 commented Jan 5, 2026

Description

Upgrades

  • @metamask/gator-permissions-snap from ^0.7.0 to ^0.9.0
  • @metamask/permissions-kernel-snap from ^0.5.0 to ^0.6.0

Open in GitHub Codespaces

Changelog

CHANGELOG entry: Adds 'erc20-token-revocation' Advanced Permission type in Flask build only

Related issues

Fixes:

Manual testing steps

  1. Install MetaMask Flask build
  2. Run the 7715 Advanced Permissions snap testing page
  3. Request the erc20-token-revocation permission

Expect the permission picker to show the revocation permission.

  1. Install MetaMask Prod build
  2. Run the 7715 Advanced Permissions snap testing page
  3. Request the erc20-token-revocation permission

Expect an error "Advanced Permissions not enabled" (or something similar).

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Updates Advanced Permissions dependencies.

  • Bumps @metamask/gator-permissions-snap from ^0.7.0 to ^0.9.0 and @metamask/permissions-kernel-snap from ^0.5.0 to ^0.6.0 in package.json
  • Refreshes yarn.lock to align transitive deps, including @metamask/[email protected] and @metamask/[email protected]

Written by Cursor Bugbot for commit 51ee1a2. This will update automatically on new commits. Configure here.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 5, 2026

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-delegation MetaMask Delegation Team label Jan 5, 2026
@jeffsmale90 jeffsmale90 force-pushed the chore/enable-erc20-token-revocation branch from 079b4e0 to eb50235 Compare January 5, 2026 06:44
@jeffsmale90 jeffsmale90 marked this pull request as draft January 5, 2026 06:45
@jeffsmale90 jeffsmale90 force-pushed the chore/enable-erc20-token-revocation branch from eb50235 to 893f141 Compare January 5, 2026 06:46
@jeffsmale90 jeffsmale90 force-pushed the chore/enable-erc20-token-revocation branch from 893f141 to 7ea5921 Compare January 7, 2026 20:42
@jeffsmale90 jeffsmale90 force-pushed the chore/enable-erc20-token-revocation branch from 7ea5921 to defcc6b Compare January 7, 2026 21:05
@jeffsmale90 jeffsmale90 changed the title Enable erc20-token-revocation permission in flask build feat: Enable erc20-token-revocation permission in flask build Jan 7, 2026
@jeffsmale90 jeffsmale90 changed the title feat: Enable erc20-token-revocation permission in flask build chore: update Advanced Permissions snaps Jan 7, 2026
@jeffsmale90 jeffsmale90 changed the title chore: update Advanced Permissions snaps chore: upgrade Advanced Permissions snaps Jan 7, 2026
@jeffsmale90 jeffsmale90 force-pushed the chore/enable-erc20-token-revocation branch from defcc6b to dd25e00 Compare January 8, 2026 00:11
- update @metamask/gator-permissions-snap from ^0.7.0 to ^0.9.0
- update @metamask/permissions-kernel-snap from ^0.5.0 to ^0.6.0
@jeffsmale90 jeffsmale90 force-pushed the chore/enable-erc20-token-revocation branch from dd25e00 to 4d2821c Compare January 8, 2026 05:09
@socket-security
Copy link

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Updated@​metamask/​permissions-kernel-snap@​0.5.0 ⏵ 0.6.0971005991 -1100
Updated@​metamask/​gator-permissions-snap@​0.7.0 ⏵ 0.9.097 +11006195 +1100

View full report

@MoMannn MoMannn marked this pull request as ready for review January 8, 2026 10:18
@metamaskbotv2
Copy link
Contributor

metamaskbotv2 bot commented Jan 8, 2026

Builds ready [51ee1a2]
UI Startup Metrics (1322 ± 113 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyStandard HomeuiStartup13221051163811313911521
load1100878141410611641284
domContentLoaded1093868140910611511275
domInteractive271698182481
firstPaint176691222154200320
backgroundConnect22319826812228249
firstReactRender1493851528
getState3416121143753
initialActions104112
loadScripts87766311921069441054
setupStore1262741320
numNetworkReqs171174161166
BrowserifyPower User HomeuiStartup19001462249521420102369
load1018882139711510421286
domContentLoaded1007875137811510291279
domInteractive33171212331100
firstPaint182651387178220359
backgroundConnect263203669111233594
firstReactRender21165162236
getState16813725223183216
initialActions102111
loadScripts79667411441118201073
setupStore1896481836
numNetworkReqs60352203260133
WebpackStandard HomeuiStartup813670118686841967
load657587107980668817
domContentLoaded652583107380662811
domInteractive261694192285
firstPaint1056334054109233
backgroundConnect2661373035100
firstReactRender16117371625
getState3515167224466
initialActions105112
loadScripts648581107178659802
setupStore1263651423
numNetworkReqs181182181169
WebpackPower User HomeuiStartup1370994234125114641903
load707601109888725904
domContentLoaded697594108688713894
domInteractive37171833333135
firstPaint1456647484178333
backgroundConnect95758217327551
firstReactRender23163942530
getState16113571860159192
initialActions103111
loadScripts693592107287710887
setupStore17105281737
numNetworkReqs59372033157140
FirefoxBrowserifyStandard HomeuiStartup13591079241622614581829
load1083907214516511741406
domContentLoaded1083907214516511741406
domInteractive69299159485135
firstPaint------
backgroundConnect57183265848186
firstReactRender1394751222
getState145134201124
initialActions103112
loadScripts1051893202214111151278
setupStore154198221442
numNetworkReqs19980191475
BrowserifyPower User HomeuiStartup25351979514865925294286
load12501020287437511682501
domContentLoaded12491020287437511672501
domInteractive12033778107111382
firstPaint------
backgroundConnect136231233199116519
firstReactRender22148992430
getState27486852213362781
initialActions204123
loadScripts11811002261828711271736
setupStore1657756198197633
numNetworkReqs57272084545183
WebpackStandard HomeuiStartup15571284228019116372023
load13091140186812213791516
domContentLoaded13081140186812213791515
domInteractive782925243112140
firstPaint------
backgroundConnect53171843851146
firstReactRender14115851519
getState198192291480
initialActions102122
loadScripts12771115183311113351462
setupStore184201261561
numNetworkReqs20988201378
WebpackPower User HomeuiStartup28802066516878829004742
load16191187329156616792957
domContentLoaded16191187329156616782957
domInteractive122311702182107404
firstPaint------
backgroundConnect1722415882771521130
firstReactRender2616121162834
getState31970915244519825
initialActions206123
loadScripts15171171318746316112855
setupStore85959611092366
numNetworkReqs56282074345170
📊 Page Load Benchmark Results

Current Commit: 51ee1a2 | Date: 1/8/2026

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

  • pageLoadTime-> current mean value: 1.04s (±77ms) 🟡 | historical mean value: 1.05s ⬇️ (historical data)
  • domContentLoaded-> current mean value: 724ms (±74ms) 🟢 | historical mean value: 730ms ⬇️ (historical data)
  • firstContentfulPaint-> current mean value: 80ms (±13ms) 🟢 | historical mean value: 80ms ⬆️ (historical data)

📈 Detailed Results

Metric Mean Std Dev Min Max P95 P99
pageLoadTime 1.04s 77ms 989ms 1.33s 1.29s 1.33s
domContentLoaded 724ms 74ms 677ms 1.00s 964ms 1.00s
firstPaint 80ms 13ms 64ms 188ms 92ms 188ms
firstContentfulPaint 80ms 13ms 64ms 188ms 92ms 188ms
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 15 Bytes (0%)
  • ui: 0 Bytes (0%)
  • common: 20 Bytes (0%)

@jeffsmale90 jeffsmale90 enabled auto-merge January 8, 2026 16:45
@jeffsmale90 jeffsmale90 added this pull request to the merge queue Jan 8, 2026
Merged via the queue into main with commit 3f92346 Jan 8, 2026
180 checks passed
@jeffsmale90 jeffsmale90 deleted the chore/enable-erc20-token-revocation branch January 8, 2026 17:50
@github-actions github-actions bot locked and limited conversation to collaborators Jan 8, 2026
@metamaskbot metamaskbot added the release-13.14.0 Issue or pull request that will be included in release 13.14.0 label Jan 8, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-13.14.0 Issue or pull request that will be included in release 13.14.0 size-XS team-delegation MetaMask Delegation Team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants