Skip to content

Conversation

@n3ps
Copy link
Contributor

@n3ps n3ps commented Jan 8, 2026

Description

In asset and DeFi details pages, keep the header sticky. Aligns with other pages.

Open in GitHub Codespaces

Changelog

CHANGELOG entry: chore: asset details sticky header

Related issues

Fixes:

Manual testing steps

  1. Tokens > click on an asset and scroll
  2. DeFi > click on an item and scroll

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Keeps navigation/actions visible by making the top header sticky on asset and DeFi details pages.

  • Updated ui/pages/asset/components/asset-page.tsx: removed outer marginTop, moved header paddingTop to classes, and added pt-4 sticky top-0 z-10 bg-background-default on the header Box
  • Updated ui/pages/defi/components/defi-details-page.tsx: added pt-4 sticky top-0 z-10 bg-background-default to the header Box
  • Refreshed snapshots for asset-page.test.tsx.snap and defi-details-page.test.tsx.snap to reflect new classes

Written by Cursor Bugbot for commit d8a94a7. This will update automatically on new commits. Configure here.

@n3ps n3ps added the team-core-extension-ux Core Extension UX team label Jan 8, 2026
@n3ps n3ps requested a review from a team January 8, 2026 15:47
@github-actions
Copy link
Contributor

github-actions bot commented Jan 8, 2026

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbotv2
Copy link
Contributor

metamaskbotv2 bot commented Jan 8, 2026

Builds ready [d8a94a7]
UI Startup Metrics (1283 ± 114 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyStandard HomeuiStartup12831018156611413431492
load1074858132511111251279
domContentLoaded1068855131811011201271
domInteractive251589182178
firstPaint165611090170192303
backgroundConnect21019125811214235
firstReactRender1392431518
getState34177693847
initialActions103111
loadScripts86565611171119181070
setupStore1162731220
numNetworkReqs181179181173
BrowserifyPower User HomeuiStartup18501448244716819292154
load1020902134210410371275
domContentLoaded1007887132310510291269
domInteractive33171292332101
firstPaint188751170147235345
backgroundConnect270199692125244610
firstReactRender22154752330
getState17413527727188228
initialActions104112
loadScripts79868211131048111072
setupStore1794881740
numNetworkReqs59382022559119
WebpackStandard HomeuiStartup807652109189860989
load64657595474664812
domContentLoaded64157194774658807
domInteractive251599192287
firstPaint1185962789136344
backgroundConnect2961133038102
firstReactRender16113441726
getState321591134252
initialActions104111
loadScripts63856993972655797
setupStore1364171427
numNetworkReqs181180181173
WebpackPower User HomeuiStartup13421005215726114281993
load7016021152102699955
domContentLoaded6925961146101687942
domInteractive37181913431134
firstPaint15864962112198320
backgroundConnect80856515166537
firstReactRender22153332329
getState15213122615161177
initialActions103112
loadScripts6885931137100685937
setupStore1786891739
numNetworkReqs60381502762136
FirefoxBrowserifyStandard HomeuiStartup13861089229919414881719
load1110939204814311591308
domContentLoaded1109935204814311581308
domInteractive75328889286185
firstPaint------
backgroundConnect52191744162149
firstReactRender1292021217
getState176256361131
initialActions102012
loadScripts1075923193812611121264
setupStore205798791138
numNetworkReqs19983191371
BrowserifyPower User HomeuiStartup25541918689773925454496
load1268996547450311901979
domContentLoaded1267996547450311891979
domInteractive12033490107116454
firstPaint------
backgroundConnect110331177130107291
firstReactRender251590122661
getState27572845222417758
initialActions217123
loadScripts1215971543948011501640
setupStore152111460221137629
numNetworkReqs60322124750199
WebpackStandard HomeuiStartup14921256204616015611862
load12611060157310813271465
domContentLoaded12611059157210813271465
domInteractive68272123992129
firstPaint------
backgroundConnect46191332451110
firstReactRender14103831418
getState158138151340
initialActions103122
loadScripts12341044155710012901432
setupStore174220271472
numNetworkReqs20990201378
WebpackPower User HomeuiStartup28752129685979731254408
load16171142544965015522903
domContentLoaded16171142544965115522903
domInteractive119281010155101466
firstPaint------
backgroundConnect160231175216152920
firstReactRender24168592831
getState27774892228403772
initialActions214123
loadScripts15561126534560215202681
setupStore119872916992607
numNetworkReqs57301773386126
📊 Page Load Benchmark Results

Current Commit: d8a94a7 | Date: 1/8/2026

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

  • pageLoadTime-> current mean value: 1.04s (±39ms) 🟡 | historical mean value: 1.04s ⬆️ (historical data)
  • domContentLoaded-> current mean value: 723ms (±36ms) 🟢 | historical mean value: 723ms ⬇️ (historical data)
  • firstContentfulPaint-> current mean value: 77ms (±14ms) 🟢 | historical mean value: 79ms ⬇️ (historical data)

📈 Detailed Results

Metric Mean Std Dev Min Max P95 P99
pageLoadTime 1.04s 39ms 1.01s 1.33s 1.06s 1.33s
domContentLoaded 723ms 36ms 703ms 989ms 741ms 989ms
firstPaint 77ms 14ms 56ms 200ms 84ms 200ms
firstContentfulPaint 77ms 14ms 56ms 200ms 84ms 200ms
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 58 Bytes (0%)
  • ui: 76 Bytes (0%)
  • common: 20 Bytes (0%)

@n3ps n3ps enabled auto-merge January 8, 2026 16:30
@n3ps n3ps added this pull request to the merge queue Jan 8, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 8, 2026
@n3ps n3ps added this pull request to the merge queue Jan 9, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 9, 2026
@HowardBraham HowardBraham added this pull request to the merge queue Jan 10, 2026
Merged via the queue into main with commit 49a1102 Jan 10, 2026
191 of 192 checks passed
@HowardBraham HowardBraham deleted the n3ps/papercut-sticky branch January 10, 2026 03:44
@github-actions github-actions bot locked and limited conversation to collaborators Jan 10, 2026
@metamaskbot metamaskbot added the release-13.15.0 Issue or pull request that will be included in release 13.15.0 label Jan 10, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-13.15.0 Issue or pull request that will be included in release 13.15.0 size-XS team-core-extension-ux Core Extension UX team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants